From 9ae722659fb36066de25fe12522bba367b905327 Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Thu, 29 Dec 2022 09:31:14 +0100 Subject: [PATCH] Spotbugs: don't doubleCheck Map contains value, just check for null Signed-off-by: Andy Scherzinger --- .../talk/webrtc/WebSocketConnectionHelper.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/webrtc/WebSocketConnectionHelper.java b/app/src/main/java/com/nextcloud/talk/webrtc/WebSocketConnectionHelper.java index 096e71b10..52259b03c 100644 --- a/app/src/main/java/com/nextcloud/talk/webrtc/WebSocketConnectionHelper.java +++ b/app/src/main/java/com/nextcloud/talk/webrtc/WebSocketConnectionHelper.java @@ -60,11 +60,13 @@ public class WebSocketConnectionHelper { @SuppressLint("LongLogTag") public static synchronized MagicWebSocketInstance getMagicWebSocketInstanceForUserId(long userId) { - if (userId != -1 && magicWebSocketInstanceMap.containsKey(userId)) { - return magicWebSocketInstanceMap.get(userId); + MagicWebSocketInstance webSocketInstance = magicWebSocketInstanceMap.get(userId); + + if (webSocketInstance == null) { + Log.d(TAG, "No magicWebSocketInstance found for user " + userId); } - Log.d(TAG, "no magicWebSocketInstance found"); - return null; + + return webSocketInstance; } public static synchronized MagicWebSocketInstance getExternalSignalingInstanceForServer(String url,