From 8ded97ee03a3119e16b470a991d9ae37a97894bf Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Wed, 30 Nov 2022 18:30:29 +0100 Subject: [PATCH] resolve codacy warnings Signed-off-by: Marcel Hibbe --- .../talk/adapters/messages/PreviewMessageViewHolder.kt | 1 + .../com/nextcloud/talk/ui/dialog/MessageActionsDialog.kt | 5 +++++ app/src/main/res/layout/reactions_inside_message.xml | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/nextcloud/talk/adapters/messages/PreviewMessageViewHolder.kt b/app/src/main/java/com/nextcloud/talk/adapters/messages/PreviewMessageViewHolder.kt index c66e7788b..7891e601b 100644 --- a/app/src/main/java/com/nextcloud/talk/adapters/messages/PreviewMessageViewHolder.kt +++ b/app/src/main/java/com/nextcloud/talk/adapters/messages/PreviewMessageViewHolder.kt @@ -97,6 +97,7 @@ abstract class PreviewMessageViewHolder(itemView: View?, payload: Any?) : } @SuppressLint("SetTextI18n") + @Suppress("NestedBlockDepth", "ComplexMethod", "LongMethod") override fun onBind(message: ChatMessage) { super.onBind(message) if (userAvatar != null) { diff --git a/app/src/main/java/com/nextcloud/talk/ui/dialog/MessageActionsDialog.kt b/app/src/main/java/com/nextcloud/talk/ui/dialog/MessageActionsDialog.kt index 22335ad06..c953c5c40 100644 --- a/app/src/main/java/com/nextcloud/talk/ui/dialog/MessageActionsDialog.kt +++ b/app/src/main/java/com/nextcloud/talk/ui/dialog/MessageActionsDialog.kt @@ -27,6 +27,7 @@ import android.content.Context import android.os.Bundle import android.os.Handler import android.os.Looper +import android.util.Log import android.view.MotionEvent import android.view.View import android.view.ViewGroup @@ -321,6 +322,7 @@ class MessageActionsDialog( inner class ReactionAddedObserver : Observer { override fun onSubscribe(d: Disposable) { + // unused atm } override fun onNext(reactionAddedModel: ReactionAddedModel) { @@ -333,6 +335,7 @@ class MessageActionsDialog( } override fun onError(e: Throwable) { + Log.e(TAG, "failure in ReactionAddedObserver", e) } override fun onComplete() { @@ -342,6 +345,7 @@ class MessageActionsDialog( inner class ReactionDeletedObserver : Observer { override fun onSubscribe(d: Disposable) { + // unused atm } override fun onNext(reactionDeletedModel: ReactionDeletedModel) { @@ -354,6 +358,7 @@ class MessageActionsDialog( } override fun onError(e: Throwable) { + Log.e(TAG, "failure in ReactionDeletedObserver", e) } override fun onComplete() { diff --git a/app/src/main/res/layout/reactions_inside_message.xml b/app/src/main/res/layout/reactions_inside_message.xml index 0378a086b..2ba8e3b41 100644 --- a/app/src/main/res/layout/reactions_inside_message.xml +++ b/app/src/main/res/layout/reactions_inside_message.xml @@ -33,4 +33,4 @@ android:gravity="center_vertical" android:orientation="horizontal" > - \ No newline at end of file +