gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-01-31 11:32:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix to show all participants in conversation info

Browse Source 
In general it's a bad idea to use recyclerview inside scrollviews because of poor performance! So this is only a fix until everything is replaced with jetpack compose.

setHasFixedSize and isNestedScrollingEnabled were set to false. This might not be necessary for the current implementation, but it's recommended when using NestedScrollView.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This commit is contained in:
Marcel Hibbe 2024-03-25 11:55:33 +01:00 committed by backportbot[bot]
parent c1aa51e67a
commit 883f3e74f1
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt
View File

@ -495,7 +495,7 @@ class ConversationInfoActivity :
val layoutManager = SmoothScrollLinearLayoutManager(this) val layoutManager = SmoothScrollLinearLayoutManager(this)
binding.recyclerView.layoutManager = layoutManager binding.recyclerView.layoutManager = layoutManager
binding.recyclerView.setHasFixedSize(true) binding.recyclerView.setHasFixedSize(false)
binding.recyclerView.adapter = adapter binding.recyclerView.adapter = adapter
binding.recyclerView.isNestedScrollingEnabled = false binding.recyclerView.isNestedScrollingEnabled = false
adapter!!.addListener(this) adapter!!.addListener(this)

4
app/src/main/res/layout/activity_conversation_info.xml
View File

@ -65,7 +65,7 @@
android:indeterminateTintMode="src_in" android:indeterminateTintMode="src_in"
tools:visibility="gone" /> tools:visibility="gone" />
<ScrollView <androidx.core.widget.NestedScrollView
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content"> android:layout_height="wrap_content">
@ -429,5 +429,5 @@
</LinearLayout> </LinearLayout>
</LinearLayout> </LinearLayout>
</LinearLayout> </LinearLayout>
</ScrollView> </androidx.core.widget.NestedScrollView>
</LinearLayout> </LinearLayout>