From 81f353f7f0277ab5597033755b6dbaace06e28f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Fri, 25 Nov 2022 12:18:12 +0100 Subject: [PATCH] Return empty display name rather than default nick from web socket MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the display name is not known whether "Guest" or something else needs to be shown is not a responsibility of the web socket, so now an empty string is returned instead. In practice this should not make any difference, though, as the display name of users is always known as soon as the user joined, and if the nick of a guest is not known the UI will set it to "Guest". Signed-off-by: Daniel Calviño Sánchez --- .../java/com/nextcloud/talk/webrtc/MagicWebSocketInstance.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/webrtc/MagicWebSocketInstance.java b/app/src/main/java/com/nextcloud/talk/webrtc/MagicWebSocketInstance.java index ef965eb3b..49df4b00e 100644 --- a/app/src/main/java/com/nextcloud/talk/webrtc/MagicWebSocketInstance.java +++ b/app/src/main/java/com/nextcloud/talk/webrtc/MagicWebSocketInstance.java @@ -25,7 +25,6 @@ import android.text.TextUtils; import android.util.Log; import com.bluelinelabs.logansquare.LoganSquare; -import com.nextcloud.talk.R; import com.nextcloud.talk.application.NextcloudTalkApplication; import com.nextcloud.talk.data.user.model.User; import com.nextcloud.talk.events.NetworkEvent; @@ -384,7 +383,7 @@ public class MagicWebSocketInstance extends WebSocketListener { } } - return NextcloudTalkApplication.Companion.getSharedApplication().getString(R.string.nc_nick_guest); + return ""; } public String getUserIdForSession(String session) {