From 7e68ecbde9b43bbe19406bacb91318cc76249177 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Thu, 28 Oct 2021 12:30:43 +0200 Subject: [PATCH] rename "runAllThings" :D :D setUpAfterConversationIsKnown might not be the best name, but i'm not sure when in onCreate the currentConversation can be null. depending on that it might even not be necessary to have the "things" in a method.. Signed-off-by: Marcel Hibbe --- .../nextcloud/talk/activities/CallNotificationActivity.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java b/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java index aaa1cda0f..475b145c2 100644 --- a/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java +++ b/app/src/main/java/com/nextcloud/talk/activities/CallNotificationActivity.java @@ -142,7 +142,7 @@ public class CallNotificationActivity extends BaseActivity { if (currentConversation == null) { handleFromNotification(); } else { - runAllThings(); + setUpAfterConversationIsKnown(); } if (DoNotDisturbUtils.INSTANCE.shouldPlaySound()) { @@ -278,7 +278,7 @@ public class CallNotificationActivity extends BaseActivity { @Override public void onNext(@io.reactivex.annotations.NonNull RoomOverall roomOverall) { currentConversation = roomOverall.getOcs().data; - runAllThings(); + setUpAfterConversationIsKnown(); if (apiVersion >= 3) { boolean hasCallFlags = @@ -316,7 +316,7 @@ public class CallNotificationActivity extends BaseActivity { || Participant.ParticipantFlags.IN_CALL_WITH_AUDIO_AND_VIDEO.getValue() == callFlag); } - private void runAllThings() { + private void setUpAfterConversationIsKnown() { binding.conversationNameTextView.setText(currentConversation.getDisplayName()); // TODO: load avatar, but don't block UI!