diff --git a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java index 01e339d28..c0950631a 100644 --- a/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java +++ b/app/src/main/java/com/nextcloud/talk/activities/CallActivity.java @@ -440,7 +440,7 @@ public class CallActivity extends CallBaseActivity { binding.gridview.setOnItemClickListener((parent, view, position, id) -> animateCallControls(true, 0)); binding.callStates.callStateRelativeLayout.setOnClickListener(l -> { - if (currentCallStatus.equals(CallStatus.CALLING_TIMEOUT)) { + if (currentCallStatus == CallStatus.CALLING_TIMEOUT) { setCallState(CallStatus.RECONNECTING); hangupNetworkCalls(false); } @@ -747,7 +747,7 @@ public class CallActivity extends CallBaseActivity { } private boolean isConnectionEstablished() { - return (currentCallStatus.equals(CallStatus.JOINED) || currentCallStatus.equals(CallStatus.IN_CONVERSATION)); + return (currentCallStatus == CallStatus.JOINED || currentCallStatus == CallStatus.IN_CONVERSATION); } @AfterPermissionGranted(100) @@ -838,9 +838,9 @@ public class CallActivity extends CallBaseActivity { Log.d(TAG, "onAudioManagerDevicesChanged: " + availableDevices + ", " + "currentDevice: " + currentDevice); - final boolean shouldDisableProximityLock = (currentDevice.equals(WebRtcAudioManager.AudioDevice.WIRED_HEADSET) - || currentDevice.equals(WebRtcAudioManager.AudioDevice.SPEAKER_PHONE) - || currentDevice.equals(WebRtcAudioManager.AudioDevice.BLUETOOTH)); + final boolean shouldDisableProximityLock = (currentDevice == WebRtcAudioManager.AudioDevice.WIRED_HEADSET + || currentDevice == WebRtcAudioManager.AudioDevice.SPEAKER_PHONE + || currentDevice == WebRtcAudioManager.AudioDevice.BLUETOOTH); if (shouldDisableProximityLock) { powerManagerUtils.updatePhoneState(PowerManagerUtils.PhoneState.WITHOUT_PROXIMITY_SENSOR_LOCK); @@ -1230,7 +1230,7 @@ public class CallActivity extends CallBaseActivity { Log.d(TAG, "localStream is null"); } - if (!currentCallStatus.equals(CallStatus.LEAVING)) { + if (currentCallStatus != CallStatus.LEAVING) { hangup(true); } powerManagerUtils.updatePhoneState(PowerManagerUtils.PhoneState.IDLE); @@ -1457,7 +1457,7 @@ public class CallActivity extends CallBaseActivity { @Override public void onNext(@io.reactivex.annotations.NonNull GenericOverall genericOverall) { - if (!currentCallStatus.equals(CallStatus.LEAVING)) { + if (currentCallStatus != CallStatus.LEAVING) { setCallState(CallStatus.JOINED); ApplicationWideCurrentRoomHolder.getInstance().setInCall(true); @@ -1549,7 +1549,7 @@ public class CallActivity extends CallBaseActivity { conversationUser, externalSignalingServer.getExternalSignalingTicket(), TextUtils.isEmpty(credentials)); } else { - if (webSocketClient.isConnected() && currentCallStatus.equals(CallStatus.PUBLISHER_FAILED)) { + if (webSocketClient.isConnected() && currentCallStatus == CallStatus.PUBLISHER_FAILED) { webSocketClient.restartWebSocket(); } } @@ -1567,7 +1567,7 @@ public class CallActivity extends CallBaseActivity { @Subscribe(threadMode = ThreadMode.BACKGROUND) public void onMessageEvent(WebSocketCommunicationEvent webSocketCommunicationEvent) { - if (CallStatus.LEAVING.equals(currentCallStatus)) { + if (currentCallStatus == CallStatus.LEAVING) { return; } @@ -1575,7 +1575,7 @@ public class CallActivity extends CallBaseActivity { case "hello": Log.d(TAG, "onMessageEvent 'hello'"); if (!webSocketCommunicationEvent.getHashMap().containsKey("oldResumeId")) { - if (currentCallStatus.equals(CallStatus.RECONNECTING)) { + if (currentCallStatus == CallStatus.RECONNECTING) { hangup(false); } else { initiateCall(); @@ -1660,7 +1660,7 @@ public class CallActivity extends CallBaseActivity { private void receivedSignalingMessage(Signaling signaling) throws IOException { String messageType = signaling.getType(); - if (!isConnectionEstablished() && !currentCallStatus.equals(CallStatus.CONNECTING)) { + if (!isConnectionEstablished() && currentCallStatus != CallStatus.CONNECTING) { return; } @@ -1889,7 +1889,7 @@ public class CallActivity extends CallBaseActivity { userIdsBySessionId.put(participant.get("sessionId").toString(), userId); } else { Log.d(TAG, " inCallFlag of currentSessionId: " + inCallFlag); - if (inCallFlag == 0 && !CallStatus.LEAVING.equals(currentCallStatus) && ApplicationWideCurrentRoomHolder.getInstance().isInCall()) { + if (inCallFlag == 0 && currentCallStatus != CallStatus.LEAVING && ApplicationWideCurrentRoomHolder.getInstance().isInCall()) { Log.d(TAG, "Most probably a moderator ended the call for all."); hangup(true); } @@ -1909,7 +1909,7 @@ public class CallActivity extends CallBaseActivity { // Calculate sessions that join the call newSessions.removeAll(oldSessions); - if (!isConnectionEstablished() && !currentCallStatus.equals(CallStatus.CONNECTING)) { + if (!isConnectionEstablished() && currentCallStatus != CallStatus.CONNECTING) { return; } @@ -1938,7 +1938,7 @@ public class CallActivity extends CallBaseActivity { }); } - if (newSessions.size() > 0 && !currentCallStatus.equals(CallStatus.IN_CONVERSATION)) { + if (newSessions.size() > 0 && currentCallStatus != CallStatus.IN_CONVERSATION) { setCallState(CallStatus.IN_CONVERSATION); } @@ -2193,7 +2193,7 @@ public class CallActivity extends CallBaseActivity { boolean enableVideo = peerConnectionEvent.getPeerConnectionEventType() == PeerConnectionEvent.PeerConnectionEventType.SENSOR_FAR && videoOn; if (EffortlessPermissions.hasPermissions(this, PERMISSIONS_CAMERA) && - (currentCallStatus.equals(CallStatus.CONNECTING) || isConnectionEstablished()) && videoOn + (currentCallStatus == CallStatus.CONNECTING || isConnectionEstablished()) && videoOn && enableVideo != localVideoTrack.enabled()) { toggleMedia(enableVideo, true); } @@ -2416,7 +2416,7 @@ public class CallActivity extends CallBaseActivity { } private void setCallState(CallStatus callState) { - if (currentCallStatus == null || !currentCallStatus.equals(callState)) { + if (currentCallStatus == null || currentCallStatus != callState) { currentCallStatus = callState; if (handler == null) { handler = new Handler(Looper.getMainLooper()); diff --git a/app/src/main/java/com/nextcloud/talk/adapters/items/ContactItem.java b/app/src/main/java/com/nextcloud/talk/adapters/items/ContactItem.java index a785def5e..6ebb30e2e 100644 --- a/app/src/main/java/com/nextcloud/talk/adapters/items/ContactItem.java +++ b/app/src/main/java/com/nextcloud/talk/adapters/items/ContactItem.java @@ -145,8 +145,8 @@ public class ContactItem extends AbstractFlexibleItem= Build.VERSION_CODES.O) { Drawable[] layers = new Drawable[2]; diff --git a/app/src/main/java/com/nextcloud/talk/adapters/items/ParticipantItem.java b/app/src/main/java/com/nextcloud/talk/adapters/items/ParticipantItem.java index eb440001f..ea676457b 100644 --- a/app/src/main/java/com/nextcloud/talk/adapters/items/ParticipantItem.java +++ b/app/src/main/java/com/nextcloud/talk/adapters/items/ParticipantItem.java @@ -140,8 +140,8 @@ public class ParticipantItem extends AbstractFlexibleItem