From 6fb5d3f9bbd945c027ca04714d70626aef365ed4 Mon Sep 17 00:00:00 2001 From: Tobias Kaminsky Date: Wed, 7 Apr 2021 17:09:36 +0200 Subject: [PATCH] Fixed some spotbugs, excluded some bug categories to be consistent with Files Signed-off-by: tobiasKaminsky --- .../talk/controllers/ProfileController.java | 1 + .../json/userprofile/UserProfileFieldsOCS.java | 2 ++ findbugs-filter.xml | 18 ++++++++++++++++-- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.java b/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.java index ad22cac76..49935537e 100644 --- a/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.java +++ b/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.java @@ -523,6 +523,7 @@ public class ProfileController extends BaseController { }); } + @SuppressWarnings({"IOI_USE_OF_FILE_STREAM_CONSTRUCTORS"}) // only possible with API26 private void saveBitmapAndPassToImagePicker(Bitmap bitmap) { File file = null; try { diff --git a/app/src/main/java/com/nextcloud/talk/models/json/userprofile/UserProfileFieldsOCS.java b/app/src/main/java/com/nextcloud/talk/models/json/userprofile/UserProfileFieldsOCS.java index b87aac230..26e60ee5c 100644 --- a/app/src/main/java/com/nextcloud/talk/models/json/userprofile/UserProfileFieldsOCS.java +++ b/app/src/main/java/com/nextcloud/talk/models/json/userprofile/UserProfileFieldsOCS.java @@ -29,7 +29,9 @@ import org.parceler.Parcel; import java.util.ArrayList; import lombok.Data; +import lombok.EqualsAndHashCode; +@EqualsAndHashCode(callSuper = true) @Parcel @Data @JsonObject diff --git a/findbugs-filter.xml b/findbugs-filter.xml index 585711f9f..514a0e3a5 100644 --- a/findbugs-filter.xml +++ b/findbugs-filter.xml @@ -23,9 +23,23 @@ - + - + + + + + + + + + + + + + + +