From 69dae28f8336e2ccdb6caa4e365e849a0a79d2d6 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Thu, 23 Mar 2023 12:20:12 +0100 Subject: [PATCH] Avoid NPE in deleteAvatar#onError Exception java.lang.NullPointerException: at com.nextcloud.talk.controllers.ProfileController$save$1.onError (ProfileController.kt:457) at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.checkTerminated (ObservableObserveOn.java:281) at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.drainNormal (ObservableObserveOn.java:172) at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run (ObservableObserveOn.java:255) at io.reactivex.android.schedulers.HandlerScheduler$ScheduledRunnable.run (HandlerScheduler.java:124) at android.os.Handler.handleCallback (Handler.java:883) at android.os.Handler.dispatchMessage (Handler.java:100) at android.os.Looper.loop (Looper.java:237) at android.app.ActivityThread.main (ActivityThread.java:8167) at java.lang.reflect.Method.invoke at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:496) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1100) Signed-off-by: Marcel Hibbe --- .../java/com/nextcloud/talk/controllers/ProfileController.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.kt b/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.kt index 83318fc89..92f58b7aa 100644 --- a/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.kt +++ b/app/src/main/java/com/nextcloud/talk/controllers/ProfileController.kt @@ -222,7 +222,7 @@ class ProfileController : BaseController(R.layout.controller_profile) { } override fun onError(e: Throwable) { - Toast.makeText(applicationContext, "Error", Toast.LENGTH_LONG).show() + Log.e(TAG, "Failed to delete avatar", e) } override fun onComplete() {