From 652dd5033ab5d70adec64dd8d584dd3b20dda3f5 Mon Sep 17 00:00:00 2001 From: sowjanyakch Date: Mon, 26 May 2025 18:20:48 +0200 Subject: [PATCH] use constants and proper names Signed-off-by: sowjanyakch --- .../nextcloud/talk/contacts/ContactsViewModel.kt | 4 ++-- .../talk/contacts/components/SearchComponent.kt | 13 ++++++++++--- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/contacts/ContactsViewModel.kt b/app/src/main/java/com/nextcloud/talk/contacts/ContactsViewModel.kt index 4f85cbfc9..97d6a8ea2 100644 --- a/app/src/main/java/com/nextcloud/talk/contacts/ContactsViewModel.kt +++ b/app/src/main/java/com/nextcloud/talk/contacts/ContactsViewModel.kt @@ -37,11 +37,11 @@ class ContactsViewModel @Inject constructor( private val _isAddParticipantsView = MutableStateFlow(false) val isAddParticipantsView: StateFlow = _isAddParticipantsView - @Suppress("PropertyName") + @SuppressLint("PropertyName") private val _enableAddButton = MutableStateFlow(false) val enableAddButton: StateFlow = _enableAddButton - @Suppress("PropertyName") + @SuppressLint("PropertyName") private val _selectedContacts = MutableStateFlow>(emptyList()) @SuppressLint("PropertyName") diff --git a/app/src/main/java/com/nextcloud/talk/contacts/components/SearchComponent.kt b/app/src/main/java/com/nextcloud/talk/contacts/components/SearchComponent.kt index 79518353b..644314f09 100644 --- a/app/src/main/java/com/nextcloud/talk/contacts/components/SearchComponent.kt +++ b/app/src/main/java/com/nextcloud/talk/contacts/components/SearchComponent.kt @@ -40,15 +40,15 @@ fun SearchComponent( onDisableSearch: () -> Unit, isAddParticipants: Boolean ) { - var width_ratio = 0.85f + var widthRatio = SearchComponentCompanionClass.WIDTH_RATI0_SMALL if (!isAddParticipants) { - width_ratio = 1.0f + widthRatio = SearchComponentCompanionClass.WIDTH_RATIO_LARGE } val keyboardController = LocalSoftwareKeyboardController.current TextField( modifier = Modifier .background(MaterialTheme.colorScheme.background) - .fillMaxWidth(width_ratio) + .fillMaxWidth(widthRatio) .height(60.dp), value = text, onValueChange = { onTextChange(it) }, @@ -109,3 +109,10 @@ fun searchKeyboardActions(text: String, keyboardController: SoftwareKeyboardCont } } ) + +class SearchComponentCompanionClass { + companion object { + const val WIDTH_RATI0_SMALL = 0.85f + const val WIDTH_RATIO_LARGE = 1.0f + } +}