ktlint: No whitespace expected between opening parenthesis and first parameter name

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

app/src/main/java/com/nextcloud/talk/activities/CallActivity.kt

@@ -1050,10 +1050,7 @@ class CallActivity : CallBaseActivity() {
     private val isConnectionEstablished: Boolean
         get() = currentCallStatus === CallStatus.JOINED || currentCallStatus === CallStatus.IN_CONVERSATION
 
-    private fun onAudioManagerDevicesChanged(
+    private fun onAudioManagerDevicesChanged(currentDevice: AudioDevice, availableDevices: Set<AudioDevice>) {
-        currentDevice: AudioDevice,
-        availableDevices: Set<AudioDevice>
-    ) {
         Log.d(TAG, "onAudioManagerDevicesChanged: $availableDevices, currentDevice: $currentDevice")
         val shouldDisableProximityLock =
             currentDevice == AudioDevice.WIRED_HEADSET ||
@@ -1529,10 +1526,7 @@ class CallActivity : CallBaseActivity() {
             })
     }
 
-    private fun addIceServers(
+    private fun addIceServers(signalingSettingsOverall: SignalingSettingsOverall, apiVersion: Int) {
-        signalingSettingsOverall: SignalingSettingsOverall,
-        apiVersion: Int
-    ) {
         if (signalingSettingsOverall.ocs!!.settings!!.stunServers != null) {
             val stunServers = signalingSettingsOverall.ocs!!.settings!!.stunServers
             if (apiVersion == ApiUtils.APIv3) {
@@ -3035,11 +3029,7 @@ class CallActivity : CallBaseActivity() {
         }
     }
 
-    private fun updatePictureInPictureActions(
+    private fun updatePictureInPictureActions(@DrawableRes iconId: Int, title: String?, requestCode: Int) {
-        @DrawableRes iconId: Int,
-        title: String?,
-        requestCode: Int
-    ) {
         if (isGreaterEqualOreo && isPipModePossible) {
             val actions = ArrayList<RemoteAction>()
             val icon = Icon.createWithResource(this, iconId)

app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.kt

@@ -203,9 +203,7 @@ class ConversationItem(
         }
     }
 
-    private fun shouldLoadAvatar(
+    private fun shouldLoadAvatar(holder: ConversationItemViewHolder): Boolean {
-        holder: ConversationItemViewHolder
-    ): Boolean {
         return when (model.objectType) {
             Conversation.ObjectType.SHARE_PASSWORD -> {
                 holder.binding.dialogAvatar.setImageDrawable(
@@ -237,10 +235,7 @@ class ConversationItem(
         }
     }
 
-    private fun setLastMessage(
+    private fun setLastMessage(holder: ConversationItemViewHolder, appContext: Context) {
-        holder: ConversationItemViewHolder,
-        appContext: Context
-    ) {
         if (model.lastMessage != null) {
             holder.binding.dialogDate.visibility = View.VISIBLE
             holder.binding.dialogDate.text = DateUtils.getRelativeTimeSpanString(

app/src/main/java/com/nextcloud/talk/adapters/messages/LinkPreview.kt

@@ -38,12 +38,7 @@ import io.reactivex.schedulers.Schedulers
 
 class LinkPreview {
 
-    fun showLink(
+    fun showLink(message: ChatMessage, ncApi: NcApi, binding: ReferenceInsideMessageBinding, context: Context) {
-        message: ChatMessage,
-        ncApi: NcApi,
-        binding: ReferenceInsideMessageBinding,
-        context: Context
-    ) {
         binding.referenceName.text = ""
         binding.referenceDescription.text = ""
         binding.referenceLink.text = ""

app/src/main/java/com/nextcloud/talk/bottomsheet/items/ListIconDialogAdapter.kt

@@ -79,10 +79,7 @@ internal class ListIconDialogAdapter<IT : ListItemWithImage>(
         }
     }
 
-    override fun onCreateViewHolder(
+    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ListItemViewHolder {
-        parent: ViewGroup,
-        viewType: Int
-    ): ListItemViewHolder {
         val listItemView: View = parent.inflate(dialog.windowContext, R.layout.menu_item_sheet)
         val viewHolder = ListItemViewHolder(
             itemView = listItemView,
@@ -94,10 +91,7 @@ internal class ListIconDialogAdapter<IT : ListItemWithImage>(
 
     override fun getItemCount() = items.size
 
-    override fun onBindViewHolder(
+    override fun onBindViewHolder(holder: ListItemViewHolder, position: Int) {
-        holder: ListItemViewHolder,
-        position: Int
-    ) {
         holder.itemView.isEnabled = !disabledIndices.contains(position)
         val currentItem = items[position]
 
@@ -120,10 +114,7 @@ internal class ListIconDialogAdapter<IT : ListItemWithImage>(
         }
     }
 
-    override fun replaceItems(
+    override fun replaceItems(items: List<IT>, listener: ListItemListener<IT>) {
-        items: List<IT>,
-        listener: ListItemListener<IT>
-    ) {
         this.items = items
         if (listener != null) {
             this.selection = listener

app/src/main/java/com/nextcloud/talk/call/ReactionAnimator.kt

@@ -46,10 +46,7 @@ class ReactionAnimator(
 ) {
     private val reactionsList: MutableList<CallReaction> = ArrayList()
 
-    fun addReaction(
+    fun addReaction(emoji: String, displayName: String) {
-        emoji: String,
-        displayName: String
-    ) {
         val callReaction = CallReaction(emoji, displayName)
         reactionsList.add(callReaction)
 
@@ -58,9 +55,7 @@ class ReactionAnimator(
         }
     }
 
-    private fun animateReaction(
+    private fun animateReaction(callReaction: CallReaction) {
-        callReaction: CallReaction
-    ) {
         val reactionWrapper = getReactionWrapperView(callReaction)
 
         val params = RelativeLayout.LayoutParams(

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

@@ -2979,9 +2979,7 @@ class ChatActivity :
         }
     }
 
-    fun leaveRoom(
+    fun leaveRoom(funToCallWhenLeaveSuccessful: (() -> Unit)?) {
-        funToCallWhenLeaveSuccessful: (() -> Unit)?
-    ) {
         logConversationInfos("leaveRoom")
 
         var apiVersion = 1
@@ -3147,11 +3145,7 @@ class ChatActivity :
         signalingMessageSender = webSocketInstance?.signalingMessageSender
     }
 
-    fun pullChatMessages(
+    fun pullChatMessages(lookIntoFuture: Boolean, setReadMarker: Boolean = true, xChatLastCommonRead: Int? = null) {
-        lookIntoFuture: Boolean,
-        setReadMarker: Boolean = true,
-        xChatLastCommonRead: Int? = null
-    ) {
         if (!validSessionId()) {
             return
         }
@@ -3471,10 +3465,7 @@ class ChatActivity :
         }
     }
 
-    private fun addMessagesToAdapter(
+    private fun addMessagesToAdapter(shouldAddNewMessagesNotice: Boolean, chatMessageList: List<ChatMessage>) {
-        shouldAddNewMessagesNotice: Boolean,
-        chatMessageList: List<ChatMessage>
-    ) {
         val isThereANewNotice =
             shouldAddNewMessagesNotice || adapter?.getMessagePositionByIdInReverse("-1") != -1
         for (chatMessage in chatMessageList) {

app/src/main/java/com/nextcloud/talk/chat/data/ChatRepositoryImpl.kt

@@ -29,10 +29,7 @@ import com.nextcloud.talk.utils.ApiUtils
 import io.reactivex.Observable
 
 class ChatRepositoryImpl(private val ncApi: NcApi) : ChatRepository {
-    override fun getRoom(
+    override fun getRoom(user: User, roomToken: String): Observable<ConversationModel> {
-        user: User,
-        roomToken: String
-    ): Observable<ConversationModel> {
         val credentials: String = ApiUtils.getCredentials(user.username, user.token)
         val apiVersion = ApiUtils.getConversationApiVersion(user, intArrayOf(ApiUtils.APIv4, ApiUtils.APIv3, 1))
 
@@ -42,11 +39,7 @@ class ChatRepositoryImpl(private val ncApi: NcApi) : ChatRepository {
         ).map { ConversationModel.mapToConversationModel(it.ocs?.data!!) }
     }
 
-    override fun joinRoom(
+    override fun joinRoom(user: User, roomToken: String, roomPassword: String): Observable<ConversationModel> {
-        user: User,
-        roomToken: String,
-        roomPassword: String
-    ): Observable<ConversationModel> {
         val credentials: String = ApiUtils.getCredentials(user.username, user.token)
         val apiVersion = ApiUtils.getConversationApiVersion(user, intArrayOf(ApiUtils.APIv4, 1))
 

app/src/main/java/com/nextcloud/talk/conversation/repository/ConversationRepository.kt

@@ -27,13 +27,7 @@ import io.reactivex.Observable
 
 interface ConversationRepository {
 
-    fun renameConversation(
+    fun renameConversation(roomToken: String, roomNameNew: String): Observable<GenericOverall>
-        roomToken: String,
-        roomNameNew: String
-    ): Observable<GenericOverall>
 
-    fun createConversation(
+    fun createConversation(roomName: String, conversationType: Conversation.ConversationType?): Observable<RoomOverall>
-        roomName: String,
-        conversationType: Conversation.ConversationType?
-    ): Observable<RoomOverall>
 }

app/src/main/java/com/nextcloud/talk/conversation/repository/ConversationRepositoryImpl.kt

@@ -38,10 +38,7 @@ class ConversationRepositoryImpl(private val ncApi: NcApi, currentUserProvider:
     val currentUser: User = currentUserProvider.currentUser.blockingGet()
     val credentials: String = ApiUtils.getCredentials(currentUser.username, currentUser.token)
 
-    override fun renameConversation(
+    override fun renameConversation(roomToken: String, roomNameNew: String): Observable<GenericOverall> {
-        roomToken: String,
-        roomNameNew: String
-    ): Observable<GenericOverall> {
         val apiVersion = ApiUtils.getConversationApiVersion(currentUser, intArrayOf(ApiUtils.APIv4, ApiUtils.APIv1))
 
         return ncApi.renameRoom(

app/src/main/java/com/nextcloud/talk/conversation/viewmodel/ConversationViewModel.kt

@@ -54,10 +54,7 @@ class ConversationViewModel @Inject constructor(private val repository: Conversa
         disposable?.dispose()
     }
 
-    fun createConversation(
+    fun createConversation(roomName: String, conversationType: Conversation.ConversationType?) {
-        roomName: String,
-        conversationType: Conversation.ConversationType?
-    ) {
         _viewState.value = CreatingState
 
         repository.createConversation(

app/src/main/java/com/nextcloud/talk/conversationlist/ConversationsListActivity.kt

@@ -352,9 +352,7 @@ class ConversationsListActivity :
         viewThemeUtils.material.themeToolbar(binding.conversationListToolbar)
     }
 
-    private fun loadUserAvatar(
+    private fun loadUserAvatar(target: Target) {
-        target: Target
-    ) {
         if (currentUser != null) {
             val url = ApiUtils.getUrlForAvatar(
                 currentUser!!.baseUrl,

app/src/main/java/com/nextcloud/talk/jobs/ShareOperationWorker.kt

@@ -93,12 +93,7 @@ class ShareOperationWorker(context: Context, workerParams: WorkerParameters) : W
     companion object {
         private val TAG = ShareOperationWorker::class.simpleName
 
-        fun shareFile(
+        fun shareFile(roomToken: String?,   currentUser: User, remotePath: String, metaData: String?) {
-            roomToken: String?,
-            currentUser: User,
-            remotePath: String,
-            metaData: String?
-        ) {
             val paths: MutableList<String> = ArrayList()
             paths.add(remotePath)
 

app/src/main/java/com/nextcloud/talk/jobs/UploadAndShareFilesWorker.kt

@@ -186,9 +186,7 @@ class UploadAndShareFilesWorker(val context: Context, workerParameters: WorkerPa
         return remotePath
     }
 
-    override fun onTransferProgress(
+    override fun onTransferProgress(percentage: Int) {
-        percentage: Int
-    ) {
         notification = mBuilder!!
             .setProgress(HUNDRED_PERCENT, percentage, false)
             .setContentText(getNotificationContentText(percentage))
@@ -322,12 +320,7 @@ class UploadAndShareFilesWorker(val context: Context, workerParameters: WorkerPa
             }
         }
 
-        fun upload(
+        fun upload(fileUri: String, roomToken: String, conversationName: String, metaData: String?) {
-            fileUri: String,
-            roomToken: String,
-            conversationName: String,
-            metaData: String?
-        ) {
             val data: Data = Data.Builder()
                 .putString(DEVICE_SOURCE_FILE, fileUri)
                 .putString(ROOM_TOKEN, roomToken)

app/src/main/java/com/nextcloud/talk/location/LocationPickerActivity.kt

@@ -524,11 +524,7 @@ class LocationPickerActivity :
         )
     }
 
-    override fun onRequestPermissionsResult(
+    override fun onRequestPermissionsResult(requestCode: Int, permissions: Array<out String>, grantResults: IntArray) {
-        requestCode: Int,
-        permissions: Array<out String>,
-        grantResults: IntArray
-    ) {
         super.onRequestPermissionsResult(requestCode, permissions, grantResults)
 
         fun areAllGranted(grantResults: IntArray): Boolean {

app/src/main/java/com/nextcloud/talk/models/domain/ConversationModel.kt

@@ -46,9 +46,7 @@ class ConversationModel(
 ) {
 
     companion object {
-        fun mapToConversationModel(
+        fun mapToConversationModel(conversation: Conversation): ConversationModel {
-            conversation: Conversation
-        ): ConversationModel {
             return ConversationModel(
                 roomId = conversation.roomId,
                 token = conversation.token,

app/src/main/java/com/nextcloud/talk/models/json/chat/ChatUtils.kt

@@ -35,10 +35,7 @@ class ChatUtils {
         }
 
         @Suppress("Detekt.ComplexMethod")
-        private fun parse(
+        private fun parse(messageParameters: HashMap<String?, HashMap<String?, String?>>, message: String?): String? {
-            messageParameters: HashMap<String?, HashMap<String?, String?>>,
-            message: String?
-        ): String? {
             var resultMessage = message
             for (key in messageParameters.keys) {
                 val individualHashMap = messageParameters[key]

app/src/main/java/com/nextcloud/talk/openconversations/data/OpenConversationsRepositoryImpl.kt

@@ -42,9 +42,7 @@ class OpenConversationsRepositoryImpl(private val ncApi: NcApi, currentUserProvi
         ).map { mapToOpenConversationsModel(it.ocs?.data!!) }
     }
 
-    private fun mapToOpenConversationsModel(
+    private fun mapToOpenConversationsModel(conversations: List<Conversation>): OpenConversationsModel {
-        conversations: List<Conversation>
-    ): OpenConversationsModel {
         return OpenConversationsModel(
             conversations.map { conversation ->
                 OpenConversation(

app/src/main/java/com/nextcloud/talk/polls/ui/PollLoadingFragment.kt

@@ -49,11 +49,7 @@ class PollLoadingFragment : Fragment() {
         fragmentHeight = arguments?.getInt(KEY_FRAGMENT_HEIGHT)!!
     }
 
-    override fun onCreateView(
+    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
-    ): View {
         binding = DialogPollLoadingBinding.inflate(inflater, container, false)
         binding.root.layoutParams.height = fragmentHeight
         viewThemeUtils.platform.colorCircularProgressBar(binding.pollLoadingProgressbar, ColorRole.PRIMARY)
@@ -65,9 +61,7 @@ class PollLoadingFragment : Fragment() {
         private const val KEY_FRAGMENT_HEIGHT = "keyFragmentHeight"
 
         @JvmStatic
-        fun newInstance(
+        fun newInstance(fragmentHeight: Int): PollLoadingFragment {
-            fragmentHeight: Int
-        ): PollLoadingFragment {
             val args = bundleOf(
                 KEY_FRAGMENT_HEIGHT to fragmentHeight
             )

app/src/main/java/com/nextcloud/talk/polls/ui/PollResultsFragment.kt

@@ -65,11 +65,7 @@ class PollResultsFragment : Fragment(), PollResultItemClickListener {
         parentViewModel = ViewModelProvider(requireParentFragment(), viewModelFactory)[PollMainViewModel::class.java]
     }
 
-    override fun onCreateView(
+    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
-    ): View {
         binding = DialogPollResultsBinding.inflate(inflater, container, false)
         return binding.root
     }

app/src/main/java/com/nextcloud/talk/polls/ui/PollVoteFragment.kt

@@ -69,11 +69,7 @@ class PollVoteFragment : Fragment() {
         parentViewModel = ViewModelProvider(requireParentFragment(), viewModelFactory)[PollMainViewModel::class.java]
     }
 
-    override fun onCreateView(
+    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
-    ): View {
         binding = DialogPollVoteBinding.inflate(inflater, container, false)
         return binding.root
     }

app/src/main/java/com/nextcloud/talk/profile/ProfileActivity.kt

@@ -688,10 +688,7 @@ class ProfileActivity : BaseActivity() {
             }
         }
 
-        private fun initUserInfoEditText(
+        private fun initUserInfoEditText(holder: ViewHolder, item: UserInfoDetailsItem) {
-            holder: ViewHolder,
-            item: UserInfoDetailsItem
-        ) {
             holder.binding.userInfoEditTextEdit.setText(item.text)
             holder.binding.userInfoInputLayout.hint = item.hint
             holder.binding.userInfoEditTextEdit.addTextChangedListener(object : TextWatcher {
@@ -714,10 +711,7 @@ class ProfileActivity : BaseActivity() {
             })
         }
 
-        private fun initScopeElements(
+        private fun initScopeElements(item: UserInfoDetailsItem, holder: ViewHolder) {
-            item: UserInfoDetailsItem,
-            holder: ViewHolder
-        ) {
             if (item.scope == null) {
                 holder.binding.scope.visibility = View.GONE
             } else {

app/src/main/java/com/nextcloud/talk/raisehand/RequestAssistanceRepository.kt

@@ -24,11 +24,7 @@ import io.reactivex.Observable
 
 interface RequestAssistanceRepository {
 
-    fun requestAssistance(
+    fun requestAssistance(roomToken: String): Observable<RequestAssistanceModel>
-        roomToken: String
-    ): Observable<RequestAssistanceModel>
 
-    fun withdrawRequestAssistance(
+    fun withdrawRequestAssistance(roomToken: String): Observable<WithdrawRequestAssistanceModel>
-        roomToken: String
-    ): Observable<WithdrawRequestAssistanceModel>
 }

app/src/main/java/com/nextcloud/talk/raisehand/RequestAssistanceRepositoryImpl.kt

@@ -57,18 +57,14 @@ class RequestAssistanceRepositoryImpl(private val ncApi: NcApi, currentUserProvi
         ).map { mapToWithdrawRequestAssistanceModel(it.ocs?.meta!!) }
     }
 
-    private fun mapToRequestAssistanceModel(
+    private fun mapToRequestAssistanceModel(response: GenericMeta): RequestAssistanceModel {
-        response: GenericMeta
-    ): RequestAssistanceModel {
         val success = response.statusCode == HTTP_OK
         return RequestAssistanceModel(
             success
         )
     }
 
-    private fun mapToWithdrawRequestAssistanceModel(
+    private fun mapToWithdrawRequestAssistanceModel(response: GenericMeta): WithdrawRequestAssistanceModel {
-        response: GenericMeta
-    ): WithdrawRequestAssistanceModel {
         val success = response.statusCode == HTTP_OK
         return WithdrawRequestAssistanceModel(
             success

app/src/main/java/com/nextcloud/talk/remotefilebrowser/activities/RemoteFileBrowserActivity.kt

@@ -160,10 +160,7 @@ class RemoteFileBrowserActivity : AppCompatActivity(), SelectionInterface, Swipe
         }
     }
 
-    private fun loadList(
+    private fun loadList(state: RemoteFileBrowserItemsViewModel.LoadedState, mimeTypeSelectionFilter: String?) {
-        state: RemoteFileBrowserItemsViewModel.LoadedState,
-        mimeTypeSelectionFilter: String?
-    ) {
         val remoteFileBrowserItems = state.items
         Log.d(TAG, "Items received: $remoteFileBrowserItems")
 

app/src/main/java/com/nextcloud/talk/repositories/callrecording/CallRecordingRepository.kt

@@ -26,11 +26,7 @@ import io.reactivex.Observable
 
 interface CallRecordingRepository {
 
-    fun startRecording(
+    fun startRecording(roomToken: String): Observable<StartCallRecordingModel>
-        roomToken: String
-    ): Observable<StartCallRecordingModel>
 
-    fun stopRecording(
+    fun stopRecording(roomToken: String): Observable<StopCallRecordingModel>
-        roomToken: String
-    ): Observable<StopCallRecordingModel>
 }

app/src/main/java/com/nextcloud/talk/repositories/callrecording/CallRecordingRepositoryImpl.kt

@@ -37,9 +37,7 @@ class CallRecordingRepositoryImpl(private val ncApi: NcApi, currentUserProvider:
 
     var apiVersion = 1
 
-    override fun startRecording(
+    override fun startRecording(roomToken: String): Observable<StartCallRecordingModel> {
-        roomToken: String
-    ): Observable<StartCallRecordingModel> {
         return ncApi.startRecording(
             credentials,
             ApiUtils.getUrlForRecording(
@@ -51,9 +49,7 @@ class CallRecordingRepositoryImpl(private val ncApi: NcApi, currentUserProvider:
         ).map { mapToStartCallRecordingModel(it.ocs?.meta!!) }
     }
 
-    override fun stopRecording(
+    override fun stopRecording(roomToken: String): Observable<StopCallRecordingModel> {
-        roomToken: String
-    ): Observable<StopCallRecordingModel> {
         return ncApi.stopRecording(
             credentials,
             ApiUtils.getUrlForRecording(
@@ -64,18 +60,14 @@ class CallRecordingRepositoryImpl(private val ncApi: NcApi, currentUserProvider:
         ).map { mapToStopCallRecordingModel(it.ocs?.meta!!) }
     }
 
-    private fun mapToStartCallRecordingModel(
+    private fun mapToStartCallRecordingModel(response: GenericMeta): StartCallRecordingModel {
-        response: GenericMeta
-    ): StartCallRecordingModel {
         val success = response.statusCode == HTTP_OK
         return StartCallRecordingModel(
             success
         )
     }
 
-    private fun mapToStopCallRecordingModel(
+    private fun mapToStopCallRecordingModel(response: GenericMeta): StopCallRecordingModel {
-        response: GenericMeta
-    ): StopCallRecordingModel {
         val success = response.statusCode == HTTP_OK
         return StopCallRecordingModel(
             success

app/src/main/java/com/nextcloud/talk/repositories/reactions/ReactionsRepository.kt

@@ -27,15 +27,7 @@ import io.reactivex.Observable
 
 interface ReactionsRepository {
 
-    fun addReaction(
+    fun addReaction(roomToken: String, message: ChatMessage, emoji: String): Observable<ReactionAddedModel>
-        roomToken: String,
-        message: ChatMessage,
-        emoji: String
-    ): Observable<ReactionAddedModel>
 
-    fun deleteReaction(
+    fun deleteReaction(roomToken: String, message: ChatMessage, emoji: String): Observable<ReactionDeletedModel>
-        roomToken: String,
-        message: ChatMessage,
-        emoji: String
-    ): Observable<ReactionDeletedModel>
 }

app/src/main/java/com/nextcloud/talk/repositories/reactions/ReactionsRepositoryImpl.kt

@@ -36,11 +36,7 @@ class ReactionsRepositoryImpl(private val ncApi: NcApi, currentUserProvider: Cur
     val currentUser: User = currentUserProvider.currentUser.blockingGet()
     val credentials: String = ApiUtils.getCredentials(currentUser.username, currentUser.token)
 
-    override fun addReaction(
+    override fun addReaction(roomToken: String, message: ChatMessage, emoji: String): Observable<ReactionAddedModel> {
-        roomToken: String,
-        message: ChatMessage,
-        emoji: String
-    ): Observable<ReactionAddedModel> {
         return ncApi.sendReaction(
             credentials,
             ApiUtils.getUrlForMessageReaction(

app/src/main/java/com/nextcloud/talk/shareditems/repositories/SharedItemsRepository.kt

@@ -28,16 +28,9 @@ import io.reactivex.Observable
 
 interface SharedItemsRepository {
 
-    fun media(
+    fun media(parameters: Parameters, type: SharedItemType): Observable<SharedItems>?
-        parameters: Parameters,
-        type: SharedItemType
-    ): Observable<SharedItems>?
 
-    fun media(
+    fun media(parameters: Parameters, type: SharedItemType, lastKnownMessageId: Int?): Observable<SharedItems>?
-        parameters: Parameters,
-        type: SharedItemType,
-        lastKnownMessageId: Int?
-    ): Observable<SharedItems>?
 
     fun availableTypes(parameters: Parameters): Observable<Set<SharedItemType>>
 

app/src/main/java/com/nextcloud/talk/shareditems/repositories/SharedItemsRepositoryImpl.kt

@@ -48,10 +48,7 @@ import javax.inject.Inject
 class SharedItemsRepositoryImpl @Inject constructor(private val ncApi: NcApi, private val dateUtils: DateUtils) :
     SharedItemsRepository {
 
-    override fun media(
+    override fun media(parameters: SharedItemsRepository.Parameters, type: SharedItemType): Observable<SharedItems>? {
-        parameters: SharedItemsRepository.Parameters,
-        type: SharedItemType
-    ): Observable<SharedItems>? {
         return media(parameters, type, null)
     }
 

app/src/main/java/com/nextcloud/talk/translate/repositories/TranslateRepository.kt

@@ -13,8 +13,5 @@ interface TranslateRepository {
         fromLanguage: String?
     ): Observable<String>
 
-    fun getLanguages(
+    fun getLanguages(authorization: String, url: String): Observable<List<Language>>
-        authorization: String,
-        url: String
-    ): Observable<List<Language>>
 }

app/src/main/java/com/nextcloud/talk/ui/dialog/DateTimePickerFragment.kt

@@ -299,14 +299,11 @@ class DateTimePickerFragment(
         private const val HOUR_SIX_PM = 18
 
         @JvmStatic
-        fun newInstance(
+        fun newInstance(token: String, id: String, chatViewModel: ChatViewModel) =
-            token: String,
+            DateTimePickerFragment(
-            id: String,
+                token,
-            chatViewModel: ChatViewModel
+                id,
-        ) = DateTimePickerFragment(
+                chatViewModel
-            token,
+            )
-            id,
-            chatViewModel
-        )
     }
 }

app/src/main/java/com/nextcloud/talk/ui/dialog/FilterConversationFragment.kt

@@ -62,11 +62,7 @@ class FilterConversationFragment(
         return MaterialAlertDialogBuilder(requireContext()).setView(dialogView).create()
     }
 
-    override fun onCreateView(
+    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
-    ): View? {
         NextcloudTalkApplication.sharedApplication!!.componentApplication.inject(this)
         setUpColors()
         setUpListeners()

app/src/main/java/com/nextcloud/talk/ui/dialog/SaveToStorageDialogFragment.kt

@@ -83,9 +83,7 @@ class SaveToStorageDialogFragment : DialogFragment() {
     }
 
     @SuppressLint("LongLogTag")
-    private fun saveImageToStorage(
+    private fun saveImageToStorage(fileName: String) {
-        fileName: String
-    ) {
         val sourceFilePath = requireContext().cacheDir.path
         val workerTag = SAVE_TO_STORAGE_WORKER_PREFIX + fileName
 

app/src/main/java/com/nextcloud/talk/ui/dialog/SetStatusDialogFragment.kt

@@ -350,9 +350,7 @@ class SetStatusDialogFragment :
         return returnValue
     }
 
-    private fun clearAtToUnixTimeTypeEndOf(
+    private fun clearAtToUnixTimeTypeEndOf(clearAt: ClearAt): Long {
-        clearAt: ClearAt
-    ): Long {
         var returnValue = -1L
         if (clearAt.time == "day") {
             val date = Calendar.getInstance().apply {

app/src/main/java/com/nextcloud/talk/ui/theme/TalkSpecificViewThemeUtils.kt

@@ -295,11 +295,7 @@ class TalkSpecificViewThemeUtils @Inject constructor(
         }
     }
 
-    fun themeAndHighlightText(
+    fun themeAndHighlightText(textView: TextView, originalText: String?, c: String?) {
-        textView: TextView,
-        originalText: String?,
-        c: String?
-    ) {
         withScheme(textView) { scheme ->
             var constraint = c
             constraint = FlexibleUtils.toLowerCase(constraint)
@@ -374,11 +370,7 @@ class TalkSpecificViewThemeUtils @Inject constructor(
         }
     }
 
-    fun getTextColor(
+    fun getTextColor(isOutgoingMessage: Boolean, isSelfReaction: Boolean, binding: ReactionsInsideMessageBinding): Int {
-        isOutgoingMessage: Boolean,
-        isSelfReaction: Boolean,
-        binding: ReactionsInsideMessageBinding
-    ): Int {
         return withScheme(binding.root) { scheme ->
             return@withScheme if (!isOutgoingMessage || isSelfReaction) {
                 ContextCompat.getColor(binding.root.context, R.color.high_emphasis_text)

app/src/main/java/com/nextcloud/talk/upload/chunked/ChunkedFileUploader.kt

@@ -83,11 +83,7 @@ class ChunkedFileUploader(
     }
 
     @Suppress("Detekt.TooGenericExceptionCaught")
-    fun upload(
+    fun upload(localFile: File, mimeType: MediaType?, targetPath: String): Boolean {
-        localFile: File,
-        mimeType: MediaType?,
-        targetPath: String
-    ): Boolean {
         try {
             val uploadFolderUri: String = remoteChunkUrl + "/" + FileUtils.md5Sum(localFile)
             val davResource = DavResource(
@@ -137,10 +133,7 @@ class ChunkedFileUploader(
     }
 
     @Suppress("Detekt.ComplexMethod")
-    private fun getUploadedChunks(
+    private fun getUploadedChunks(davResource: DavResource, uploadFolderUri: String): MutableList<Chunk> {
-        davResource: DavResource,
-        uploadFolderUri: String
-    ): MutableList<Chunk> {
         val davResponse = DavResponse()
         val memberElements: MutableList<at.bitfire.dav4jvm.Response> = ArrayList()
         val rootElement = arrayOfNulls<at.bitfire.dav4jvm.Response>(1)

app/src/main/java/com/nextcloud/talk/upload/chunked/OnDataTransferProgressListener.kt

@@ -25,7 +25,5 @@
 package com.nextcloud.talk.upload.chunked
 
 interface OnDataTransferProgressListener {
-    fun onTransferProgress(
+    fun onTransferProgress(percentage: Int)
-        percentage: Int
-    )
 }

app/src/main/java/com/nextcloud/talk/upload/normal/FileUploader.kt

@@ -21,12 +21,7 @@ class FileUploader(
     val roomToken: String,
     val ncApi: NcApi
 ) {
-    fun upload(
+    fun upload(sourceFileUri: Uri, fileName: String, remotePath: String, metaData: String?): Observable<Boolean> {
-        sourceFileUri: Uri,
-        fileName: String,
-        remotePath: String,
-        metaData: String?
-    ): Observable<Boolean> {
         return ncApi.uploadFile(
             ApiUtils.getCredentials(currentUser.username, currentUser.token),
             ApiUtils.getUrlForFileUpload(currentUser.baseUrl, currentUser.userId, remotePath),

app/src/main/java/com/nextcloud/talk/utils/BitmapShrinker.kt

@@ -35,21 +35,13 @@ object BitmapShrinker {
     private const val DEGREES_270 = 270f
 
     @JvmStatic
-    fun shrinkBitmap(
+    fun shrinkBitmap(path: String, reqWidth: Int, reqHeight: Int): Bitmap {
-        path: String,
-        reqWidth: Int,
-        reqHeight: Int
-    ): Bitmap {
         val bitmap = decodeBitmap(path, reqWidth, reqHeight)
         return rotateBitmap(path, bitmap)
     }
 
     // solution inspired by https://developer.android.com/topic/performance/graphics/load-bitmap
-    private fun decodeBitmap(
+    private fun decodeBitmap(path: String, requestedWidth: Int, requestedHeight: Int): Bitmap {
-        path: String,
-        requestedWidth: Int,
-        requestedHeight: Int
-    ): Bitmap {
         return BitmapFactory.Options().run {
             inJustDecodeBounds = true
             BitmapFactory.decodeFile(path, this)
@@ -60,11 +52,7 @@ object BitmapShrinker {
     }
 
     // solution inspired by https://developer.android.com/topic/performance/graphics/load-bitmap
-    private fun getInSampleSize(
+    private fun getInSampleSize(options: BitmapFactory.Options, requestedWidth: Int, requestedHeight: Int): Int {
-        options: BitmapFactory.Options,
-        requestedWidth: Int,
-        requestedHeight: Int
-    ): Int {
         val (height: Int, width: Int) = options.run { outHeight to outWidth }
         var inSampleSize = 1
         if (height > requestedHeight || width > requestedWidth) {

app/src/main/java/com/nextcloud/talk/utils/FileViewerUtils.kt

@@ -73,10 +73,7 @@ import java.util.concurrent.ExecutionException
  */
 class FileViewerUtils(private val context: Context, private val user: User) {
 
-    fun openFile(
+    fun openFile(message: ChatMessage, progressUi: ProgressUi) {
-        message: ChatMessage,
-        progressUi: ProgressUi
-    ) {
         val fileName = message.selectedIndividualHashMap!![PreviewMessageViewHolder.KEY_NAME]!!
         val mimetype = message.selectedIndividualHashMap!![PreviewMessageViewHolder.KEY_MIMETYPE]!!
         val link = message.selectedIndividualHashMap!!["link"]!!

app/src/main/java/com/nextcloud/talk/utils/NotificationUtils.kt

@@ -102,10 +102,7 @@ object NotificationUtils {
         }
     }
 
-    private fun createCallsNotificationChannel(
+    private fun createCallsNotificationChannel(context: Context, appPreferences: AppPreferences) {
-        context: Context,
-        appPreferences: AppPreferences
-    ) {
         val audioAttributes =
             AudioAttributes.Builder()
                 .setContentType(AudioAttributes.CONTENT_TYPE_SONIFICATION)
@@ -126,10 +123,7 @@ object NotificationUtils {
         )
     }
 
-    private fun createMessagesNotificationChannel(
+    private fun createMessagesNotificationChannel(context: Context, appPreferences: AppPreferences) {
-        context: Context,
-        appPreferences: AppPreferences
-    ) {
         val audioAttributes =
             AudioAttributes.Builder()
                 .setContentType(AudioAttributes.CONTENT_TYPE_SONIFICATION)
@@ -150,9 +144,7 @@ object NotificationUtils {
         )
     }
 
-    private fun createUploadsNotificationChannel(
+    private fun createUploadsNotificationChannel(context: Context) {
-        context: Context
-    ) {
         createNotificationChannel(
             context,
             Channel(
@@ -166,10 +158,7 @@ object NotificationUtils {
         )
     }
 
-    fun registerNotificationChannels(
+    fun registerNotificationChannels(context: Context, appPreferences: AppPreferences) {
-        context: Context,
-        appPreferences: AppPreferences
-    ) {
         createCallsNotificationChannel(context, appPreferences)
         createMessagesNotificationChannel(context, appPreferences)
         createUploadsNotificationChannel(context)
@@ -197,10 +186,7 @@ object NotificationUtils {
     }
 
     @TargetApi(Build.VERSION_CODES.O)
-    private fun getNotificationChannel(
+    private fun getNotificationChannel(context: Context, channelId: String): NotificationChannel? {
-        context: Context,
-        channelId: String
-    ): NotificationChannel? {
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
             val notificationManager = context.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
             return notificationManager.getNotificationChannel(channelId)
@@ -275,10 +261,7 @@ object NotificationUtils {
         }
     }
 
-    fun isNotificationVisible(
+    fun isNotificationVisible(context: Context?, notificationId: Int): Boolean {
-        context: Context?,
-        notificationId: Int
-    ): Boolean {
         var isVisible = false
 
         val notificationManager = context!!.getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
@@ -319,10 +302,7 @@ object NotificationUtils {
         }
     }
 
-    fun getCallRingtoneUri(
+    fun getCallRingtoneUri(context: Context, appPreferences: AppPreferences): Uri? {
-        context: Context,
-        appPreferences: AppPreferences
-    ): Uri? {
         return getRingtoneUri(
             context,
             appPreferences.callRingtoneUri,
@@ -331,10 +311,7 @@ object NotificationUtils {
         )
     }
 
-    fun getMessageRingtoneUri(
+    fun getMessageRingtoneUri(context: Context, appPreferences: AppPreferences): Uri? {
-        context: Context,
-        appPreferences: AppPreferences
-    ): Uri? {
         return getRingtoneUri(
             context,
             appPreferences.messageRingtoneUri,

app/src/main/java/com/nextcloud/talk/utils/RemoteFileUtils.kt

@@ -31,11 +31,7 @@ import io.reactivex.schedulers.Schedulers
 object RemoteFileUtils {
     private val TAG = RemoteFileUtils::class.java.simpleName
 
-    fun getNewPathIfFileExists(
+    fun getNewPathIfFileExists(ncApi: NcApi, currentUser: User, remotePath: String): String {
-        ncApi: NcApi,
-        currentUser: User,
-        remotePath: String
-    ): String {
         var finalPath = remotePath
         val fileExists = doesFileExist(
             ncApi,
@@ -53,11 +49,7 @@ object RemoteFileUtils {
         return finalPath
     }
 
-    private fun doesFileExist(
+    private fun doesFileExist(ncApi: NcApi, currentUser: User, remotePath: String): Observable<Boolean> {
-        ncApi: NcApi,
-        currentUser: User,
-        remotePath: String
-    ): Observable<Boolean> {
         return ncApi.checkIfFileExists(
             ApiUtils.getCredentials(currentUser.username, currentUser.token),
             ApiUtils.getUrlForFileUpload(
@@ -72,11 +64,7 @@ object RemoteFileUtils {
             }
     }
 
-    private fun getFileNameWithoutCollision(
+    private fun getFileNameWithoutCollision(ncApi: NcApi, currentUser: User, remotePath: String): String {
-        ncApi: NcApi,
-        currentUser: User,
-        remotePath: String
-    ): String {
         val extPos = remotePath.lastIndexOf('.')
         var suffix: String
         var extension = ""

app/src/main/java/com/nextcloud/talk/utils/ShareUtils.kt

@@ -25,11 +25,7 @@ import com.nextcloud.talk.data.user.model.User
 import com.nextcloud.talk.models.json.conversations.Conversation
 
 object ShareUtils {
-    fun getStringForIntent(
+    fun getStringForIntent(context: Context, user: User, conversation: Conversation?): String {
-        context: Context,
-        user: User,
-        conversation: Conversation?
-    ): String {
         return String.format(
             context.resources.getString(R.string.nc_share_text),
             user.baseUrl,

app/src/main/java/third/parties/fresco/BetterImageSpan.kt

@@ -65,13 +65,7 @@ open class BetterImageSpan @JvmOverloads constructor(
     /**
      * Returns the width of the image span and increases the height if font metrics are available.
      */
-    override fun getSize(
+    override fun getSize(paint: Paint, text: CharSequence, start: Int, end: Int, fontMetrics: FontMetricsInt?): Int {
-        paint: Paint,
-        text: CharSequence,
-        start: Int,
-        end: Int,
-        fontMetrics: FontMetricsInt?
-    ): Int {
         updateBounds()
         if (fontMetrics == null) {
             return mWidth