From 62041d2581c2a841caace6a2b624a694ce8c7ca9 Mon Sep 17 00:00:00 2001 From: sowjanyakch Date: Tue, 20 May 2025 18:31:50 +0200 Subject: [PATCH] refactor Signed-off-by: sowjanyakch --- app/src/main/java/com/nextcloud/talk/api/NcApiCoroutines.kt | 1 - .../nextcloud/talk/conversationinfo/ConversationInfoActivity.kt | 2 +- .../conversationinfo/viewmodel/ConversationInfoViewModel.kt | 1 - .../talk/repositories/conversations/ConversationsRepository.kt | 1 - .../preferences/preferencestorage/DatabaseStorageModule.kt | 1 - 5 files changed, 1 insertion(+), 5 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/api/NcApiCoroutines.kt b/app/src/main/java/com/nextcloud/talk/api/NcApiCoroutines.kt index aa356b95f..a2e58dcd1 100644 --- a/app/src/main/java/com/nextcloud/talk/api/NcApiCoroutines.kt +++ b/app/src/main/java/com/nextcloud/talk/api/NcApiCoroutines.kt @@ -179,7 +179,6 @@ interface NcApiCoroutines { @Url url: String ): GenericOverall - @POST suspend fun markConversationAsImportant( @Header("Authorization") authorization: String, diff --git a/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt b/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt index 8db02892e..48a48c6fe 100644 --- a/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt +++ b/app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt @@ -387,6 +387,7 @@ class ConversationInfoActivity : viewModel.markAsImportantResult.observe(this) { uiState -> when (uiState) { is ConversationInfoViewModel.MarkConversationAsImportantViewState.Success -> { + Snackbar.make( binding.root, context.getString(R.string.nc_mark_conversation_as_important), Snackbar.LENGTH_LONG @@ -402,7 +403,6 @@ class ConversationInfoActivity : } } - private fun initMarkConversationAsUnimportantObserver() { viewModel.markAsUnimportantResult.observe(this) { uiState -> when (uiState) { diff --git a/app/src/main/java/com/nextcloud/talk/conversationinfo/viewmodel/ConversationInfoViewModel.kt b/app/src/main/java/com/nextcloud/talk/conversationinfo/viewmodel/ConversationInfoViewModel.kt index ea67f57d4..d530f1c13 100644 --- a/app/src/main/java/com/nextcloud/talk/conversationinfo/viewmodel/ConversationInfoViewModel.kt +++ b/app/src/main/java/com/nextcloud/talk/conversationinfo/viewmodel/ConversationInfoViewModel.kt @@ -366,7 +366,6 @@ class ConversationInfoViewModel @Inject constructor( conversationsRepository.unarchiveConversation(user.getCredentials(), url) } - @Suppress("Detekt.TooGenericExceptionCaught") fun markConversationAsImportant(credentials: String, baseUrl: String, roomToken: String) { viewModelScope.launch { diff --git a/app/src/main/java/com/nextcloud/talk/repositories/conversations/ConversationsRepository.kt b/app/src/main/java/com/nextcloud/talk/repositories/conversations/ConversationsRepository.kt index bda3839d5..2a6e8dd69 100644 --- a/app/src/main/java/com/nextcloud/talk/repositories/conversations/ConversationsRepository.kt +++ b/app/src/main/java/com/nextcloud/talk/repositories/conversations/ConversationsRepository.kt @@ -58,4 +58,3 @@ interface ConversationsRepository { suspend fun markConversationAsUnImportant(credentials: String, baseUrl: String, roomToken: String): GenericOverall } - diff --git a/app/src/main/java/com/nextcloud/talk/utils/preferences/preferencestorage/DatabaseStorageModule.kt b/app/src/main/java/com/nextcloud/talk/utils/preferences/preferencestorage/DatabaseStorageModule.kt index 080c909b3..7a34e7d4e 100644 --- a/app/src/main/java/com/nextcloud/talk/utils/preferences/preferencestorage/DatabaseStorageModule.kt +++ b/app/src/main/java/com/nextcloud/talk/utils/preferences/preferencestorage/DatabaseStorageModule.kt @@ -22,7 +22,6 @@ import com.nextcloud.talk.utils.ApiUtils import com.nextcloud.talk.utils.ApiUtils.getConversationApiVersion import com.nextcloud.talk.utils.ApiUtils.getCredentials import com.nextcloud.talk.utils.ApiUtils.getUrlForMessageExpiration -import com.nextcloud.talk.utils.ApiUtils.getUrlForRoomNotificationCalls import com.nextcloud.talk.utils.ApiUtils.getUrlForRoomNotificationLevel import com.nextcloud.talk.utils.CapabilitiesUtil.hasSpreedFeatureCapability import com.nextcloud.talk.utils.SpreedFeatures