diff --git a/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java b/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java index d6c2f8a63..9c281972a 100644 --- a/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java +++ b/app/src/main/java/com/nextcloud/talk/adapters/items/ConversationItem.java @@ -133,7 +133,7 @@ public class ConversationItem extends AbstractFlexibleItem pinConversation(@Header("Authorization") String authorization, - @Url String url); - - // Url is: /api/{apiVersion}/room/{token}/pin - @DELETE - Observable unpinConversation(@Header("Authorization") String authorization, + Observable addConversationToFavorites(@Header("Authorization") String authorization, @Url String url); + // Url is: /api/{apiVersion}/room/{token}/favorites + @DELETE + Observable removeConversationFromFavorites(@Header("Authorization") String authorization, + @Url String url); + @GET Observable getNotification(@Header("Authorization") String authorization, @Url String url); diff --git a/app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.java b/app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.java index 160da2e8b..1beb3412c 100644 --- a/app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.java +++ b/app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.java @@ -296,7 +296,7 @@ public class ConversationsListController extends BaseController implements Searc Conversation conversation1 = ((ConversationItem) o1).getModel(); Conversation conversation2 = ((ConversationItem) o2).getModel(); return new CompareToBuilder() - .append(conversation2.isPinned(), conversation1.isPinned()) + .append(conversation2.isFavorite(), conversation1.isFavorite()) .append(conversation2.getLastActivity(), conversation1.getLastActivity()) .toComparison(); }); diff --git a/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/CallMenuController.java b/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/CallMenuController.java index dadbfed48..d857e3dfa 100644 --- a/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/CallMenuController.java +++ b/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/CallMenuController.java @@ -132,12 +132,12 @@ public class CallMenuController extends BaseController implements FlexibleAdapte menuItems.add(new MenuItem(getResources().getString(R.string.nc_configure_room), 0, null)); } - if (conversation.isPinned()) { - menuItems.add(new MenuItem(getResources().getString(R.string.nc_unpin), 97, getResources() - .getDrawable(R.drawable.ic_unpin_grey600_24px))); + if (conversation.isFavorite()) { + menuItems.add(new MenuItem(getResources().getString(R.string.nc_remove_from_favorites), 97, getResources() + .getDrawable(R.drawable.ic_star_border_grey600_24dp))); } else { - menuItems.add(new MenuItem(getResources().getString(R.string.nc_pin_to_top), 98, getResources() - .getDrawable(R.drawable.ic_pin_grey600_24px))); + menuItems.add(new MenuItem(getResources().getString(R.string.nc_add_to_favorites), 98, getResources() + .getDrawable(R.drawable.ic_star_grey600_24dp))); } if (conversation.isNameEditable()) { diff --git a/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/OperationsMenuController.java b/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/OperationsMenuController.java index e6a24e50f..076ebdc7b 100644 --- a/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/OperationsMenuController.java +++ b/app/src/main/java/com/nextcloud/talk/controllers/bottomsheet/OperationsMenuController.java @@ -319,14 +319,14 @@ public class OperationsMenuController extends BaseController { case 97: case 98: if (operationCode == 97) { - ncApi.unpinConversation(credentials, ApiUtils.getUrlForConversationPin(currentUser.getBaseUrl(), + ncApi.removeConversationFromFavorites(credentials, ApiUtils.getUrlForConversationFavorites(currentUser.getBaseUrl(), conversation.getToken())) .subscribeOn(Schedulers.newThread()) .observeOn(AndroidSchedulers.mainThread()) .retry(1) .subscribe(operationsObserver); } else { - ncApi.pinConversation(credentials, ApiUtils.getUrlForConversationPin(currentUser.getBaseUrl(), + ncApi.addConversationToFavorites(credentials, ApiUtils.getUrlForConversationFavorites(currentUser.getBaseUrl(), conversation.getToken())) .subscribeOn(Schedulers.newThread()) .observeOn(AndroidSchedulers.mainThread()) diff --git a/app/src/main/java/com/nextcloud/talk/models/json/rooms/Conversation.java b/app/src/main/java/com/nextcloud/talk/models/json/rooms/Conversation.java index 7a57e261a..cd2ecc0c5 100644 --- a/app/src/main/java/com/nextcloud/talk/models/json/rooms/Conversation.java +++ b/app/src/main/java/com/nextcloud/talk/models/json/rooms/Conversation.java @@ -64,8 +64,8 @@ public class Conversation { @JsonField(name = "sessionId") public String sessionId; public String password; - @JsonField(name = "isPinned") - public boolean isPinned; + @JsonField(name = "isFavorite") + public boolean isFavorite; @JsonField(name = "lastActivity") public long lastActivity; @JsonField(name = "unreadMessages") diff --git a/app/src/main/java/com/nextcloud/talk/utils/ApiUtils.java b/app/src/main/java/com/nextcloud/talk/utils/ApiUtils.java index 46f72a11d..1c89528e2 100644 --- a/app/src/main/java/com/nextcloud/talk/utils/ApiUtils.java +++ b/app/src/main/java/com/nextcloud/talk/utils/ApiUtils.java @@ -188,8 +188,8 @@ public class ApiUtils { getApplicationContext().getResources().getString(R.string.nc_push_server_url) + "/devices"; } - public static String getUrlForConversationPin(String baseUrl, String roomToken) { - return baseUrl + ocsApiVersion + "/room/" + roomToken + "/pin"; + public static String getUrlForConversationFavorites(String baseUrl, String roomToken) { + return baseUrl + ocsApiVersion + "/room/" + roomToken + "/favorite"; } public static String getUrlForNotificationWithId(String baseUrl, String notificationId) { diff --git a/app/src/main/res/drawable/ic_unpin_grey600_24px.xml b/app/src/main/res/drawable/ic_star_border_grey600_24dp.xml similarity index 51% rename from app/src/main/res/drawable/ic_unpin_grey600_24px.xml rename to app/src/main/res/drawable/ic_star_border_grey600_24dp.xml index 330ba98db..5d27ad5ab 100644 --- a/app/src/main/res/drawable/ic_unpin_grey600_24px.xml +++ b/app/src/main/res/drawable/ic_star_border_grey600_24dp.xml @@ -19,7 +19,7 @@ --> - + diff --git a/app/src/main/res/drawable/ic_pin_grey600_24px.xml b/app/src/main/res/drawable/ic_star_grey600_24dp.xml similarity index 78% rename from app/src/main/res/drawable/ic_pin_grey600_24px.xml rename to app/src/main/res/drawable/ic_star_grey600_24dp.xml index 406b53eff..5538185bc 100644 --- a/app/src/main/res/drawable/ic_pin_grey600_24px.xml +++ b/app/src/main/res/drawable/ic_star_grey600_24dp.xml @@ -19,7 +19,7 @@ --> - + diff --git a/app/src/main/res/layout/rv_item_conversation_with_last_message.xml b/app/src/main/res/layout/rv_item_conversation_with_last_message.xml index a0ca5ede7..89a9df555 100644 --- a/app/src/main/res/layout/rv_item_conversation_with_last_message.xml +++ b/app/src/main/res/layout/rv_item_conversation_with_last_message.xml @@ -131,17 +131,17 @@ android:layout_width="12dp" android:layout_height="12dp" android:layout_marginBottom="4dp" - android:layout_toStartOf="@id/pinnedConversationImageView" + android:layout_toStartOf="@id/favoriteConversationImageView" android:src="@drawable/ic_lock_grey600_24px" android:visibility="visible"/> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index e22f1d970..4e77c745b 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -102,8 +102,8 @@ New conversation Join via link Join via web - Pin to top - Unpin + Add to favorites + Remove from favorites Select contacts