gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-06-20 12:09:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

improve detekt score: avoid magicNumbers...

Browse Source 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This commit is contained in:
Marcel Hibbe 2023-05-23 11:31:55 +02:00
parent 154ea08c37
commit 5a97e90a82
No known key found for this signature in database
GPG Key ID: C793F8B59F43CE7B
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt
View File

@ -908,6 +908,7 @@ class ChatActivity :
} }
} }
@Suppress("MagicNumber")
private fun updateTypingIndicator() { private fun updateTypingIndicator() {
fun ellipsize(text: String): String { fun ellipsize(text: String): String {
return DisplayUtils.ellipsize(text, TYPING_INDICATOR_MAX_NAME_LENGTH) return DisplayUtils.ellipsize(text, TYPING_INDICATOR_MAX_NAME_LENGTH)
@ -999,12 +1000,16 @@ class ChatActivity :
for ((sessionId, participant) in webSocketInstance?.getUserMap()!!) { for ((sessionId, participant) in webSocketInstance?.getUserMap()!!) {
val ncSignalingMessage = NCSignalingMessage() val ncSignalingMessage = NCSignalingMessage()
ncSignalingMessage.to = sessionId ncSignalingMessage.to = sessionId
ncSignalingMessage.type = "startedTyping" ncSignalingMessage.type = TYPING_STARTED_SIGNALING_MESSAGE_TYPE
signalingMessageSender!!.send(ncSignalingMessage) signalingMessageSender!!.send(ncSignalingMessage)
} }
typingTimer = object : CountDownTimer(4000, 1000) { typingTimer = object : CountDownTimer(
TYPING_DURATION_BEFORE_SENDING_STOP,
TYPING_DURATION_BEFORE_SENDING_STOP
) {
override fun onTick(millisUntilFinished: Long) { override fun onTick(millisUntilFinished: Long) {
// unused atm
} }
override fun onFinish() { override fun onFinish() {
@ -1025,7 +1030,7 @@ class ChatActivity :
for ((sessionId, participant) in webSocketInstance?.getUserMap()!!) { for ((sessionId, participant) in webSocketInstance?.getUserMap()!!) {
val ncSignalingMessage = NCSignalingMessage() val ncSignalingMessage = NCSignalingMessage()
ncSignalingMessage.to = sessionId ncSignalingMessage.to = sessionId
ncSignalingMessage.type = "stoppedTyping" ncSignalingMessage.type = TYPING_STOPPED_SIGNALING_MESSAGE_TYPE
signalingMessageSender!!.send(ncSignalingMessage) signalingMessageSender!!.send(ncSignalingMessage)
} }
} }
@ -3795,5 +3800,8 @@ class ChatActivity :
private const val COMMA = ", " private const val COMMA = ", "
private const val TYPING_INDICATOR_ANIMATION_DURATION = 200L private const val TYPING_INDICATOR_ANIMATION_DURATION = 200L
private const val TYPING_INDICATOR_MAX_NAME_LENGTH = 14 private const val TYPING_INDICATOR_MAX_NAME_LENGTH = 14
private const val TYPING_DURATION_BEFORE_SENDING_STOP = 4000L
private const val TYPING_STARTED_SIGNALING_MESSAGE_TYPE = "startedTyping"
private const val TYPING_STOPPED_SIGNALING_MESSAGE_TYPE = "stoppedTyping"
} }
} }