Merge pull request #2648 from nextcloud/bugfix/2647/fixNpeProcessAutocompleteUserList

avoid NPE in processAutocompleteUserList
This commit is contained in:
Andy Scherzinger 2022-12-23 11:50:43 +01:00 committed by GitHub
commit 528deb1fb4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -130,13 +130,12 @@ class ContactsController(args: Bundle) :
setHasOptionsMenu(true)
sharedApplication!!.componentApplication.inject(this)
existingParticipants = ArrayList()
if (args.containsKey(BundleKeys.KEY_NEW_CONVERSATION)) {
isNewConversationView = true
existingParticipants = ArrayList()
} else if (args.containsKey(BundleKeys.KEY_ADD_PARTICIPANTS)) {
isAddingParticipantsView = true
conversationToken = args.getString(BundleKeys.KEY_TOKEN)
existingParticipants = ArrayList()
if (args.containsKey(BundleKeys.KEY_EXISTING_PARTICIPANTS)) {
existingParticipants = args.getStringArrayList(BundleKeys.KEY_EXISTING_PARTICIPANTS)
}
@ -497,8 +496,9 @@ class ContactsController(args: Bundle) :
val actorTypeConverter = EnumActorTypeConverter()
val newUserItemList: MutableList<AbstractFlexibleItem<*>> = ArrayList<AbstractFlexibleItem<*>>()
for (autocompleteUser in autocompleteUsersList) {
if (autocompleteUser.id != currentUser!!.userId &&
!existingParticipants!!.contains(autocompleteUser.id!!)
if (autocompleteUser.id != null &&
autocompleteUser.id != currentUser!!.userId &&
!existingParticipants!!.contains(autocompleteUser.id)
) {
participant = createParticipant(autocompleteUser, actorTypeConverter)
val headerTitle = getHeaderTitle(participant)