Fix "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE" SpotBugs complaint

Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
Joas Schilling 2021-05-14 14:40:28 +02:00
parent 16ca03cb5c
commit 4790e7b7e4
No known key found for this signature in database
GPG Key ID: 7076EA9751AACDDA

View File

@ -74,56 +74,64 @@ public class AddParticipantsToConversation extends Worker {
String credentials = ApiUtils.getCredentials(user.getUsername(), user.getToken()); String credentials = ApiUtils.getCredentials(user.getUsername(), user.getToken());
RetrofitBucket retrofitBucket; RetrofitBucket retrofitBucket;
for (String userId : selectedUserIds) { if (selectedUserIds != null) {
retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipant(apiVersion, user.getBaseUrl(), for (String userId : selectedUserIds) {
conversationToken, retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipant(apiVersion, user.getBaseUrl(),
userId); conversationToken,
userId);
ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap()) ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap())
.subscribeOn(Schedulers.io()) .subscribeOn(Schedulers.io())
.blockingSubscribe(); .blockingSubscribe();
}
} }
for (String groupId : selectedGroupIds) { if (selectedGroupIds != null) {
retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipantWithSource( for (String groupId : selectedGroupIds) {
apiVersion, retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipantWithSource(
user.getBaseUrl(), apiVersion,
conversationToken, user.getBaseUrl(),
"groups", conversationToken,
groupId "groups",
); groupId
);
ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap()) ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap())
.subscribeOn(Schedulers.io()) .subscribeOn(Schedulers.io())
.blockingSubscribe(); .blockingSubscribe();
}
} }
for (String circleId : selectedCircleIds) { if (selectedCircleIds != null) {
retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipantWithSource( for (String circleId : selectedCircleIds) {
apiVersion, retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipantWithSource(
user.getBaseUrl(), apiVersion,
conversationToken, user.getBaseUrl(),
"circles", conversationToken,
circleId "circles",
); circleId
);
ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap()) ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap())
.subscribeOn(Schedulers.io()) .subscribeOn(Schedulers.io())
.blockingSubscribe(); .blockingSubscribe();
}
} }
for (String email : selectedEmails) { if (selectedEmails != null) {
retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipantWithSource( for (String email : selectedEmails) {
apiVersion, retrofitBucket = ApiUtils.getRetrofitBucketForAddParticipantWithSource(
user.getBaseUrl(), apiVersion,
conversationToken, user.getBaseUrl(),
"emails", conversationToken,
email "emails",
); email
);
ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap()) ncApi.addParticipant(credentials, retrofitBucket.getUrl(), retrofitBucket.getQueryMap())
.subscribeOn(Schedulers.io()) .subscribeOn(Schedulers.io())
.blockingSubscribe(); .blockingSubscribe();
}
} }
eventBus.post(new EventStatus(user.getId(), EventStatus.EventType.PARTICIPANTS_UPDATE, true)); eventBus.post(new EventStatus(user.getId(), EventStatus.EventType.PARTICIPANTS_UPDATE, true));