From 4305e9ccf84171ad460d0366828a115f85bd5124 Mon Sep 17 00:00:00 2001 From: o0lwj0o <373911550@qq.com> Date: Fri, 31 Aug 2018 15:38:46 +0800 Subject: [PATCH] improve performance see https://stackoverflow.com/questions/44334233/why-is-the-stringbuilder-chaining-pattern-sb-appendx-appendy-faster-than-reg/44338950 --- .../talk/controllers/CallController.java | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/controllers/CallController.java b/app/src/main/java/com/nextcloud/talk/controllers/CallController.java index c9ec70307..8f954a5b0 100644 --- a/app/src/main/java/com/nextcloud/talk/controllers/CallController.java +++ b/app/src/main/java/com/nextcloud/talk/controllers/CallController.java @@ -1554,16 +1554,15 @@ public class CallController extends BaseController { StringBuilder stringBuilder = new StringBuilder(); - stringBuilder.append("{"); - stringBuilder.append("\"fn\":\""); - stringBuilder.append(StringEscapeUtils.escapeJson(LoganSquare.serialize(ncMessageWrapper - .getSignalingMessage()))).append("\""); - stringBuilder.append(","); - stringBuilder.append("\"sessionId\":"); - stringBuilder.append("\"").append(StringEscapeUtils.escapeJson(callSession)).append("\""); - stringBuilder.append(","); - stringBuilder.append("\"ev\":\"message\""); - stringBuilder.append("}"); + stringBuilder.append("{") + .append("\"fn\":\"") + .append(StringEscapeUtils.escapeJson(LoganSquare.serialize(ncMessageWrapper.getSignalingMessage()))).append("\"") + .append(",") + .append("\"sessionId\":") + .append("\"").append(StringEscapeUtils.escapeJson(callSession)).append("\"") + .append(",") + .append("\"ev\":\"message\"") + .append("}"); List strings = new ArrayList<>(); String stringToSend = stringBuilder.toString(); @@ -1771,4 +1770,4 @@ public class CallController extends BaseController { showCallControls(); } } -} \ No newline at end of file +}