gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-07-10 22:34:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

extract methods from fetchRooms method

Browse Source 
reduce complexity for codacy score..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This commit is contained in:
Marcel Hibbe 2022-10-13 13:26:31 +02:00
parent 871f798720
commit 42e6d9b52f
No known key found for this signature in database
GPG Key ID: C793F8B59F43CE7B
1 changed files with 52 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
app/src/main/java/com/nextcloud/talk/controllers/ConversationsListController.kt
View File

@ -523,51 +523,9 @@ class ConversationsListController(bundle: Bundle) :
adapterWasNull = false adapterWasNull = false
binding.loadingContent.visibility = View.GONE binding.loadingContent.visibility = View.GONE
} }
if (ocs!!.data!!.isNotEmpty()) { initOverallLayout(ocs!!.data!!.isNotEmpty())
if (binding.emptyLayout.visibility != View.GONE) {
binding.emptyLayout.visibility = View.GONE
}
if (binding.swipeRefreshLayoutView.visibility != View.VISIBLE) {
binding.swipeRefreshLayoutView.visibility = View.VISIBLE
}
} else {
if (binding.emptyLayout.visibility != View.VISIBLE) {
binding.emptyLayout.visibility = View.VISIBLE
}
if (binding.swipeRefreshLayoutView.visibility != View.GONE) {
binding.swipeRefreshLayoutView.visibility = View.GONE
}
}
for (conversation in ocs.data!!) { for (conversation in ocs.data!!) {
if (bundle.containsKey(KEY_FORWARD_HIDE_SOURCE_ROOM) && conversation.roomId == bundle.getString( addToConversationItems(conversation)
KEY_FORWARD_HIDE_SOURCE_ROOM
)
) {
continue
}
val headerTitle: String = resources!!.getString(R.string.conversations)
var genericTextHeaderItem: GenericTextHeaderItem
if (!callHeaderItems.containsKey(headerTitle)) {
genericTextHeaderItem = GenericTextHeaderItem(headerTitle, viewThemeUtils)
callHeaderItems[headerTitle] = genericTextHeaderItem
}
if (activity != null) {
val conversationItem = ConversationItem(
conversation,
currentUser,
activity,
viewThemeUtils
)
conversationItems.add(conversationItem)
val conversationItemWithHeader = ConversationItem(
conversation,
currentUser,
activity,
callHeaderItems[headerTitle],
viewThemeUtils
)
conversationItemsWithHeader.add(conversationItemWithHeader)
}
} }
sortConversations(conversationItems) sortConversations(conversationItems)
sortConversations(conversationItemsWithHeader) sortConversations(conversationItemsWithHeader)
@ -593,6 +551,56 @@ class ConversationsListController(bundle: Bundle) :
} }
} }
private fun initOverallLayout(isConversationListNotEmpty: Boolean) {
if (isConversationListNotEmpty) {
if (binding.emptyLayout.visibility != View.GONE) {
binding.emptyLayout.visibility = View.GONE
}
if (binding.swipeRefreshLayoutView.visibility != View.VISIBLE) {
binding.swipeRefreshLayoutView.visibility = View.VISIBLE
}
} else {
if (binding.emptyLayout.visibility != View.VISIBLE) {
binding.emptyLayout.visibility = View.VISIBLE
}
if (binding.swipeRefreshLayoutView.visibility != View.GONE) {
binding.swipeRefreshLayoutView.visibility = View.GONE
}
}
}
private fun addToConversationItems(conversation: Conversation) {
if (bundle.containsKey(KEY_FORWARD_HIDE_SOURCE_ROOM) && conversation.roomId == bundle.getString(
KEY_FORWARD_HIDE_SOURCE_ROOM
)
) {
return
}
val headerTitle: String = resources!!.getString(R.string.conversations)
val genericTextHeaderItem: GenericTextHeaderItem
if (!callHeaderItems.containsKey(headerTitle)) {
genericTextHeaderItem = GenericTextHeaderItem(headerTitle, viewThemeUtils)
callHeaderItems[headerTitle] = genericTextHeaderItem
}
if (activity != null) {
val conversationItem = ConversationItem(
conversation,
currentUser,
activity,
viewThemeUtils
)
conversationItems.add(conversationItem)
val conversationItemWithHeader = ConversationItem(
conversation,
currentUser,
activity,
callHeaderItems[headerTitle],
viewThemeUtils
)
conversationItemsWithHeader.add(conversationItemWithHeader)
}
}
private fun showErrorDialog() { private fun showErrorDialog() {
val dialogBuilder = MaterialAlertDialogBuilder(binding.floatingActionButton.context) val dialogBuilder = MaterialAlertDialogBuilder(binding.floatingActionButton.context)
.setIcon( .setIcon(