From 9fe39603c3db5c104a8b5daa5d212599196c6802 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Tue, 3 Jun 2025 12:09:50 +0200 Subject: [PATCH 1/4] rely on canDeleteConversation to show "Delete conversation" button Signed-off-by: Marcel Hibbe --- .../nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt b/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt index 7aa5052c5..b329b5a09 100644 --- a/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt +++ b/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt @@ -118,7 +118,6 @@ class ConversationsListBottomDialog( currentUser.capabilities?.spreedCapability!!, SpreedFeatures.FAVORITES ) - val canModerate = ConversationUtils.canModerate(conversation, currentUser.capabilities?.spreedCapability!!) binding.conversationRemoveFromFavorites.visibility = setVisibleIf( hasFavoritesCapability && conversation.favorite @@ -149,7 +148,7 @@ class ConversationsListBottomDialog( ) binding.conversationOperationDelete.visibility = setVisibleIf( - canModerate + conversation.canDeleteConversation ) binding.conversationOperationLeave.visibility = setVisibleIf( From 14fd9b4af808c14ed54730cb21c7a526c7ec04d1 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Tue, 3 Jun 2025 12:12:04 +0200 Subject: [PATCH 2/4] rely on conversationOperationLeave to show "Leave conversation" button Signed-off-by: Marcel Hibbe --- .../talk/ui/dialog/ConversationsListBottomDialog.kt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt b/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt index b329b5a09..b1d16b955 100644 --- a/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt +++ b/app/src/main/java/com/nextcloud/talk/ui/dialog/ConversationsListBottomDialog.kt @@ -152,10 +152,7 @@ class ConversationsListBottomDialog( ) binding.conversationOperationLeave.visibility = setVisibleIf( - conversation.canLeaveConversation && - // leaving is by api not possible for the last user with moderator permissions. - // for now, hide this option for all moderators. - !ConversationUtils.canModerate(conversation, currentUser.capabilities!!.spreedCapability!!) + conversation.canLeaveConversation ) } From cc8e24121355c863b59b55347df62f4e322d8968 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Tue, 3 Jun 2025 12:16:16 +0200 Subject: [PATCH 3/4] show "Delete conversation" as last entry same as for web/iOS Signed-off-by: Marcel Hibbe --- .../layout/dialog_conversation_operations.xml | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/app/src/main/res/layout/dialog_conversation_operations.xml b/app/src/main/res/layout/dialog_conversation_operations.xml index b4c554219..a6ef03540 100644 --- a/app/src/main/res/layout/dialog_conversation_operations.xml +++ b/app/src/main/res/layout/dialog_conversation_operations.xml @@ -256,36 +256,6 @@ android:textSize="@dimen/bottom_sheet_text_size" /> - - - - - - - + + + + + + + From 12cb0825ca5b6a2a8f7ffed9034945d918ac8015 Mon Sep 17 00:00:00 2001 From: Marcel Hibbe Date: Tue, 3 Jun 2025 12:17:32 +0200 Subject: [PATCH 4/4] show "Archive conversation" just before Leave & Delete same as for web/iOS Signed-off-by: Marcel Hibbe --- .../layout/dialog_conversation_operations.xml | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/app/src/main/res/layout/dialog_conversation_operations.xml b/app/src/main/res/layout/dialog_conversation_operations.xml index a6ef03540..6062ff11e 100644 --- a/app/src/main/res/layout/dialog_conversation_operations.xml +++ b/app/src/main/res/layout/dialog_conversation_operations.xml @@ -195,6 +195,36 @@ android:textSize="@dimen/bottom_sheet_text_size" /> + + + + + + + - - - - - - -