gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-06-19 03:29:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

bump detekt score

Browse Source 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
This commit is contained in:
Andy Scherzinger 2021-06-21 22:51:56 +02:00
parent 2b71d30637
commit 2cf5952fae
No known key found for this signature in database
GPG Key ID: 6CADC7E3523C308B
3 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/src/main/java/com/nextcloud/talk/adapters/messages/IncomingVoiceMessageViewHolder.kt
View File

@ -116,7 +116,7 @@ class IncomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
override fun onStartTrackingTouch(seekBar: SeekBar) {} override fun onStartTrackingTouch(seekBar: SeekBar) {}
override fun onProgressChanged(seekBar: SeekBar, progress: Int, fromUser: Boolean) { override fun onProgressChanged(seekBar: SeekBar, progress: Int, fromUser: Boolean) {
if (mediaPlayer != null && fromUser) { if (mediaPlayer != null && fromUser) {
mediaPlayer!!.seekTo(progress * 1000) mediaPlayer!!.seekTo(progress * SEEKBAR_BASE)
} }
} }
}) })
@ -269,10 +269,10 @@ class IncomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
activity.runOnUiThread(object : Runnable { activity.runOnUiThread(object : Runnable {
override fun run() { override fun run() {
if (mediaPlayer != null) { if (mediaPlayer != null) {
val currentPosition: Int = mediaPlayer!!.currentPosition / 1000 val currentPosition: Int = mediaPlayer!!.currentPosition / SEEKBAR_BASE
binding.seekbar.progress = currentPosition binding.seekbar.progress = currentPosition
} }
handler.postDelayed(this, 1000) handler.postDelayed(this, SECOND)
} }
}) })
@ -301,12 +301,12 @@ class IncomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
} }
} }
binding.seekbar.max = mediaPlayer!!.duration / 1000 binding.seekbar.max = mediaPlayer!!.duration / SEEKBAR_BASE
mediaPlayer!!.setOnCompletionListener { mediaPlayer!!.setOnCompletionListener {
binding.playBtn.visibility = View.VISIBLE binding.playBtn.visibility = View.VISIBLE
binding.pauseBtn.visibility = View.GONE binding.pauseBtn.visibility = View.GONE
binding.seekbar.progress = 0 binding.seekbar.progress = SEEKBAR_START
handler.removeCallbacksAndMessages(null) handler.removeCallbacksAndMessages(null)
mediaPlayer?.stop() mediaPlayer?.stop()
mediaPlayer?.release() mediaPlayer?.release()
@ -392,5 +392,8 @@ class IncomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
companion object { companion object {
private const val TAG = "VoiceInMessageView" private const val TAG = "VoiceInMessageView"
private const val SECOND: Long = 1000
private const val SEEKBAR_BASE: Int = 1000
private const val SEEKBAR_START: Int = 0
} }
} }

13
app/src/main/java/com/nextcloud/talk/adapters/messages/OutcomingVoiceMessageViewHolder.kt
View File

@ -109,7 +109,7 @@ class OutcomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
override fun onStartTrackingTouch(seekBar: SeekBar) {} override fun onStartTrackingTouch(seekBar: SeekBar) {}
override fun onProgressChanged(seekBar: SeekBar, progress: Int, fromUser: Boolean) { override fun onProgressChanged(seekBar: SeekBar, progress: Int, fromUser: Boolean) {
if (mediaPlayer != null && fromUser) { if (mediaPlayer != null && fromUser) {
mediaPlayer!!.seekTo(progress * 1000) mediaPlayer!!.seekTo(progress * SEEKBAR_BASE)
} }
} }
}) })
@ -245,10 +245,10 @@ class OutcomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
activity.runOnUiThread(object : Runnable { activity.runOnUiThread(object : Runnable {
override fun run() { override fun run() {
if (mediaPlayer != null) { if (mediaPlayer != null) {
val currentPosition: Int = mediaPlayer!!.currentPosition / 1000 val currentPosition: Int = mediaPlayer!!.currentPosition / SEEKBAR_BASE
binding.seekbar.progress = currentPosition binding.seekbar.progress = currentPosition
} }
handler.postDelayed(this, 1000) handler.postDelayed(this, SECOND)
} }
}) })
@ -277,12 +277,12 @@ class OutcomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
} }
} }
binding.seekbar.max = mediaPlayer!!.duration / 1000 binding.seekbar.max = mediaPlayer!!.duration / SEEKBAR_BASE
mediaPlayer!!.setOnCompletionListener { mediaPlayer!!.setOnCompletionListener {
binding.playBtn.visibility = View.VISIBLE binding.playBtn.visibility = View.VISIBLE
binding.pauseBtn.visibility = View.GONE binding.pauseBtn.visibility = View.GONE
binding.seekbar.progress = 0 binding.seekbar.progress = SEEKBAR_START
handler.removeCallbacksAndMessages(null) handler.removeCallbacksAndMessages(null)
mediaPlayer?.stop() mediaPlayer?.stop()
mediaPlayer?.release() mediaPlayer?.release()
@ -368,5 +368,8 @@ class OutcomingVoiceMessageViewHolder(incomingView: View) : MessageHolders
companion object { companion object {
private const val TAG = "VoiceOutMessageView" private const val TAG = "VoiceOutMessageView"
private const val SECOND: Long = 1000
private const val SEEKBAR_BASE: Int = 1000
private const val SEEKBAR_START: Int = 0
} }
} }

2
detekt.yml
View File

@ -1,5 +1,5 @@
build: build:
maxIssues: 202 maxIssues: 223
weights: weights:
# complexity: 2 # complexity: 2
# LongParameterList: 1 # LongParameterList: 1