add comments where to implement the raise hand signaling message

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This commit is contained in:
Marcel Hibbe 2023-02-15 15:16:32 +01:00
parent 0ea13c1ec7
commit 2637884a83
No known key found for this signature in database
GPG Key ID: C793F8B59F43CE7B
2 changed files with 17 additions and 18 deletions

View File

@ -421,6 +421,22 @@ public class CallActivity extends CallBaseActivity {
} else if (viewState instanceof RaiseHandViewModel.LoweredHandState) { } else if (viewState instanceof RaiseHandViewModel.LoweredHandState) {
binding.lowerHandButton.setVisibility(View.GONE); binding.lowerHandButton.setVisibility(View.GONE);
} }
// TODO: build&send raiseHand message (if not possible in RaiseHandViewModel, just do it here..)
// if (isConnectionEstablished() && peerConnectionWrapperList != null) {
// if (!hasMCU) {
// for (PeerConnectionWrapper peerConnectionWrapper : peerConnectionWrapperList) {
// peerConnectionWrapper.raiseHand(...);
// }
// } else {
// for (PeerConnectionWrapper peerConnectionWrapper : peerConnectionWrapperList) {
// if (peerConnectionWrapper.getSessionId().equals(webSocketClient.getSessionId())) {
// peerConnectionWrapper.raiseHand(...);
// break;
// }
// }
// }
// }
}); });
callRecordingViewModel = new ViewModelProvider(this, viewModelFactory).get((CallRecordingViewModel.class)); callRecordingViewModel = new ViewModelProvider(this, viewModelFactory).get((CallRecordingViewModel.class));
@ -1248,22 +1264,6 @@ public class CallActivity extends CallBaseActivity {
public void clickRaiseOrLowerHandButton() { public void clickRaiseOrLowerHandButton() {
raiseHandViewModel.clickHandButton(); raiseHandViewModel.clickHandButton();
// TODO: fix how to build&send the message
// if (isConnectionEstablished() && peerConnectionWrapperList != null) {
// if (!hasMCU) {
// for (PeerConnectionWrapper peerConnectionWrapper : peerConnectionWrapperList) {
// peerConnectionWrapper.raiseHand(raise);
// }
// } else {
// for (PeerConnectionWrapper peerConnectionWrapper : peerConnectionWrapperList) {
// if (peerConnectionWrapper.getSessionId().equals(webSocketClient.getSessionId())) {
// peerConnectionWrapper.raiseHand(raise);
// break;
// }
// }
// }
// }
} }

View File

@ -191,8 +191,7 @@ public class PeerConnectionWrapper {
} }
public void raiseHand(Boolean raise) { public void raiseHand(Boolean raise) {
// TODO: build&send raiseHand message (either here or via RaiseHandViewModel)
// TODO: fix how to build&send the message
// NCMessagePayload ncMessagePayload = new NCMessagePayload(); // NCMessagePayload ncMessagePayload = new NCMessagePayload();
// ncMessagePayload.setState(raise); // ncMessagePayload.setState(raise);
// ncMessagePayload.setTimestamp(System.currentTimeMillis()); // ncMessagePayload.setTimestamp(System.currentTimeMillis());