gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-06-20 03:59:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1425 from nextcloud/bugfix/1424/conversationInfoViewBindingNPE

Browse Source 
Binding can be null due to async call
This commit is contained in:
Andy Scherzinger 2021-07-09 11:30:18 +02:00 committed by GitHub
commit 1333ce768a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 58 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

102
app/src/main/java/com/nextcloud/talk/controllers/ConversationInfoController.kt
View File

@ -427,8 +427,15 @@ class ConversationInfoController(args: Bundle) :
participantsDisposable = d participantsDisposable = d
} }
@Suppress("Detekt.TooGenericExceptionCaught")
override fun onNext(participantsOverall: ParticipantsOverall) { override fun onNext(participantsOverall: ParticipantsOverall) {
handleParticipants(participantsOverall.ocs.data) try {
handleParticipants(participantsOverall.ocs.data)
} catch (npe: NullPointerException) {
// view binding can be null
// since this is called asynchronously and UI might have been destroyed in the meantime
Log.i(TAG, "UI destroyed - view binding already gone")
}
} }
override fun onError(e: Throwable) { override fun onError(e: Throwable) {
@ -513,55 +520,62 @@ class ConversationInfoController(args: Bundle) :
roomDisposable = d roomDisposable = d
} }
@Suppress("Detekt.TooGenericExceptionCaught")
override fun onNext(roomOverall: RoomOverall) { override fun onNext(roomOverall: RoomOverall) {
conversation = roomOverall.ocs.data try {
conversation = roomOverall.ocs.data
val conversationCopy = conversation val conversationCopy = conversation
if (conversationCopy!!.canModerate(conversationUser)) { if (conversationCopy!!.canModerate(conversationUser)) {
binding.addParticipantsAction.visibility = View.VISIBLE binding.addParticipantsAction.visibility = View.VISIBLE
} else {
binding.addParticipantsAction.visibility = View.GONE
}
if (isAttached && (!isBeingDestroyed || !isDestroyed)) {
binding.ownOptions.visibility = View.VISIBLE
setupWebinaryView()
if (!conversation!!.canLeave(conversationUser)) {
binding.leaveConversationAction.visibility = View.GONE
} else { } else {
binding.leaveConversationAction.visibility = View.VISIBLE binding.addParticipantsAction.visibility = View.GONE
} }
if (!conversation!!.canDelete(conversationUser)) { if (isAttached && (!isBeingDestroyed || !isDestroyed)) {
binding.deleteConversationAction.visibility = View.GONE binding.ownOptions.visibility = View.VISIBLE
} else {
binding.deleteConversationAction.visibility = View.VISIBLE setupWebinaryView()
if (!conversation!!.canLeave(conversationUser)) {
binding.leaveConversationAction.visibility = View.GONE
} else {
binding.leaveConversationAction.visibility = View.VISIBLE
}
if (!conversation!!.canDelete(conversationUser)) {
binding.deleteConversationAction.visibility = View.GONE
} else {
binding.deleteConversationAction.visibility = View.VISIBLE
}
if (Conversation.ConversationType.ROOM_SYSTEM == conversation!!.type) {
binding.notificationSettingsView.muteCalls.visibility = View.GONE
}
getListOfParticipants()
binding.progressBar.visibility = View.GONE
binding.conversationInfoName.visibility = View.VISIBLE
binding.displayNameText.text = conversation!!.displayName
if (conversation!!.description != null && !conversation!!.description.isEmpty()) {
binding.descriptionText.text = conversation!!.description
binding.conversationDescription.visibility = View.VISIBLE
}
loadConversationAvatar()
adjustNotificationLevelUI()
binding.notificationSettingsView.notificationSettings.visibility = View.VISIBLE
} }
} catch (npe: NullPointerException) {
if (Conversation.ConversationType.ROOM_SYSTEM == conversation!!.type) { // view binding can be null
binding.notificationSettingsView.muteCalls.visibility = View.GONE // since this is called asynchronously and UI might have been destroyed in the meantime
} Log.i(TAG, "UI destroyed - view binding already gone")
getListOfParticipants()
binding.progressBar.visibility = View.GONE
binding.conversationInfoName.visibility = View.VISIBLE
binding.displayNameText.text = conversation!!.displayName
if (conversation!!.description != null && !conversation!!.description.isEmpty()) {
binding.descriptionText.text = conversation!!.description
binding.conversationDescription.visibility = View.VISIBLE
}
loadConversationAvatar()
adjustNotificationLevelUI()
binding.notificationSettingsView.notificationSettings.visibility = View.VISIBLE
} }
} }
@ -986,7 +1000,7 @@ class ConversationInfoController(args: Bundle) :
} }
companion object { companion object {
private const val TAG = "ConversationInfoController" private const val TAG = "ConversationInfControll"
private const val ID_DELETE_CONVERSATION_DIALOG = 0 private const val ID_DELETE_CONVERSATION_DIALOG = 0
private val LOW_EMPHASIS_OPACITY: Float = 0.38f private val LOW_EMPHASIS_OPACITY: Float = 0.38f
} }