diff --git a/app/src/main/java/com/nextcloud/talk/activities/TakePhotoActivity.java b/app/src/main/java/com/nextcloud/talk/activities/TakePhotoActivity.java index ff2d3fd25..9922234ff 100644 --- a/app/src/main/java/com/nextcloud/talk/activities/TakePhotoActivity.java +++ b/app/src/main/java/com/nextcloud/talk/activities/TakePhotoActivity.java @@ -97,10 +97,6 @@ public class TakePhotoActivity extends AppCompatActivity { imageCapture, preview); - viewModel.getCameraSelectorToggleButtonImageResource() - .observe( - this, - res -> binding.switchCamera.setIcon(ContextCompat.getDrawable(this, res))); viewModel.getTorchToggleButtonImageResource() .observe( this, diff --git a/app/src/main/java/com/nextcloud/talk/models/TakePictureViewModel.java b/app/src/main/java/com/nextcloud/talk/models/TakePictureViewModel.java index 2b0daf47f..87ceb5614 100644 --- a/app/src/main/java/com/nextcloud/talk/models/TakePictureViewModel.java +++ b/app/src/main/java/com/nextcloud/talk/models/TakePictureViewModel.java @@ -38,9 +38,7 @@ public class TakePictureViewModel extends ViewModel { @NonNull private CameraSelector cameraSelector = DEFAULT_BACK_CAMERA; - @NonNull - private final MutableLiveData cameraSelectorToggleButtonImageResource = - new MutableLiveData<>(R.drawable.ic_baseline_camera_front_24); + @NonNull private final MutableLiveData torchEnabled = new MutableLiveData<>(Boolean.FALSE); @@ -49,17 +47,11 @@ public class TakePictureViewModel extends ViewModel { return this.cameraSelector; } - public LiveData getCameraSelectorToggleButtonImageResource() { - return this.cameraSelectorToggleButtonImageResource; - } - public void toggleCameraSelector() { if (this.cameraSelector == DEFAULT_BACK_CAMERA) { this.cameraSelector = DEFAULT_FRONT_CAMERA; - this.cameraSelectorToggleButtonImageResource.postValue(R.drawable.ic_baseline_camera_rear_24); } else { this.cameraSelector = DEFAULT_BACK_CAMERA; - this.cameraSelectorToggleButtonImageResource.postValue(R.drawable.ic_baseline_camera_front_24); } } diff --git a/app/src/main/res/drawable/ic_baseline_camera_front_24.xml b/app/src/main/res/drawable/ic_baseline_camera_front_24.xml deleted file mode 100644 index 25c1a79b8..000000000 --- a/app/src/main/res/drawable/ic_baseline_camera_front_24.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - diff --git a/app/src/main/res/drawable/ic_baseline_camera_rear_24.xml b/app/src/main/res/drawable/ic_baseline_camera_rear_24.xml deleted file mode 100644 index 51cea2177..000000000 --- a/app/src/main/res/drawable/ic_baseline_camera_rear_24.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - diff --git a/app/src/main/res/drawable/ic_baseline_flip_camera_android_24.xml b/app/src/main/res/drawable/ic_baseline_flip_camera_android_24.xml new file mode 100644 index 000000000..951aa1f62 --- /dev/null +++ b/app/src/main/res/drawable/ic_baseline_flip_camera_android_24.xml @@ -0,0 +1,16 @@ + + + + + diff --git a/app/src/main/res/layout/activity_take_picture.xml b/app/src/main/res/layout/activity_take_picture.xml index 0f674bd83..402583e80 100644 --- a/app/src/main/res/layout/activity_take_picture.xml +++ b/app/src/main/res/layout/activity_take_picture.xml @@ -52,6 +52,7 @@ android:layout_marginStart="0dp" android:layout_marginTop="12dp" android:layout_marginEnd="12dp" + android:layout_marginBottom="12dp" android:contentDescription="@string/take_photo_toggle_torch" android:insetLeft="4dp" android:insetTop="4dp" @@ -66,8 +67,9 @@ app:iconPadding="0dp" app:iconSize="24dp" app:iconTint="@color/white" - app:layout_constraintEnd_toEndOf="parent" - app:layout_constraintTop_toTopOf="parent" /> + app:layout_constraintBottom_toBottomOf="@id/takePhoto" + app:layout_constraintEnd_toStartOf="@id/takePhoto" + app:layout_constraintStart_toStartOf="parent" /> + app:layout_constraintBottom_toBottomOf="@id/takePhoto" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintStart_toEndOf="@id/takePhoto" />