gronod/talk-android
1
0
Fork 1
mirror of https://github.com/nextcloud/talk-android synced 2025-06-20 03:59:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Some refactoring

Browse Source 
- Removed spelling issues
- Removed unneded boolean comparisons
- Improve code readability by reformatting

Signed-off-by: Tim Krüger <t@timkrueger.me>
This commit is contained in:
Tim Krüger 2021-11-02 12:04:53 +01:00
parent fce5fca535
commit 036cf7c590
No known key found for this signature in database
GPG Key ID: FECE3A7222C52A4E
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/com/nextcloud/talk/controllers/ChatController.kt
View File

@ -585,7 +585,7 @@ class ChatController(args: Bundle) :
if (layoutManager!!.findFirstCompletelyVisibleItemPosition() < newMessagesCount) { if (layoutManager!!.findFirstCompletelyVisibleItemPosition() < newMessagesCount) {
newMessagesCount = 0 newMessagesCount = 0
if (binding.popupBubbleView.isShown == true) { if (binding.popupBubbleView.isShown) {
binding.popupBubbleView.hide() binding.popupBubbleView.hide()
} }
} }
@ -640,7 +640,7 @@ class ChatController(args: Bundle) :
} }
} catch (npe: NullPointerException) { } catch (npe: NullPointerException) {
// view binding can be null // view binding can be null
// since this is called asynchrously and UI might have been destroyed in the meantime // since this is called asynchronously and UI might have been destroyed in the meantime
Log.i(TAG, "UI destroyed - view binding already gone") Log.i(TAG, "UI destroyed - view binding already gone")
} }
} }

10
app/src/main/java/com/nextcloud/talk/controllers/ConversationInfoController.kt
View File

@ -1007,8 +1007,14 @@ class ConversationInfoController(args: Bundle) :
R.drawable.ic_lock_grey600_24px, R.drawable.ic_lock_grey600_24px,
context!!.getString(R.string.nc_attendee_pin, participant.attendeePin) context!!.getString(R.string.nc_attendee_pin, participant.attendeePin)
), ),
BasicListItemWithImage(R.drawable.ic_pencil_grey600_24dp, context!!.getString(R.string.nc_promote)), BasicListItemWithImage(
BasicListItemWithImage(R.drawable.ic_pencil_grey600_24dp, context!!.getString(R.string.nc_demote)), R.drawable.ic_pencil_grey600_24dp,
context!!.getString(R.string.nc_promote)
),
BasicListItemWithImage(
R.drawable.ic_pencil_grey600_24dp,
context!!.getString(R.string.nc_demote)
),
BasicListItemWithImage( BasicListItemWithImage(
R.drawable.ic_delete_grey600_24dp, R.drawable.ic_delete_grey600_24dp,
context!!.getString(R.string.nc_remove_participant) context!!.getString(R.string.nc_remove_participant)