read_media details: duplicate imdb, missing tmdb, bogus tvmaze identifier #6
Notifications
Due Date
No due date set.
Blocks
Reference: gronod/ombi-mcp#6
Reference in New Issue
Block a user
Summary
read_mediadetailsemits a duplicatedimdbidentifier and drops thetmdbidentifier for movie lookups, and emits a bogustvmazeidentifier echoing the TMDB id for tv lookups viaprovider: tmdb.Environment
develop@d047d76Reproduction
Expected
tmdb:348,imdb:tt0078748(each once).tmdb:1206,tvdb:75150,imdb:tt0227882,tvmaze:4828.Actual
imdb:tt0078748twice and notmdbidentifier (also reproduced on Yummy/2207).tmdb:1206,tvdb:75150,imdb×2, andtvmaze:1206— the TMDB id echoed into the tvmaze namespace (real TVMaze id is 4828). The tvdb details route (provider: tvdb) correctly emitstvmaze:42468for Seven Up!.Causes
In
internal/tools/project.go:projectSearchMediaemitsimdbfromimdbId;projectFullMovie/projectFullTVthen appendimdbagain fromexternalIds.imdbId→ duplicate.tmdbis only read fromtheMovieDbId, which is absent on the details route response — no fallback toidorexternalIds.projectSearchMedialabelsseriesIdastvmazeunconditionally; on the v2moviedbrouteseriesIdholds the TMDB id, not a TVMaze id — it should only be emitted from the v1 TVMaze-backed route.projectFullMovieaddsbelongsToCollection.idas atmdbmovie identifier — that id is the collection's TMDB id, not the movie's.Correlation IDs
ffd178db79e1a625485193db,9eb53c95559f4dfc1f6d56c9(movie),6b38ec2a17b930b7e9c9d242,103e31ec38b54a78717c6cee(tv)