From e67d9960224e8bf8638ab8496bd3038222405f75 Mon Sep 17 00:00:00 2001 From: Pierre Labastie Date: Thu, 8 Feb 2024 13:56:10 +0100 Subject: [PATCH 01/21] Typo in expect Thanks to rhubarbpieguy for the report Fix #5436 --- chapter08/expect.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/expect.xml b/chapter08/expect.xml index 5c21e390f..76795782d 100644 --- a/chapter08/expect.xml +++ b/chapter08/expect.xml @@ -63,7 +63,7 @@ other virtual kernel file systems) mounted correctly. Then reenter the chroot environment following . This issue needs to be resolved before continuing, or the test suites - requring Expect (for example the test suites of Bash, Binutils, GCC, + requiring Expect (for example the test suites of Bash, Binutils, GCC, GDBM, and of course Expect itself) will fail catastrophically, and other subtle breakages may also happen. From fe99d50d949255dbb5a9f28d9fcbaa05b4bc55a2 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sat, 10 Feb 2024 18:49:55 +0800 Subject: [PATCH 02/21] systemd: Fix a bug breaking systemd-verify an instantiated unit It's breaking Git test suite (and maybe other things). --- chapter01/changelog.xml | 10 ++++++++++ chapter01/whatsnew.xml | 12 ++++++++---- chapter03/patches.xml | 4 +--- chapter08/systemd.xml | 7 ++++--- patches.ent | 3 +++ 5 files changed, 26 insertions(+), 10 deletions(-) diff --git a/chapter01/changelog.xml b/chapter01/changelog.xml index fa7fc12c4..0a646f658 100644 --- a/chapter01/changelog.xml +++ b/chapter01/changelog.xml @@ -40,6 +40,16 @@ appropriate for the entry or if needed the entire day's listitem. --> + + 2024-02-10 + + + [xry111] - Fix a bug in systemd breaking running + systemd-analyze on an instantiated systemd unit. + + + + 2024-02-02 diff --git a/chapter01/whatsnew.xml b/chapter01/whatsnew.xml index 5faf938b7..f7b9ed05c 100644 --- a/chapter01/whatsnew.xml +++ b/chapter01/whatsnew.xml @@ -294,10 +294,6 @@ &bash-upstream-fixes-patch; - - setuptools-&setuptools-version; - - &pkgconf-upstream-fix-patch; @@ -306,6 +302,14 @@ &readline-fixes-patch; + + setuptools-&setuptools-version; + + + + &systemd-upstream-patch; + + diff --git a/chapter03/patches.xml b/chapter03/patches.xml index f05fbd604..c48e2ce0e 100644 --- a/chapter03/patches.xml +++ b/chapter03/patches.xml @@ -142,15 +142,13 @@ - Now fix a security vulnerability in the DNSSEC verification of - systemd-resolved: + systemd-resolved and a bug breaking running + systemd-analyze verify on an instantiated systemd + unit: -sed -e '/return FLAGS_SET.*AUTHENTICATED/s/(t/(dt/' \ - -i src/resolve/resolved-dns-transaction.c +patch -Np1 -i ../&systemd-upstream-patch; Prepare systemd for compilation: diff --git a/patches.ent b/patches.ent index a6e3a306e..b10f24414 100644 --- a/patches.ent +++ b/patches.ent @@ -38,3 +38,6 @@ + + + From b1998a2375cac0e9ecf56c663adde5263a2eb9a5 Mon Sep 17 00:00:00 2001 From: Pierre Labastie Date: Sat, 10 Feb 2024 12:28:12 +0100 Subject: [PATCH 03/21] Use http://cdn.docbook.org to run on other distros Upstream documentation has been changed a few years ago to point to https rather than http, but for example ubuntu-2023.10 still has only http in its catalog file. So use http here, and change the catalog file in blfs to have both http and https... --- stylesheets/lfs-xsl/lfs-l10n.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stylesheets/lfs-xsl/lfs-l10n.xml b/stylesheets/lfs-xsl/lfs-l10n.xml index 783bb1118..b47ee7f76 100644 --- a/stylesheets/lfs-xsl/lfs-l10n.xml +++ b/stylesheets/lfs-xsl/lfs-l10n.xml @@ -1,5 +1,5 @@ - + From 96026a103a050853137c244a66145e7006092f17 Mon Sep 17 00:00:00 2001 From: Bruce Dubbs Date: Mon, 12 Feb 2024 11:05:36 -0600 Subject: [PATCH 04/21] Package updates. Update to shadow-4.14.4. Update to setuptools-69.1.0 (Python module). Update to python-3.12.2. Update to pkgconf-2.1.1. Update to MarkupSafe-2.1.5 (Python module). Update to man-pages-6.06. Update to expat-2.6.0. Update to linux-6.7.4. --- chapter01/changelog.xml | 38 ++++++++++++++++++++++++++++++++ chapter01/whatsnew.xml | 16 ++++++-------- chapter03/patches.xml | 4 ++-- chapter08/pkgconf.xml | 5 ----- packages.ent | 48 ++++++++++++++++++++--------------------- patches.ent | 4 ---- 6 files changed, 70 insertions(+), 45 deletions(-) diff --git a/chapter01/changelog.xml b/chapter01/changelog.xml index 0a646f658..f7bd0c405 100644 --- a/chapter01/changelog.xml +++ b/chapter01/changelog.xml @@ -40,6 +40,44 @@ appropriate for the entry or if needed the entire day's listitem. --> + + 2024-02-12 + + + [bdubbs] - Update to shadow-4.14.4. Fixes + #5437. + + + [bdubbs] - Update to setuptools-69.1.0 (Python module). Fixes + #5439. + + + [bdubbs] - Update to python-3.12.2. Fixes + #5434. + + + [bdubbs] - Update to pkgconf-2.1.1. Fixes + #5432. + + + [bdubbs] - Update to MarkupSafe-2.1.5 (Python module). Fixes + #5431. + + + [bdubbs] - Update to man-pages-6.06. Fixes + #5438. + + + [bdubbs] - Update to expat-2.6.0. Fixes + #5435. + + + [bdubbs] - Update to linux-6.7.4. Fixes + #5433. + + + + 2024-02-10 diff --git a/chapter01/whatsnew.xml b/chapter01/whatsnew.xml index f7b9ed05c..d1cc11706 100644 --- a/chapter01/whatsnew.xml +++ b/chapter01/whatsnew.xml @@ -71,9 +71,9 @@ - + @@ -176,9 +176,9 @@ Man-DB-&man-db-version; - + MarkupSafe-&markupsafe-version; @@ -224,9 +224,9 @@ - Setuptools-&setuptools-version; - --> + Shadow-&shadow-version; @@ -294,10 +294,6 @@ &bash-upstream-fixes-patch; - - &pkgconf-upstream-fix-patch; - - &readline-fixes-patch; diff --git a/chapter03/patches.xml b/chapter03/patches.xml index c48e2ce0e..067dc9aea 100644 --- a/chapter03/patches.xml +++ b/chapter03/patches.xml @@ -117,7 +117,7 @@ --> - + Readline Upstream Fix Patch - &readline-fixes-patch-size;: diff --git a/chapter08/pkgconf.xml b/chapter08/pkgconf.xml index 139e0c810..3e7e737fa 100644 --- a/chapter08/pkgconf.xml +++ b/chapter08/pkgconf.xml @@ -44,11 +44,6 @@ Installation of Pkgconf - - Fix a regression in pkgconf-2.1.0 breaking BLFS packages: - - patch -Np1 -i ../&pkgconf-upstream-fix-patch; - Prepare Pkgconf for compilation: ./configure --prefix=/usr \ diff --git a/packages.ent b/packages.ent index 6d319968a..ccff2c3f2 100644 --- a/packages.ent +++ b/packages.ent @@ -156,10 +156,10 @@ - - + + - + @@ -431,12 +431,12 @@ - + - + - + - + - + - + - - + + @@ -631,18 +631,18 @@ - + - + - - + + - + diff --git a/patches.ent b/patches.ent index b10f24414..17966e30c 100644 --- a/patches.ent +++ b/patches.ent @@ -26,10 +26,6 @@ - - - - From d93d11b5bae6562aed6c51bf632feccd4a0b9657 Mon Sep 17 00:00:00 2001 From: Bruce Dubbs Date: Wed, 14 Feb 2024 09:37:42 -0600 Subject: [PATCH 05/21] Package updates and stats updates. Update to meson-1.3.2. Update to shadow-4.14.5. --- chapter01/changelog.xml | 12 +++- packages.ent | 136 ++++++++++++++++++++-------------------- 2 files changed, 79 insertions(+), 69 deletions(-) diff --git a/chapter01/changelog.xml b/chapter01/changelog.xml index f7bd0c405..43423619c 100644 --- a/chapter01/changelog.xml +++ b/chapter01/changelog.xml @@ -40,11 +40,21 @@ appropriate for the entry or if needed the entire day's listitem. --> + + 2024-02-14 + + + [bdubbs] - Update to meson-1.3.2. Fixes + #5442. + + + + 2024-02-12 - [bdubbs] - Update to shadow-4.14.4. Fixes + [bdubbs] - Update to shadow-4.14.5. Fixes #5437. diff --git a/packages.ent b/packages.ent index ccff2c3f2..9d7cf84df 100644 --- a/packages.ent +++ b/packages.ent @@ -18,7 +18,7 @@ - + @@ -26,7 +26,7 @@ - + @@ -34,8 +34,8 @@ - - + + @@ -44,8 +44,8 @@ - - + + @@ -55,14 +55,14 @@ - + - + @@ -70,9 +70,9 @@ - + - + @@ -86,7 +86,7 @@ - + @@ -109,10 +109,10 @@ - + - - + + @@ -128,7 +128,7 @@ - + @@ -146,14 +146,14 @@ - + - + @@ -161,7 +161,7 @@ - + @@ -205,7 +205,7 @@ - + @@ -213,9 +213,9 @@ - + - + @@ -223,10 +223,10 @@ - - + + - + @@ -243,7 +243,7 @@ - + @@ -260,10 +260,10 @@ - - - - + + + + @@ -304,7 +304,7 @@ - + @@ -330,7 +330,7 @@ - + @@ -354,7 +354,7 @@ - + @@ -362,7 +362,7 @@ - + @@ -419,7 +419,7 @@ - + @@ -475,7 +475,7 @@ - + @@ -491,13 +491,13 @@ - + - + - + @@ -515,8 +515,8 @@ - - + + @@ -544,8 +544,8 @@ - - + + @@ -569,7 +569,7 @@ - + @@ -584,7 +584,7 @@ - + @@ -604,10 +604,10 @@ - - - - + + + + @@ -636,15 +636,15 @@ - - + + - - + + - + - + @@ -677,7 +677,7 @@ - + @@ -688,7 +688,7 @@ - + @@ -707,9 +707,9 @@ - - - + + + @@ -718,7 +718,7 @@ - + @@ -733,9 +733,9 @@ - + - + @@ -746,8 +746,8 @@ - - + + @@ -762,7 +762,7 @@ - + @@ -772,7 +772,7 @@ - + @@ -784,7 +784,7 @@ - + @@ -793,5 +793,5 @@ - + From 28614cdda5ef1b1173ea36b237a3b38c802dc93c Mon Sep 17 00:00:00 2001 From: Bruce Dubbs Date: Wed, 14 Feb 2024 15:41:22 -0600 Subject: [PATCH 06/21] Update descriptions for some test failures. --- chapter08/gcc.xml | 17 +++++++++++------ chapter08/glibc.xml | 5 +++++ chapter08/procps.xml | 2 ++ 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/chapter08/gcc.xml b/chapter08/gcc.xml index 84cf8a86f..b97b0b8cc 100644 --- a/chapter08/gcc.xml +++ b/chapter08/gcc.xml @@ -177,15 +177,20 @@ su tester -c "PATH=$PATH make -k check" files does not account for the - -enable-default-ssp option.--> - Two tests named copy.cc and - pr56837.c are known to fail. - + Eight gcc tests (out of over 185,000), data-model-4.c, pr56837.c, + and six "analyzer" tests are known to fail. + + One libstdc++ test (out of over 15000), copy.cc, is known to fail. + + For g++, 21 tests (out of approximately 250,000), 14 "AddressSanitizer*" + tests and 7 interception-malloc-test-1.C tests, are known to fail. + Additionally, several tests in the vect directory are known to fail if the hardware does not support AVX. - + A few unexpected failures cannot always be avoided. The GCC developers are usually aware of these issues, but have not resolved them yet. Unless the test results are vastly different from those at the above URL, diff --git a/chapter08/glibc.xml b/chapter08/glibc.xml index 64ed3b630..e8432fe19 100644 --- a/chapter08/glibc.xml +++ b/chapter08/glibc.xml @@ -163,6 +163,11 @@ esac is known to fail in the LFS chroot environment. + + Three nptl/tst-thread-affinity* + tests are known to fail. + + - + From 0800455fb6619c45f5313b3dbc74db88ec4922a4 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sun, 18 Feb 2024 15:34:58 +0800 Subject: [PATCH 08/21] Glibc: Re-organize test failures and mention how to rule out timed out tests Glibc tests occansionally fail due to a timeout because: 1. The hardware is slower than the developers expected. 2. Some tests use multiple or even all CPU cores internally, for e.g. with 8 active CPU cores we may end up running 8 tests (due to -j8) each of them uses 8 cores in the worst case, resulting a severe congestion. I'm almost sure nptl/tst-thread-affinity* are cases of 2. Let's document how to rule out the timed out tests instead of making the list of known failures longer and longer. --- chapter08/glibc.xml | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/chapter08/glibc.xml b/chapter08/glibc.xml index e8432fe19..10fccb3a9 100644 --- a/chapter08/glibc.xml +++ b/chapter08/glibc.xml @@ -163,34 +163,34 @@ esac is known to fail in the LFS chroot environment. - - Three nptl/tst-thread-affinity* - tests are known to fail. - - - - - - - The stdlib/tst-arc4random-thread - test is known to fail if the host kernel is relatively old. - - Some tests, for example - nss/tst-nss-files-hosts-multi, - are known to fail on relatively slow systems due to an internal - timeout. + nss/tst-nss-files-hosts-multi and + nptl/tst-thread-affinity* + are known to fail due to a timeout (especially when the system is + relatively slow and/or running the test suite with multiple + parallel make jobs). These tests can be identified with: + + + grep "Timed out" -l $(find -name \*.out) + + It's possible to re-run a single test with enlarged timeout + with + TIMEOUTFACTOR=<factor> + make test t=<test name>. + For example, TIMEOUTFACTOR=10 make test + t=nss/tst-nss-files-hosts-multi will re-run + nss/tst-nss-files-hosts-multi with ten times + the original timeout. Additionally, some tests may fail with a relatively old CPU - model or host kernel version. + model (for example + elf/tst-cpu-features-cpuinfo) or host kernel + version (for example + stdlib/tst-arc4random-thread). From 5f2ba8ce99b9e189615f9ae975e9ea1b902173de Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sun, 18 Feb 2024 22:09:17 +0800 Subject: [PATCH 09/21] gcc: Decorate test failures, remove outdated comments, ... move comments for upstream PR links to correct location. BTW data-model-4.c is also in analyzer directory, so we can just say 7 analyzer tests. --- chapter08/gcc.xml | 44 +++++++++++++------------------------------- 1 file changed, 13 insertions(+), 31 deletions(-) diff --git a/chapter08/gcc.xml b/chapter08/gcc.xml index b97b0b8cc..66f803273 100644 --- a/chapter08/gcc.xml +++ b/chapter08/gcc.xml @@ -172,48 +172,30 @@ su tester -c "PATH=$PATH make -k check" url="&test-results;"/> and . - - - Eight gcc tests (out of over 185,000), data-model-4.c, pr56837.c, - and six "analyzer" tests are known to fail. + + Eight gcc tests (out of over 185,000): + pr56837.c + and seven tests in the analyzer + directory are known to fail. - One libstdc++ test (out of over 15000), copy.cc, is known to fail. + + One libstdc++ test (out of over 15000), copy.cc, is + known to fail. - For g++, 21 tests (out of approximately 250,000), 14 "AddressSanitizer*" - tests and 7 interception-malloc-test-1.C tests, are known to fail. + For g++, 21 tests (out of approximately 250,000): 14 + AddressSanitizer* + tests and 7 interception-malloc-test-1.C tests, are + known to fail. Additionally, several tests in the vect directory are known to fail if the hardware does not support AVX. - + A few unexpected failures cannot always be avoided. The GCC developers are usually aware of these issues, but have not resolved them yet. Unless the test results are vastly different from those at the above URL, it is safe to continue. - - Install the package: make install From 109afb297c1f15f2c6ccb33af74a486e3f7a8aa1 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Fri, 23 Feb 2024 03:33:14 +0800 Subject: [PATCH 10/21] dependencies: Kbd can use Linux-PAM The book already mentions the vlock program needs PAM to be built, but in dependencies page we say Kbd has no external optional dependencies. This is obviously incorrect... --- appendices/dependencies.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/appendices/dependencies.xml b/appendices/dependencies.xml index 158ed0f04..2fb197ffa 100644 --- a/appendices/dependencies.xml +++ b/appendices/dependencies.xml @@ -1566,7 +1566,9 @@ &external; - None + + Linux-PAM + From 3827fcf6e2e7c5ae7303e8a2c3af8f4b3b813874 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Fri, 23 Feb 2024 23:47:06 +0800 Subject: [PATCH 11/21] vim: Set TERM=xterm-256color for test I spent some time investigating the difference of vim test results from different editors. It turns out the value of TERM can affect the test results in a deterministic way: when TERM=xterm-256color all tests pass, when TERM=linux one test fails, and when TERM=vt100 20+ tests fail. As we are redirecting the output to a file, the actual type of the terminal does not matter and we can just specify a value known to work. --- chapter08/vim.xml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/chapter08/vim.xml b/chapter08/vim.xml index 030c50442..0a1af29be 100644 --- a/chapter08/vim.xml +++ b/chapter08/vim.xml @@ -71,10 +71,13 @@ Now run the tests as user tester: -su tester -c "LANG=en_US.UTF-8 make -j1 test" &> vim-test.log +su tester -c "TERM=xterm-256color LANG=en_US.UTF-8 make -j1 test" \ + &> vim-test.log The test suite outputs a lot of binary data to the screen. This can - cause issues with the settings of the current terminal. The problem can be + cause issues with the settings of the current terminal (especially while + we are overriding the TERM variable to satisify some + assumptions of the test suite). The problem can be avoided by redirecting the output to a log file as shown above. A successful test will result in the words "ALL DONE" in the log file at completion. From bd003a8a8c6bd262b5f00ebea8387ebc4cc2657b Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sat, 24 Feb 2024 13:15:49 +0800 Subject: [PATCH 12/21] glibc: Correctly mark revision='systemd' for a paragraph in update note --- chapter08/glibc.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/glibc.xml b/chapter08/glibc.xml index 10fccb3a9..486164cf9 100644 --- a/chapter08/glibc.xml +++ b/chapter08/glibc.xml @@ -258,7 +258,7 @@ esac rm -f /usr/sbin/nscd - + If this system (prior to LFS 12.1, exclusive) is based on Systemd, it's also needed to disable and stop the nscd service now: From 4aa6831f14175db6e3792cf84bb992fcfde832bd Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sat, 24 Feb 2024 13:24:20 +0800 Subject: [PATCH 13/21] glibc: Don't "overwrite" libcrypt.so.1* when updating As we've already concluded, overwriting a shared object can crash running processes using code or data from this shared object. For example if gdm is crashed, we may leave the system unusable :(. --- chapter08/glibc.xml | 2 +- chapter08/libxcrypt.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chapter08/glibc.xml b/chapter08/glibc.xml index 486164cf9..49eeceb1c 100644 --- a/chapter08/glibc.xml +++ b/chapter08/glibc.xml @@ -240,7 +240,7 @@ esac you MUST follow the note in Libxcrypt section to install libcrypt.so.1* - (overwritting + (replacing libcrypt.so.1 from the prior Glibc installation). diff --git a/chapter08/libxcrypt.xml b/chapter08/libxcrypt.xml index 7c6cc15ba..fb4c4adaa 100644 --- a/chapter08/libxcrypt.xml +++ b/chapter08/libxcrypt.xml @@ -110,7 +110,7 @@ --disable-static \ --disable-failure-tokens make -cp -av .libs/libcrypt.so.1* /usr/lib +cp -av --remove-destination .libs/libcrypt.so.1* /usr/lib From 64be5a4bfa0cde2defacc744d2f137edbea64c12 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sun, 25 Feb 2024 00:53:31 +0800 Subject: [PATCH 14/21] dependencies: Gettext may use system libunistring When system libunistring is not installed (for eg building LFS), a shipped copy of libunistring is used. --- appendices/dependencies.xml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/appendices/dependencies.xml b/appendices/dependencies.xml index 2fb197ffa..d3fd94707 100644 --- a/appendices/dependencies.xml +++ b/appendices/dependencies.xml @@ -1047,7 +1047,15 @@ &external; - libxml2 + + + libunistring + + and + + libxml2 + + From 141a1fa181f9f5526bfb5d2129c319d31baf2698 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Mon, 26 Feb 2024 14:52:49 +0800 Subject: [PATCH 15/21] vim: Minor decoration --- chapter08/vim.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chapter08/vim.xml b/chapter08/vim.xml index 0a1af29be..88322132e 100644 --- a/chapter08/vim.xml +++ b/chapter08/vim.xml @@ -79,8 +79,8 @@ we are overriding the TERM variable to satisify some assumptions of the test suite). The problem can be avoided by redirecting the output to a log file as shown above. A - successful test will result in the words "ALL DONE" in the log file - at completion. + successful test will result in the words ALL + DONE in the log file at completion. Install the package: From 64ef2e93db6afd606da03af486b2354d77bdf34c Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 27 Feb 2024 00:40:57 +0800 Subject: [PATCH 16/21] coreutils: Comment out test-getlogin failure It seems fixed by the upstream. (Well, they'd claimed this "fixed" in 2014 but we were still seeing this failure in ten years. However let me trust the upstream once again...) Link: https://lists.gnu.org/archive/html/bug-gnulib/2022-06/msg00079.html --- chapter08/coreutils.xml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/chapter08/coreutils.xml b/chapter08/coreutils.xml index 655e0dd66..94c276360 100644 --- a/chapter08/coreutils.xml +++ b/chapter08/coreutils.xml @@ -129,8 +129,14 @@ FORCE_UNSAFE_CONFIGURE=1 ./configure \ + understand it! The test-getlogin test may fail in the LFS chroot environment. + 20240226: Commented out as it seems the upstream has root-caused and + fixed the issue. I've checked the fix is in Coreutils 9.4 release + tarball: + + https://lists.gnu.org/archive/html/bug-gnulib/2022-06/msg00079.html +--> Remove the temporary group: From ed38e9d2cfd1c73d5dbb9ad5da63728412229718 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 27 Feb 2024 01:29:23 +0800 Subject: [PATCH 17/21] procps: Be more specific about the known ps test failure --- chapter08/procps.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/chapter08/procps.xml b/chapter08/procps.xml index 5f3e5c6e6..9b014face 100644 --- a/chapter08/procps.xml +++ b/chapter08/procps.xml @@ -74,7 +74,10 @@ make check - One test in the "ps" tests is known to fail. + One test named + ps with output flag bsdtime,cputime,etime,etimes + is known to fail if the host kernel is not built with + CONFIG_BSD_PROCESS_ACCT enabled. Install the package: From 74f9697fdd649307ecd89ae99a7189e5fc387583 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 27 Feb 2024 17:43:47 +0800 Subject: [PATCH 18/21] changelog: Mark procps-4.0.4 as a security fix It contains a fix for CVE-2023-4016, rated low and only affecting 32-bit systems. --- chapter01/changelog.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chapter01/changelog.xml b/chapter01/changelog.xml index 43423619c..72ef95ea8 100644 --- a/chapter01/changelog.xml +++ b/chapter01/changelog.xml @@ -697,7 +697,8 @@ #5330. - [bdubbs] - Update to procps-ng-4.0.4. Fixes + [bdubbs] - Update to procps-ng-4.0.4 (security fix + for 32-bit systems). Fixes #5335. From 4e486a2efc09142cc3b56d34e8254b729651e062 Mon Sep 17 00:00:00 2001 From: Bruce Dubbs Date: Tue, 20 Feb 2024 14:54:50 -0600 Subject: [PATCH 19/21] Typo (cherry picked from commit 0c06e1e04885602e3eda558edb6ea1b6885cf277) --- chapter10/kernel.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter10/kernel.xml b/chapter10/kernel.xml index cf0b30f35..6eafeaf27 100644 --- a/chapter10/kernel.xml +++ b/chapter10/kernel.xml @@ -87,7 +87,7 @@ un-tarring. There are several ways to configure the kernel options. Usually, - This is done through a menu-driven interface, for example: + this is done through a menu-driven interface, for example: make menuconfig From 283f7119a0d5cc3c433159b3dbcdb8d9ab5c3e99 Mon Sep 17 00:00:00 2001 From: Bruce Dubbs Date: Sun, 18 Feb 2024 13:44:30 -0600 Subject: [PATCH 20/21] Typos (cherry picked from commit a2808be815801c0b3bb2d7c1919b1623bb19c12e) --- appendices/dependencies.xml | 2 +- chapter08/glibc.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/appendices/dependencies.xml b/appendices/dependencies.xml index d3fd94707..9d92de448 100644 --- a/appendices/dependencies.xml +++ b/appendices/dependencies.xml @@ -2480,7 +2480,7 @@ &testsuites; - Iana-Etc, Less. and Procps-ng + Iana-Etc, Less, and Procps-ng diff --git a/chapter08/glibc.xml b/chapter08/glibc.xml index 49eeceb1c..39923c03b 100644 --- a/chapter08/glibc.xml +++ b/chapter08/glibc.xml @@ -535,7 +535,7 @@ unset ZONEINFO zic ... -p ... This creates the posixrules file. We use - New York because POSIX requires the daylight savings time rules + New York because POSIX requires the daylight saving time rules to be in accordance with US rules. From 23f436750e4bf87e802b9b6015197db4ec2561cc Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 27 Feb 2024 20:53:38 +0800 Subject: [PATCH 21/21] procps: Add "-k" for make check and document two additional failures --- chapter08/procps.xml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/chapter08/procps.xml b/chapter08/procps.xml index 9b014face..3f229c713 100644 --- a/chapter08/procps.xml +++ b/chapter08/procps.xml @@ -72,12 +72,20 @@ To run the test suite, run: -make check +make -k check One test named ps with output flag bsdtime,cputime,etime,etimes is known to fail if the host kernel is not built with - CONFIG_BSD_PROCESS_ACCT enabled. + CONFIG_BSD_PROCESS_ACCT enabled. + + Two tests named + pmap X with unreachable process and + pmap XX with unreachable process are known to + fail occasionally. Install the package: