From 94dc9c26d2ee84c7d81b785d2d9124d630e2ca17 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sat, 8 Feb 2025 08:42:47 +0800 Subject: [PATCH 1/3] Revert "Fix cmds installing python docs (permissions)" This reverts commit dc8572f2413a4d25444bb1237ea2a01dfba60429. The permission issue seems fixed upstream: after I untar the tarball with --no-same-owner --no-same-permissions as root, all files are 644 and all directories are 755 (proven via find -type f -not -perm 644 and find -type d -not -perm 755). --- chapter08/python.xml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/chapter08/python.xml b/chapter08/python.xml index 75f18945f..ebda61181 100644 --- a/chapter08/python.xml +++ b/chapter08/python.xml @@ -162,21 +162,21 @@ EOF install -v -dm755 /usr/share/doc/python-&python-version;/html -tar --no-same-owner \ - -xvf ../python-&python-version;-docs-html.tar.bz2 -cp -R --no-preserve=mode python-&python-version;-docs-html/* \ - /usr/share/doc/python-&python-version;/html +tar --strip-components=1 \ + --no-same-owner \ + --no-same-permissions \ + -C /usr/share/doc/python-&python-version;/html \ + -xvf ../python-&python-version;-docs-html.tar.bz2 The meaning of the documentation install commands: - (tar) and (cp) + and Ensure the installed files have the correct ownership and permissions. Without these options, tar - will install the package files with the upstream creator's values - and files would have restrictive permissions. + will install the package files with the upstream creator's values. From 3f2235c907b373df5ae9512e1e9ada97443d9427 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sat, 8 Feb 2025 09:17:21 +0800 Subject: [PATCH 2/3] coreutils: Better explain the autoreconf and automake commands --- chapter08/coreutils.xml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/chapter08/coreutils.xml b/chapter08/coreutils.xml index 70eb1e318..1acad31ca 100644 --- a/chapter08/coreutils.xml +++ b/chapter08/coreutils.xml @@ -62,22 +62,28 @@ FORCE_UNSAFE_CONFIGURE=1 ./configure \ --enable-no-install-program=kill,uptime - The meaning of the configure options: + The meaning of the commands and configure options: - autoreconf + autoreconf -fv The patch for internationalization has modified the build system, so the configuration files must - be regenerated. + be regenerated. Normally we would use the + -i option to update the standard + auxilary files, but for this package it does not work because + configure.ac specified an old gettext + version. - automake + automake -af - Work around a problem with an older versions of autotools. - + The automake auxilary files were not updated by + autoreconf due to the missing + -i option. This command updates them + to prevent a build failure. From cb1b56efce6ba83f916bcb5da854045f10054ad5 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Sat, 8 Feb 2025 09:50:39 +0800 Subject: [PATCH 3/3] coreutils: Remove outdated known failures They seem fixed with 9.6. --- chapter08/coreutils.xml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/chapter08/coreutils.xml b/chapter08/coreutils.xml index 1acad31ca..dfe6d0da5 100644 --- a/chapter08/coreutils.xml +++ b/chapter08/coreutils.xml @@ -149,12 +149,6 @@ FORCE_UNSAFE_CONFIGURE=1 ./configure \ groupdel dummy - - Two tests, tests/cp/preserve-mode.sh and - tests/mv/acl.sh, are known to - fail in the chroot environment, but pass in a complete system. - - Install the package: make install