From 0d487e09e603e7a86fdec911d9b0b4d53c4f1ac5 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 14 Sep 2022 00:03:45 +0800 Subject: [PATCH 1/6] gcc: update sanity check command and output for default PIE Scrt1.o is used for PIE, instead of crt1.o. --- chapter08/gcc.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chapter08/gcc.xml b/chapter08/gcc.xml index 65f502dde..c5c446e9a 100644 --- a/chapter08/gcc.xml +++ b/chapter08/gcc.xml @@ -227,11 +227,11 @@ readelf -l a.out | grep ': /lib' Now make sure that we're setup to use the correct start files: -grep -o '/usr/lib.*/crt[1in].*succeeded' dummy.log +grep -E -o '/usr/lib.*/S?crt[1in].*succeeded' dummy.log The output of the last command should be: -/usr/lib/gcc/x86_64-pc-linux-gnu/&gcc-version;/../../../../lib/crt1.o succeeded +/usr/lib/gcc/x86_64-pc-linux-gnu/&gcc-version;/../../../../lib/Scrt1.o succeeded /usr/lib/gcc/x86_64-pc-linux-gnu/&gcc-version;/../../../../lib/crti.o succeeded /usr/lib/gcc/x86_64-pc-linux-gnu/&gcc-version;/../../../../lib/crtn.o succeeded From 951e07508bf0147030fe0aae229faf481824c02f Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 14 Sep 2022 00:08:40 +0800 Subject: [PATCH 2/6] ncurses: remove an outdated sentence about libncurses++w.a We now build the C++ binding as shared library. --- chapter08/ncurses.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/chapter08/ncurses.xml b/chapter08/ncurses.xml index e8d42bc7a..d68bfa44c 100644 --- a/chapter08/ncurses.xml +++ b/chapter08/ncurses.xml @@ -131,8 +131,7 @@ in-place. It may crash the shell process which is using code and data from the library file. Install the package with DESTDIR, and replace the library file correctly using - install command. A useless static archive which is - not handled by configure is also removed: + install command: make DESTDIR=$PWD/dest install install -vm755 dest/usr/lib/libncursesw.so.&ncurses-version; /usr/lib From 36c456218741f71f13b6e767d53a5a0bcfca36de Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 14 Sep 2022 00:15:12 +0800 Subject: [PATCH 3/6] ncurses: mention libncurses++w in contents --- chapter08/ncurses.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/chapter08/ncurses.xml b/chapter08/ncurses.xml index d68bfa44c..58221d144 100644 --- a/chapter08/ncurses.xml +++ b/chapter08/ncurses.xml @@ -211,6 +211,7 @@ cp -av lib/lib*.so.5* /usr/lib libformw.so, libmenuw.so, libncursesw.so, + libncurses++w.so, libpanelw.so, and their non-wide-character counterparts without "w" in the library names. @@ -365,6 +366,16 @@ cp -av lib/lib*.so.5* /usr/lib + + libncurses++w + + Contains C++ binding for other libraries in this package + + libncurses++w + + + + libformw From 2844cded1c151d8b6f3e073e5f32119bef352892 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 14 Sep 2022 01:32:24 +0800 Subject: [PATCH 4/6] libtool: document test failures related to grep-3.8 --- chapter08/libtool.xml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/chapter08/libtool.xml b/chapter08/libtool.xml index 2082c6cf9..e7eeb3ad9 100644 --- a/chapter08/libtool.xml +++ b/chapter08/libtool.xml @@ -52,7 +52,7 @@ To test the results, issue: -make check +make -k check The test time for libtool can be reduced significantly on a system with multiple cores. To do this, append @@ -61,8 +61,9 @@ percent. Five tests are known to fail in the LFS build environment due - to a circular dependency, but all tests pass if rechecked after - automake is installed. + to a circular dependency, but these tests pass if rechecked after + automake is installed. Additionally, with grep-3.8, two tests will + trigger a warning for non-POSIX regular expressions and fail. Install the package: From 395eb462ba1fc1835ec9b6018f4427f41d78fa00 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 14 Sep 2022 01:34:15 +0800 Subject: [PATCH 5/6] bash: document egrep warnings in tests The test suite says "Any output from any test, unless otherwise noted, indicates a possible anomaly". So we should note those warnings. --- chapter08/bash.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/chapter08/bash.xml b/chapter08/bash.xml index 4ea981d5b..1dd020f28 100644 --- a/chapter08/bash.xml +++ b/chapter08/bash.xml @@ -87,6 +87,10 @@ lassign [wait] _ _ _ value exit $value EOF + Several tests invoke the obsolete egrep + command and trigger a warning about the obsoletion. These warnings + should be ignored. + Install the package: make install From 95789f1ae44b1a2b033ea02ff8f463d1c406f0d9 Mon Sep 17 00:00:00 2001 From: Bruce Dubbs Date: Tue, 13 Sep 2022 12:49:26 -0500 Subject: [PATCH 6/6] Minor wording change. --- chapter08/bash.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/bash.xml b/chapter08/bash.xml index 1dd020f28..a994999ec 100644 --- a/chapter08/bash.xml +++ b/chapter08/bash.xml @@ -88,7 +88,7 @@ exit $value EOF Several tests invoke the obsolete egrep - command and trigger a warning about the obsoletion. These warnings + command and trigger a warning. These warnings should be ignored. Install the package: