From f01f8a56da958581636000229edb1e233d281986 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 22 Nov 2022 16:13:30 +0800 Subject: [PATCH 01/13] gcc: remove --disable-decimal-float from pass 1 and 2 We need to enable decimal float here or MPFR will be built w/o decimal float support. Then 2 of 183 tests will be skipped, and this will also cause an ICA issue. Q: Why we need decimal float in pass 1? A: We need pass-1 GCC with decimal float support to build decimal float routines in pass-2 libgcc. --- chapter05/gcc-pass1.xml | 1 - chapter06/gcc-pass2.xml | 1 - 2 files changed, 2 deletions(-) diff --git a/chapter05/gcc-pass1.xml b/chapter05/gcc-pass1.xml index 89e163b6b..613e0fe27 100644 --- a/chapter05/gcc-pass1.xml +++ b/chapter05/gcc-pass1.xml @@ -92,7 +92,6 @@ cd build --disable-nls \ --disable-shared \ --disable-multilib \ - --disable-decimal-float \ --disable-threads \ --disable-libatomic \ --disable-libgomp \ diff --git a/chapter06/gcc-pass2.xml b/chapter06/gcc-pass2.xml index 24e14a346..ebc20a296 100644 --- a/chapter06/gcc-pass2.xml +++ b/chapter06/gcc-pass2.xml @@ -93,7 +93,6 @@ cd build --enable-default-ssp \ --disable-nls \ --disable-multilib \ - --disable-decimal-float \ --disable-libatomic \ --disable-libgomp \ --disable-libquadmath \ From e354e5846291e0a352078f1763dad43a385cc75a Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 22 Nov 2022 16:20:34 +0800 Subject: [PATCH 02/13] package updates - update to linux-6.0.9 - update to libpipeline-1.5.7 - update to xz-5.2.8 - update to man-db-2.11.1 - update to mpfr-4.1.1 --- packages.ent | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/packages.ent b/packages.ent index b01d751f5..76a3fa183 100644 --- a/packages.ent +++ b/packages.ent @@ -406,10 +406,10 @@ - - + + - + @@ -424,12 +424,12 @@ - + - + - + - - The sort-NaN-infloop test is known to fail with GCC-12. + + The test-getlogin test may fail in the LFS chroot environment. Remove the temporary group: From 3845081b0007c8a2e224e80b52e4979b8e3beb13 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 22 Nov 2022 23:34:06 +0800 Subject: [PATCH 05/13] changelog: remove a buggy revision="systemd" --- chapter01/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter01/changelog.xml b/chapter01/changelog.xml index 7d69c0a78..2730cd2cf 100644 --- a/chapter01/changelog.xml +++ b/chapter01/changelog.xml @@ -39,7 +39,7 @@ or as appropriate for the entry or if needed the entire day's listitem. --> - + 2022-11-10 From 1dd37a1807fcf44344c7ff0a3d959e5882a9dc68 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 22 Nov 2022 23:40:38 +0800 Subject: [PATCH 06/13] changelog: add entries for change today --- chapter01/changelog.xml | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/chapter01/changelog.xml b/chapter01/changelog.xml index 2730cd2cf..a24873253 100644 --- a/chapter01/changelog.xml +++ b/chapter01/changelog.xml @@ -39,6 +39,40 @@ or as appropriate for the entry or if needed the entire day's listitem. --> + + 2022-11-22 + + + [xry111] - Update to linux-6.0.9. Fixes + #5162. + + + [xry111] - Update to libpipeline-1.5.7. Fixes + #5163. + + + [xry111] - Update to xz-5.2.8. Fixes + #5164. + + + [xry111] - Update to man-db-2.11.1. Fixes + #5166. + + + [xry111] - Update to mpfr-4.1.1. Fixes + #5167. + + + [xry111] - Stop disabling decimal float for temporary GCC, + so mpfr will be built with decimal float support. + + + [xry111] - Update instruction for wheel to avoid relying on + deprecated Python features. + + + + 2022-11-10 From 31e9ff95277e88a3e56846892de889d04e4e182f Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 23 Nov 2022 00:58:21 +0800 Subject: [PATCH 07/13] gcc-pass1: housekeeping after --disable-decimal-float removal --- chapter05/gcc-pass1.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/chapter05/gcc-pass1.xml b/chapter05/gcc-pass1.xml index 613e0fe27..7a431ec90 100644 --- a/chapter05/gcc-pass1.xml +++ b/chapter05/gcc-pass1.xml @@ -165,15 +165,15 @@ cd build - --disable-decimal-float, --disable-threads, - --disable-libatomic, --disable-libgomp, + --disable-threads, + --disable-libatomic, --disable-libgomp, --disable-libquadmath, --disable-libssp, --disable-libvtv, --disable-libstdcxx - These switches disable support for the decimal floating point - extension, threading, libatomic, libgomp, libquadmath, libssp, + These switches disable support for + threading, libatomic, libgomp, libquadmath, libssp, libvtv, and the C++ standard library respectively. These features - will fail to compile when building a cross-compiler and are not + may fail to compile when building a cross-compiler and are not necessary for the task of cross-compiling the temporary libc. From 9af3d7f77da065fc7e09d43e203bf257b769fbce Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 23 Nov 2022 00:59:43 +0800 Subject: [PATCH 08/13] shadow: fix (clarify?) the consequence of missing "users" group To me "has been created" is not correct. Or maybe it's some advanced usage of English I don't understand... --- chapter08/shadow.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/shadow.xml b/chapter08/shadow.xml index 68cc130c9..efa000dcd 100644 --- a/chapter08/shadow.xml +++ b/chapter08/shadow.xml @@ -205,7 +205,7 @@ useradd -D --gid 999 useradd without the -g parameter, an error message will be generated—useradd: unknown GID 999, - even though the account has been created correctly. That is why we + despite the account can still be created correctly. That is why we created the group users with this group ID in . From 0298c764d8ae6a6e2b237bad78512496dfc14fab Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 23 Nov 2022 01:04:04 +0800 Subject: [PATCH 09/13] shadow: add spaces around — IMO it makes the rendering prettier. --- chapter08/shadow.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/shadow.xml b/chapter08/shadow.xml index efa000dcd..9ed79103f 100644 --- a/chapter08/shadow.xml +++ b/chapter08/shadow.xml @@ -203,7 +203,7 @@ useradd -D --gid 999 next available number. Note also that if you don't have a group with an ID equal to this number on your system, then the first time you use useradd without the -g - parameter, an error message will be generated—useradd: + parameter, an error message will be generated — useradd: unknown GID 999, despite the account can still be created correctly. That is why we created the group users From a66cd7f0201c2bc14f46f89c7625d3040408dd08 Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 23 Nov 2022 01:18:04 +0800 Subject: [PATCH 10/13] shadow: update desc of libsubid I was using the transitive verb "process" here, not the noun. Use another word to avoid the ambiguity. Also add "and groups" because there is also subgid alongside subuid. --- chapter08/shadow.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/shadow.xml b/chapter08/shadow.xml index 9ed79103f..720b52db2 100644 --- a/chapter08/shadow.xml +++ b/chapter08/shadow.xml @@ -639,7 +639,7 @@ useradd -D --gid 999 libsubid - library for processing subordinate id ranges for users + library to handle subordinate id ranges for users and groups libsubid From 66d32d7e29f713446127b4bcb57b2f2ef7b0c912 Mon Sep 17 00:00:00 2001 From: Bruce Dubbs Date: Tue, 22 Nov 2022 15:19:47 -0600 Subject: [PATCH 11/13] word choice --- chapter08/shadow.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/shadow.xml b/chapter08/shadow.xml index 720b52db2..c12826f9f 100644 --- a/chapter08/shadow.xml +++ b/chapter08/shadow.xml @@ -205,7 +205,7 @@ useradd -D --gid 999 useradd without the -g parameter, an error message will be generated — useradd: unknown GID 999, - despite the account can still be created correctly. That is why we + even though the account has been created correctly. That is why we created the group users with this group ID in . From 30f3041a7d4ddd47fdb2c000ea1b8548225bb79d Mon Sep 17 00:00:00 2001 From: David Bryant Date: Tue, 22 Nov 2022 16:00:02 -0600 Subject: [PATCH 12/13] Rewrote a cumbersome sentence to make it clearer. Capitalized the names of packages. Clarified verbiage in re PIE & ASLR. Improved the description of SSP, and tightened it up. Clarified the instructions for running tests concurrently. Modified descriptions of tests that fail. Patched up punctuation. Spelled "set up" correctly: "setup" is a noun. The phrasal verb used here is spelled as two words. Use the word "directives" to describe "#include" and similar preprocessor instructions. Add periods to some otherwise complete sentences. --- chapter08/gcc.xml | 70 +++++++++++++++++++++++------------------------ 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/chapter08/gcc.xml b/chapter08/gcc.xml index a36720374..4b5c2dd61 100644 --- a/chapter08/gcc.xml +++ b/chapter08/gcc.xml @@ -80,8 +80,8 @@ cd build --disable-bootstrap \ --with-system-zlib - Note that for other programming languages there are some prerequisites that - are not yet available. See the + GCC supports seven different computer languages, but the + prerequisites for most of them have not yet been installed. See the BLFS Book GCC page for instructions on how to build all of GCC's supported languages. @@ -91,8 +91,8 @@ cd build LD=ld - This parameter makes the configure script use the ld installed - by the binutils built earlier in this chapter, rather than + This parameter makes the configure script use the ld program installed + by the Binutils package built earlier in this chapter, rather than the cross-built version which would otherwise be used. @@ -101,7 +101,7 @@ cd build --with-system-zlib This switch tells GCC to link to the system installed copy of - the zlib library, rather than its own internal copy. + the Zlib library, rather than its own internal copy. @@ -109,21 +109,21 @@ cd build - PIE (position-independent executable) is a technique to produce + PIE (position-independent executables) are binary programs that can be loaded anywhere in memory. Without PIE, the security feature named ASLR (Address Space Layout Randomization) - can be applied for the shared libraries, but not the executable - itself. Enabling PIE allows ASLR for the executables in addition to + can be applied for the shared libraries, but not for the executables + themselves. Enabling PIE allows ASLR for the executables in addition to the shared libraries, and mitigates some attacks based on fixed addresses of sensitive code or data in the executables. SSP (Stack Smashing Protection) is a technique to ensure - that the parameter stack is not corrupted. Stack corruption can - for example alter the return address of a subroutine, - which would allow transferring control to some dangerous code + that the parameter stack is not corrupted. Stack corruption can, + for example, alter the return address of a subroutine, + thus transferring control to some dangerous code (existing in the program or shared libraries, or injected by the - attacker somehow) instead of the original one. + attacker somehow). @@ -133,10 +133,10 @@ cd build In this section, the test suite for GCC is considered - important, but it takes a long time. First time builders are - encouraged to not skip it. The time to run the tests can be - reduced significantly by adding -jx to the make command below - where x is the number of cores on your system. + important, but it takes a long time. First-time builders are + encouraged to run the test suite. The time to run the tests can be + reduced significantly by adding -jx to the make -k check command below, + where x is the number of CPU cores on your system. One set of tests in the GCC test suite is known to exhaust the default @@ -149,23 +149,23 @@ cd build chown -Rv tester . su tester -c "PATH=$PATH make -k check" - To receive a summary of the test suite results, run: + To extract a summary of the test suite results, run: ../contrib/test_summary - For only the summaries, pipe the output through + To filter out only the summaries, pipe the output through grep -A7 Summ. Results can be compared with those located at and . - In gcc, eleven tests, in the i386 test suite are known to FAIL. + Eleven tests in the i386 test suite for the gcc compiler are known to FAIL. It's because the test files do not account for the --enable-default-pie option. - In g++, four tests related to PR100400 are known to be reported - as both XPASS and FAIL. It's because the test file for this known issue + Four tests related to PR100400 may be reported + as both XPASS and FAIL when testing the g++ compiler; the test file is not well written. A few unexpected failures cannot always be avoided. The GCC developers @@ -187,8 +187,8 @@ su tester -c "PATH=$PATH make -k check" make install The GCC build directory is owned by - tester now and the ownership of the installed header - directory (and its content) will be incorrect. Change the ownership to + tester now, and the ownership of the installed header + directory (and its content) is incorrect. Change the ownership to the root user and group: chown -v -R root:root \ @@ -225,7 +225,7 @@ readelf -l a.out | grep ': /lib' [Requesting program interpreter: /lib64/ld-linux-x86-64.so.2] - Now make sure that we're setup to use the correct start files: + Now make sure that we're set up to use the correct start files: grep -E -o '/usr/lib.*/S?crt[1in].*succeeded' dummy.log @@ -274,7 +274,7 @@ SEARCH_DIR("/usr/local/lib") SEARCH_DIR("/lib") SEARCH_DIR("/usr/lib"); - A 32-bit system may see a few different directories. For example, here + A 32-bit system may use a few other directories. For example, here is the output from an i686 machine: SEARCH_DIR("/usr/i686-pc-linux-gnu/lib32") @@ -307,7 +307,7 @@ SEARCH_DIR("/usr/lib"); at all, then something is seriously wrong. Investigate and retrace the steps to find out where the problem is and correct it. Any - issues will need to be resolved before continuing with the process. + issues should be resolved before continuing with the process. Once everything is working correctly, clean up the test files: @@ -374,7 +374,7 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib cpp The C preprocessor; it is used by the compiler to expand the - #include, #define, and similar statements in the source files + #include, #define, and similar directives in the source files cpp @@ -407,7 +407,7 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib A wrapper around ar that adds a plugin to the command line. This program is only used to add "link time optimization" and is not useful with the - default build options + default build options. gc-ar @@ -420,7 +420,7 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib A wrapper around nm that adds a plugin to the command line. This program is only used to add "link time optimization" and is not useful with the - default build options + default build options. gc-nm @@ -433,7 +433,7 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib A wrapper around ranlib that adds a plugin to the command line. This program is only used to add "link time optimization" and is not useful with the - default build options + default build options. gc-ranlib @@ -444,7 +444,7 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib gcov A coverage testing tool; it is used to analyze programs to - determine where optimizations will have the most effect + determine where optimizations will have the greatest effect gcov @@ -525,7 +525,7 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib libgcov - This library is linked in to a program when GCC is instructed + This library is linked into a program when GCC is instructed to enable profiling libgcov @@ -567,7 +567,7 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib liblto_plugin - GCC's LTO plugin allows binutils to process object files + GCC's LTO plugin allows Binutils to process object files produced by GCC with LTO enabled liblto_plugin @@ -589,8 +589,8 @@ mv -v /usr/lib/*gdb.py /usr/share/gdb/auto-load/usr/lib libssp Contains routines supporting GCC's stack-smashing protection - functionality. Normally it's unused because glibc also provides - those routines + functionality. Normally it is not used, because Glibc also provides + those routines. libssp From 9a23a75c5dc3cee5a3f1b10bc61c1192ae4a17bb Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Wed, 23 Nov 2022 11:18:29 +0800 Subject: [PATCH 13/13] Revert "shadow: add spaces around —" This reverts commit 0298c764d8ae6a6e2b237bad78512496dfc14fab. We don't use spaces around &mdash anywhere else in the book. --- chapter08/shadow.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chapter08/shadow.xml b/chapter08/shadow.xml index c12826f9f..83c8f6ec9 100644 --- a/chapter08/shadow.xml +++ b/chapter08/shadow.xml @@ -203,7 +203,7 @@ useradd -D --gid 999 next available number. Note also that if you don't have a group with an ID equal to this number on your system, then the first time you use useradd without the -g - parameter, an error message will be generated — useradd: + parameter, an error message will be generated—useradd: unknown GID 999, even though the account has been created correctly. That is why we created the group users