Hardens ProcessManager finalisation, ensures stdout/stderr pipe write-ends close after spawn, sets termination handlers before run(), and fixes the runCaptured continuation hand-off for fast exits. Resolves the Stage 3 prompt stream being dropped and the handheld fixture UI not advancing, unskips and repairs the handheld UI test, and fixes averaging panel accessibility. Includes the selected #52 profile, verification, and artefact-gating fixes. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
172 lines
5.9 KiB
Swift
172 lines
5.9 KiB
Swift
import Foundation
|
|
import Testing
|
|
@testable import ICCeryCore
|
|
|
|
/// A `FileManager` subclass that reports a temporary directory as the
|
|
/// user home, so `ProfileInstaller` can be tested without writing to the
|
|
/// real `~/Library/ColorSync/Profiles`.
|
|
private final class TestFileManager: FileManager {
|
|
let tempHome: URL
|
|
|
|
init(home: URL) {
|
|
self.tempHome = home
|
|
super.init()
|
|
}
|
|
|
|
override var homeDirectoryForCurrentUser: URL {
|
|
tempHome
|
|
}
|
|
}
|
|
|
|
@Suite("ProfileInstaller")
|
|
struct ProfileInstallerTests {
|
|
|
|
private func makeTempDir() throws -> URL {
|
|
let fm = FileManager.default
|
|
let tmp = fm.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
|
try fm.createDirectory(at: tmp, withIntermediateDirectories: true)
|
|
return tmp
|
|
}
|
|
|
|
private func makeSource(
|
|
at dir: URL,
|
|
name: String,
|
|
bytes: [UInt8] = Array(repeating: 0, count: 256)
|
|
) throws -> URL {
|
|
let url = dir.appendingPathComponent(name)
|
|
let data = Data(bytes)
|
|
try data.write(to: url)
|
|
return url
|
|
}
|
|
|
|
@Test("Installs .icc to user ColorSync folder")
|
|
func userInstall() throws {
|
|
let fm = FileManager.default
|
|
let tmp = try makeTempDir()
|
|
let testFM = TestFileManager(home: tmp)
|
|
let source = try makeSource(at: tmp, name: "test.icc")
|
|
|
|
let result = try ProfileInstaller.install(
|
|
config: InstallProfileConfig(sourceURL: source),
|
|
fileManager: testFM
|
|
)
|
|
|
|
#expect(result.registered)
|
|
#expect(!result.overwritten)
|
|
#expect(!result.renamed)
|
|
#expect(result.destPath.hasSuffix("test.icc"))
|
|
#expect(fm.fileExists(atPath: result.destPath))
|
|
}
|
|
|
|
@Test("Overwrite succeeds and replaces the existing file")
|
|
func overwriteSucceeds() throws {
|
|
let fm = FileManager.default
|
|
let tmp = try makeTempDir()
|
|
let testFM = TestFileManager(home: tmp)
|
|
let source = try makeSource(at: tmp, name: "m5_profile.icc", bytes: (0..<256).map { UInt8($0) })
|
|
|
|
// First install.
|
|
let first = try ProfileInstaller.install(
|
|
config: InstallProfileConfig(sourceURL: source),
|
|
fileManager: testFM
|
|
)
|
|
#expect(!first.overwritten)
|
|
|
|
// Change the source contents.
|
|
let newBytes: [UInt8] = (0..<256).map { UInt8(($0 + 100) % 256) }
|
|
try Data(newBytes).write(to: source)
|
|
|
|
let options = InstallProfileOptions(
|
|
forceOverwrite: true,
|
|
preferSystem: false,
|
|
collisionPolicy: .overwrite,
|
|
openColorPanel: false
|
|
)
|
|
let second = try ProfileInstaller.install(
|
|
config: InstallProfileConfig(sourceURL: source, options: options),
|
|
fileManager: testFM
|
|
)
|
|
|
|
#expect(second.overwritten)
|
|
#expect(!second.renamed)
|
|
#expect(fm.fileExists(atPath: second.destPath))
|
|
let installed = try Data(contentsOf: URL(fileURLWithPath: second.destPath))
|
|
#expect(Array(installed) == newBytes)
|
|
}
|
|
|
|
@Test("Preserves .icm source extension")
|
|
func preservesIcmExtension() throws {
|
|
let tmp = try makeTempDir()
|
|
let testFM = TestFileManager(home: tmp)
|
|
let source = try makeSource(at: tmp, name: "m5_profile.icm")
|
|
|
|
let result = try ProfileInstaller.install(
|
|
config: InstallProfileConfig(sourceURL: source),
|
|
fileManager: testFM
|
|
)
|
|
|
|
#expect(URL(fileURLWithPath: result.destPath).pathExtension == "icm")
|
|
#expect(result.destPath.hasSuffix("m5_profile.icm"))
|
|
}
|
|
|
|
@Test("Rejects parent traversal in source path")
|
|
func rejectsParentTraversal() throws {
|
|
let fm = FileManager.default
|
|
let tmp = try makeTempDir()
|
|
|
|
// Create a real file in the parent of `tmp` with a path that contains
|
|
// a literal ".." component.
|
|
let parent = tmp.deletingLastPathComponent()
|
|
let naughtyName = "naughty-\(UUID().uuidString).icc"
|
|
let realFile = parent.appendingPathComponent(naughtyName)
|
|
_ = try makeSource(at: parent, name: naughtyName)
|
|
defer { try? fm.removeItem(at: realFile) }
|
|
|
|
let sourceURL = tmp
|
|
.appendingPathComponent("..")
|
|
.appendingPathComponent(naughtyName)
|
|
#expect(fm.fileExists(atPath: sourceURL.path))
|
|
|
|
do {
|
|
_ = try ProfileInstaller.install(config: InstallProfileConfig(sourceURL: sourceURL))
|
|
Issue.record("Expected unsafeStem error")
|
|
} catch let error as ProfileInstallError {
|
|
if case .unsafeStem = error { } else { Issue.record("Expected unsafeStem, got \(error)") }
|
|
} catch {
|
|
Issue.record("Unexpected error type: \(error)")
|
|
}
|
|
}
|
|
|
|
@Test("Allows stems with consecutive dots like foo..bar")
|
|
func allowsDoubleDotStem() throws {
|
|
let fm = FileManager.default
|
|
let tmp = try makeTempDir()
|
|
let testFM = TestFileManager(home: tmp)
|
|
let source = try makeSource(at: tmp, name: "foo..bar.icc")
|
|
|
|
let result = try ProfileInstaller.install(
|
|
config: InstallProfileConfig(sourceURL: source),
|
|
fileManager: testFM
|
|
)
|
|
|
|
#expect(result.destPath.hasSuffix("foo..bar.icc"))
|
|
#expect(fm.fileExists(atPath: result.destPath))
|
|
}
|
|
|
|
@Test("Rejects source files that are too small")
|
|
func rejectsSmallSource() throws {
|
|
let tmp = try makeTempDir()
|
|
let source = tmp.appendingPathComponent("tiny.icc")
|
|
try Data(repeating: 0, count: 64).write(to: source)
|
|
|
|
do {
|
|
_ = try ProfileInstaller.install(config: InstallProfileConfig(sourceURL: source))
|
|
Issue.record("Expected sourceTooSmall error")
|
|
} catch let error as ProfileInstallError {
|
|
if case .sourceTooSmall = error { } else { Issue.record("Expected sourceTooSmall, got \(error)") }
|
|
} catch {
|
|
Issue.record("Unexpected error type: \(error)")
|
|
}
|
|
}
|
|
}
|