fix(profile): complete calibration identity and profile resolution (#83) #99
@@ -79,14 +79,17 @@ public enum ArtefactProbe {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Resolve an explicit profile URL, flipping `.icc` ↔ `.icm` when the
|
/// Resolve an explicit profile URL, flipping `.icc` ↔ `.icm` when the
|
||||||
/// requested path is missing (#69 / issue #83).
|
/// requested path is missing (#69 / issue #83). Any other extension
|
||||||
|
/// (`.mpp`, `.txt`, …) is returned unchanged — never rewritten.
|
||||||
public static func resolveProfile(
|
public static func resolveProfile(
|
||||||
_ url: URL,
|
_ url: URL,
|
||||||
fileManager: FileManager = .default
|
fileManager: FileManager = .default
|
||||||
) -> URL {
|
) -> URL {
|
||||||
if fileManager.fileExists(atPath: url.path) { return url }
|
if fileManager.fileExists(atPath: url.path) { return url }
|
||||||
let altExt = url.pathExtension.lowercased() == "icc" ? "icm" : "icc"
|
let ext = url.pathExtension.lowercased()
|
||||||
let alt = url.deletingPathExtension().appendingPathExtension(altExt)
|
guard ext == "icc" || ext == "icm" else { return url }
|
||||||
|
let alt = url.deletingPathExtension()
|
||||||
|
.appendingPathExtension(ext == "icc" ? "icm" : "icc")
|
||||||
return fileManager.fileExists(atPath: alt.path) ? alt : url
|
return fileManager.fileExists(atPath: alt.path) ? alt : url
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -33,16 +33,16 @@ public struct CalibrationIdentity: Equatable, Sendable {
|
|||||||
|
|
||||||
/// Derive identity from the live wizard basename and the persisted
|
/// Derive identity from the live wizard basename and the persisted
|
||||||
/// original. A non-empty persisted original wins over a `CAL_` live
|
/// original. A non-empty persisted original wins over a `CAL_` live
|
||||||
/// name (Force Quit mid-calibration).
|
/// name (Force Quit mid-calibration). An empty live basename always
|
||||||
|
/// produces an empty identity — a persisted original must never
|
||||||
|
/// resurrect a target that no longer exists (#83).
|
||||||
public static func parse(liveBasename: String, persistedOriginal: String) -> CalibrationIdentity {
|
public static func parse(liveBasename: String, persistedOriginal: String) -> CalibrationIdentity {
|
||||||
if liveBasename.isEmpty && persistedOriginal.isEmpty {
|
guard !liveBasename.isEmpty else {
|
||||||
return CalibrationIdentity(originalBasename: "", calibrationBasename: "")
|
return CalibrationIdentity(originalBasename: "", calibrationBasename: "")
|
||||||
}
|
}
|
||||||
let original: String
|
let original: String
|
||||||
if liveBasename.hasPrefix("CAL_") {
|
if liveBasename.hasPrefix("CAL_") {
|
||||||
original = persistedOriginal.isEmpty ? strip(liveBasename) : persistedOriginal
|
original = persistedOriginal.isEmpty ? strip(liveBasename) : persistedOriginal
|
||||||
} else if liveBasename.isEmpty {
|
|
||||||
original = persistedOriginal
|
|
||||||
} else {
|
} else {
|
||||||
original = liveBasename
|
original = liveBasename
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -41,6 +41,34 @@ struct ArgyllRunnerCalibrationTests {
|
|||||||
try? FileManager.default.removeItem(at: testRoot)
|
try? FileManager.default.removeItem(at: testRoot)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test("Calibration targen from foo runs as process id targen_CAL_foo")
|
||||||
|
func calibrationTargenProcessId() async throws {
|
||||||
|
let testRoot = try makeTestDir()
|
||||||
|
let runner = makeRunner()
|
||||||
|
let events = ProcessManager.shared.events()
|
||||||
|
// Subscribed before spawn; the exit event is emitted before
|
||||||
|
// runCalibrationTargen returns, so this always terminates.
|
||||||
|
let sawExit = Task {
|
||||||
|
for await event in events {
|
||||||
|
guard event.id == "targen_CAL_foo" else { continue }
|
||||||
|
if case .exit = event { return true }
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
let config = CalibrationTargenConfig(
|
||||||
|
colourSpace: .rgb,
|
||||||
|
steps: 21,
|
||||||
|
basename: "foo",
|
||||||
|
workingDirectory: testRoot
|
||||||
|
)
|
||||||
|
|
||||||
|
let url = try await runner.runCalibrationTargen(config: config)
|
||||||
|
|
||||||
|
#expect(url.lastPathComponent == "CAL_foo.ti1")
|
||||||
|
#expect(await sawExit.value)
|
||||||
|
try? FileManager.default.removeItem(at: testRoot)
|
||||||
|
}
|
||||||
|
|
||||||
@Test("printcal captured run creates .cal")
|
@Test("printcal captured run creates .cal")
|
||||||
func printcalProducesCal() async throws {
|
func printcalProducesCal() async throws {
|
||||||
let testRoot = try makeTestDir()
|
let testRoot = try makeTestDir()
|
||||||
|
|||||||
@@ -125,26 +125,102 @@ struct ArtefactFilesTests {
|
|||||||
|
|
||||||
@Suite("ArtefactProbe profile resolve")
|
@Suite("ArtefactProbe profile resolve")
|
||||||
struct ArtefactProbeProfileTests {
|
struct ArtefactProbeProfileTests {
|
||||||
@Test("basename probe prefers .icm")
|
private func makeDir() throws -> URL {
|
||||||
func icmWins() throws {
|
|
||||||
let dir = FileManager.default.temporaryDirectory
|
let dir = FileManager.default.temporaryDirectory
|
||||||
.appendingPathComponent("probe-\(UUID().uuidString)")
|
.appendingPathComponent("probe-\(UUID().uuidString)")
|
||||||
try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
|
try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
|
||||||
|
return dir
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: Basename probe matrix (#69)
|
||||||
|
|
||||||
|
@Test("basename probe: only .icc exists")
|
||||||
|
func onlyIcc() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
let icc = dir.appendingPathComponent("job.icc")
|
||||||
|
try Data("icc".utf8).write(to: icc)
|
||||||
|
#expect(ArtefactProbe.resolveProfile(basename: "job", cwd: dir)?.path == icc.path)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("basename probe: only .icm exists")
|
||||||
|
func onlyIcm() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
let icm = dir.appendingPathComponent("job.icm")
|
||||||
|
try Data("icm".utf8).write(to: icm)
|
||||||
|
#expect(ArtefactProbe.resolveProfile(basename: "job", cwd: dir)?.path == icm.path)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("basename probe prefers .icm")
|
||||||
|
func icmWins() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
try Data("icc".utf8).write(to: dir.appendingPathComponent("job.icc"))
|
try Data("icc".utf8).write(to: dir.appendingPathComponent("job.icc"))
|
||||||
try Data("icm".utf8).write(to: dir.appendingPathComponent("job.icm"))
|
let icm = dir.appendingPathComponent("job.icm")
|
||||||
|
try Data("icm".utf8).write(to: icm)
|
||||||
let url = ArtefactProbe.resolveProfile(basename: "job", cwd: dir)
|
let url = ArtefactProbe.resolveProfile(basename: "job", cwd: dir)
|
||||||
#expect(url?.pathExtension == "icm")
|
#expect(url?.path == icm.path)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("basename probe: neither exists returns nil")
|
||||||
|
func neitherExists() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
#expect(ArtefactProbe.resolveProfile(basename: "job", cwd: dir) == nil)
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: Explicit URL matrix (#69 / #83)
|
||||||
|
|
||||||
|
@Test("explicit existing .icc wins even when .icm exists")
|
||||||
|
func explicitIccWins() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
let icc = dir.appendingPathComponent("job.icc")
|
||||||
|
try Data("icc".utf8).write(to: icc)
|
||||||
|
try Data("icm".utf8).write(to: dir.appendingPathComponent("job.icm"))
|
||||||
|
#expect(ArtefactProbe.resolveProfile(icc).path == icc.path)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("explicit existing .icm wins even when .icc exists")
|
||||||
|
func explicitIcmWins() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
try Data("icc".utf8).write(to: dir.appendingPathComponent("job.icc"))
|
||||||
|
let icm = dir.appendingPathComponent("job.icm")
|
||||||
|
try Data("icm".utf8).write(to: icm)
|
||||||
|
#expect(ArtefactProbe.resolveProfile(icm).path == icm.path)
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test("explicit missing .icc flips to sibling .icm")
|
@Test("explicit missing .icc flips to sibling .icm")
|
||||||
func flipExtension() throws {
|
func flipExtension() throws {
|
||||||
let dir = FileManager.default.temporaryDirectory
|
let dir = try makeDir()
|
||||||
.appendingPathComponent("probe-\(UUID().uuidString)")
|
|
||||||
try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
|
|
||||||
let icc = dir.appendingPathComponent("job.icc")
|
let icc = dir.appendingPathComponent("job.icc")
|
||||||
let icm = dir.appendingPathComponent("job.icm")
|
let icm = dir.appendingPathComponent("job.icm")
|
||||||
try Data("icm".utf8).write(to: icm)
|
try Data("icm".utf8).write(to: icm)
|
||||||
let resolved = ArtefactProbe.resolveProfile(icc)
|
let resolved = ArtefactProbe.resolveProfile(icc)
|
||||||
#expect(resolved.path == icm.path)
|
#expect(resolved.path == icm.path)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test("explicit missing .icm flips to sibling .icc")
|
||||||
|
func flipToIcc() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
let icc = dir.appendingPathComponent("job.icc")
|
||||||
|
let icm = dir.appendingPathComponent("job.icm")
|
||||||
|
try Data("icc".utf8).write(to: icc)
|
||||||
|
#expect(ArtefactProbe.resolveProfile(icm).path == icc.path)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("explicit missing both returns the original URL")
|
||||||
|
func missingBoth() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
let icc = dir.appendingPathComponent("job.icc")
|
||||||
|
#expect(ArtefactProbe.resolveProfile(icc).path == icc.path)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("unrelated extension is never rewritten")
|
||||||
|
func unrelatedExtension() throws {
|
||||||
|
let dir = try makeDir()
|
||||||
|
let mpp = dir.appendingPathComponent("job.mpp")
|
||||||
|
let icc = dir.appendingPathComponent("job.icc")
|
||||||
|
try Data("icc".utf8).write(to: icc)
|
||||||
|
// Even though a sibling .icc exists, a missing .mpp stays .mpp.
|
||||||
|
#expect(ArtefactProbe.resolveProfile(mpp).path == mpp.path)
|
||||||
|
let txt = dir.appendingPathComponent("job.txt")
|
||||||
|
#expect(ArtefactProbe.resolveProfile(txt).path == txt.path)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,78 @@
|
|||||||
|
import Foundation
|
||||||
|
import Testing
|
||||||
|
@testable import ICCeryCore
|
||||||
|
|
||||||
|
/// Issue #83 — canonical `CAL_` / original-stem pairing.
|
||||||
|
@Suite("CalibrationIdentity")
|
||||||
|
struct CalibrationIdentityTests {
|
||||||
|
@Test("live foo, no persisted")
|
||||||
|
func livePlain() {
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "foo", persistedOriginal: "")
|
||||||
|
#expect(id.originalBasename == "foo")
|
||||||
|
#expect(id.calibrationBasename == "CAL_foo")
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("live foo ignores stale persisted")
|
||||||
|
func livePlainIgnoresPersisted() {
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "foo", persistedOriginal: "bar")
|
||||||
|
#expect(id.originalBasename == "foo")
|
||||||
|
#expect(id.calibrationBasename == "CAL_foo")
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("live CAL_foo, persisted foo")
|
||||||
|
func liveCalPersisted() {
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "CAL_foo", persistedOriginal: "foo")
|
||||||
|
#expect(id.originalBasename == "foo")
|
||||||
|
#expect(id.calibrationBasename == "CAL_foo")
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("live CAL_foo, empty persisted strips prefix")
|
||||||
|
func liveCalNoPersist() {
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "CAL_foo", persistedOriginal: "")
|
||||||
|
#expect(id.originalBasename == "foo")
|
||||||
|
#expect(id.calibrationBasename == "CAL_foo")
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("persisted original wins over CAL_ live")
|
||||||
|
func persistedWins() {
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "CAL_foo", persistedOriginal: "bar")
|
||||||
|
#expect(id.originalBasename == "bar")
|
||||||
|
#expect(id.calibrationBasename == "CAL_bar")
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("empty live yields empty identity even with persisted original")
|
||||||
|
func emptyLiveWithPersisted() {
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "", persistedOriginal: "foo")
|
||||||
|
#expect(id.originalBasename.isEmpty)
|
||||||
|
#expect(id.calibrationBasename.isEmpty)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("empty live, empty persisted")
|
||||||
|
func emptyLive() {
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "", persistedOriginal: "")
|
||||||
|
#expect(id.originalBasename.isEmpty)
|
||||||
|
#expect(id.calibrationBasename.isEmpty)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("prefix is idempotent on already-prefixed input")
|
||||||
|
func alreadyPrefixed() {
|
||||||
|
#expect(CalibrationIdentity.prefix("CAL_foo") == "CAL_foo")
|
||||||
|
#expect(CalibrationIdentity.prefix("foo") == "CAL_foo")
|
||||||
|
let id = CalibrationIdentity.parse(liveBasename: "CAL_CAL_foo", persistedOriginal: "")
|
||||||
|
#expect(id.originalBasename == "CAL_foo")
|
||||||
|
#expect(id.calibrationBasename == "CAL_foo")
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("prefix never invents a name from empty input")
|
||||||
|
func prefixEmpty() {
|
||||||
|
#expect(CalibrationIdentity.prefix("").isEmpty)
|
||||||
|
#expect(CalibrationIdentity.strip("foo") == "foo")
|
||||||
|
#expect(CalibrationIdentity.strip("CAL_foo") == "foo")
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test("runner process id for a calibration targen is targen_CAL_*")
|
||||||
|
func processIdMatches() {
|
||||||
|
let cal = CalibrationIdentity.prefix("foo")
|
||||||
|
#expect(ProcessID.targen(cal) == "targen_CAL_foo")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -82,41 +82,3 @@ struct JSONFileStoreTests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@Suite("CalibrationIdentity")
|
|
||||||
struct CalibrationIdentityTests {
|
|
||||||
@Test("live foo, no persisted")
|
|
||||||
func livePlain() {
|
|
||||||
let id = CalibrationIdentity.parse(liveBasename: "foo", persistedOriginal: "")
|
|
||||||
#expect(id.originalBasename == "foo")
|
|
||||||
#expect(id.calibrationBasename == "CAL_foo")
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test("live CAL_foo, persisted foo")
|
|
||||||
func liveCalPersisted() {
|
|
||||||
let id = CalibrationIdentity.parse(liveBasename: "CAL_foo", persistedOriginal: "foo")
|
|
||||||
#expect(id.originalBasename == "foo")
|
|
||||||
#expect(id.calibrationBasename == "CAL_foo")
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test("live CAL_foo, empty persisted strips prefix")
|
|
||||||
func liveCalNoPersist() {
|
|
||||||
let id = CalibrationIdentity.parse(liveBasename: "CAL_foo", persistedOriginal: "")
|
|
||||||
#expect(id.originalBasename == "foo")
|
|
||||||
#expect(id.calibrationBasename == "CAL_foo")
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test("persisted original wins")
|
|
||||||
func persistedWins() {
|
|
||||||
let id = CalibrationIdentity.parse(liveBasename: "CAL_foo", persistedOriginal: "bar")
|
|
||||||
#expect(id.originalBasename == "bar")
|
|
||||||
#expect(id.calibrationBasename == "CAL_bar")
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test("empty live does not invent a name")
|
|
||||||
func emptyLive() {
|
|
||||||
let id = CalibrationIdentity.parse(liveBasename: "", persistedOriginal: "")
|
|
||||||
#expect(id.originalBasename.isEmpty)
|
|
||||||
#expect(id.calibrationBasename.isEmpty)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
Reference in New Issue
Block a user