From d11232813b4f5c9284f25b56a9534e08a5235a0c Mon Sep 17 00:00:00 2001 From: Gronod Date: Thu, 10 Sep 2026 07:30:07 +0100 Subject: [PATCH 1/2] fix(uitest): wait for closeAboutBtn in AboutHelp using app-wide identifier The previous sheet-scoped query did not resolve on the runner. Use the existing waitFor helper to locate closeAboutBtn anywhere in the app and remove the redundant immediate activation call. Refs gronod/iccery-v2-mac#72 --- Tests/ICCeryUITests/AboutHelpUITests.swift | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Tests/ICCeryUITests/AboutHelpUITests.swift b/Tests/ICCeryUITests/AboutHelpUITests.swift index 1080883..ce70d58 100644 --- a/Tests/ICCeryUITests/AboutHelpUITests.swift +++ b/Tests/ICCeryUITests/AboutHelpUITests.swift @@ -52,8 +52,7 @@ final class AboutHelpUITests: XCTestCase { _ = waitFor("aboutVersion", timeout: 10) XCTAssertTrue(element("aboutBuildDate").exists) - let close = app.sheets.firstMatch.buttons["closeAboutBtn"] - XCTAssertTrue(close.waitForExistence(timeout: 5)) + let close = waitFor("closeAboutBtn", timeout: 10) close.click() XCTAssertFalse(element("aboutDialog").exists) -- 2.39.5 From 0122d92f2b9f162ef84df54122ee3ef8ba63e806 Mon Sep 17 00:00:00 2001 From: Gronod Date: Thu, 10 Sep 2026 07:50:24 +0100 Subject: [PATCH 2/2] fix(about): expose closeAboutBtn in AboutView accessibility hierarchy The outer VStack was missing .accessibilityElement(children: .contain), so the close button identifier was not visible to XCUITest on the runner. Add the container modifier to match other dialog views and keep the aboutDialog identifier usable by tests. Refs gronod/iccery-v2-mac#75 --- Sources/ICCery/AboutView.swift | 1 + 1 file changed, 1 insertion(+) diff --git a/Sources/ICCery/AboutView.swift b/Sources/ICCery/AboutView.swift index 97b9377..2960f8b 100644 --- a/Sources/ICCery/AboutView.swift +++ b/Sources/ICCery/AboutView.swift @@ -61,6 +61,7 @@ struct AboutView: View { .padding(32) .frame(width: 360) .background(Theme.panel) + .accessibilityElement(children: .contain) .accessibilityIdentifier("aboutDialog") } } -- 2.39.5