From 5134e82e63ea7df43a7862f576f15b8826706b06 Mon Sep 17 00:00:00 2001 From: Gronod Date: Sat, 12 Sep 2026 11:39:16 +0100 Subject: [PATCH] fix(m9): stable 'sidebar' a11y identifier for AboutHelp UI test (#122) Xcode 14.2 / SDK 13.1 does not surface the sidebar root as an AXGroup, so the groups-containing query in testHelpOverlaysDoNotChangeSidebarHeight found nothing (run 32029). Give the sidebar root a stable identifier and query it directly. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- Sources/ICCery/SidebarView.swift | 1 + Tests/ICCeryUITests/AboutHelpUITests.swift | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Sources/ICCery/SidebarView.swift b/Sources/ICCery/SidebarView.swift index 0c4d3c1..f7928b0 100644 --- a/Sources/ICCery/SidebarView.swift +++ b/Sources/ICCery/SidebarView.swift @@ -129,6 +129,7 @@ struct SidebarView: View { } .frame(width: Theme.Metrics.sidebarWidth) .background(Theme.panel) + .accessibilityIdentifier("sidebar") } } diff --git a/Tests/ICCeryUITests/AboutHelpUITests.swift b/Tests/ICCeryUITests/AboutHelpUITests.swift index ce70d58..f928b6e 100644 --- a/Tests/ICCeryUITests/AboutHelpUITests.swift +++ b/Tests/ICCeryUITests/AboutHelpUITests.swift @@ -64,7 +64,8 @@ final class AboutHelpUITests: XCTestCase { let toggle = app.buttons["btnToggleAllHelp"] XCTAssertTrue(toggle.waitForExistence(timeout: 10)) - let sidebar = app.groups.containing(.button, identifier: "openSettingsBtn").element + let sidebar = app.descendants(matching: .any)["sidebar"] + XCTAssertTrue(sidebar.waitForExistence(timeout: 10)) let before = sidebar.frame toggle.click() -- 2.39.5