GamutView pauses on .onDisappear as a fallback when the sheet is dismissed without dismantleNSView.
GamutSceneGeometryBuilder drops any face whose vertex indices are out of bounds before building the SCNGeometryElement.
Edge-line construction filters the same way, preventing mesh.vertices[...] crashes on malformed .gam data.
Adds GamutGeometryBuilderTests to verify an OOB face does not crash and is not written to the element.
Targets develop; no milestone umbrella.
Slice 3 fix for #28.
- `GamutSceneView.dismantleNSView` pauses `SCNView` rendering (`isPlaying = false`).
- `GamutView` pauses on `.onDisappear` as a fallback when the sheet is dismissed without `dismantleNSView`.
- `GamutSceneGeometryBuilder` drops any face whose vertex indices are out of bounds before building the `SCNGeometryElement`.
- Edge-line construction filters the same way, preventing `mesh.vertices[...]` crashes on malformed `.gam` data.
- Adds `GamutGeometryBuilderTests` to verify an OOB face does not crash and is not written to the element.
Targets `develop`; no milestone umbrella.
- GamutSceneView.dismantleNSView now sets scnView.isPlaying = false.
- GamutView pauses the renderer on .onDisappear so the sheet can be
dismissed without relying solely on dismantleNSView.
- GamutSceneGeometryBuilder drops faces with any vertex index >=
vertices.count before building the SCNGeometryElement; the edge-line
builder filters the same way.
- Add GamutGeometryBuilderTests to verify an OOB face does not crash
and is not included in the geometry element.
Generated with Devin
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Slice 3 fix for #28.
GamutSceneView.dismantleNSViewpausesSCNViewrendering (isPlaying = false).GamutViewpauses on.onDisappearas a fallback when the sheet is dismissed withoutdismantleNSView.GamutSceneGeometryBuilderdrops any face whose vertex indices are out of bounds before building theSCNGeometryElement.mesh.vertices[...]crashes on malformed.gamdata.GamutGeometryBuilderTeststo verify an OOB face does not crash and is not written to the element.Targets
develop; no milestone umbrella.Pull request closed