gronod/iccery-v2-mac
1
0
Fork 0
Code Issues 1 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

feat(#29): Stage 0 printer calibration #64

Merged
gronod merged 2 commits from feat/29-stage0-calibration into milestone/m6-gamut-stage0-cgats-release 2026-09-09 22:48:50 +01:00
Conversation 0 Commits 2 Files Changed 18
+1238 -14
gronod commented 2026-09-09 22:43:25 +01:00
Owner
Copy Link
Copy Source

Implements Stage 0 printer calibration with printcal / applycal integration.

  • Adds CalibrationTargenArgs, PrintcalArgs, and CalibrationStore.
  • Adds ArgyllRunner.runCalibrationTargen and runPrintcal.
  • Adds CalibrationView + CalibrationViewModel, wired into RootView, SidebarView, Stage1View, and TargetWorkflowViewModel.
  • Ensures CAL_ printtarg basenames never receive -K/-I.
  • Adds core tests and Milestone6CalibrationUITests.
  • Builds on top of merged #28 (0ee609b / e929576).

Refs #29

Implements Stage 0 printer calibration with `printcal` / `applycal` integration. - Adds `CalibrationTargenArgs`, `PrintcalArgs`, and `CalibrationStore`. - Adds `ArgyllRunner.runCalibrationTargen` and `runPrintcal`. - Adds `CalibrationView` + `CalibrationViewModel`, wired into `RootView`, `SidebarView`, `Stage1View`, and `TargetWorkflowViewModel`. - Ensures `CAL_` printtarg basenames never receive `-K`/`-I`. - Adds core tests and `Milestone6CalibrationUITests`. - Builds on top of merged #28 (`0ee609b` / `e929576`). Refs #29
gronod added the
Priority
High
2
Project/ICCery-v2Feature/Backend labels 2026-09-09 22:43:25 +01:00
gronod added 2 commits 2026-09-09 22:43:26 +01:00
fix(stage0): implement printer calibration workflow and stabilise M6 UI tests. 34bef9a78e 
- Add CalibrationTargenArgs, PrintcalArgs, CalibrationStore (stage 0).
- Add ArgyllRunner.runCalibrationTargen and runPrintcal.
- Add CalibrationView + CalibrationViewModel to the app shell.
- Wire calibration into RootView, SidebarView, Stage1View, TargetWorkflowViewModel.
- Remove mutable _uiTestRoot from AppPaths; derive isolated test roots from
  ICCERY_TEST_WORKDIR / process id.
- Fix Milestone6CGATSUITests to assert stage4TargetBasename instead of a
  VStack accessibility identifier.
- Fix Milestone6CalibrationUITests fixture binary path.

Refs: #29

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
fix(#29): manual gamut sheet binding so RootView compiles with let wizard ff883a43b2
gronod merged commit 6f4491d0e9 into milestone/m6-gamut-stage0-cgats-release 2026-09-09 22:48:50 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug/Architecture
Core / wizard / process infra defect
 Bug/Backend
Argyll orchestration, file/data defect
 Bug/DevOps
Build, packaging, CI defect
 Bug/UI
Views, controls, dialogs defect
 Compat/Breaking
Breaking change that won't be backward compatible
 Feature/Architecture
Core / wizard / process infra
 Feature/Backend
Argyll orchestration, file/data engines
 Feature/DevOps
Build, packaging, CI
 Feature/UI
Views, controls, dialogs
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Project/ICCery-v2
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Feature/Backend
Priority
High
2
 Project/ICCery-v2
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#64