[Bug/High] Stage 2 quality picker offers qualities invalid for selected media type #214
Closed
opened 2026-09-17 22:07:22 +01:00 by gronod
·
0 comments
No Branch/Tag Specified
main
docs/27-roadmap-candidates
develop
milestone/m13-print-ticket
feat/218-paper-source
feat/217-panel-ticket-restore
bugfix/211-print-output-flip
milestone/m12-native-spool
feat/202-airprint-detection
feat/201-native-print-operation
feat/201-raster-canvas
feat/201-ticket-capture
feat/201-pm-ticket-bridge
chore/m11-sync-develop
milestone/m11-print-settings
chore/m11-docs-hygiene
feat/186-panel-binding
feat/181-canon-media-locale
feat/180-epson-qual-options
feat/183-stage2-print-settings
chore/m11-tracking
docs/ui-interactive-map
v2.0.4-prerelease-docs27
v2.0.4
v2.0.3
v2.0.3-prerelease
v2.0.2
v2.0.1
v2.0.0
Labels
Clear labels
Bug/Architecture
Bug/Backend
Bug/DevOps
Bug/UI
Compat/Breaking
Feature/Architecture
Feature/Backend
Feature/DevOps
Feature/UI
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Project/ICCery-v2
Core / wizard / process infra defect
Argyll orchestration, file/data defect
Build, packaging, CI defect
Views, controls, dialogs defect
Breaking change that won't be backward compatible
Core / wizard / process infra
Argyll orchestration, file/data engines
Build, packaging, CI
Views, controls, dialogs
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
ICCery v2 Mac rewrite
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gronod/iccery-v2-mac#214
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
The Stage 2 quality selector lists every quality token advertised by
lpoptions -l, regardless of the selected media type. Both the Epson (InkjetPrinter2, e.g. XP-55) and Canon (Pro9500 II) drivers restrict which quality values are valid per media — selecting an invalid combination makes the driver reject the job.Example (Epson XP-55): media 0 (plain) allows {301 Fast Economy, 302 Economy, 303 Normal, 304 Fine}; media 15 (Premium Semigloss) allows {305 Quality, 307 Best Quality, 308 Draft} — the picker currently shows all 7 for every media.
Root Cause Analysis
Stage2View.qualityGrouprendersworkflow.print.printerCaps.qualitiesunfiltered (Sources/ICCery/Stage2View.swift~L416-420).CupsService.capabilities(from:listings,ppd:)populatesqualitiesfrom the globallpoptions -llisting of the detected quality key (EPIJ_Qual/CNIJPrintQuality) — no media relationship (Packages/ICCeryCore/Sources/ICCeryCore/Print/CupsService.swift~L157-170).PrinterCapabilitieshas no media→quality field (PrinterModels.swift).*UIConstraints/*Constraints(absent in both PPDs);APPrinterPresetblocks (recommended defaults only, not validity); IPPprint-quality-supported/media-col-database(global lists only, no per-media matrix).Driver truth found:
*EPIJUIConstraint: <cond>|<forbidden choice>in<EPIJDriverBasePath>/Machine/<EPIJMachineBundleName>/Contents/Resources/PDEData.dat— forbids*EPIJ_Qual <q>when LHS terms hold (*EPIJ_Medi <m>plusEPIJ_PSrc/EPIJ_FdSo/EPIJ_Ink_). Evaluating non-media terms against lpoptions*-defaults reproduces the driver sets exactly.*CNIJNameTblPath+*CNIJTableIDPPD keys →cnb_<TableID>0.tblbinary — 20-byte LE records{0x30, 1, u32 0, u16 3, u16 flag, u32 mediaID(|0x10000=borderless), u16 0, u16 quality}enumerating allowedCNIJPrintQualityvalues perCNIJMediaType.Proposed Fix
PrinterCapabilitiesgainsqualityIDsByMediaType: [String: Set<String>]+qualities(forMediaType:)(order-preserving, never-empty fallback).MediaQualityConstraintsresolver (ICCeryCore, pure): PPD*UIConstraints→ EpsonPDEData.dat→ Canon tbl; first non-empty source wins; fail-open to unfiltered.PrintSessionViewModel:availableQualitiescomputed;selectedMediaType.didSetclampsselectedQuality(default-if-allowed else first); seeding + panel apply-back +makeRequesthonour the map.Stage2View.qualityGroupiteratesavailableQualities.Acceptance Criteria
xcodebuild test -scheme ICCery -destination 'platform=macOS'green.References