Two negative assertions in Milestone2UITests use XCTAssertFalse(el.waitForExistence(timeout: 3)), which always burns the full 3s timeout on the negative (expected) path because waitForExistence only returns early on success:
An audit of all XCTAssertFalse(...waitForExistence...) and XCTAssertFalse(...exists...) sites across Tests/ICCeryUITests/ confirmed these are the only two full-timeout negative waits; the rest already use the instant .exists form.
Change
Add a small assertAbsent(_:dwell:) helper next to the existing waitFor helper in Milestone2UITests.swift, then replace the two waitForExistence(timeout: 3) sites with it:
/// Assert an element stays absent after a short dwell — unlike/// `waitForExistence`, which always burns its full timeout on the/// negative path.privatefuncassertAbsent(_el:XCUIElement,dwell:TimeInterval=0.5,_message:String="expected element to stay absent",file:StaticString=#filePath,line:UInt=#line){RunLoop.current.run(until:Date().addingTimeInterval(dwell))XCTAssertFalse(el.exists,message,file:file,line:line)}
The 0.5s dwell lets the SwiftUI list settle after the synchronous store deletion before asserting absence. ~6s saved per suite run.
Acceptance
testSaveAndDeleteCustomPreset and testPresetExportImport pass with the new helper.
No other test file changes.
Scope
Tests/ICCeryUITests/Milestone2UITests.swift only.
Out of scope: collapsing app-side delays (separate issue), CI workflow changes.
## Problem
Two negative assertions in `Milestone2UITests` use `XCTAssertFalse(el.waitForExistence(timeout: 3))`, which always burns the full 3s timeout on the negative (expected) path because `waitForExistence` only returns early on success:
- `Tests/ICCeryUITests/Milestone2UITests.swift:319` — preset deletion confirmation
- `Tests/ICCeryUITests/Milestone2UITests.swift:351` — preset re-import setup
An audit of all `XCTAssertFalse(...waitForExistence...)` and `XCTAssertFalse(...exists...)` sites across `Tests/ICCeryUITests/` confirmed these are the only two full-timeout negative waits; the rest already use the instant `.exists` form.
## Change
Add a small `assertAbsent(_:dwell:)` helper next to the existing `waitFor` helper in `Milestone2UITests.swift`, then replace the two `waitForExistence(timeout: 3)` sites with it:
```swift
/// Assert an element stays absent after a short dwell — unlike
/// `waitForExistence`, which always burns its full timeout on the
/// negative path.
private func assertAbsent(_ el: XCUIElement, dwell: TimeInterval = 0.5,
_ message: String = "expected element to stay absent",
file: StaticString = #filePath, line: UInt = #line) {
RunLoop.current.run(until: Date().addingTimeInterval(dwell))
XCTAssertFalse(el.exists, message, file: file, line: line)
}
```
The 0.5s dwell lets the SwiftUI list settle after the synchronous store deletion before asserting absence. ~6s saved per suite run.
## Acceptance
- `testSaveAndDeleteCustomPreset` and `testPresetExportImport` pass with the new helper.
- No other test file changes.
## Scope
- `Tests/ICCeryUITests/Milestone2UITests.swift` only.
- Out of scope: collapsing app-side delays (separate issue), CI workflow changes.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
Two negative assertions in
Milestone2UITestsuseXCTAssertFalse(el.waitForExistence(timeout: 3)), which always burns the full 3s timeout on the negative (expected) path becausewaitForExistenceonly returns early on success:Tests/ICCeryUITests/Milestone2UITests.swift:319— preset deletion confirmationTests/ICCeryUITests/Milestone2UITests.swift:351— preset re-import setupAn audit of all
XCTAssertFalse(...waitForExistence...)andXCTAssertFalse(...exists...)sites acrossTests/ICCeryUITests/confirmed these are the only two full-timeout negative waits; the rest already use the instant.existsform.Change
Add a small
assertAbsent(_:dwell:)helper next to the existingwaitForhelper inMilestone2UITests.swift, then replace the twowaitForExistence(timeout: 3)sites with it:The 0.5s dwell lets the SwiftUI list settle after the synchronous store deletion before asserting absence. ~6s saved per suite run.
Acceptance
testSaveAndDeleteCustomPresetandtestPresetExportImportpass with the new helper.Scope
Tests/ICCeryUITests/Milestone2UITests.swiftonly.