fix(m9): revert sidebar container a11y id; measure presetSelect frame (#130) #131

Merged
gronod merged 1 commits from feat/130-sidebar-a11y-revert into milestone/m9-monterey 2026-09-12 12:37:40 +01:00
Owner

Closes #130.

The run 32201 hierarchy dump showed the sidebar identifier on the root VStack propagates to every child on SDK 13.1, erasing openSettingsBtn/openAboutBtn/btnToggleAllHelp — hence the probe timeout.

  • Reverts .accessibilityIdentifier("sidebar") in SidebarView.
  • testHelpOverlaysDoNotChangeSidebarHeight now compares presetSelect's frame before/after the help toggle (documented fallback).
Closes #130. The run 32201 hierarchy dump showed the `sidebar` identifier on the root VStack propagates to every child on SDK 13.1, erasing `openSettingsBtn`/`openAboutBtn`/`btnToggleAllHelp` — hence the probe timeout. - Reverts `.accessibilityIdentifier("sidebar")` in `SidebarView`. - `testHelpOverlaysDoNotChangeSidebarHeight` now compares `presetSelect`'s frame before/after the help toggle (documented fallback).
gronod added the
Priority
High
2
Project/ICCery-v2Bug/UI
labels 2026-09-12 12:37:31 +01:00
gronod added 1 commit 2026-09-12 12:37:32 +01:00
On SDK 13.1 the 'sidebar' identifier on the root VStack propagates to
every child, erasing openSettingsBtn/openAboutBtn/btnToggleAllHelp
(a11y dump, run 32201). Revert it; the test now compares presetSelect
frame before/after toggling help overlays.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
gronod merged commit c1ec07f726 into milestone/m9-monterey 2026-09-12 12:37:40 +01:00
gronod deleted branch feat/130-sidebar-a11y-revert 2026-09-12 12:37:41 +01:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/iccery-v2-mac#131