Compare commits
20
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
4f3caf335d | ||
|
|
de142a9690 | ||
|
|
a2f994821f | ||
|
|
1d6032456d | ||
|
|
fc1530ab2e | ||
|
|
ffbe56f43a | ||
|
|
ee5da4a637 | ||
|
|
0513b272cb | ||
|
|
555bf8fda4 | ||
|
|
f3c7b19694 | ||
|
|
5e696ff3e9 | ||
|
|
19f619ad98 | ||
|
|
09f466ae46 | ||
|
|
d228594bd3 | ||
|
|
6adbf99bd9 | ||
|
|
d8c41444b9 | ||
|
|
1767792f75 | ||
|
|
e8678586bd | ||
|
|
c9b423b229 | ||
|
|
62a45d9c7d |
@@ -50,6 +50,27 @@ bump `project.yml` on `develop` before tagging. CI needs `fetch-depth: 0`.
|
|||||||
`develop` ← `milestone/mN-<name>` ← `feat/<issue#>-<slug>`.
|
`develop` ← `milestone/mN-<name>` ← `feat/<issue#>-<slug>`.
|
||||||
PRs via Gitea MCP. Every issue/PR: `Project/ICCery-v2` + `Feature/*` or `Bug/*` + `Priority/*`.
|
PRs via Gitea MCP. Every issue/PR: `Project/ICCery-v2` + `Feature/*` or `Bug/*` + `Priority/*`.
|
||||||
|
|
||||||
|
## Issue ticket style
|
||||||
|
- Title: `[Kind/Priority] short description` — e.g. `[Bug/Critical] …`, `[Feature/Medium] …`.
|
||||||
|
- Labels: `Kind/Bug` or `Kind/Feature` (also `Kind/Testing` for test work),
|
||||||
|
one `Bug/<area>` or `Feature/<area>` (Architecture/Backend/UI/DevOps),
|
||||||
|
one `Priority/*`, plus `Project/ICCery-v2`. Set the milestone when the work
|
||||||
|
belongs to an active `mN` milestone.
|
||||||
|
- Bug bodies: `## Summary` → `## Root Cause Analysis` (file:line evidence;
|
||||||
|
note checked-and-dismissed hypotheses) → `## Proposed Fix` (options or
|
||||||
|
deterministic plan) → `## Acceptance Criteria` (checkbox list) →
|
||||||
|
`## Dependencies` → `## References`.
|
||||||
|
- Feature bodies: same skeleton minus Root Cause; lead with Summary and a
|
||||||
|
concrete implementation plan.
|
||||||
|
- Dependencies/blockers must **always** be recorded via the gitea MCP
|
||||||
|
`issue_write` methods (`add_dependency`, `block_issue`; reads via
|
||||||
|
`issue_read` `list_dependencies` / `list_blocks` — see "Gitea issue
|
||||||
|
dependencies"), not just mentioned in the body. This is
|
||||||
|
mandatory when issues share a milestone with an implementation order:
|
||||||
|
wire up `add_dependency` (blocked-by) and `block_issue` (blocks) links so
|
||||||
|
the order is machine-readable. The `## Dependencies` body section may
|
||||||
|
still summarise them for readability, but the MCP links are authoritative.
|
||||||
|
|
||||||
## Verify
|
## Verify
|
||||||
```
|
```
|
||||||
xcodebuild test -scheme ICCery -destination 'platform=macOS' ARCHS="$(uname -m)"
|
xcodebuild test -scheme ICCery -destination 'platform=macOS' ARCHS="$(uname -m)"
|
||||||
|
|||||||
+1
-1
@@ -23,7 +23,7 @@ Hardware gates block *release of that sprint*, not filing, and not starting codi
|
|||||||
| M11 | Printer settings completeness & dialog binding | 183, 180, 181, 186 | Quality/media/paper caps parse + `LpArgs` emit + picker UI smoke + panel capture-return | Real Epson: 7 `EPIJ_Qual` options; real Canon Pro9500: English media labels; dialog bound to non-default queue with paper/quality/media/orientation preselected; captured settings reach `lp` argv |
|
| M11 | Printer settings completeness & dialog binding | 183, 180, 181, 186 | Quality/media/paper caps parse + `LpArgs` emit + picker UI smoke + panel capture-return | Real Epson: 7 `EPIJ_Qual` options; real Canon Pro9500: English media labels; dialog bound to non-default queue with paper/quality/media/orientation preselected; captured settings reach `lp` argv |
|
||||||
| Later | Quartz / TargetPrint | 16 | `ICCeryPrintKit` standalone + seam test | 1:1 on paper vs TIFF |
|
| Later | Quartz / TargetPrint | 16 | `ICCeryPrintKit` standalone + seam test | 1:1 on paper vs TIFF |
|
||||||
|
|
||||||
M8–M10 are merged to `develop`; M11 assembles on `milestone/m11-print-settings` from `736fd08`.
|
M8–M11 are merged to `develop`; M11 shipped via PR #199 (hardware gate passed on real Epson XP-55 / Canon Pro9500 II).
|
||||||
|
|
||||||
Issue **16 is not an M3, M6, M10, or M11 exit gate.**
|
Issue **16 is not an M3, M6, M10, or M11 exit gate.**
|
||||||
|
|
||||||
|
|||||||
@@ -46,4 +46,23 @@ public enum ColorMatchingAttempts {
|
|||||||
"AP_ColorMatchingMode",
|
"AP_ColorMatchingMode",
|
||||||
"AP.ColorMatchingMode",
|
"AP.ColorMatchingMode",
|
||||||
]
|
]
|
||||||
|
|
||||||
|
/// The Quartz/`NSPrintOperation` colour-matching vocabulary
|
||||||
|
/// (docs/14 §7). With the `lp` path removed there is a single
|
||||||
|
/// spool path and it carries **both** dictionaries — these keys
|
||||||
|
/// are written alongside the AP_* pair (#201 D2).
|
||||||
|
///
|
||||||
|
/// `PMColorMatchingMode=APCustomColorMatching` plus an empty
|
||||||
|
/// `PMCustomColorMatchingProfile` tell Quartz the application
|
||||||
|
/// supplies device colour; the `com.apple.print.PrintSettings.*`
|
||||||
|
/// legacy spelling covers drivers that read the flattened
|
||||||
|
/// dictionary.
|
||||||
|
public static let quartzModeKey = "PMColorMatchingMode"
|
||||||
|
public static let quartzCustomMatching = "APCustomColorMatching"
|
||||||
|
public static let quartzProfileKey = "PMCustomColorMatchingProfile"
|
||||||
|
public static let quartzLegacyModeKey =
|
||||||
|
"com.apple.print.PrintSettings.PMColorMatchingMode"
|
||||||
|
/// The nested sub-dictionary inside `NSPrintInfo.dictionary()` the
|
||||||
|
/// colour keys are mirrored into.
|
||||||
|
public static let quartzNestedDictKey = "com.apple.print.printSettings"
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -174,8 +174,13 @@ public enum CupsParsers {
|
|||||||
|
|
||||||
/// PPD `*<key> <id>/<Human Label>:` lines → `id → label` map.
|
/// PPD `*<key> <id>/<Human Label>:` lines → `id → label` map.
|
||||||
/// Language-qualified forms (`*en_US.<key> id/Label:`) also match.
|
/// Language-qualified forms (`*en_US.<key> id/Label:`) also match.
|
||||||
|
/// Precedence is deterministic, not positional (#181): unqualified
|
||||||
|
/// `*Key` > `en_US.` > `en.` > first-qualified-seen, so a trailing
|
||||||
|
/// locale block (Canon `th.CNIJMediaType`) can never overwrite the
|
||||||
|
/// base English labels — and a qualified-only id still gets its
|
||||||
|
/// first-seen qualified label (R9).
|
||||||
public static func ppdChoiceLabels(_ ppd: String, key: String) -> [String: String] {
|
public static func ppdChoiceLabels(_ ppd: String, key: String) -> [String: String] {
|
||||||
var map: [String: String] = [:]
|
var hits: [String: [(qualifier: String?, label: String)]] = [:]
|
||||||
for rawLine in ppd.split(separator: "\n") {
|
for rawLine in ppd.split(separator: "\n") {
|
||||||
var line = rawLine.trimmingCharacters(in: .whitespaces)
|
var line = rawLine.trimmingCharacters(in: .whitespaces)
|
||||||
guard line.hasPrefix("*"), !line.hasPrefix("**") else { continue }
|
guard line.hasPrefix("*"), !line.hasPrefix("**") else { continue }
|
||||||
@@ -183,7 +188,9 @@ public enum CupsParsers {
|
|||||||
// Optional locale qualifier: `en_US.InputSlot` → `InputSlot`.
|
// Optional locale qualifier: `en_US.InputSlot` → `InputSlot`.
|
||||||
// Only strip when the part before the first `.` looks like
|
// Only strip when the part before the first `.` looks like
|
||||||
// a locale (short `xx`/`xx_YY`); real keys containing dots
|
// a locale (short `xx`/`xx_YY`); real keys containing dots
|
||||||
// are left alone.
|
// are left alone. The qualifier is recorded for precedence
|
||||||
|
// rather than dropped (#181).
|
||||||
|
var qualifier: String?
|
||||||
if let dot = line.firstIndex(of: ".") {
|
if let dot = line.firstIndex(of: ".") {
|
||||||
let prefix = line[..<dot]
|
let prefix = line[..<dot]
|
||||||
let looksLikeLocale = (2...5).contains(prefix.count)
|
let looksLikeLocale = (2...5).contains(prefix.count)
|
||||||
@@ -191,6 +198,7 @@ public enum CupsParsers {
|
|||||||
&& (prefix.count == 2 || prefix.contains("_"))
|
&& (prefix.count == 2 || prefix.contains("_"))
|
||||||
let candidate = line[line.index(after: dot)...]
|
let candidate = line[line.index(after: dot)...]
|
||||||
if looksLikeLocale && candidate.hasPrefix(key) {
|
if looksLikeLocale && candidate.hasPrefix(key) {
|
||||||
|
qualifier = prefix.lowercased()
|
||||||
line = String(candidate)
|
line = String(candidate)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -201,15 +209,50 @@ public enum CupsParsers {
|
|||||||
rest = String(rest[..<colon])
|
rest = String(rest[..<colon])
|
||||||
// `<id>/<Human label>` — human label after the last `/`.
|
// `<id>/<Human label>` — human label after the last `/`.
|
||||||
guard let slash = rest.firstIndex(of: "/") else { continue }
|
guard let slash = rest.firstIndex(of: "/") else { continue }
|
||||||
let id = String(rest[..<slash])
|
let id = ppdUnescape(String(rest[..<slash])
|
||||||
.trimmingCharacters(in: .whitespaces)
|
.trimmingCharacters(in: .whitespaces))
|
||||||
let human = String(rest[rest.index(after: slash)...])
|
let human = ppdUnescape(String(rest[rest.index(after: slash)...])
|
||||||
.trimmingCharacters(in: .whitespaces)
|
.trimmingCharacters(in: .whitespaces))
|
||||||
if !id.isEmpty { map[id] = human.isEmpty ? id : human }
|
guard !id.isEmpty else { continue }
|
||||||
|
hits[id, default: []].append(
|
||||||
|
(qualifier, human.isEmpty ? id : human))
|
||||||
|
}
|
||||||
|
var map: [String: String] = [:]
|
||||||
|
for (id, candidates) in hits {
|
||||||
|
// First occurrence wins inside each qualifier class, in
|
||||||
|
// file order — same as the old sequential behaviour.
|
||||||
|
map[id] = candidates.first { $0.qualifier == nil }?.label
|
||||||
|
?? candidates.first { $0.qualifier == "en_us" }?.label
|
||||||
|
?? candidates.first { $0.qualifier == "en" }?.label
|
||||||
|
?? candidates[0].label
|
||||||
}
|
}
|
||||||
return map
|
return map
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// PPD `<XX>` hex escapes → the literal byte (`<2F>` → `/`,
|
||||||
|
/// `<20>` → space). Anything that is not `<` + two hex digits +
|
||||||
|
/// `>` passes through untouched (#181).
|
||||||
|
private static func ppdUnescape(_ text: String) -> String {
|
||||||
|
var result = ""
|
||||||
|
var index = text.startIndex
|
||||||
|
while index < text.endIndex {
|
||||||
|
guard text[index] == "<",
|
||||||
|
let hexEnd = text.index(
|
||||||
|
index, offsetBy: 3, limitedBy: text.endIndex),
|
||||||
|
hexEnd < text.endIndex, text[hexEnd] == ">",
|
||||||
|
let byte = UInt8(
|
||||||
|
text[text.index(after: index)..<hexEnd], radix: 16)
|
||||||
|
else {
|
||||||
|
result.append(text[index])
|
||||||
|
index = text.index(after: index)
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
result.append(Character(UnicodeScalar(byte)))
|
||||||
|
index = text.index(after: hexEnd)
|
||||||
|
}
|
||||||
|
return result
|
||||||
|
}
|
||||||
|
|
||||||
// MARK: - Detection (docs/11)
|
// MARK: - Detection (docs/11)
|
||||||
|
|
||||||
/// Media-type option key in preference order — used both to read a
|
/// Media-type option key in preference order — used both to read a
|
||||||
@@ -223,13 +266,20 @@ public enum CupsParsers {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Media type from a captured `key=value key=value` options string.
|
/// Media type from a captured `key=value key=value` options string.
|
||||||
/// Prefers `MediaType`, then `EPIJ_Medi` (docs/11 §tests).
|
/// Prefers `MediaType` (docs/11 §tests), then the remaining roster
|
||||||
|
/// keys in detection order — `CNIJMediaType`, `EPIJ_Medi`,
|
||||||
|
/// `StpMediaType` (#186 capture-return).
|
||||||
public static func extractMediaType(fromOptionsString options: String) -> String? {
|
public static func extractMediaType(fromOptionsString options: String) -> String? {
|
||||||
let pairs = lpoptions(options)
|
let pairs = lpoptions(options)
|
||||||
if let v = pairs.first(where: { $0.key == "MediaType" })?.value {
|
if let v = pairs.first(where: { $0.key == "MediaType" })?.value {
|
||||||
return v
|
return v
|
||||||
}
|
}
|
||||||
return pairs.first(where: { $0.key == "EPIJ_Medi" })?.value
|
for key in mediaTypeKeys where key != "MediaType" {
|
||||||
|
if let v = pairs.first(where: { $0.key == key })?.value {
|
||||||
|
return v
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Print-quality option key in preference order — vendor-first,
|
/// Print-quality option key in preference order — vendor-first,
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ import Foundation
|
|||||||
/// Errors from CUPS tool invocations.
|
/// Errors from CUPS tool invocations.
|
||||||
public enum CupsError: LocalizedError, Equatable {
|
public enum CupsError: LocalizedError, Equatable {
|
||||||
case toolFailed(tool: String, code: Int32, stderr: String)
|
case toolFailed(tool: String, code: Int32, stderr: String)
|
||||||
case tiffMissing(String)
|
|
||||||
case noPrinterSelected
|
case noPrinterSelected
|
||||||
|
|
||||||
public var errorDescription: String? {
|
public var errorDescription: String? {
|
||||||
@@ -13,8 +12,6 @@ public enum CupsError: LocalizedError, Equatable {
|
|||||||
return detail.isEmpty
|
return detail.isEmpty
|
||||||
? "\(tool) failed with exit code \(code)"
|
? "\(tool) failed with exit code \(code)"
|
||||||
: "\(tool) failed (\(code)): \(detail)"
|
: "\(tool) failed (\(code)): \(detail)"
|
||||||
case .tiffMissing(let path):
|
|
||||||
return "Target TIFF does not exist: \(path)"
|
|
||||||
case .noPrinterSelected:
|
case .noPrinterSelected:
|
||||||
return "No printer selected."
|
return "No printer selected."
|
||||||
}
|
}
|
||||||
@@ -27,9 +24,11 @@ public enum CupsError: LocalizedError, Equatable {
|
|||||||
/// `ProcessManager.runCaptured` so spawns are logged, get killAll
|
/// `ProcessManager.runCaptured` so spawns are logged, get killAll
|
||||||
/// coverage, and share the dup-id discipline; `binaryDir`/`ppdDir` are
|
/// coverage, and share the dup-id discipline; `binaryDir`/`ppdDir` are
|
||||||
/// injectable so tests use fixture scripts and never touch real CUPS.
|
/// injectable so tests use fixture scripts and never touch real CUPS.
|
||||||
|
/// Target spooling is **not** here — it is the app-target
|
||||||
|
/// `NativeTargetSpooler` (`NSPrintOperation`, #201 D1/D4).
|
||||||
public struct CupsService: Sendable {
|
public struct CupsService: Sendable {
|
||||||
public let processManager: ProcessManager
|
public let processManager: ProcessManager
|
||||||
/// Directory containing `lpstat`/`lpoptions`/`lp` — `/usr/bin` in
|
/// Directory containing `lpstat`/`lpoptions` — `/usr/bin` in
|
||||||
/// production, a fixture dir under test.
|
/// production, a fixture dir under test.
|
||||||
public let binaryDir: URL
|
public let binaryDir: URL
|
||||||
/// `/etc/cups/ppd` in production.
|
/// `/etc/cups/ppd` in production.
|
||||||
@@ -53,11 +52,11 @@ public struct CupsService: Sendable {
|
|||||||
// lpstat exits non-zero when no destinations exist — an empty
|
// lpstat exits non-zero when no destinations exist — an empty
|
||||||
// queue list is a valid result, not a failure (issue 12).
|
// queue list is a valid result, not a failure (issue 12).
|
||||||
let destinationsOut = try await run(
|
let destinationsOut = try await run(
|
||||||
"lpstat", ["-e"], id: ProcessID.lpstat("e"), tolerateFailure: true)
|
"lpstat", ["-e"], id: ProcessID.cupsLpstat("e"), tolerateFailure: true)
|
||||||
let statusOut = try await run(
|
let statusOut = try await run(
|
||||||
"lpstat", ["-p"], id: ProcessID.lpstat("p"), tolerateFailure: true)
|
"lpstat", ["-p"], id: ProcessID.cupsLpstat("p"), tolerateFailure: true)
|
||||||
let defaultOut = try await run(
|
let defaultOut = try await run(
|
||||||
"lpstat", ["-d"], id: ProcessID.lpstat("d"), tolerateFailure: true)
|
"lpstat", ["-d"], id: ProcessID.cupsLpstat("d"), tolerateFailure: true)
|
||||||
|
|
||||||
let names = CupsParsers.lpstatDestinations(destinationsOut.stdout)
|
let names = CupsParsers.lpstatDestinations(destinationsOut.stdout)
|
||||||
let statuses = CupsParsers.lpstatStatuses(statusOut.stdout)
|
let statuses = CupsParsers.lpstatStatuses(statusOut.stdout)
|
||||||
@@ -80,7 +79,7 @@ public struct CupsService: Sendable {
|
|||||||
/// display name, docs/11 §binding).
|
/// display name, docs/11 §binding).
|
||||||
public func displayName(for queue: String) async throws -> String? {
|
public func displayName(for queue: String) async throws -> String? {
|
||||||
let result = try await run(
|
let result = try await run(
|
||||||
"lpoptions", ["-p", queue], id: ProcessID.lpoptions(queue))
|
"lpoptions", ["-p", queue], id: ProcessID.cupsLpoptions(queue))
|
||||||
return CupsParsers.lpoptionsDisplayName(result.stdout)
|
return CupsParsers.lpoptionsDisplayName(result.stdout)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -90,7 +89,7 @@ public struct CupsService: Sendable {
|
|||||||
/// to media-key and colour-bypass detection (docs/11 layer ④).
|
/// to media-key and colour-bypass detection (docs/11 layer ④).
|
||||||
public func optionListings(for queue: String) async throws -> [CupsOptionListing] {
|
public func optionListings(for queue: String) async throws -> [CupsOptionListing] {
|
||||||
let result = try await run(
|
let result = try await run(
|
||||||
"lpoptions", ["-p", queue, "-l"], id: ProcessID.lpoptions("\(queue)-l"))
|
"lpoptions", ["-p", queue, "-l"], id: ProcessID.cupsLpoptions("\(queue)-l"))
|
||||||
return CupsParsers.lpoptionsList(result.stdout)
|
return CupsParsers.lpoptionsList(result.stdout)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -162,32 +161,15 @@ public struct CupsService: Sendable {
|
|||||||
Set(try await optionListings(for: queue).map(\.key))
|
Set(try await optionListings(for: queue).map(\.key))
|
||||||
}
|
}
|
||||||
|
|
||||||
// MARK: - Spool (issue 15)
|
|
||||||
|
|
||||||
/// `lp -d <queue> … <tiff>` — spool one target page unmanaged.
|
|
||||||
/// Never uses `-o raw` (#92). `page` disambiguates the process id
|
|
||||||
/// when several pages are spooled in sequence.
|
|
||||||
public func printTarget(
|
|
||||||
queue: String,
|
|
||||||
tiffPath: String,
|
|
||||||
options: PrintOptions,
|
|
||||||
page: Int = 0
|
|
||||||
) async throws {
|
|
||||||
guard FileManager.default.fileExists(atPath: tiffPath) else {
|
|
||||||
throw CupsError.tiffMissing(tiffPath)
|
|
||||||
}
|
|
||||||
let optionKeys = (try? await self.optionKeys(for: queue)) ?? []
|
|
||||||
let argv = try LpArgs.build(
|
|
||||||
queue: queue, tiffPath: tiffPath,
|
|
||||||
options: options, optionKeys: optionKeys)
|
|
||||||
try await run("lp", argv, id: ProcessID.lp(queue, page: page))
|
|
||||||
}
|
|
||||||
|
|
||||||
// MARK: - PPD
|
// MARK: - PPD
|
||||||
|
|
||||||
private func loadPPD(for queue: String) -> String? {
|
private func loadPPD(for queue: String) -> String? {
|
||||||
let url = ppdDir.appendingPathComponent("\(queue).ppd")
|
let url = ppdDir.appendingPathComponent("\(queue).ppd")
|
||||||
return try? String(contentsOf: url, encoding: .utf8)
|
// UTF-8 first — the Canon Thai labels are UTF-8 and a blanket
|
||||||
|
// Latin-1 read would mojibake them (#181, R10). Latin-1 only
|
||||||
|
// when UTF-8 decoding fails outright.
|
||||||
|
return (try? String(contentsOf: url, encoding: .utf8))
|
||||||
|
?? (try? String(contentsOf: url, encoding: .isoLatin1))
|
||||||
}
|
}
|
||||||
|
|
||||||
// MARK: - Spawn
|
// MARK: - Spawn
|
||||||
|
|||||||
@@ -1,136 +0,0 @@
|
|||||||
import Foundation
|
|
||||||
|
|
||||||
/// Errors from `buildLpArgs`.
|
|
||||||
public enum LpArgsError: LocalizedError, Equatable {
|
|
||||||
case unsanitisedOption(String)
|
|
||||||
|
|
||||||
public var errorDescription: String? {
|
|
||||||
switch self {
|
|
||||||
case .unsanitisedOption(let option):
|
|
||||||
return "Captured CUPS option contains unsafe characters: \(option)"
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// `lp` argv builder — issue 15, docs/11 `build_lp_args`.
|
|
||||||
///
|
|
||||||
/// ```
|
|
||||||
/// lp -d <queue> -t "ICCery Target - <file>"
|
|
||||||
/// -o AP_ColorMatchingMode=AP_ApplicationColorMatching
|
|
||||||
/// -o AP.ColorMatchingMode=AP_ApplicationColorMatching
|
|
||||||
/// <captured cups_options>
|
|
||||||
/// <media_type, if no media key already captured>
|
|
||||||
/// <quality, if no quality key already captured> (#183)
|
|
||||||
/// <driver bypass, if no bypass key captured>
|
|
||||||
/// <orientation-requested=3|4, unless captured>
|
|
||||||
/// <PageSize, unless captured>
|
|
||||||
/// <tiff>
|
|
||||||
/// ```
|
|
||||||
///
|
|
||||||
/// - **Never `-o raw`** — `raw` skips the raster filter that honours
|
|
||||||
/// `AP_ApplicationColorMatching` (#92).
|
|
||||||
/// - Captured options **win** over explicit fields: any key already
|
|
||||||
/// present (case-insensitive) suppresses the derived `-o`.
|
|
||||||
/// - Captured keys/values are sanitised — `;`, newlines, or shell
|
|
||||||
/// metacharacters throw `unsanitisedOption`; args are passed as a
|
|
||||||
/// `Process` argv array, never through a shell.
|
|
||||||
/// - The TIFF path is always the **last** argument.
|
|
||||||
public enum LpArgs {
|
|
||||||
|
|
||||||
/// `options` = the captured `PrintOptions`; `optionKeys` = the
|
|
||||||
/// queue's `lpoptions -l` key set (for media-key/bypass detection).
|
|
||||||
public static func build(
|
|
||||||
queue: String,
|
|
||||||
tiffPath: String,
|
|
||||||
options: PrintOptions,
|
|
||||||
optionKeys: Set<String>
|
|
||||||
) throws -> [String] {
|
|
||||||
var argv: [String] = [
|
|
||||||
"-d", queue,
|
|
||||||
"-t", "ICCery Target - \((tiffPath as NSString).lastPathComponent)",
|
|
||||||
"-o", "AP_ColorMatchingMode=AP_ApplicationColorMatching",
|
|
||||||
"-o", "AP.ColorMatchingMode=AP_ApplicationColorMatching",
|
|
||||||
]
|
|
||||||
var addedKeys: Set<String> = [
|
|
||||||
"ap_colormatchingmode", "ap.colormatchingmode",
|
|
||||||
]
|
|
||||||
|
|
||||||
// Captured CUPS options — sanitised, lowercased-key dedup.
|
|
||||||
if let captured = options.cupsOptions, !captured.isEmpty {
|
|
||||||
// Newlines can't survive the tokeniser — check the raw
|
|
||||||
// string so embedded line breaks are still rejected.
|
|
||||||
if captured.contains("\n") || captured.contains("\r") {
|
|
||||||
throw LpArgsError.unsanitisedOption(captured)
|
|
||||||
}
|
|
||||||
for pair in CupsParsers.lpoptions(captured) {
|
|
||||||
try sanitize(pair.key, pair.value)
|
|
||||||
let lowered = pair.key.lowercased()
|
|
||||||
// Defence in depth: never let a captured `raw` reach
|
|
||||||
// argv — `-o raw` skips the raster filter that honours
|
|
||||||
// AP_ApplicationColorMatching (#92).
|
|
||||||
if lowered == "raw" { continue }
|
|
||||||
guard !addedKeys.contains(lowered) else { continue }
|
|
||||||
addedKeys.insert(lowered)
|
|
||||||
argv += ["-o", "\(pair.key)=\(pair.value)"]
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Media type — only when the captured options didn't carry one.
|
|
||||||
if let mediaType = options.mediaType,
|
|
||||||
let mediaKey = CupsParsers.detectMediaTypeKey(optionKeys: optionKeys),
|
|
||||||
!addedKeys.contains(mediaKey.lowercased()) {
|
|
||||||
addedKeys.insert(mediaKey.lowercased())
|
|
||||||
argv += ["-o", "\(mediaKey)=\(mediaType)"]
|
|
||||||
}
|
|
||||||
|
|
||||||
// Print quality — after media, before the driver bypass; the
|
|
||||||
// detected queue key is skipped when already captured (#183).
|
|
||||||
if let quality = options.quality,
|
|
||||||
let qualityKey = CupsParsers.detectQualityKey(optionKeys: optionKeys),
|
|
||||||
!addedKeys.contains(qualityKey.lowercased()) {
|
|
||||||
addedKeys.insert(qualityKey.lowercased())
|
|
||||||
argv += ["-o", "\(qualityKey)=\(quality)"]
|
|
||||||
}
|
|
||||||
|
|
||||||
// Driver colour bypass — when no bypass key was captured. NOT
|
|
||||||
// gated on ppdUncorrectedPassthrough (macOS always bypasses).
|
|
||||||
let capturedKeys = Set(
|
|
||||||
CupsParsers.lpoptions(options.cupsOptions ?? "")
|
|
||||||
.map { $0.key })
|
|
||||||
if capturedKeys.isDisjoint(with: CupsParsers.bypassKeys),
|
|
||||||
let bypass = CupsParsers.detectDriverColorBypass(optionKeys: optionKeys),
|
|
||||||
!addedKeys.contains(bypass.key.lowercased()) {
|
|
||||||
addedKeys.insert(bypass.key.lowercased())
|
|
||||||
argv += ["-o", "\(bypass.key)=\(bypass.value)"]
|
|
||||||
}
|
|
||||||
|
|
||||||
// Orientation — portrait=3, landscape=4.
|
|
||||||
if let orientation = options.orientation,
|
|
||||||
!addedKeys.contains("orientation-requested") {
|
|
||||||
let value = orientation == "landscape" ? "4" : "3"
|
|
||||||
addedKeys.insert("orientation-requested")
|
|
||||||
argv += ["-o", "orientation-requested=\(value)"]
|
|
||||||
}
|
|
||||||
|
|
||||||
// PageSize — the printtarg layout page size.
|
|
||||||
if let paperSize = options.paperSize, !paperSize.isEmpty,
|
|
||||||
!addedKeys.contains("pagesize") {
|
|
||||||
argv += ["-o", "PageSize=\(paperSize)"]
|
|
||||||
}
|
|
||||||
|
|
||||||
argv.append(tiffPath)
|
|
||||||
return argv
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Reject shell/metachar injection — args go to `Process` as an
|
|
||||||
/// argv array, but a hostile captured string must not smuggle a
|
|
||||||
/// second option or command.
|
|
||||||
static func sanitize(_ key: String, _ value: String) throws {
|
|
||||||
let forbidden = CharacterSet(charactersIn: ";\n\r`|$&<>\\\"'")
|
|
||||||
if key.rangeOfCharacter(from: forbidden) != nil
|
|
||||||
|| value.rangeOfCharacter(from: forbidden) != nil
|
|
||||||
|| key.isEmpty {
|
|
||||||
throw LpArgsError.unsanitisedOption("\(key)=\(value)")
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -111,24 +111,24 @@ public struct PrinterCapabilities: Codable, Equatable, Sendable {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Options carried into `lp` (docs/10 §PrintOptions). On macOS
|
/// The Stage 2 mirror — panel selections and the captured `k=v`
|
||||||
/// `paperSource` is ignored unless already present inside captured
|
/// string (docs/10 §PrintOptions). Since #201 removed the `lp` path
|
||||||
/// `cupsOptions`; `ppdUncorrectedPassthrough` is stored (the panel sets
|
/// these fields feed `TargetPrintOverrides` (Stage 2 always wins, D6)
|
||||||
/// it on OK) but never gates the argv — macOS always bypasses driver
|
/// and the mirror apply-back; the opaque vendor state now travels
|
||||||
/// colour management.
|
/// inside the `PrintTicket`, not a flattened option string.
|
||||||
public struct PrintOptions: Codable, Equatable, Sendable {
|
public struct PrintOptions: Codable, Equatable, Sendable {
|
||||||
public var paperSource: Int?
|
public var paperSource: Int?
|
||||||
/// `"portrait"` / `"landscape"` → `orientation-requested=3|4`.
|
/// `"portrait"` / `"landscape"` → `orientation-requested=3|4`.
|
||||||
public var orientation: String?
|
public var orientation: String?
|
||||||
/// Stage 2 paper token → `PageSize=` (skipped if captured, #183).
|
/// Stage 2 paper token → `PageSize=` ticket write + `PMPaper`.
|
||||||
public var paperSize: String?
|
public var paperSize: String?
|
||||||
public var mediaType: String?
|
public var mediaType: String?
|
||||||
/// Print-quality token → `-o <detectedQualityKey>=` (skipped if
|
/// Print-quality token → `<detectedQualityKey>=` ticket write.
|
||||||
/// captured, #183).
|
|
||||||
public var quality: String?
|
public var quality: String?
|
||||||
public var ppdUncorrectedPassthrough: Bool?
|
public var ppdUncorrectedPassthrough: Bool?
|
||||||
/// Space-separated `key=value` captured from
|
/// Space-separated `key=value` captured from
|
||||||
/// `PMPrintSettingsToOptions` and filtered (docs/11 layer ⑥).
|
/// `PMPrintSettingsToOptions` and filtered (docs/11 layer ⑥) —
|
||||||
|
/// the Stage 2 mirror only, never a spool payload.
|
||||||
public var cupsOptions: String?
|
public var cupsOptions: String?
|
||||||
|
|
||||||
public init(
|
public init(
|
||||||
|
|||||||
@@ -18,8 +18,8 @@ public enum ProcessID {
|
|||||||
public static func applycal(_ stem: String) -> String { "applycal_\(stem)" }
|
public static func applycal(_ stem: String) -> String { "applycal_\(stem)" }
|
||||||
|
|
||||||
/// CUPS system tools (`/usr/bin/…`) — captured one-shots, not
|
/// CUPS system tools (`/usr/bin/…`) — captured one-shots, not
|
||||||
/// streaming Argyll children.
|
/// streaming Argyll children. Named `cups*` so no `lp*`-prefixed
|
||||||
public static func lpstat(_ mode: String) -> String { "lpstat_\(mode)" }
|
/// identifier survives the target-print removal (#201).
|
||||||
public static func lpoptions(_ queue: String) -> String { "lpoptions_\(queue)" }
|
public static func cupsLpstat(_ mode: String) -> String { "lpstat_\(mode)" }
|
||||||
public static func lp(_ queue: String, page: Int) -> String { "lp_\(queue)_\(page)" }
|
public static func cupsLpoptions(_ queue: String) -> String { "lpoptions_\(queue)" }
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -26,7 +26,7 @@ as AGPLv3 child processes. The GUI never `dlopen`s or links Argyll.
|
|||||||
| M8 | Deduplication contracts & UAT-ready hardening (#79–#86) — shipped |
|
| M8 | Deduplication contracts & UAT-ready hardening (#79–#86) — shipped |
|
||||||
| M9 | macOS 12 / Xcode 14.2 retarget (PR #145) — shipped |
|
| M9 | macOS 12 / Xcode 14.2 retarget (PR #145) — shipped |
|
||||||
| M10 | Studio workflow: media library (#146), gamut compare (#147), Spot Read (#148), project files (#149) — shipped on `develop` |
|
| M10 | Studio workflow: media library (#146), gamut compare (#147), Spot Read (#148), project files (#149) — shipped on `develop` |
|
||||||
| M11 | Printer settings completeness & dialog binding (#183, #180, #181, #186) — in flight on `milestone/m11-print-settings` |
|
| M11 | Printer settings completeness & dialog binding (#183, #180, #181, #186) — shipped on `develop` (PR #199) |
|
||||||
| Licence | Proprietary source in [`LICENCE.md`](LICENCE.md); bundled Argyll sidecars remain AGPLv3 |
|
| Licence | Proprietary source in [`LICENCE.md`](LICENCE.md); bundled Argyll sidecars remain AGPLv3 |
|
||||||
|
|
||||||
## What it does
|
## What it does
|
||||||
@@ -299,9 +299,9 @@ fix/<issue>-<slug>
|
|||||||
```
|
```
|
||||||
|
|
||||||
Open feature/fix PRs against **`develop`**. A `milestone/m…` integration
|
Open feature/fix PRs against **`develop`**. A `milestone/m…` integration
|
||||||
branch is used only while that milestone is assembling — currently
|
branch is used only while that milestone is assembling; `milestone/m10-studio`
|
||||||
`milestone/m11-print-settings` (`milestone/m10-studio` was merged and
|
and `milestone/m11-print-settings` have been merged (branches retained). Do
|
||||||
deleted). Do not open umbrella “bugfix” branches that mix tickets.
|
not open umbrella “bugfix” branches that mix tickets.
|
||||||
|
|
||||||
`main` is push-protected and requires status check
|
`main` is push-protected and requires status check
|
||||||
`macOS CI / build-and-test (push)`. Protected **file** patterns on `main`
|
`macOS CI / build-and-test (push)`. Protected **file** patterns on `main`
|
||||||
|
|||||||
@@ -106,12 +106,14 @@ enum UITestHooks {
|
|||||||
|
|
||||||
// MARK: - Print panel / CUPS stubs (issue 13/17)
|
// MARK: - Print panel / CUPS stubs (issue 13/17)
|
||||||
|
|
||||||
/// Directory of mock `lp`/`lpstat`/`lpoptions` fixture scripts —
|
/// Directory of mock `lpstat`/`lpoptions` fixture scripts —
|
||||||
/// `CupsService.binaryDir` under UI tests.
|
/// `CupsService.binaryDir` under UI tests.
|
||||||
static var cupsBinaryDir: URL? { url("ICCERY_CUPS_BIN_DIR") }
|
static var cupsBinaryDir: URL? { url("ICCERY_CUPS_BIN_DIR") }
|
||||||
|
|
||||||
/// Path the mock `lp` script appends its argv to, for assertions.
|
/// Path the `RecordingTargetSpooler` appends resolved ticket
|
||||||
static var lpArgvOutURL: URL? { url("ICCERY_TEST_LP_ARGV") }
|
/// lines to, for assertions (#201 D8 — replaces the `lp` argv
|
||||||
|
/// log).
|
||||||
|
static var spoolLogURL: URL? { url("ICCERY_TEST_SPOOL_LOG") }
|
||||||
|
|
||||||
/// Whether the `NSPrintPanel` should be stubbed under UI testing —
|
/// Whether the `NSPrintPanel` should be stubbed under UI testing —
|
||||||
/// separate from the stub's *result* so "cancel" (`nil`) does not
|
/// separate from the stub's *result* so "cancel" (`nil`) does not
|
||||||
|
|||||||
@@ -84,6 +84,35 @@ struct ColorSyncSuppressor {
|
|||||||
return applied
|
return applied
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// MARK: - Layer ⑤′ Quartz vocabulary (#201 D2)
|
||||||
|
|
||||||
|
/// With `lp` gone there is one print path and it carries **both**
|
||||||
|
/// dictionaries: write keys 3–5 of the resolver order into
|
||||||
|
/// `PMPrintSettings` so the PDE and the spool job see them
|
||||||
|
/// (docs/14 §7). Warn-only — a rejected key never aborts.
|
||||||
|
@discardableResult
|
||||||
|
func applyQuartzMode(to settings: PMPrintSettings) -> Int {
|
||||||
|
var applied = 0
|
||||||
|
let pairs: [(key: String, value: String, locked: Bool)] = [
|
||||||
|
(ColorMatchingAttempts.quartzModeKey,
|
||||||
|
ColorMatchingAttempts.quartzCustomMatching, true),
|
||||||
|
(ColorMatchingAttempts.quartzProfileKey, "", false),
|
||||||
|
(ColorMatchingAttempts.quartzLegacyModeKey,
|
||||||
|
ColorMatchingAttempts.quartzCustomMatching, false),
|
||||||
|
]
|
||||||
|
for pair in pairs {
|
||||||
|
let status = PMPrintSettingsSetValue(
|
||||||
|
settings, pair.key as CFString, pair.value as CFString,
|
||||||
|
pair.locked)
|
||||||
|
if status == 0 { applied += 1 }
|
||||||
|
}
|
||||||
|
if applied == 0 {
|
||||||
|
log("ColorSync: PMPrintSettingsSetValue rejected the "
|
||||||
|
+ "Quartz colour-matching keys")
|
||||||
|
}
|
||||||
|
return applied
|
||||||
|
}
|
||||||
|
|
||||||
// MARK: - Layer ④ driver bypass
|
// MARK: - Layer ④ driver bypass
|
||||||
|
|
||||||
/// Pre-select the driver "no colour adjustment" option, unlocked —
|
/// Pre-select the driver "no colour adjustment" option, unlocked —
|
||||||
@@ -112,7 +141,11 @@ struct ColorSyncSuppressor {
|
|||||||
// MARK: - Layer ⑤ NSPrintInfo mirror
|
// MARK: - Layer ⑤ NSPrintInfo mirror
|
||||||
|
|
||||||
/// Mirror the applied keys into `printSettings` so the PDE pick
|
/// Mirror the applied keys into `printSettings` so the PDE pick
|
||||||
/// sees them.
|
/// sees them. Also populates the nested
|
||||||
|
/// `com.apple.print.printSettings` sub-dictionary of
|
||||||
|
/// `printInfo.dictionary()` with the AP_* **and** Quartz keys —
|
||||||
|
/// the single remaining path carries both vocabularies (#201 D2,
|
||||||
|
/// docs/14 §7).
|
||||||
func mirror(
|
func mirror(
|
||||||
into printInfo: NSPrintInfo,
|
into printInfo: NSPrintInfo,
|
||||||
driverBypass: (key: String, value: String)?
|
driverBypass: (key: String, value: String)?
|
||||||
@@ -121,9 +154,29 @@ struct ColorSyncSuppressor {
|
|||||||
for key in ColorMatchingAttempts.printSettingsKeys {
|
for key in ColorMatchingAttempts.printSettingsKeys {
|
||||||
settings[key as NSString] = ColorMatchingAttempts.applicationMatchingValue as NSString
|
settings[key as NSString] = ColorMatchingAttempts.applicationMatchingValue as NSString
|
||||||
}
|
}
|
||||||
|
settings[ColorMatchingAttempts.quartzModeKey as NSString] =
|
||||||
|
ColorMatchingAttempts.quartzCustomMatching as NSString
|
||||||
|
settings[ColorMatchingAttempts.quartzProfileKey as NSString] =
|
||||||
|
"" as NSString
|
||||||
|
settings[ColorMatchingAttempts.quartzLegacyModeKey as NSString] =
|
||||||
|
ColorMatchingAttempts.quartzCustomMatching as NSString
|
||||||
if let driverBypass {
|
if let driverBypass {
|
||||||
settings[driverBypass.key as NSString] = driverBypass.value as NSString
|
settings[driverBypass.key as NSString] = driverBypass.value as NSString
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Nested mirror — drivers that read the flattened dictionary.
|
||||||
|
let nestedKey = ColorMatchingAttempts.quartzNestedDictKey as NSString
|
||||||
|
let nested = (settings[nestedKey] as? NSMutableDictionary)
|
||||||
|
?? NSMutableDictionary()
|
||||||
|
for key in ColorMatchingAttempts.printSettingsKeys {
|
||||||
|
nested[key] = ColorMatchingAttempts.applicationMatchingValue
|
||||||
|
}
|
||||||
|
nested[ColorMatchingAttempts.quartzModeKey] =
|
||||||
|
ColorMatchingAttempts.quartzCustomMatching
|
||||||
|
nested[ColorMatchingAttempts.quartzProfileKey] = ""
|
||||||
|
nested[ColorMatchingAttempts.quartzLegacyModeKey] =
|
||||||
|
ColorMatchingAttempts.quartzCustomMatching
|
||||||
|
settings[nestedKey] = nested
|
||||||
}
|
}
|
||||||
|
|
||||||
// MARK: - Layer ⑥ capture
|
// MARK: - Layer ⑥ capture
|
||||||
|
|||||||
@@ -0,0 +1,317 @@
|
|||||||
|
import AppKit
|
||||||
|
import ApplicationServices
|
||||||
|
import ICCeryCore
|
||||||
|
|
||||||
|
/// One page to draw — the TIFF plus its printtarg manifest size for
|
||||||
|
/// the drift check (#201 D9).
|
||||||
|
struct TargetPrintPage: Equatable {
|
||||||
|
let url: URL
|
||||||
|
let expectedWidthMm: Double?
|
||||||
|
let expectedHeightMm: Double?
|
||||||
|
}
|
||||||
|
|
||||||
|
/// One spool job — a single-element `pages` in per-page mode, all
|
||||||
|
/// pages when `singleJobForAllPages` is on (#201 D5).
|
||||||
|
struct TargetPrintRequest {
|
||||||
|
let queue: String
|
||||||
|
let displayName: String?
|
||||||
|
let pages: [TargetPrintPage]
|
||||||
|
let jobTitle: String // "ICCery Target - <basename>"
|
||||||
|
/// nil → bind + PM defaults + suppression only (the ticket carries
|
||||||
|
/// the captured PDE state; without it the job is Stage 2 writes
|
||||||
|
/// over queue defaults).
|
||||||
|
let ticket: PrintTicket?
|
||||||
|
let overrides: TargetPrintOverrides
|
||||||
|
/// The queue's `lpoptions -l` key roster — feeds vendor media-key
|
||||||
|
/// and driver-bypass detection.
|
||||||
|
let optionKeys: Set<String>
|
||||||
|
/// Test-only: `.save` to this URL instead of `.spool` (#201 D8).
|
||||||
|
var savePDFTo: URL?
|
||||||
|
}
|
||||||
|
|
||||||
|
enum TargetSpoolError: LocalizedError, Equatable {
|
||||||
|
case noPages
|
||||||
|
case printerUnresolved(queue: String)
|
||||||
|
case operationFailed(queue: String, jobTitle: String)
|
||||||
|
|
||||||
|
var errorDescription: String? {
|
||||||
|
switch self {
|
||||||
|
case .noPages:
|
||||||
|
return "Nothing to print."
|
||||||
|
case .printerUnresolved(let queue):
|
||||||
|
return "The print queue '\(queue)' could not be resolved."
|
||||||
|
case .operationFailed(_, let jobTitle):
|
||||||
|
return "The print operation for '\(jobTitle)' failed."
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@MainActor
|
||||||
|
protocol TargetSpooling {
|
||||||
|
/// Warn-only diagnostics (manifest drift, oversize page, rejected
|
||||||
|
/// key) are delivered here; the throw path is reserved for real
|
||||||
|
/// failures.
|
||||||
|
var diagnostics: ((Notice) -> Void)? { get set }
|
||||||
|
func spool(_ request: TargetPrintRequest) throws
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Production spooler — rehydrates the captured ticket, applies the
|
||||||
|
/// resolved Stage 2 writes, and draws each TIFF 1:1 through a silent
|
||||||
|
/// `NSPrintOperation` (#201, the S1–S14 trace in the M12 megaplan).
|
||||||
|
@MainActor
|
||||||
|
final class NativeTargetSpooler: TargetSpooling {
|
||||||
|
var suppressor = ColorSyncSuppressor()
|
||||||
|
var diagnostics: ((Notice) -> Void)?
|
||||||
|
var log: (LogLevel, String) -> Void = { AppLogger.shared.log($0, $1) }
|
||||||
|
|
||||||
|
func spool(_ request: TargetPrintRequest) throws {
|
||||||
|
guard !request.pages.isEmpty else { throw TargetSpoolError.noPages }
|
||||||
|
|
||||||
|
// The PM printer handle is held for the whole operation and
|
||||||
|
// released on every path (S14).
|
||||||
|
let printer = PMTicketBridge.makePrinter(queue: request.queue)
|
||||||
|
defer { if let printer { PMTicketBridge.release(printer) } }
|
||||||
|
|
||||||
|
let (printInfo, _) = try makePrintInfo(for: request, boundTo: printer)
|
||||||
|
|
||||||
|
// S10 — decode every page 1:1. Warn-only findings ride the
|
||||||
|
// `diagnostics` seam, never the throw path (D9).
|
||||||
|
var rasters: [TargetPageRaster] = []
|
||||||
|
rasters.reserveCapacity(request.pages.count)
|
||||||
|
for page in request.pages {
|
||||||
|
let raster = try TargetRasterLoader.load(
|
||||||
|
tiff: page.url,
|
||||||
|
expectedWidthMm: page.expectedWidthMm,
|
||||||
|
expectedHeightMm: page.expectedHeightMm)
|
||||||
|
if let drift = raster.manifestDrift {
|
||||||
|
diagnostics?(Notice(kind: .warning, text: drift))
|
||||||
|
}
|
||||||
|
if raster.pointSize.width > printInfo.paperSize.width + 0.5
|
||||||
|
|| raster.pointSize.height
|
||||||
|
> printInfo.paperSize.height + 0.5 {
|
||||||
|
diagnostics?(Notice(
|
||||||
|
kind: .warning,
|
||||||
|
text: "\(page.url.lastPathComponent) exceeds the "
|
||||||
|
+ "paper size — it will be clipped, not scaled."))
|
||||||
|
}
|
||||||
|
rasters.append(raster)
|
||||||
|
}
|
||||||
|
|
||||||
|
// S11–S13 — headless canvas + silent operation (D7).
|
||||||
|
let canvas = TargetPageCanvasView(
|
||||||
|
pages: rasters, paperSize: printInfo.paperSize)
|
||||||
|
let operation = NSPrintOperation(view: canvas, printInfo: printInfo)
|
||||||
|
operation.showsPrintPanel = false
|
||||||
|
operation.showsProgressPanel = false
|
||||||
|
operation.canSpawnSeparateThread = false
|
||||||
|
operation.jobTitle = request.jobTitle
|
||||||
|
guard operation.run() else {
|
||||||
|
throw TargetSpoolError.operationFailed(
|
||||||
|
queue: request.queue, jobTitle: request.jobTitle)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// S1–S9 — a fully configured `NSPrintInfo` plus the resolved
|
||||||
|
/// write list. Extracted for the PDF harness + unit tests;
|
||||||
|
/// `spool(_:)` is the production entry point (it keeps the PM
|
||||||
|
/// printer handle alive through `run()`).
|
||||||
|
func makePrintInfo(
|
||||||
|
for request: TargetPrintRequest
|
||||||
|
) throws -> (NSPrintInfo, ResolvedTicketWrites) {
|
||||||
|
let printer = PMTicketBridge.makePrinter(queue: request.queue)
|
||||||
|
defer { if let printer { PMTicketBridge.release(printer) } }
|
||||||
|
return try makePrintInfo(for: request, boundTo: printer)
|
||||||
|
}
|
||||||
|
|
||||||
|
private func makePrintInfo(
|
||||||
|
for request: TargetPrintRequest,
|
||||||
|
boundTo printer: PMPrinter?
|
||||||
|
) throws -> (NSPrintInfo, ResolvedTicketWrites) {
|
||||||
|
// S1
|
||||||
|
let printInfo = NSPrintInfo()
|
||||||
|
|
||||||
|
// S2 — Cocoa-level printer first: it runs before binding and
|
||||||
|
// ticket restore, so a printer-driven settings reset cannot
|
||||||
|
// clobber the ticket (R9). Best effort; PM binding is
|
||||||
|
// authoritative.
|
||||||
|
var resolvedNSPrinter = false
|
||||||
|
if let nsPrinter = NSPrinter(name: request.queue)
|
||||||
|
?? request.displayName.flatMap({ NSPrinter(name: $0) }) {
|
||||||
|
printInfo.printer = nsPrinter
|
||||||
|
resolvedNSPrinter = true
|
||||||
|
}
|
||||||
|
|
||||||
|
// S3 — PM binding + session defaults. A failed bind degrades
|
||||||
|
// to the NSPrinter fallback; with neither, the job would land
|
||||||
|
// on the default queue — a wrong answer, so it throws.
|
||||||
|
var boundViaPM = false
|
||||||
|
if let printer {
|
||||||
|
do {
|
||||||
|
try PMTicketBridge.bind(printer: printer, to: printInfo)
|
||||||
|
boundViaPM = true
|
||||||
|
} catch {
|
||||||
|
log(.warn, "Spool: PM bind failed for "
|
||||||
|
+ "'\(request.queue)' — continuing on the "
|
||||||
|
+ "NSPrinter fallback")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
guard boundViaPM || resolvedNSPrinter else {
|
||||||
|
throw TargetSpoolError.printerUnresolved(queue: request.queue)
|
||||||
|
}
|
||||||
|
|
||||||
|
// S4 — rehydrate the captured ticket. `restore` itself refuses
|
||||||
|
// a cross-queue replay (R3).
|
||||||
|
if let ticket = request.ticket {
|
||||||
|
try PMTicketBridge.restore(ticket, into: printInfo)
|
||||||
|
}
|
||||||
|
|
||||||
|
// S5 — Stage 2 writes (AP_* + Quartz vocabularies + media /
|
||||||
|
// quality / bypass, D2/D6) onto the live PMPrintSettings.
|
||||||
|
let resolved = TicketWriteResolver.resolve(
|
||||||
|
overrides: request.overrides, optionKeys: request.optionKeys)
|
||||||
|
let settings = PMTicketBridge.settings(printInfo)
|
||||||
|
for write in resolved.writes {
|
||||||
|
// R4 — write only when the value differs, and log old→new
|
||||||
|
// so a vendor companion-key desync is diagnosable.
|
||||||
|
let current = PMTicketBridge.stringValue(
|
||||||
|
forKey: write.key, in: settings)
|
||||||
|
guard current != write.value else { continue }
|
||||||
|
if let current {
|
||||||
|
log(.info, "Spool: \(write.key): '\(current)' "
|
||||||
|
+ "→ '\(write.value)'")
|
||||||
|
}
|
||||||
|
PMTicketBridge.setValue(
|
||||||
|
write.value, forKey: write.key, locked: write.locked,
|
||||||
|
in: settings, context: "Spool")
|
||||||
|
}
|
||||||
|
printInfo.updateFromPMPrintSettings()
|
||||||
|
mirror(resolved.writes, into: printInfo)
|
||||||
|
|
||||||
|
// S6 — paper override: `PMPaper` match on the bound printer;
|
||||||
|
// `Custom.<w>x<h>` tokens (already points) set the Cocoa paper
|
||||||
|
// size directly.
|
||||||
|
if let token = resolved.paperToken {
|
||||||
|
if let printer, boundViaPM {
|
||||||
|
PMTicketBridge.applyPaper(
|
||||||
|
token: token, printer: printer,
|
||||||
|
session: PMTicketBridge.session(printInfo),
|
||||||
|
printInfo: printInfo)
|
||||||
|
} else if let custom = PMTicketBridge
|
||||||
|
.customPaperDimensions(from: token) {
|
||||||
|
printInfo.paperSize = NSSize(
|
||||||
|
width: custom.width, height: custom.height)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// S7 — orientation on the Cocoa page format; the
|
||||||
|
// `orientation-requested` write above is the driver half.
|
||||||
|
if let orientation = resolved.orientation {
|
||||||
|
printInfo.orientation = orientation == "landscape"
|
||||||
|
? .landscape : .portrait
|
||||||
|
}
|
||||||
|
|
||||||
|
// S8 — private SPI on the live session; only meaningful with
|
||||||
|
// a bound printer (same constraint as the panel path).
|
||||||
|
if boundViaPM {
|
||||||
|
suppressor.applySPIMode(to: PMTicketBridge.session(printInfo))
|
||||||
|
}
|
||||||
|
|
||||||
|
// S9 — Cocoa geometry: margins 0, `.clip` pagination, 1:1
|
||||||
|
// scale, no centring; `.spool`, or `.save` + jobSavingURL
|
||||||
|
// under the PDF harness (D8/D9).
|
||||||
|
printInfo.topMargin = 0
|
||||||
|
printInfo.bottomMargin = 0
|
||||||
|
printInfo.leftMargin = 0
|
||||||
|
printInfo.rightMargin = 0
|
||||||
|
printInfo.horizontalPagination = .clip
|
||||||
|
printInfo.verticalPagination = .clip
|
||||||
|
printInfo.scalingFactor = 1.0
|
||||||
|
printInfo.isHorizontallyCentered = false
|
||||||
|
printInfo.isVerticallyCentered = false
|
||||||
|
if let saveURL = request.savePDFTo {
|
||||||
|
printInfo.jobDisposition = .save
|
||||||
|
printInfo.dictionary()[
|
||||||
|
NSPrintInfo.AttributeKey.jobSavingURL] = saveURL
|
||||||
|
} else {
|
||||||
|
printInfo.jobDisposition = .spool
|
||||||
|
}
|
||||||
|
|
||||||
|
return (printInfo, resolved)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The resolved writes also land in `NSPrintInfo.printSettings` so
|
||||||
|
/// the driver sees them through Cocoa — the
|
||||||
|
/// `com.apple.print.printSettings` sub-dictionary carries the
|
||||||
|
/// colour keys (D2 / docs/14 §7).
|
||||||
|
private func mirror(
|
||||||
|
_ writes: [TicketWrite], into printInfo: NSPrintInfo
|
||||||
|
) {
|
||||||
|
let settings = printInfo.printSettings
|
||||||
|
for write in writes {
|
||||||
|
settings[write.key as NSString] = write.value as NSString
|
||||||
|
}
|
||||||
|
let nestedKey = ColorMatchingAttempts.quartzNestedDictKey as NSString
|
||||||
|
let nested = (settings[nestedKey] as? NSMutableDictionary)
|
||||||
|
?? NSMutableDictionary()
|
||||||
|
for write in writes where Self.isColourKey(write.key) {
|
||||||
|
nested[write.key] = write.value
|
||||||
|
}
|
||||||
|
settings[nestedKey] = nested
|
||||||
|
}
|
||||||
|
|
||||||
|
private static func isColourKey(_ key: String) -> Bool {
|
||||||
|
ColorMatchingAttempts.printSettingsKeys.contains(key)
|
||||||
|
|| key == ColorMatchingAttempts.quartzModeKey
|
||||||
|
|| key == ColorMatchingAttempts.quartzProfileKey
|
||||||
|
|| key == ColorMatchingAttempts.quartzLegacyModeKey
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#if DEBUG
|
||||||
|
/// UI-test seam (#201 D8). Runs the same `TicketWriteResolver` the
|
||||||
|
/// native spooler runs, appends one deterministic line per request to
|
||||||
|
/// `ICCERY_TEST_SPOOL_LOG`, and never touches the print system — so
|
||||||
|
/// UI tests need no queue, no driver and no PM binding.
|
||||||
|
///
|
||||||
|
/// `ICCERY_TEST_SPOOL_FAIL=1` injects an `operationFailed` error for
|
||||||
|
/// the failure-notice tests.
|
||||||
|
@MainActor
|
||||||
|
final class RecordingTargetSpooler: TargetSpooling {
|
||||||
|
let logURL: URL
|
||||||
|
var diagnostics: ((Notice) -> Void)?
|
||||||
|
|
||||||
|
init(logURL: URL) {
|
||||||
|
self.logURL = logURL
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `queue=<q> title=<t> page=<basename> pages=<n> paper=<token|->
|
||||||
|
/// orientation=<o> keys=<k=v k=v …>` — keys sorted alphabetically
|
||||||
|
/// so assertions are order-free.
|
||||||
|
func spool(_ request: TargetPrintRequest) throws {
|
||||||
|
guard !request.pages.isEmpty else { throw TargetSpoolError.noPages }
|
||||||
|
if ProcessInfo.processInfo.environment["ICCERY_TEST_SPOOL_FAIL"]
|
||||||
|
== "1" {
|
||||||
|
throw TargetSpoolError.operationFailed(
|
||||||
|
queue: request.queue, jobTitle: request.jobTitle)
|
||||||
|
}
|
||||||
|
let resolved = TicketWriteResolver.resolve(
|
||||||
|
overrides: request.overrides, optionKeys: request.optionKeys)
|
||||||
|
let keys = resolved.writes
|
||||||
|
.sorted { $0.key < $1.key }
|
||||||
|
.map { "\($0.key)=\($0.value)" }
|
||||||
|
.joined(separator: " ")
|
||||||
|
let line = "queue=\(request.queue)"
|
||||||
|
+ " title=\(request.jobTitle)"
|
||||||
|
+ " page=\(request.pages[0].url.lastPathComponent)"
|
||||||
|
+ " pages=\(request.pages.count)"
|
||||||
|
+ " paper=\(resolved.paperToken ?? "-")"
|
||||||
|
+ " orientation=\(resolved.orientation ?? "-")"
|
||||||
|
+ " keys=\(keys)\n"
|
||||||
|
// Atomic append — existing content + one line via the
|
||||||
|
// `.tmp`-then-rename convention (#213).
|
||||||
|
let existing = (try? String(contentsOf: logURL, encoding: .utf8))
|
||||||
|
?? ""
|
||||||
|
try AtomicFileWriter.write(existing + line, to: logURL)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
#endif
|
||||||
@@ -0,0 +1,389 @@
|
|||||||
|
import AppKit
|
||||||
|
import ApplicationServices
|
||||||
|
import ICCeryCore
|
||||||
|
|
||||||
|
/// Errors raised by Core Printing bridge operations.
|
||||||
|
enum PMTicketError: LocalizedError, Equatable {
|
||||||
|
case printerUnknown(queue: String)
|
||||||
|
case sessionBindingFailed(OSStatus)
|
||||||
|
case serialiseFailed(stage: String, status: OSStatus)
|
||||||
|
case restoreFailed(stage: String, status: OSStatus)
|
||||||
|
|
||||||
|
var errorDescription: String? {
|
||||||
|
switch self {
|
||||||
|
case .printerUnknown(let queue):
|
||||||
|
return "No printer found for queue '\(queue)'."
|
||||||
|
case .sessionBindingFailed(let status):
|
||||||
|
return "Could not bind the print session to the queue (OSStatus \(status))."
|
||||||
|
case .serialiseFailed(let stage, let status):
|
||||||
|
return "Print ticket capture failed at \(stage) (OSStatus \(status))."
|
||||||
|
case .restoreFailed(let stage, let status):
|
||||||
|
return "Print ticket restore failed at \(stage) (OSStatus \(status))."
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Every Core Printing (`PM*`) call in ICCery lives here (#201 D12).
|
||||||
|
///
|
||||||
|
/// Ownership — the ONLY rules, do not improvise:
|
||||||
|
/// * `PMPrinterCreateFromPrinterID`, `PMCreatePageFormatWithPMPaper`,
|
||||||
|
/// `PMPrintSettingsCreateWithDataRepresentation`,
|
||||||
|
/// `PMPageFormatCreateWithDataRepresentation` return **+1** →
|
||||||
|
/// `PMRelease(object(_:))` on every path (`defer`).
|
||||||
|
/// * `PM*CreateDataRepresentation` writes a **+1 CFData** →
|
||||||
|
/// `takeRetainedValue()` (the headers say "the caller is responsible
|
||||||
|
/// for releasing"; the out-param is not `CF_RETURNS_RETAINED`-annotated,
|
||||||
|
/// so Swift hands back an unbalanced `Unmanaged`).
|
||||||
|
/// * `PMPrinterGetPaperList`, `PMPaperGetID`, `PMPrinterGetID`,
|
||||||
|
/// `PMPrintSettingsGetValue` are **borrowed** → `takeUnretainedValue()`,
|
||||||
|
/// never released. `PMSessionGetCurrentPrinter` hands back the
|
||||||
|
/// session's own printer — also borrowed, never `PMRelease`d (an
|
||||||
|
/// over-release here dangles the session and crashes AppKit's
|
||||||
|
/// `_printerInPrintSession` / session teardown).
|
||||||
|
/// * `printInfo.pmPrintSession()/pmPrintSettings()/pmPageFormat()` are
|
||||||
|
/// borrowed from the `NSPrintInfo` → never released.
|
||||||
|
@MainActor
|
||||||
|
enum PMTicketBridge {
|
||||||
|
|
||||||
|
// MARK: Handles
|
||||||
|
|
||||||
|
/// Borrowed `PMPrintSession` from the `NSPrintInfo` — never released.
|
||||||
|
static func session(_ printInfo: NSPrintInfo) -> PMPrintSession {
|
||||||
|
unsafeBitCast(printInfo.pmPrintSession(), to: PMPrintSession.self)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Borrowed `PMPrintSettings` from the `NSPrintInfo` — never released.
|
||||||
|
static func settings(_ printInfo: NSPrintInfo) -> PMPrintSettings {
|
||||||
|
unsafeBitCast(printInfo.pmPrintSettings(), to: PMPrintSettings.self)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Borrowed `PMPageFormat` from the `NSPrintInfo` — never released.
|
||||||
|
static func pageFormat(_ printInfo: NSPrintInfo) -> PMPageFormat {
|
||||||
|
unsafeBitCast(printInfo.pmPageFormat(), to: PMPageFormat.self)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Any `PM*` handle → `PMObject` for `PMRelease` — the Carbon API
|
||||||
|
/// wants `UnsafeRawPointer`, Swift imports handles as `OpaquePointer`.
|
||||||
|
static func object<Handle>(_ handle: Handle) -> PMObject {
|
||||||
|
unsafeBitCast(handle, to: PMObject.self)
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: Binding (layer ①)
|
||||||
|
|
||||||
|
/// `PMPrinterCreateFromPrinterID` — **+1**, caller must
|
||||||
|
/// `PMTicketBridge.release` on every path.
|
||||||
|
static func makePrinter(queue: String) -> PMPrinter? {
|
||||||
|
PMPrinterCreateFromPrinterID(queue as CFString)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Balances `makePrinter(queue:)` / any +1 PM handle.
|
||||||
|
static func release(_ printer: PMPrinter) {
|
||||||
|
PMRelease(object(printer))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `PMSessionSetCurrentPMPrinter` + session defaults (warn-only).
|
||||||
|
/// Throws `PMTicketError.sessionBindingFailed` when the bind itself
|
||||||
|
/// fails — the caller still owns `printer` on every path.
|
||||||
|
static func bind(printer: PMPrinter, to printInfo: NSPrintInfo) throws {
|
||||||
|
let session = session(printInfo)
|
||||||
|
let status = PMSessionSetCurrentPMPrinter(session, printer)
|
||||||
|
guard status == 0 else {
|
||||||
|
throw PMTicketError.sessionBindingFailed(status)
|
||||||
|
}
|
||||||
|
// Warn-only: defaults keep the panel consistent with the
|
||||||
|
// queue but are not fatal when they fail.
|
||||||
|
_ = PMSessionDefaultPrintSettings(session, settings(printInfo))
|
||||||
|
_ = PMSessionDefaultPageFormat(session, pageFormat(printInfo))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `PMSessionGetCurrentPrinter` → `PMPrinterGetID` → String.
|
||||||
|
static func currentPrinterID(
|
||||||
|
session: PMPrintSession,
|
||||||
|
fallback: String
|
||||||
|
) -> String {
|
||||||
|
var current: PMPrinter?
|
||||||
|
guard PMSessionGetCurrentPrinter(session, ¤t) == 0,
|
||||||
|
let printer = current
|
||||||
|
else { return fallback }
|
||||||
|
// Borrowed from the session — never released (see header doc).
|
||||||
|
guard let id = PMPrinterGetID(printer)
|
||||||
|
else { return fallback }
|
||||||
|
return id.takeUnretainedValue() as String
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: Ticket (#201 D3)
|
||||||
|
|
||||||
|
/// Capture the live `PMPrintSettings` + `PMPageFormat` as XML
|
||||||
|
/// `Data` plus a plist-safe `NSPrintInfo.dictionary()` fallback.
|
||||||
|
/// The CFData out-params are **+1** by header contract
|
||||||
|
/// ("the caller is responsible for releasing") →
|
||||||
|
/// `takeRetainedValue()`.
|
||||||
|
static func serialise(
|
||||||
|
_ printInfo: NSPrintInfo,
|
||||||
|
queue: String
|
||||||
|
) throws -> PrintTicket {
|
||||||
|
var settingsRef: Unmanaged<CFData>?
|
||||||
|
let settingsStatus = PMPrintSettingsCreateDataRepresentation(
|
||||||
|
settings(printInfo), &settingsRef, kPMDataFormatXMLDefault)
|
||||||
|
guard settingsStatus == noErr, let settingsRef else {
|
||||||
|
throw PMTicketError.serialiseFailed(
|
||||||
|
stage: "printSettings", status: settingsStatus)
|
||||||
|
}
|
||||||
|
let settingsData = settingsRef.takeRetainedValue() as Data
|
||||||
|
|
||||||
|
var pageFormatRef: Unmanaged<CFData>?
|
||||||
|
let pageFormatStatus = PMPageFormatCreateDataRepresentation(
|
||||||
|
pageFormat(printInfo), &pageFormatRef, kPMDataFormatXMLDefault)
|
||||||
|
guard pageFormatStatus == noErr, let pageFormatRef else {
|
||||||
|
throw PMTicketError.serialiseFailed(
|
||||||
|
stage: "pageFormat", status: pageFormatStatus)
|
||||||
|
}
|
||||||
|
let pageFormatData = pageFormatRef.takeRetainedValue() as Data
|
||||||
|
|
||||||
|
// Cocoa-level fallback — warn-only, never fatal: filter the
|
||||||
|
// dictionary to plist-safe values so one exotic attribute
|
||||||
|
// cannot fail the whole snapshot.
|
||||||
|
let plist = try? PropertyListSerialization.data(
|
||||||
|
fromPropertyList: plistSafe(printInfo.dictionary()) ?? [:],
|
||||||
|
format: .binary, options: 0)
|
||||||
|
|
||||||
|
return PrintTicket(
|
||||||
|
queue: queue,
|
||||||
|
printSettings: settingsData,
|
||||||
|
pageFormat: pageFormatData,
|
||||||
|
printInfoPlist: plist,
|
||||||
|
capturedAt: Date())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Rehydrate a ticket into `printInfo`'s live PM objects. Order is
|
||||||
|
/// load-bearing: create → copy → session-validate → Cocoa update.
|
||||||
|
/// Cross-queue replay is refused (R3) — the destination's bound
|
||||||
|
/// queue is the session's current printer; a destination with no
|
||||||
|
/// bound printer accepts the ticket (the spooler always binds
|
||||||
|
/// first, so production replay is always guarded).
|
||||||
|
/// A page-format failure is warn-only — paper is re-derived
|
||||||
|
/// upstream by the spooler's S6/S7.
|
||||||
|
static func restore(
|
||||||
|
_ ticket: PrintTicket,
|
||||||
|
into printInfo: NSPrintInfo
|
||||||
|
) throws {
|
||||||
|
let bound = currentPrinterID(
|
||||||
|
session: session(printInfo),
|
||||||
|
fallback: ticket.queue)
|
||||||
|
guard ticket.queue == bound else {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"PrintTicket: refusing to replay a ticket captured "
|
||||||
|
+ "for '\(ticket.queue)' onto '\(bound)'")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
var srcSettings: PMPrintSettings?
|
||||||
|
let createStatus = PMPrintSettingsCreateWithDataRepresentation(
|
||||||
|
ticket.printSettings as CFData, &srcSettings)
|
||||||
|
defer {
|
||||||
|
if let srcSettings { PMRelease(object(srcSettings)) }
|
||||||
|
}
|
||||||
|
guard createStatus == noErr, let srcSettings else {
|
||||||
|
throw PMTicketError.restoreFailed(
|
||||||
|
stage: "printSettings", status: createStatus)
|
||||||
|
}
|
||||||
|
let copyStatus = PMCopyPrintSettings(
|
||||||
|
srcSettings, settings(printInfo))
|
||||||
|
guard copyStatus == noErr else {
|
||||||
|
throw PMTicketError.restoreFailed(
|
||||||
|
stage: "printSettings", status: copyStatus)
|
||||||
|
}
|
||||||
|
var changed = DarwinBoolean(false)
|
||||||
|
_ = PMSessionValidatePrintSettings(
|
||||||
|
session(printInfo), settings(printInfo), &changed)
|
||||||
|
if changed.boolValue {
|
||||||
|
AppLogger.shared.info(
|
||||||
|
"PrintTicket: driver adjusted the restored ticket")
|
||||||
|
}
|
||||||
|
printInfo.updateFromPMPrintSettings()
|
||||||
|
|
||||||
|
// Page format — warn-only.
|
||||||
|
var srcFormat: PMPageFormat?
|
||||||
|
let formatStatus = PMPageFormatCreateWithDataRepresentation(
|
||||||
|
ticket.pageFormat as CFData, &srcFormat)
|
||||||
|
defer {
|
||||||
|
if let srcFormat { PMRelease(object(srcFormat)) }
|
||||||
|
}
|
||||||
|
guard formatStatus == noErr, let srcFormat else {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"PrintTicket: page format restore failed "
|
||||||
|
+ "(\(formatStatus)) — paper re-derived upstream")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
guard PMCopyPageFormat(srcFormat, pageFormat(printInfo)) == noErr
|
||||||
|
else {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"PrintTicket: page format copy failed — "
|
||||||
|
+ "paper re-derived upstream")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var formatChanged = DarwinBoolean(false)
|
||||||
|
_ = PMSessionValidatePageFormat(
|
||||||
|
session(printInfo), pageFormat(printInfo), &formatChanged)
|
||||||
|
printInfo.updateFromPMPageFormat()
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Recursive plist-safety filter for `NSPrintInfo.dictionary()`:
|
||||||
|
/// keeps String / NSNumber / Bool / Date / Data / URL (→
|
||||||
|
/// absoluteString) / Array / Dictionary, drops everything else, so
|
||||||
|
/// one non-plist attribute cannot fail the whole snapshot.
|
||||||
|
private static func plistSafe(_ value: Any) -> Any? {
|
||||||
|
switch value {
|
||||||
|
case let string as String:
|
||||||
|
return string
|
||||||
|
case let number as NSNumber:
|
||||||
|
return number
|
||||||
|
case let date as Date:
|
||||||
|
return date
|
||||||
|
case let data as Data:
|
||||||
|
return data
|
||||||
|
case let url as URL:
|
||||||
|
return url.absoluteString
|
||||||
|
case let array as [Any]:
|
||||||
|
return array.compactMap(plistSafe)
|
||||||
|
case let dictionary as [String: Any]:
|
||||||
|
var safe: [String: Any] = [:]
|
||||||
|
for (key, element) in dictionary {
|
||||||
|
if let filtered = plistSafe(element) {
|
||||||
|
safe[key] = filtered
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return safe
|
||||||
|
case let dictionary as [NSPrintInfo.AttributeKey: Any]:
|
||||||
|
var safe: [String: Any] = [:]
|
||||||
|
for (key, element) in dictionary {
|
||||||
|
if let filtered = plistSafe(element) {
|
||||||
|
safe[key.rawValue] = filtered
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return safe
|
||||||
|
default:
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: Values
|
||||||
|
|
||||||
|
/// Warn-only `PMPrintSettingsSetValue`: a driver that rejects a key
|
||||||
|
/// must not abort the caller's flow. Returns `true` on success.
|
||||||
|
@discardableResult
|
||||||
|
static func setValue(
|
||||||
|
_ value: String,
|
||||||
|
forKey key: String,
|
||||||
|
locked: Bool,
|
||||||
|
in settings: PMPrintSettings,
|
||||||
|
context: String
|
||||||
|
) -> Bool {
|
||||||
|
let status = PMPrintSettingsSetValue(
|
||||||
|
settings, key as CFString, value as CFString, locked)
|
||||||
|
if status != 0 {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"\(context): PMPrintSettingsSetValue(\(key)) "
|
||||||
|
+ "rejected (\(status))")
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `PMPrintSettingsGetValue` — borrowed value, never released.
|
||||||
|
/// `nil` for absent keys, non-string values, or lookup errors.
|
||||||
|
static func stringValue(
|
||||||
|
forKey key: String,
|
||||||
|
in settings: PMPrintSettings
|
||||||
|
) -> String? {
|
||||||
|
var value: Unmanaged<CFTypeRef>?
|
||||||
|
guard PMPrintSettingsGetValue(
|
||||||
|
settings, key as CFString, &value) == 0,
|
||||||
|
let ref = value?.takeUnretainedValue()
|
||||||
|
else { return nil }
|
||||||
|
return ref as? String
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: Paper
|
||||||
|
|
||||||
|
/// The `PMPageFormat` half of paper preselect (#186 E1): the
|
||||||
|
/// panel's paper dropdown reflects the page format's `PMPaper`,
|
||||||
|
/// not `PMPrintSettings`. Match the Stage 2 `PageSize` token to a
|
||||||
|
/// paper from `PMPrinterGetPaperList`, rebuild the page format
|
||||||
|
/// around it, and copy it into the printInfo's format (TN2248:
|
||||||
|
/// `PMCreatePageFormatWithPMPaper` → `PMSessionValidatePageFormat`
|
||||||
|
/// → `PMCopyPageFormat` → `updateFromPMPageFormat`).
|
||||||
|
/// `Custom.<w>x<h>` tokens (already points) have no `PMPaper` —
|
||||||
|
/// set the Cocoa `paperSize` directly. Warn-only throughout: a
|
||||||
|
/// missed match must not keep the panel from opening.
|
||||||
|
static func applyPaper(
|
||||||
|
token: String,
|
||||||
|
printer: PMPrinter,
|
||||||
|
session: PMPrintSession,
|
||||||
|
printInfo: NSPrintInfo
|
||||||
|
) {
|
||||||
|
if let custom = customPaperDimensions(from: token) {
|
||||||
|
printInfo.paperSize = NSSize(
|
||||||
|
width: custom.width, height: custom.height)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var paperList: Unmanaged<CFArray>?
|
||||||
|
guard PMPrinterGetPaperList(printer, &paperList) == 0,
|
||||||
|
let papers = paperList?.takeUnretainedValue()
|
||||||
|
else {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"Print panel: PMPrinterGetPaperList failed — "
|
||||||
|
+ "paper preselect skipped")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
// The list (and its elements) is owned by the printer —
|
||||||
|
// borrowed, never released.
|
||||||
|
var match: PMPaper?
|
||||||
|
for index in 0..<CFArrayGetCount(papers) {
|
||||||
|
let paper = unsafeBitCast(
|
||||||
|
CFArrayGetValueAtIndex(papers, index), to: PMPaper.self)
|
||||||
|
var idRef: Unmanaged<CFString>?
|
||||||
|
guard PMPaperGetID(paper, &idRef) == 0,
|
||||||
|
let paperID = idRef?.takeUnretainedValue() as String?
|
||||||
|
else { continue }
|
||||||
|
if paperID == token {
|
||||||
|
match = paper
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
guard let paper = match else {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"Print panel: no PMPaper id matches '\(token)'")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
var created: PMPageFormat?
|
||||||
|
guard PMCreatePageFormatWithPMPaper(&created, paper) == 0,
|
||||||
|
let newFormat = created
|
||||||
|
else {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"Print panel: PMCreatePageFormatWithPMPaper failed "
|
||||||
|
+ "for '\(token)'")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer { PMRelease(object(newFormat)) }
|
||||||
|
_ = PMSessionValidatePageFormat(session, newFormat, nil)
|
||||||
|
_ = PMCopyPageFormat(newFormat, pageFormat(printInfo))
|
||||||
|
printInfo.updateFromPMPageFormat()
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `Custom.<w>x<h>` → dimensions in points (the token builder
|
||||||
|
/// emits integer points, mm × 72/25.4). `nil` for non-custom or
|
||||||
|
/// malformed tokens — a malformed `Custom.*` then misses the
|
||||||
|
/// `PMPaper` match and logs instead of guessing a size.
|
||||||
|
static func customPaperDimensions(
|
||||||
|
from token: String
|
||||||
|
) -> (width: Double, height: Double)? {
|
||||||
|
guard token.hasPrefix("Custom.") else { return nil }
|
||||||
|
let dims = token.dropFirst("Custom.".count).split(separator: "x")
|
||||||
|
guard dims.count == 2,
|
||||||
|
let width = Double(dims[0]), let height = Double(dims[1]),
|
||||||
|
width > 0, height > 0
|
||||||
|
else { return nil }
|
||||||
|
return (width, height)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -4,13 +4,10 @@ import ICCeryCore
|
|||||||
|
|
||||||
/// Errors raised while preparing the bound print panel.
|
/// Errors raised while preparing the bound print panel.
|
||||||
enum PrintPanelError: LocalizedError {
|
enum PrintPanelError: LocalizedError {
|
||||||
case sessionBindingFailed(OSStatus)
|
|
||||||
case noPrinterFound(String)
|
case noPrinterFound(String)
|
||||||
|
|
||||||
var errorDescription: String? {
|
var errorDescription: String? {
|
||||||
switch self {
|
switch self {
|
||||||
case .sessionBindingFailed(let status):
|
|
||||||
return "Could not bind the print session to the queue (OSStatus \(status))."
|
|
||||||
case .noPrinterFound(let name):
|
case .noPrinterFound(let name):
|
||||||
return "No printer found for '\(name)'."
|
return "No printer found for '\(name)'."
|
||||||
}
|
}
|
||||||
@@ -18,18 +15,21 @@ enum PrintPanelError: LocalizedError {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Stage 2 selections pre-applied to the bound print panel before it
|
/// Stage 2 selections pre-applied to the bound print panel before it
|
||||||
/// opens (#183). This phase consumes `paperSize` + `qualityKey`/
|
/// opens (#183/#186). Every write is warn-only — the panel still
|
||||||
/// `quality` only; `mediaType` and `orientation` preselect — and the
|
/// opens when a driver ignores a key.
|
||||||
/// `PMPageFormat`/`PMPaper` half of paper — are #186's scope.
|
|
||||||
struct PrintPanelInitialSelections {
|
struct PrintPanelInitialSelections {
|
||||||
/// CUPS `PageSize` token, e.g. `"A4"` / `"Custom.595x842"`.
|
/// CUPS `PageSize` token, e.g. `"A4"` / `"Custom.595x842"`. Written
|
||||||
|
/// to `PMPrintSettings` **and** `PMPageFormat` (#186 E1).
|
||||||
var paperSize: String?
|
var paperSize: String?
|
||||||
/// The queue's detected quality enumeration key, e.g. `EPIJ_Qual`.
|
/// The queue's detected quality enumeration key, e.g. `EPIJ_Qual`.
|
||||||
var qualityKey: String?
|
var qualityKey: String?
|
||||||
/// The selected quality token.
|
/// The selected quality token.
|
||||||
var quality: String?
|
var quality: String?
|
||||||
var mediaType: String? // #186 consumes
|
/// The selected media token — written to the queue's detected
|
||||||
var orientation: String? // #186 consumes
|
/// vendor key (`CNIJMediaType`/`EPIJ_Medi`/…) (#186).
|
||||||
|
var mediaType: String?
|
||||||
|
/// `"portrait"`/`"landscape"` → `orientation-requested` 3|4 (#186).
|
||||||
|
var orientation: String?
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Preferences → native `NSPrintPanel` bound to the selected CUPS
|
/// Preferences → native `NSPrintPanel` bound to the selected CUPS
|
||||||
@@ -59,10 +59,12 @@ struct PrintPanelService {
|
|||||||
cupsService: CupsService,
|
cupsService: CupsService,
|
||||||
initialSelections: PrintPanelInitialSelections =
|
initialSelections: PrintPanelInitialSelections =
|
||||||
PrintPanelInitialSelections()
|
PrintPanelInitialSelections()
|
||||||
) async throws -> PrintPropertiesResult? {
|
) async throws -> PanelCaptureResult? {
|
||||||
#if DEBUG
|
#if DEBUG
|
||||||
if UITestHooks.printPanelStubbed {
|
if UITestHooks.printPanelStubbed {
|
||||||
return UITestHooks.printPanelResult(forQueue: queue)
|
return UITestHooks.printPanelResult(forQueue: queue).map {
|
||||||
|
PanelCaptureResult(properties: $0, ticket: nil)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
// `??` rhs is a non-async @autoclosure — fetch first.
|
// `??` rhs is a non-async @autoclosure — fetch first.
|
||||||
@@ -84,36 +86,43 @@ struct PrintPanelService {
|
|||||||
displayName: String?,
|
displayName: String?,
|
||||||
optionKeys: Set<String>,
|
optionKeys: Set<String>,
|
||||||
initialSelections: PrintPanelInitialSelections
|
initialSelections: PrintPanelInitialSelections
|
||||||
) throws -> PrintPropertiesResult? {
|
) throws -> PanelCaptureResult? {
|
||||||
let printInfo = NSPrintInfo()
|
let printInfo = NSPrintInfo()
|
||||||
var pmPrinter: PMPrinter?
|
var pmPrinter: PMPrinter?
|
||||||
var boundViaPM = false
|
var boundViaPM = false
|
||||||
|
|
||||||
// ① Bind the session to the selected CUPS queue (docs/11).
|
// ① Bind the session to the selected CUPS queue (docs/11).
|
||||||
if let printer = PMPrinterCreateFromPrinterID(queue as CFString) {
|
if let printer = PMTicketBridge.makePrinter(queue: queue) {
|
||||||
pmPrinter = printer
|
pmPrinter = printer
|
||||||
let session = unsafeBitCast(
|
let session = PMTicketBridge.session(printInfo)
|
||||||
printInfo.pmPrintSession(), to: PMPrintSession.self)
|
let settings = PMTicketBridge.settings(printInfo)
|
||||||
let settings = unsafeBitCast(
|
|
||||||
printInfo.pmPrintSettings(), to: PMPrintSettings.self)
|
|
||||||
let pageFormat = unsafeBitCast(
|
|
||||||
printInfo.pmPageFormat(), to: PMPageFormat.self)
|
|
||||||
|
|
||||||
let status = PMSessionSetCurrentPMPrinter(session, printer)
|
do {
|
||||||
if status != 0 {
|
try PMTicketBridge.bind(printer: printer, to: printInfo)
|
||||||
PMRelease(Self.pmObject(printer))
|
} catch {
|
||||||
throw PrintPanelError.sessionBindingFailed(status)
|
PMTicketBridge.release(printer)
|
||||||
|
throw error
|
||||||
}
|
}
|
||||||
// Warn-only: defaults keep the panel consistent with the
|
|
||||||
// queue but are not fatal when they fail.
|
|
||||||
_ = PMSessionDefaultPrintSettings(session, settings)
|
|
||||||
_ = PMSessionDefaultPageFormat(session, pageFormat)
|
|
||||||
// Initial selections — after `PMSessionDefault*`, before
|
// Initial selections — after `PMSessionDefault*`, before
|
||||||
// ColorSync suppression ②–⑤ (locked write order, #183).
|
// ColorSync suppression ②–⑤ (locked write order,
|
||||||
applyInitialSelections(initialSelections, to: settings)
|
// #183/#186). Paper is TWO writes (E1): the `PageSize`
|
||||||
|
// print-settings value drivers/capture read AND the
|
||||||
|
// `PMPageFormat` paper the panel's dropdown reflects.
|
||||||
|
applyInitialSelections(
|
||||||
|
initialSelections, to: settings, optionKeys: optionKeys)
|
||||||
|
if let paperToken = initialSelections.paperSize {
|
||||||
|
PMTicketBridge.applyPaper(
|
||||||
|
token: paperToken, printer: printer,
|
||||||
|
session: session, printInfo: printInfo)
|
||||||
|
}
|
||||||
boundViaPM = true
|
boundViaPM = true
|
||||||
} else {
|
} else {
|
||||||
// Fallback: NSPrinter by display name (docs/11 §binding).
|
// Fallback: NSPrinter by display name (docs/11 §binding).
|
||||||
|
// Warn — the display name can resolve a *different* queue
|
||||||
|
// (#186 E2: diagnosable, not a proven defect).
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"Print panel: PM binding unavailable for '\(queue)' — "
|
||||||
|
+ "falling back to NSPrinter(displayName)")
|
||||||
guard let displayName,
|
guard let displayName,
|
||||||
let nsPrinter = NSPrinter(name: displayName)
|
let nsPrinter = NSPrinter(name: displayName)
|
||||||
else {
|
else {
|
||||||
@@ -125,21 +134,20 @@ struct PrintPanelService {
|
|||||||
}
|
}
|
||||||
defer {
|
defer {
|
||||||
if let printer = pmPrinter {
|
if let printer = pmPrinter {
|
||||||
PMRelease(Self.pmObject(printer))
|
PMTicketBridge.release(printer)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// ②–⑤ ColourSync suppression — only on the PM path: the SPI
|
// ②–⑤ ColourSync suppression — only on the PM path: the SPI
|
||||||
// and PMPrintSettingsSetValue need a session with a current
|
// and PMPrintSettingsSetValue need a session with a current
|
||||||
// printer to attach to.
|
// printer to attach to.
|
||||||
var settings = unsafeBitCast(
|
var settings = PMTicketBridge.settings(printInfo)
|
||||||
printInfo.pmPrintSettings(), to: PMPrintSettings.self)
|
|
||||||
var driverBypass: (key: String, value: String)?
|
var driverBypass: (key: String, value: String)?
|
||||||
if boundViaPM {
|
if boundViaPM {
|
||||||
let session = unsafeBitCast(
|
let session = PMTicketBridge.session(printInfo)
|
||||||
printInfo.pmPrintSession(), to: PMPrintSession.self)
|
|
||||||
suppressor.applySPIMode(to: session) // ②
|
suppressor.applySPIMode(to: session) // ②
|
||||||
suppressor.applyLockedKeys(to: settings) // ③
|
suppressor.applyLockedKeys(to: settings) // ③
|
||||||
|
suppressor.applyQuartzMode(to: settings) // ⑤′-a (D2)
|
||||||
driverBypass = suppressor.applyDriverBypass( // ④
|
driverBypass = suppressor.applyDriverBypass( // ④
|
||||||
to: settings, optionKeys: optionKeys)
|
to: settings, optionKeys: optionKeys)
|
||||||
suppressor.mirror(into: printInfo, driverBypass: driverBypass) // ⑤
|
suppressor.mirror(into: printInfo, driverBypass: driverBypass) // ⑤
|
||||||
@@ -166,70 +174,73 @@ struct PrintPanelService {
|
|||||||
var cupsOptions: String?
|
var cupsOptions: String?
|
||||||
var mediaType: String?
|
var mediaType: String?
|
||||||
if boundViaPM {
|
if boundViaPM {
|
||||||
settings = unsafeBitCast(
|
settings = PMTicketBridge.settings(printInfo)
|
||||||
printInfo.pmPrintSettings(), to: PMPrintSettings.self)
|
|
||||||
let captured = suppressor.captureOptions(from: settings)
|
let captured = suppressor.captureOptions(from: settings)
|
||||||
cupsOptions = captured.cupsOptions
|
cupsOptions = captured.cupsOptions
|
||||||
mediaType = captured.mediaType
|
mediaType = captured.mediaType
|
||||||
}
|
}
|
||||||
let capturedOptions = cupsOptions ?? ""
|
let capturedOptions = cupsOptions ?? ""
|
||||||
return PrintPropertiesResult(
|
let resolvedQueue = boundViaPM
|
||||||
selectedPrinter: boundViaPM
|
? PMTicketBridge.currentPrinterID(
|
||||||
? Self.currentPrinterID(
|
session: PMTicketBridge.session(printInfo),
|
||||||
session: unsafeBitCast(
|
fallback: queue)
|
||||||
printInfo.pmPrintSession(), to: PMPrintSession.self),
|
: queue
|
||||||
fallback: queue)
|
// ⑦ Serialise the native ticket — the payload `lp -o` could
|
||||||
: nil,
|
// never carry (#201). Warn-only via `try?`: a serialise
|
||||||
options: PrintOptions(
|
// failure must not lose the Stage 2 mirror above.
|
||||||
orientation: CupsParsers.extractOrientation(
|
let ticket = try? PMTicketBridge.serialise(
|
||||||
fromOptionsString: capturedOptions),
|
printInfo, queue: resolvedQueue)
|
||||||
paperSize: CupsParsers.extractOption(
|
return PanelCaptureResult(
|
||||||
named: "PageSize", fromOptionsString: capturedOptions),
|
properties: PrintPropertiesResult(
|
||||||
mediaType: mediaType,
|
selectedPrinter: boundViaPM ? resolvedQueue : nil,
|
||||||
quality: CupsParsers.extractQuality(
|
options: PrintOptions(
|
||||||
fromOptionsString: capturedOptions),
|
orientation: CupsParsers.extractOrientation(
|
||||||
ppdUncorrectedPassthrough: true,
|
fromOptionsString: capturedOptions),
|
||||||
cupsOptions: cupsOptions))
|
paperSize: CupsParsers.extractOption(
|
||||||
|
named: "PageSize",
|
||||||
|
fromOptionsString: capturedOptions),
|
||||||
|
mediaType: mediaType,
|
||||||
|
quality: CupsParsers.extractQuality(
|
||||||
|
fromOptionsString: capturedOptions),
|
||||||
|
ppdUncorrectedPassthrough: true,
|
||||||
|
cupsOptions: cupsOptions)),
|
||||||
|
ticket: ticket)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Initial-selection `PMPrintSettings` writes — paper size and
|
/// Initial-selection `PMPrintSettings` writes — paper, quality,
|
||||||
/// quality only this phase; media type / orientation and the
|
/// media type, orientation. All warn-only: a driver that ignores
|
||||||
/// `PMPageFormat`/`PMPaper` paper half are #186's contract.
|
/// a key must not keep the panel from opening (R12 surfaces via
|
||||||
|
/// the capture echo instead).
|
||||||
private func applyInitialSelections(
|
private func applyInitialSelections(
|
||||||
_ selections: PrintPanelInitialSelections,
|
_ selections: PrintPanelInitialSelections,
|
||||||
to settings: PMPrintSettings
|
to settings: PMPrintSettings,
|
||||||
|
optionKeys: Set<String>
|
||||||
) {
|
) {
|
||||||
if let paperSize = selections.paperSize {
|
if let paperSize = selections.paperSize {
|
||||||
_ = PMPrintSettingsSetValue(
|
PMTicketBridge.setValue(
|
||||||
settings, "PageSize" as CFString,
|
paperSize, forKey: "PageSize", locked: false,
|
||||||
paperSize as CFString, false)
|
in: settings, context: "Print panel")
|
||||||
}
|
}
|
||||||
if let key = selections.qualityKey, let value = selections.quality {
|
if let key = selections.qualityKey, let value = selections.quality {
|
||||||
_ = PMPrintSettingsSetValue(
|
PMTicketBridge.setValue(
|
||||||
settings, key as CFString, value as CFString, false)
|
value, forKey: key, locked: false,
|
||||||
|
in: settings, context: "Print panel")
|
||||||
|
}
|
||||||
|
// Media type via the queue's detected vendor key (#186).
|
||||||
|
if let mediaType = selections.mediaType,
|
||||||
|
let mediaKey = CupsParsers.detectMediaTypeKey(
|
||||||
|
optionKeys: optionKeys) {
|
||||||
|
PMTicketBridge.setValue(
|
||||||
|
mediaType, forKey: mediaKey, locked: false,
|
||||||
|
in: settings, context: "Print panel")
|
||||||
|
}
|
||||||
|
// Orientation — portrait=3, landscape=4 (CUPS IPP codes).
|
||||||
|
if let orientation = selections.orientation {
|
||||||
|
let code = orientation == "landscape" ? "4" : "3"
|
||||||
|
PMTicketBridge.setValue(
|
||||||
|
code, forKey: "orientation-requested", locked: false,
|
||||||
|
in: settings, context: "Print panel")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// MARK: - PM helpers
|
|
||||||
|
|
||||||
/// `PMPrinter` → `PMObject` for `PMRelease` — the Carbon API wants
|
|
||||||
/// `UnsafeRawPointer`, Swift imports `PMPrinter` as `OpaquePointer`.
|
|
||||||
static func pmObject(_ printer: PMPrinter) -> PMObject {
|
|
||||||
unsafeBitCast(printer, to: PMObject.self)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// `PMSessionGetCurrentPrinter` → `PMPrinterGetID` → String.
|
|
||||||
private static func currentPrinterID(
|
|
||||||
session: PMPrintSession,
|
|
||||||
fallback: String
|
|
||||||
) -> String {
|
|
||||||
var current: PMPrinter?
|
|
||||||
guard PMSessionGetCurrentPrinter(session, ¤t) == 0,
|
|
||||||
let printer = current
|
|
||||||
else { return fallback }
|
|
||||||
defer { PMRelease(pmObject(printer)) }
|
|
||||||
guard let id = PMPrinterGetID(printer)
|
|
||||||
else { return fallback }
|
|
||||||
return id.takeUnretainedValue() as String
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,7 +2,8 @@ import Combine
|
|||||||
import Foundation
|
import Foundation
|
||||||
import ICCeryCore
|
import ICCeryCore
|
||||||
|
|
||||||
/// CUPS queue selection, bound print panel, and `lp` spool (issues 12–15, 17 / #85).
|
/// CUPS queue selection, bound print panel, and native headless spool
|
||||||
|
/// (issues 12–15, 17 / #85, #201).
|
||||||
@MainActor
|
@MainActor
|
||||||
final class PrintSessionViewModel: ObservableObject {
|
final class PrintSessionViewModel: ObservableObject {
|
||||||
let wizard: WizardViewModel
|
let wizard: WizardViewModel
|
||||||
@@ -13,7 +14,15 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
weak var workflow: TargetWorkflowViewModel?
|
weak var workflow: TargetWorkflowViewModel?
|
||||||
|
|
||||||
@Published var printers: [Printer] = []
|
@Published var printers: [Printer] = []
|
||||||
@Published var selectedPrinter = ""
|
@Published var selectedPrinter = "" {
|
||||||
|
didSet {
|
||||||
|
// Tickets are queue- and driver-version-specific — a stale
|
||||||
|
// ticket must never replay onto a re-selected queue (R3).
|
||||||
|
if selectedPrinter != oldValue {
|
||||||
|
capturedTickets[oldValue] = nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@Published var printerCaps = PrinterCapabilities()
|
@Published var printerCaps = PrinterCapabilities()
|
||||||
@Published var selectedTray: Int?
|
@Published var selectedTray: Int?
|
||||||
@Published var selectedMediaType: String?
|
@Published var selectedMediaType: String?
|
||||||
@@ -23,13 +32,44 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
@Published var selectedQuality: String?
|
@Published var selectedQuality: String?
|
||||||
@Published var printOrientation = "portrait"
|
@Published var printOrientation = "portrait"
|
||||||
@Published var capturedCupsOptions: [String: String] = [:]
|
@Published var capturedCupsOptions: [String: String] = [:]
|
||||||
|
/// Native print tickets per queue — the spool payload (#201).
|
||||||
|
/// Session-only; cleared whenever the queue's mirror is.
|
||||||
|
@Published var capturedTickets: [String: PrintTicket] = [:]
|
||||||
@Published var printNotice: Notice?
|
@Published var printNotice: Notice?
|
||||||
@Published var isPrinting = false
|
@Published var isPrinting = false
|
||||||
|
/// Session-only job granularity (#201 D5): off → one job per page
|
||||||
|
/// (per-page notices + error attribution); on → a single job.
|
||||||
|
@Published var singleJobForAllPages = false
|
||||||
|
/// The spool backend — the `ICCERY_TEST_SPOOL_LOG` recording seam
|
||||||
|
/// under UI testing, `NSPrintOperation` otherwise (#201 D8).
|
||||||
|
/// `internal` so unit tests inject.
|
||||||
|
var spooler: TargetSpooling
|
||||||
private var printTask: Task<Void, Never>?
|
private var printTask: Task<Void, Never>?
|
||||||
|
|
||||||
init(wizard: WizardViewModel, environment: AppEnvironment) {
|
init(wizard: WizardViewModel, environment: AppEnvironment) {
|
||||||
self.wizard = wizard
|
self.wizard = wizard
|
||||||
self.environment = environment
|
self.environment = environment
|
||||||
|
#if DEBUG
|
||||||
|
if UITestHooks.isEnabled, let logURL = UITestHooks.spoolLogURL {
|
||||||
|
spooler = RecordingTargetSpooler(logURL: logURL)
|
||||||
|
} else {
|
||||||
|
spooler = NativeTargetSpooler()
|
||||||
|
}
|
||||||
|
#else
|
||||||
|
spooler = NativeTargetSpooler()
|
||||||
|
#endif
|
||||||
|
attachDiagnostics()
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Warn-only spooler diagnostics (manifest drift, oversize page)
|
||||||
|
/// surface as the in-panel notice. Re-attached per request so an
|
||||||
|
/// injected spooler picks it up too — and so `spooler` needs no
|
||||||
|
/// `didSet` (mutating `diagnostics` through the existential would
|
||||||
|
/// re-fire the observer and recurse).
|
||||||
|
private func attachDiagnostics() {
|
||||||
|
spooler.diagnostics = { [weak self] notice in
|
||||||
|
self?.printNotice = notice
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private var printerEnumTask: Task<[Printer]?, Never>?
|
private var printerEnumTask: Task<[Printer]?, Never>?
|
||||||
@@ -131,7 +171,8 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
|
|
||||||
/// The CUPS `PageSize` token for the current Stage 2 pick — live
|
/// The CUPS `PageSize` token for the current Stage 2 pick — live
|
||||||
/// `Custom.<pt>x<pt>` for the synthetic entry, else the capability
|
/// `Custom.<pt>x<pt>` for the synthetic entry, else the capability
|
||||||
/// name. This is what `lp -o PageSize=` sees.
|
/// name. Resolved into the `PageSize` ticket write and the
|
||||||
|
/// `PMPaper` match on the native spool path (#201).
|
||||||
var selectedPaperSizeToken: String? {
|
var selectedPaperSizeToken: String? {
|
||||||
guard let id = selectedPaperSize else { return nil }
|
guard let id = selectedPaperSize else { return nil }
|
||||||
if id == 0 { return customPaperToken() }
|
if id == 0 { return customPaperToken() }
|
||||||
@@ -147,8 +188,8 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
paperSize: selectedPaperSizeToken,
|
paperSize: selectedPaperSizeToken,
|
||||||
qualityKey: printerCaps.qualityKey,
|
qualityKey: printerCaps.qualityKey,
|
||||||
quality: selectedQuality,
|
quality: selectedQuality,
|
||||||
mediaType: nil,
|
mediaType: selectedMediaType,
|
||||||
orientation: nil)
|
orientation: printOrientation)
|
||||||
Task { @MainActor in
|
Task { @MainActor in
|
||||||
do {
|
do {
|
||||||
guard let result = try await PrintPanelService()
|
guard let result = try await PrintPanelService()
|
||||||
@@ -164,29 +205,37 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
)
|
)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if let selected = result.selectedPrinter,
|
if let selected = result.properties.selectedPrinter,
|
||||||
printers.contains(where: { $0.name == selected }),
|
printers.contains(where: { $0.name == selected }),
|
||||||
selected != queue {
|
selected != queue {
|
||||||
selectedPrinter = selected
|
selectedPrinter = selected
|
||||||
await reloadSelectedCapabilities()
|
await reloadSelectedCapabilities()
|
||||||
}
|
}
|
||||||
if let captured = result.options.cupsOptions {
|
if let captured = result.properties.options.cupsOptions {
|
||||||
capturedCupsOptions[selectedPrinter] = captured
|
capturedCupsOptions[selectedPrinter] = captured
|
||||||
}
|
}
|
||||||
if let media = result.options.mediaType {
|
// The native ticket rides alongside the mirror (#201).
|
||||||
|
if let ticket = result.ticket {
|
||||||
|
capturedTickets[ticket.queue] = ticket
|
||||||
|
}
|
||||||
|
if let media = result.properties.options.mediaType {
|
||||||
selectedMediaType = media
|
selectedMediaType = media
|
||||||
}
|
}
|
||||||
// Capture-return (#183): a dialog paper/quality change
|
// Capture-return (#183/#186): a dialog paper/quality/
|
||||||
// updates the Stage 2 selections — never
|
// orientation change updates the Stage 2 selections —
|
||||||
// `workflow.pageSize` (printtarg layout is sacred).
|
// never `workflow.pageSize` (printtarg layout is
|
||||||
if let paper = result.options.paperSize,
|
// sacred).
|
||||||
|
if let paper = result.properties.options.paperSize,
|
||||||
let match = printerCaps.paperSizes
|
let match = printerCaps.paperSizes
|
||||||
.first(where: { $0.name == paper }) {
|
.first(where: { $0.name == paper }) {
|
||||||
selectedPaperSize = match.id
|
selectedPaperSize = match.id
|
||||||
}
|
}
|
||||||
if let quality = result.options.quality {
|
if let quality = result.properties.options.quality {
|
||||||
selectedQuality = quality
|
selectedQuality = quality
|
||||||
}
|
}
|
||||||
|
if let orientation = result.properties.options.orientation {
|
||||||
|
printOrientation = orientation
|
||||||
|
}
|
||||||
printNotice = Notice(
|
printNotice = Notice(
|
||||||
kind: .info,
|
kind: .info,
|
||||||
text: "Settings captured for \(selectedPrinter).",
|
text: "Settings captured for \(selectedPrinter).",
|
||||||
@@ -205,10 +254,31 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
guard let self else { return }
|
guard let self else { return }
|
||||||
// `defer` cannot mutate isolated state under Swift 5.7
|
// `defer` cannot mutate isolated state under Swift 5.7
|
||||||
// (Xcode 14.2 / macOS 12 runner), so clear explicitly (#113).
|
// (Xcode 14.2 / macOS 12 runner), so clear explicitly (#113).
|
||||||
|
if singleJobForAllPages {
|
||||||
|
// D5 — one job carries every page; a failure names the
|
||||||
|
// job, not a page (R14).
|
||||||
|
do {
|
||||||
|
try await spoolAll(result)
|
||||||
|
printNotice = Notice(
|
||||||
|
kind: .info,
|
||||||
|
text: "Sent \(result.pages.count) page(s) in "
|
||||||
|
+ "one job to \(selectedPrinter).",
|
||||||
|
autoHideAfter: nil
|
||||||
|
)
|
||||||
|
} catch {
|
||||||
|
printNotice = Notice(
|
||||||
|
kind: .error,
|
||||||
|
text: "Print failed: \(error.localizedDescription)"
|
||||||
|
)
|
||||||
|
}
|
||||||
|
isPrinting = false
|
||||||
|
self.printTask = nil
|
||||||
|
return
|
||||||
|
}
|
||||||
var printed = 0
|
var printed = 0
|
||||||
for page in result.pages {
|
for page in result.pages {
|
||||||
do {
|
do {
|
||||||
try await spool(page, index: page.index)
|
try await spool(page)
|
||||||
printed += 1
|
printed += 1
|
||||||
} catch {
|
} catch {
|
||||||
printNotice = Notice(
|
printNotice = Notice(
|
||||||
@@ -238,7 +308,7 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
let task = Task { @MainActor [weak self] in
|
let task = Task { @MainActor [weak self] in
|
||||||
guard let self else { return }
|
guard let self else { return }
|
||||||
do {
|
do {
|
||||||
try await spool(page, index: page.index)
|
try await spool(page)
|
||||||
printNotice = Notice(
|
printNotice = Notice(
|
||||||
kind: .info,
|
kind: .info,
|
||||||
text: "Sent \(page.page.filename) to \(selectedPrinter).",
|
text: "Sent \(page.page.filename) to \(selectedPrinter).",
|
||||||
@@ -256,25 +326,55 @@ final class PrintSessionViewModel: ObservableObject {
|
|||||||
printTask = task
|
printTask = task
|
||||||
}
|
}
|
||||||
|
|
||||||
private func spool(_ page: GalleryPage, index: Int) async throws {
|
private func spool(_ page: GalleryPage) async throws {
|
||||||
|
let request = try await makeRequest(
|
||||||
|
pages: [page], title: page.page.filename)
|
||||||
|
try spooler.spool(request)
|
||||||
|
wizard.printerName = selectedPrinter
|
||||||
|
}
|
||||||
|
|
||||||
|
private func spoolAll(_ result: PrinttargResult) async throws {
|
||||||
|
let request = try await makeRequest(
|
||||||
|
pages: result.pages,
|
||||||
|
title: result.ti2URL.deletingPathExtension()
|
||||||
|
.lastPathComponent)
|
||||||
|
try spooler.spool(request)
|
||||||
|
wizard.printerName = selectedPrinter
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Assemble the deterministic spool request: the captured ticket
|
||||||
|
/// (when the panel produced one) plus the Stage 2 overrides and
|
||||||
|
/// the queue's option-key roster for vendor-key detection (#201).
|
||||||
|
/// The Stage 2 paper token feeds the `PageSize` write;
|
||||||
|
/// `workflow.pageSize` remains the printtarg layout input only
|
||||||
|
/// (#183).
|
||||||
|
private func makeRequest(
|
||||||
|
pages: [GalleryPage], title: String
|
||||||
|
) async throws -> TargetPrintRequest {
|
||||||
guard !selectedPrinter.isEmpty else {
|
guard !selectedPrinter.isEmpty else {
|
||||||
throw CupsError.noPrinterSelected
|
throw CupsError.noPrinterSelected
|
||||||
}
|
}
|
||||||
// The Stage 2 paper token is what `lp -o PageSize=` sees;
|
let queue = selectedPrinter
|
||||||
// `workflow.pageSize` remains the printtarg layout input only
|
let optionKeys = (try? await environment.cupsService
|
||||||
// (#183).
|
.optionKeys(for: queue)) ?? []
|
||||||
let options = PrintOptions(
|
attachDiagnostics()
|
||||||
orientation: printOrientation,
|
return TargetPrintRequest(
|
||||||
paperSize: selectedPaperSizeToken,
|
queue: queue,
|
||||||
mediaType: selectedMediaType,
|
displayName: printers.first { $0.name == queue }?.displayName,
|
||||||
quality: selectedQuality,
|
pages: pages.map {
|
||||||
ppdUncorrectedPassthrough: true,
|
TargetPrintPage(
|
||||||
cupsOptions: capturedCupsOptions[selectedPrinter])
|
url: $0.fileURL,
|
||||||
try await environment.cupsService.printTarget(
|
expectedWidthMm: $0.page.widthMm,
|
||||||
queue: selectedPrinter,
|
expectedHeightMm: $0.page.heightMm)
|
||||||
tiffPath: page.fileURL.path,
|
},
|
||||||
options: options,
|
jobTitle: "ICCery Target - \(title)",
|
||||||
page: index)
|
ticket: capturedTickets[queue],
|
||||||
wizard.printerName = selectedPrinter
|
overrides: TargetPrintOverrides(
|
||||||
|
paperSize: selectedPaperSizeToken,
|
||||||
|
mediaType: selectedMediaType,
|
||||||
|
qualityKey: printerCaps.qualityKey,
|
||||||
|
quality: selectedQuality,
|
||||||
|
orientation: printOrientation),
|
||||||
|
optionKeys: optionKeys)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,30 @@
|
|||||||
|
import Foundation
|
||||||
|
import ICCeryCore
|
||||||
|
|
||||||
|
/// A captured native print ticket (#201) — the payload `lp -o` could
|
||||||
|
/// never carry. Vendor PDE state, including opaque binary blobs, is
|
||||||
|
/// preserved verbatim inside `printSettings`.
|
||||||
|
///
|
||||||
|
/// In-memory, session-only. Never written to `settings.json` or an
|
||||||
|
/// `.icceryproj` (a ticket is queue- and driver-version-specific).
|
||||||
|
struct PrintTicket: Equatable, Sendable {
|
||||||
|
/// CUPS queue id this ticket was captured for. Replay onto any other
|
||||||
|
/// queue is refused (R3).
|
||||||
|
let queue: String
|
||||||
|
/// `PMPrintSettingsCreateDataRepresentation(…, kPMDataFormatXMLDefault)`.
|
||||||
|
let printSettings: Data
|
||||||
|
/// `PMPageFormatCreateDataRepresentation(…, kPMDataFormatXMLDefault)`.
|
||||||
|
let pageFormat: Data
|
||||||
|
/// Binary-plist snapshot of `NSPrintInfo.dictionary()`, plist-filtered.
|
||||||
|
/// Cocoa-level fallback only — never the primary restore path.
|
||||||
|
let printInfoPlist: Data?
|
||||||
|
let capturedAt: Date
|
||||||
|
}
|
||||||
|
|
||||||
|
/// App-level panel outcome: the ICCeryCore `PrintPropertiesResult`
|
||||||
|
/// (Stage 2 mirror values, #183/#186) **plus** the native ticket the
|
||||||
|
/// spooler replays (#201).
|
||||||
|
struct PanelCaptureResult {
|
||||||
|
var properties: PrintPropertiesResult
|
||||||
|
var ticket: PrintTicket?
|
||||||
|
}
|
||||||
@@ -0,0 +1,86 @@
|
|||||||
|
import AppKit
|
||||||
|
|
||||||
|
/// Headless print canvas (#201, docs/14 §6). Never installed in a
|
||||||
|
/// window; `NSPrintOperation` is its only client.
|
||||||
|
@MainActor
|
||||||
|
final class TargetPageCanvasView: NSView {
|
||||||
|
|
||||||
|
private let pages: [TargetPageRaster]
|
||||||
|
private let paperSize: NSSize
|
||||||
|
|
||||||
|
/// Test probe — invoked once per drawn page with the live context
|
||||||
|
/// so the interpolation/antialias contract is assertable without a
|
||||||
|
/// printer.
|
||||||
|
var drawProbe: ((NSGraphicsContext, Int, NSRect) -> Void)?
|
||||||
|
|
||||||
|
init(pages: [TargetPageRaster], paperSize: NSSize) {
|
||||||
|
self.pages = pages
|
||||||
|
self.paperSize = paperSize
|
||||||
|
super.init(frame: NSRect(
|
||||||
|
x: 0, y: 0,
|
||||||
|
width: paperSize.width,
|
||||||
|
height: paperSize.height * CGFloat(pages.count)))
|
||||||
|
}
|
||||||
|
|
||||||
|
@available(*, unavailable)
|
||||||
|
required init?(coder: NSCoder) {
|
||||||
|
fatalError("TargetPageCanvasView is code-only")
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Flipped: the CoreGraphics coordinate space is correctly oriented
|
||||||
|
/// top-down, so page 1 is the TOP rect.
|
||||||
|
override var isFlipped: Bool { true }
|
||||||
|
override var isOpaque: Bool { true }
|
||||||
|
|
||||||
|
override func knowsPageRange(_ range: NSRangePointer) -> Bool {
|
||||||
|
range.pointee = NSRange(location: 1, length: pages.count)
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
/// 1-based page → its paper-sized rect, stacked top-down.
|
||||||
|
override func rectForPage(_ page: Int) -> NSRect {
|
||||||
|
NSRect(x: 0,
|
||||||
|
y: CGFloat(page - 1) * paperSize.height,
|
||||||
|
width: paperSize.width,
|
||||||
|
height: paperSize.height)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Where page `page`'s image lands: top-left anchored inside
|
||||||
|
/// `rectForPage`, sized `raster.pointSize`, origin snapped to
|
||||||
|
/// 0.001 pt (docs/14 §6) so a fractional origin cannot trigger
|
||||||
|
/// device resampling. `internal` for unit tests.
|
||||||
|
func destinationRect(forPage page: Int) -> NSRect {
|
||||||
|
let pageRect = rectForPage(page)
|
||||||
|
let size = pages[page - 1].pointSize
|
||||||
|
return NSRect(x: Self.snap(pageRect.minX),
|
||||||
|
y: Self.snap(pageRect.minY),
|
||||||
|
width: size.width,
|
||||||
|
height: size.height)
|
||||||
|
}
|
||||||
|
|
||||||
|
override func draw(_ dirtyRect: NSRect) {
|
||||||
|
guard let ctx = NSGraphicsContext.current else { return }
|
||||||
|
ctx.imageInterpolation = .none
|
||||||
|
ctx.shouldAntialias = false
|
||||||
|
let cg = ctx.cgContext
|
||||||
|
cg.interpolationQuality = .none
|
||||||
|
cg.setShouldAntialias(false)
|
||||||
|
cg.setAllowsAntialiasing(false)
|
||||||
|
cg.setShouldSmoothFonts(false)
|
||||||
|
for index in pages.indices {
|
||||||
|
let pageRect = rectForPage(index + 1)
|
||||||
|
guard pageRect.intersects(dirtyRect) else { continue }
|
||||||
|
cg.saveGState() // page N never inherits N-1's CTM
|
||||||
|
NSColor.white.setFill()
|
||||||
|
pageRect.fill()
|
||||||
|
cg.draw(pages[index].cgImage,
|
||||||
|
in: destinationRect(forPage: index + 1))
|
||||||
|
cg.restoreGState()
|
||||||
|
drawProbe?(ctx, index + 1, destinationRect(forPage: index + 1))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private static func snap(_ value: CGFloat) -> CGFloat {
|
||||||
|
(value * 1000).rounded() / 1000
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,221 @@
|
|||||||
|
import CoreGraphics
|
||||||
|
import Foundation
|
||||||
|
import ICCeryCore
|
||||||
|
import ImageIO
|
||||||
|
|
||||||
|
/// One decoded target page ready to draw 1:1 (#201, docs/14 §6).
|
||||||
|
struct TargetPageRaster: Equatable {
|
||||||
|
let sourceURL: URL
|
||||||
|
/// Re-tagged into a **device** colour space — the image Quartz draws.
|
||||||
|
let cgImage: CGImage
|
||||||
|
let pixelWidth: Int
|
||||||
|
let pixelHeight: Int
|
||||||
|
let dpiX: Double
|
||||||
|
let dpiY: Double
|
||||||
|
let componentCount: Int
|
||||||
|
let bitsPerComponent: Int
|
||||||
|
/// Expected physical size from the printtarg manifest, when known.
|
||||||
|
let expectedWidthMm: Double?
|
||||||
|
let expectedHeightMm: Double?
|
||||||
|
|
||||||
|
/// `pixels / dpi * 72`. The ONLY size the canvas ever draws at.
|
||||||
|
/// 72 pt = 1 in. **Never** `backingScaleFactor` (docs/14 §6).
|
||||||
|
var pointSize: CGSize {
|
||||||
|
CGSize(width: Double(pixelWidth) / dpiX * 72,
|
||||||
|
height: Double(pixelHeight) / dpiY * 72)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `pixels / dpi * 25.4` — the physical size the DPI implies.
|
||||||
|
var physicalMm: CGSize {
|
||||||
|
CGSize(width: Double(pixelWidth) / dpiX * 25.4,
|
||||||
|
height: Double(pixelHeight) / dpiY * 25.4)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `nil` when within 0.5 mm of the manifest, else the drift
|
||||||
|
/// message (D9 — warn + spool, never rescale).
|
||||||
|
var manifestDrift: String? {
|
||||||
|
var parts: [String] = []
|
||||||
|
if let expectedWidthMm,
|
||||||
|
abs(physicalMm.width - expectedWidthMm) > 0.5 {
|
||||||
|
parts.append(String(
|
||||||
|
format: "width %.2f mm vs manifest %.2f mm",
|
||||||
|
physicalMm.width, expectedWidthMm))
|
||||||
|
}
|
||||||
|
if let expectedHeightMm,
|
||||||
|
abs(physicalMm.height - expectedHeightMm) > 0.5 {
|
||||||
|
parts.append(String(
|
||||||
|
format: "height %.2f mm vs manifest %.2f mm",
|
||||||
|
physicalMm.height, expectedHeightMm))
|
||||||
|
}
|
||||||
|
guard !parts.isEmpty else { return nil }
|
||||||
|
return "TIFF DPI disagrees with the printtarg manifest — "
|
||||||
|
+ parts.joined(separator: "; ")
|
||||||
|
}
|
||||||
|
|
||||||
|
static func == (lhs: TargetPageRaster, rhs: TargetPageRaster) -> Bool {
|
||||||
|
lhs.sourceURL == rhs.sourceURL
|
||||||
|
&& lhs.cgImage === rhs.cgImage
|
||||||
|
&& lhs.pixelWidth == rhs.pixelWidth
|
||||||
|
&& lhs.pixelHeight == rhs.pixelHeight
|
||||||
|
&& lhs.dpiX == rhs.dpiX
|
||||||
|
&& lhs.dpiY == rhs.dpiY
|
||||||
|
&& lhs.componentCount == rhs.componentCount
|
||||||
|
&& lhs.bitsPerComponent == rhs.bitsPerComponent
|
||||||
|
&& lhs.expectedWidthMm == rhs.expectedWidthMm
|
||||||
|
&& lhs.expectedHeightMm == rhs.expectedHeightMm
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
enum TargetRasterError: LocalizedError, Equatable {
|
||||||
|
case tiffMissing(String)
|
||||||
|
case undecodable(String)
|
||||||
|
case unsupportedLayout(path: String, components: Int,
|
||||||
|
bitsPerComponent: Int, hasAlpha: Bool)
|
||||||
|
|
||||||
|
var errorDescription: String? {
|
||||||
|
switch self {
|
||||||
|
case .tiffMissing(let path):
|
||||||
|
return "Target TIFF is missing: \(path)"
|
||||||
|
case .undecodable(let path):
|
||||||
|
return "Target TIFF could not be decoded: \(path)"
|
||||||
|
case .unsupportedLayout(let path, let components,
|
||||||
|
let bitsPerComponent, let hasAlpha):
|
||||||
|
return "Target TIFF has an unsupported layout "
|
||||||
|
+ "(\(components) components, \(bitsPerComponent) bpc"
|
||||||
|
+ "\(hasAlpha ? ", alpha" : "")): \(path)"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
enum TargetRasterLoader {
|
||||||
|
/// Absent DPI metadata defaults to 72 (docs/14 §6) — and logs `warn`.
|
||||||
|
static let fallbackDPI: Double = 72
|
||||||
|
|
||||||
|
static func load(
|
||||||
|
tiff url: URL,
|
||||||
|
expectedWidthMm: Double? = nil,
|
||||||
|
expectedHeightMm: Double? = nil
|
||||||
|
) throws -> TargetPageRaster {
|
||||||
|
guard FileManager.default.fileExists(atPath: url.path) else {
|
||||||
|
throw TargetRasterError.tiffMissing(url.path)
|
||||||
|
}
|
||||||
|
guard let source = CGImageSourceCreateWithURL(url as CFURL, nil)
|
||||||
|
else {
|
||||||
|
throw TargetRasterError.undecodable(url.path)
|
||||||
|
}
|
||||||
|
let options: [CFString: Any] = [
|
||||||
|
kCGImageSourceShouldCache: true,
|
||||||
|
kCGImageSourceShouldAllowFloat: false,
|
||||||
|
]
|
||||||
|
guard let image = CGImageSourceCreateImageAtIndex(
|
||||||
|
source, 0, options as CFDictionary)
|
||||||
|
else {
|
||||||
|
throw TargetRasterError.undecodable(url.path)
|
||||||
|
}
|
||||||
|
|
||||||
|
// DPI lives in the container metadata, not the CGImage.
|
||||||
|
var dpiX = fallbackDPI
|
||||||
|
var dpiY = fallbackDPI
|
||||||
|
var foundX = false
|
||||||
|
var foundY = false
|
||||||
|
if let properties = CGImageSourceCopyPropertiesAtIndex(
|
||||||
|
source, 0, nil) as? [CFString: Any] {
|
||||||
|
if let x = (properties[kCGImagePropertyDPIWidth]
|
||||||
|
as? NSNumber)?.doubleValue, x > 0 {
|
||||||
|
dpiX = x
|
||||||
|
foundX = true
|
||||||
|
}
|
||||||
|
if let y = (properties[kCGImagePropertyDPIHeight]
|
||||||
|
as? NSNumber)?.doubleValue, y > 0 {
|
||||||
|
dpiY = y
|
||||||
|
foundY = true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if !foundX || !foundY {
|
||||||
|
AppLogger.shared.warn(
|
||||||
|
"TargetRaster: '\(url.lastPathComponent)' carries no "
|
||||||
|
+ "usable DPI metadata — assuming \(fallbackDPI) dpi")
|
||||||
|
}
|
||||||
|
|
||||||
|
let components = image.colorSpace?.numberOfComponents ?? 0
|
||||||
|
guard !Self.hasRealAlpha(image), let tagged = deviceTagged(image)
|
||||||
|
else {
|
||||||
|
throw TargetRasterError.unsupportedLayout(
|
||||||
|
path: url.path,
|
||||||
|
components: components,
|
||||||
|
bitsPerComponent: image.bitsPerComponent,
|
||||||
|
hasAlpha: Self.hasRealAlpha(image))
|
||||||
|
}
|
||||||
|
|
||||||
|
return TargetPageRaster(
|
||||||
|
sourceURL: url,
|
||||||
|
cgImage: tagged,
|
||||||
|
pixelWidth: image.width,
|
||||||
|
pixelHeight: image.height,
|
||||||
|
dpiX: dpiX,
|
||||||
|
dpiY: dpiY,
|
||||||
|
componentCount: components,
|
||||||
|
bitsPerComponent: image.bitsPerComponent,
|
||||||
|
expectedWidthMm: expectedWidthMm,
|
||||||
|
expectedHeightMm: expectedHeightMm)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Re-tag into `DeviceGray` (1 comp) / `DeviceRGB` (3) /
|
||||||
|
/// `DeviceCMYK` (4) by reusing the decoded image's own
|
||||||
|
/// `dataProvider`, `bitsPerComponent`, `bitsPerPixel`, `bytesPerRow`
|
||||||
|
/// and `bitmapInfo` — **no resample, no bit-depth change, no
|
||||||
|
/// `CGImageCreateCopyWithColorSpace` into a calibrated space**
|
||||||
|
/// (docs/14 §6.3). `shouldInterpolate: false`,
|
||||||
|
/// `intent: .defaultIntent`.
|
||||||
|
///
|
||||||
|
/// Returns `nil` (caller throws `.unsupportedLayout`) for alpha,
|
||||||
|
/// indexed, float, or >4-component images — a profiling target
|
||||||
|
/// never has those, and guessing would corrupt patches.
|
||||||
|
static func deviceTagged(_ image: CGImage) -> CGImage? {
|
||||||
|
guard !hasRealAlpha(image),
|
||||||
|
!image.bitmapInfo.contains(.floatComponents),
|
||||||
|
let colorSpace = image.colorSpace,
|
||||||
|
colorSpace.model != .indexed,
|
||||||
|
colorSpace.model != .pattern,
|
||||||
|
let space = deviceSpace(for: colorSpace.numberOfComponents),
|
||||||
|
let provider = image.dataProvider
|
||||||
|
else { return nil }
|
||||||
|
return CGImage(
|
||||||
|
width: image.width,
|
||||||
|
height: image.height,
|
||||||
|
bitsPerComponent: image.bitsPerComponent,
|
||||||
|
bitsPerPixel: image.bitsPerPixel,
|
||||||
|
bytesPerRow: image.bytesPerRow,
|
||||||
|
space: space,
|
||||||
|
bitmapInfo: image.bitmapInfo,
|
||||||
|
provider: provider,
|
||||||
|
decode: image.decode,
|
||||||
|
shouldInterpolate: false,
|
||||||
|
intent: .defaultIntent)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Skip-only padding (`noneSkipLast`/`noneSkipFirst`) is **not**
|
||||||
|
/// alpha — ImageIO pads opaque RGB TIFFs to 32 bpp that way, so
|
||||||
|
/// accepting it is required for real printtarg files. True coverage
|
||||||
|
/// alpha (`last`/`first`/`premultiplied*`/`only`) is rejected.
|
||||||
|
static func hasRealAlpha(_ image: CGImage) -> Bool {
|
||||||
|
switch image.alphaInfo {
|
||||||
|
case .none, .noneSkipLast, .noneSkipFirst:
|
||||||
|
return false
|
||||||
|
default:
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The device colour space for a component count — `nil` for
|
||||||
|
/// layouts a profiling target can never legally be (2 channels,
|
||||||
|
/// DeviceN, >4 components).
|
||||||
|
static func deviceSpace(for componentCount: Int) -> CGColorSpace? {
|
||||||
|
switch componentCount {
|
||||||
|
case 1: return CGColorSpaceCreateDeviceGray()
|
||||||
|
case 3: return CGColorSpaceCreateDeviceRGB()
|
||||||
|
case 4: return CGColorSpaceCreateDeviceCMYK()
|
||||||
|
default: return nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,127 @@
|
|||||||
|
import Foundation
|
||||||
|
import ICCeryCore
|
||||||
|
|
||||||
|
/// Stage 2 inline overrides applied on top of a rehydrated ticket
|
||||||
|
/// (#201 AC3 / D6 — Stage 2 always wins).
|
||||||
|
struct TargetPrintOverrides: Equatable {
|
||||||
|
var paperSize: String? // CUPS `PageSize` token or `Custom.<w>x<h>`
|
||||||
|
var mediaType: String?
|
||||||
|
var qualityKey: String? // PrinterCapabilities.qualityKey
|
||||||
|
var quality: String?
|
||||||
|
var orientation: String? // "portrait" | "landscape"
|
||||||
|
}
|
||||||
|
|
||||||
|
/// One resolved ticket write.
|
||||||
|
struct TicketWrite: Equatable {
|
||||||
|
let key: String
|
||||||
|
let value: String
|
||||||
|
let locked: Bool
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The fully-resolved write list for one job — a **pure value**,
|
||||||
|
/// computed with zero Core Printing calls so it is unit- and
|
||||||
|
/// UI-testable without a live queue. Replaces the old `lp` argv
|
||||||
|
/// builder (#201 D4/D8).
|
||||||
|
struct ResolvedTicketWrites: Equatable {
|
||||||
|
var writes: [TicketWrite]
|
||||||
|
var paperToken: String?
|
||||||
|
var orientation: String?
|
||||||
|
}
|
||||||
|
|
||||||
|
enum TicketWriteResolver {
|
||||||
|
|
||||||
|
/// Quartz vocabulary constants (docs/14 §7) live on
|
||||||
|
/// `ColorMatchingAttempts` next to the AP_* half — written
|
||||||
|
/// alongside because there is no `lp` path left (D2).
|
||||||
|
///
|
||||||
|
/// Order is locked and is the contract the tests assert:
|
||||||
|
/// 1 `AP_ColorMatchingMode` = AP_ApplicationColorMatching (locked)
|
||||||
|
/// 2 `AP.ColorMatchingMode` = AP_ApplicationColorMatching (locked)
|
||||||
|
/// 3 `PMColorMatchingMode` = APCustomColorMatching (locked)
|
||||||
|
/// 4 `PMCustomColorMatchingProfile` = "" (unlocked)
|
||||||
|
/// 5 `com.apple.print.PrintSettings.PMColorMatchingMode`
|
||||||
|
/// = APCustomColorMatching (unlocked)
|
||||||
|
/// 6 `PageSize` = overrides.paperSize
|
||||||
|
/// 7 detectMediaTypeKey(optionKeys) = overrides.mediaType
|
||||||
|
/// 8 overrides.qualityKey = overrides.quality
|
||||||
|
/// 9 detectDriverColorBypass(optionKeys) (unlocked)
|
||||||
|
/// 10 `orientation-requested` = 3 | 4
|
||||||
|
///
|
||||||
|
/// Invariants: `raw` can never appear (there is no `lp`); nothing
|
||||||
|
/// is suppressed because a captured key already exists (D6 — the
|
||||||
|
/// ticket carries the captured keys and Stage 2 writes land on
|
||||||
|
/// top unconditionally); an override with a `nil` value emits no
|
||||||
|
/// write.
|
||||||
|
static func resolve(
|
||||||
|
overrides: TargetPrintOverrides,
|
||||||
|
optionKeys: Set<String>
|
||||||
|
) -> ResolvedTicketWrites {
|
||||||
|
var writes: [TicketWrite] = []
|
||||||
|
|
||||||
|
// 1–2 — locked AP_* pair (layer ③).
|
||||||
|
for key in ColorMatchingAttempts.printSettingsKeys {
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: key,
|
||||||
|
value: ColorMatchingAttempts.applicationMatchingValue,
|
||||||
|
locked: true))
|
||||||
|
}
|
||||||
|
// 3–5 — Quartz/`NSPrintOperation` vocabulary (D2).
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: ColorMatchingAttempts.quartzModeKey,
|
||||||
|
value: ColorMatchingAttempts.quartzCustomMatching,
|
||||||
|
locked: true))
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: ColorMatchingAttempts.quartzProfileKey,
|
||||||
|
value: "",
|
||||||
|
locked: false))
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: ColorMatchingAttempts.quartzLegacyModeKey,
|
||||||
|
value: ColorMatchingAttempts.quartzCustomMatching,
|
||||||
|
locked: false))
|
||||||
|
|
||||||
|
// 6 — the Stage 2 paper token.
|
||||||
|
var paperToken: String?
|
||||||
|
if let paperSize = overrides.paperSize, !paperSize.isEmpty {
|
||||||
|
paperToken = paperSize
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: "PageSize", value: paperSize, locked: false))
|
||||||
|
}
|
||||||
|
|
||||||
|
// 7 — media type via the queue's detected vendor key.
|
||||||
|
if let mediaType = overrides.mediaType,
|
||||||
|
let mediaKey = CupsParsers.detectMediaTypeKey(
|
||||||
|
optionKeys: optionKeys) {
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: mediaKey, value: mediaType, locked: false))
|
||||||
|
}
|
||||||
|
|
||||||
|
// 8 — print quality; the detected enumeration key travels in
|
||||||
|
// the overrides (`PrinterCapabilities.qualityKey`, #183).
|
||||||
|
if let qualityKey = overrides.qualityKey,
|
||||||
|
let quality = overrides.quality {
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: qualityKey, value: quality, locked: false))
|
||||||
|
}
|
||||||
|
|
||||||
|
// 9 — driver "no colour adjustment" bypass. Never gated on
|
||||||
|
// `ppdUncorrectedPassthrough` — macOS always bypasses.
|
||||||
|
if let bypass = CupsParsers.detectDriverColorBypass(
|
||||||
|
optionKeys: optionKeys) {
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: bypass.key, value: bypass.value, locked: false))
|
||||||
|
}
|
||||||
|
|
||||||
|
// 10 — orientation, CUPS IPP codes portrait=3 / landscape=4.
|
||||||
|
if let orientation = overrides.orientation {
|
||||||
|
writes.append(TicketWrite(
|
||||||
|
key: "orientation-requested",
|
||||||
|
value: orientation == "landscape" ? "4" : "3",
|
||||||
|
locked: false))
|
||||||
|
}
|
||||||
|
|
||||||
|
return ResolvedTicketWrites(
|
||||||
|
writes: writes.filter { $0.key.lowercased() != "raw" },
|
||||||
|
paperToken: paperToken,
|
||||||
|
orientation: overrides.orientation)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -218,7 +218,7 @@ struct Stage2View: View {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// MARK: - Raw print panel (#rawPrintPanel) — unmanaged lp path
|
// MARK: - Raw print panel (#rawPrintPanel) — native spool path (#201)
|
||||||
|
|
||||||
private var printPanel: some View {
|
private var printPanel: some View {
|
||||||
VStack(alignment: .leading, spacing: 10) {
|
VStack(alignment: .leading, spacing: 10) {
|
||||||
@@ -267,6 +267,11 @@ struct Stage2View: View {
|
|||||||
.clipShape(Capsule())
|
.clipShape(Capsule())
|
||||||
.accessibilityIdentifier("printerStatusBadge")
|
.accessibilityIdentifier("printerStatusBadge")
|
||||||
}
|
}
|
||||||
|
// Placeholder — Phase 5 (AirPrint detection, M12)
|
||||||
|
// replaces this with the live unmanaged-colour
|
||||||
|
// warning badge for AirPrint queues.
|
||||||
|
EmptyView()
|
||||||
|
.accessibilityIdentifier("airPrintWarningBadge")
|
||||||
Button(action: workflow.print.refreshPrinters) {
|
Button(action: workflow.print.refreshPrinters) {
|
||||||
Image(systemName: "arrow.clockwise")
|
Image(systemName: "arrow.clockwise")
|
||||||
}
|
}
|
||||||
@@ -325,26 +330,7 @@ struct Stage2View: View {
|
|||||||
// Stage 1 owns the custom dimensions — the caption lives
|
// Stage 1 owns the custom dimensions — the caption lives
|
||||||
// inside `paperSizeGroup` (#183).
|
// inside `paperSizeGroup` (#183).
|
||||||
|
|
||||||
HStack(spacing: 8) {
|
printAllRow
|
||||||
Button(action: {
|
|
||||||
if let result = workflow.printtargResult {
|
|
||||||
workflow.print.printAllPages(from: result)
|
|
||||||
}
|
|
||||||
}) {
|
|
||||||
Label(workflow.print.isPrinting ? "Printing…" : "Print All",
|
|
||||||
systemImage: "printer")
|
|
||||||
}
|
|
||||||
.controlSize(.large)
|
|
||||||
.disabled(workflow.print.isPrinting
|
|
||||||
|| workflow.printtargResult == nil
|
|
||||||
|| workflow.print.selectedPrinter.isEmpty)
|
|
||||||
.accessibilityIdentifier("btnPrintAll")
|
|
||||||
Spacer()
|
|
||||||
Button("Advance to Stage 3") { workflow.advanceToStage3() }
|
|
||||||
.accessibilityIdentifier("btnAdvanceToStage3")
|
|
||||||
.disabled(workflow.printtargResult == nil
|
|
||||||
|| !workflow.wizard.isUnlocked(.measure))
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
.padding(12)
|
.padding(12)
|
||||||
.background(Theme.panel)
|
.background(Theme.panel)
|
||||||
@@ -361,6 +347,37 @@ struct Stage2View: View {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Print All + single-job granularity (#201 D5) + advance.
|
||||||
|
/// Extracted so every ViewBuilder body stays ≤10 children (R13 —
|
||||||
|
/// Xcode 14.2 has no `buildPartialBlock`).
|
||||||
|
private var printAllRow: some View {
|
||||||
|
HStack(spacing: 8) {
|
||||||
|
Button(action: {
|
||||||
|
if let result = workflow.printtargResult {
|
||||||
|
workflow.print.printAllPages(from: result)
|
||||||
|
}
|
||||||
|
}) {
|
||||||
|
Label(workflow.print.isPrinting ? "Printing…" : "Print All",
|
||||||
|
systemImage: "printer")
|
||||||
|
}
|
||||||
|
.controlSize(.large)
|
||||||
|
.disabled(workflow.print.isPrinting
|
||||||
|
|| workflow.printtargResult == nil
|
||||||
|
|| workflow.print.selectedPrinter.isEmpty)
|
||||||
|
.accessibilityIdentifier("btnPrintAll")
|
||||||
|
Toggle("Single spool job",
|
||||||
|
isOn: $workflow.print.singleJobForAllPages)
|
||||||
|
.help("Send all pages as one print job instead of "
|
||||||
|
+ "one job per page")
|
||||||
|
.accessibilityIdentifier("chkSingleSpoolJob")
|
||||||
|
Spacer()
|
||||||
|
Button("Advance to Stage 3") { workflow.advanceToStage3() }
|
||||||
|
.accessibilityIdentifier("btnAdvanceToStage3")
|
||||||
|
.disabled(workflow.printtargResult == nil
|
||||||
|
|| !workflow.wizard.isUnlocked(.measure))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Paper picker + custom-size caption under the `paperSizeGroup`
|
/// Paper picker + custom-size caption under the `paperSizeGroup`
|
||||||
/// container (#183). `caps.paperSizes` plus the synthetic custom
|
/// container (#183). `caps.paperSizes` plus the synthetic custom
|
||||||
/// entry (`id: 0`, shown as `Custom (W×H mm)`).
|
/// entry (`id: 0`, shown as `Custom (W×H mm)`).
|
||||||
|
|||||||
@@ -25,8 +25,7 @@ final class CupsOptionsFilterTests: XCTestCase {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// #180 — a captured `EPIJ_Qual` (and the other canonical quality
|
/// #180 — a captured `EPIJ_Qual` (and the other canonical quality
|
||||||
/// keys) survives the filter so it wins over the Stage 2 explicit
|
/// keys) survives the filter so it reaches the Stage 2 mirror.
|
||||||
/// quality in `LpArgs`.
|
|
||||||
func testKeepsQualityKeys() {
|
func testKeepsQualityKeys() {
|
||||||
let raw = "EPIJ_Qual=304 CNIJPrintQuality=3 PrintQuality=2 "
|
let raw = "EPIJ_Qual=304 CNIJPrintQuality=3 PrintQuality=2 "
|
||||||
+ "cupsPrintQuality=High Quality=Best "
|
+ "cupsPrintQuality=High Quality=Best "
|
||||||
|
|||||||
@@ -232,6 +232,42 @@ final class CupsParserTests: XCTestCase {
|
|||||||
fromOptionsString: "PageSize=A4"))
|
fromOptionsString: "PageSize=A4"))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// MARK: - #186 capture-return
|
||||||
|
|
||||||
|
/// A captured `k=v` string maps to all four `PrintOptions`
|
||||||
|
/// fields — `PageSize`, the detected quality key,
|
||||||
|
/// `orientation-requested`, and a vendor media key (#186).
|
||||||
|
func testCapturedStringMapsAllFields() {
|
||||||
|
let captured =
|
||||||
|
"PageSize=A4 EPIJ_Qual=305 orientation-requested=4 CNIJMediaType=Photo"
|
||||||
|
XCTAssertEqual(CupsParsers.extractOption(
|
||||||
|
named: "PageSize", fromOptionsString: captured), "A4")
|
||||||
|
XCTAssertEqual(CupsParsers.extractQuality(
|
||||||
|
fromOptionsString: captured), "305")
|
||||||
|
XCTAssertEqual(CupsParsers.extractOrientation(
|
||||||
|
fromOptionsString: captured), "landscape")
|
||||||
|
XCTAssertEqual(CupsParsers.extractMediaType(
|
||||||
|
fromOptionsString: captured), "Photo")
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Vendor media keys beyond `MediaType`/`EPIJ_Medi` extract via
|
||||||
|
/// the detection roster — `CNIJMediaType`/`StpMediaType` included
|
||||||
|
/// (#186). `MediaType` still wins when present alongside them.
|
||||||
|
func testExtractMediaTypeRosterFallback() {
|
||||||
|
XCTAssertEqual(CupsParsers.extractMediaType(
|
||||||
|
fromOptionsString: "CNIJMediaType=PhotoPlus"), "PhotoPlus")
|
||||||
|
XCTAssertEqual(CupsParsers.extractMediaType(
|
||||||
|
fromOptionsString: "StpMediaType=Glossy"), "Glossy")
|
||||||
|
XCTAssertEqual(CupsParsers.extractMediaType(
|
||||||
|
fromOptionsString: "EPIJ_Medi=Photo"), "Photo")
|
||||||
|
// `MediaType` keeps first precedence (docs/11 §tests).
|
||||||
|
XCTAssertEqual(CupsParsers.extractMediaType(
|
||||||
|
fromOptionsString: "CNIJMediaType=PhotoPlus MediaType=Plain"),
|
||||||
|
"Plain")
|
||||||
|
XCTAssertNil(CupsParsers.extractMediaType(
|
||||||
|
fromOptionsString: "PageSize=A4"))
|
||||||
|
}
|
||||||
|
|
||||||
func testDriverBypass() {
|
func testDriverBypass() {
|
||||||
func pair(_ keys: Set<String>) -> String? {
|
func pair(_ keys: Set<String>) -> String? {
|
||||||
CupsParsers.detectDriverColorBypass(optionKeys: keys)
|
CupsParsers.detectDriverColorBypass(optionKeys: keys)
|
||||||
@@ -246,4 +282,177 @@ final class CupsParserTests: XCTestCase {
|
|||||||
XCTAssertEqual(pair(["EpsonColorMode"]), "EpsonColorMode=Off")
|
XCTAssertEqual(pair(["EpsonColorMode"]), "EpsonColorMode=Off")
|
||||||
XCTAssertNil(pair(["PageSize"]))
|
XCTAssertNil(pair(["PageSize"]))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// MARK: - #181 Canon media locale precedence + PPD encoding
|
||||||
|
|
||||||
|
/// The 18 Canon Pro9500 media types named in the issue — the ids
|
||||||
|
/// are the numeric codes the driver enumerates via `lpoptions -l`.
|
||||||
|
private let canonMedia: [(id: String, label: String)] = [
|
||||||
|
("0", "Plain Paper"),
|
||||||
|
("1", "Photo Paper Plus Glossy II"),
|
||||||
|
("2", "Photo Paper Pro Platinum N"),
|
||||||
|
("3", "Photo Paper Pro Platinum"),
|
||||||
|
("4", "Photo Paper Pro Luster"),
|
||||||
|
("5", "Photo Paper Plus Semi-gloss"),
|
||||||
|
("6", "Matte Photo Paper"),
|
||||||
|
("7", "Fine Art \"Photo Rag\""),
|
||||||
|
("8", "Fine Art \"Museum Etching\""),
|
||||||
|
("9", "Photo Paper Pro Premium Matte"),
|
||||||
|
("10", "Fine Art Premium Matte"),
|
||||||
|
("11", "Other Fine Art Paper"),
|
||||||
|
("12", "Canvas"),
|
||||||
|
("13", "Board Paper"),
|
||||||
|
("14", "Ink Jet Hagaki"),
|
||||||
|
("15", "Hagaki"),
|
||||||
|
("16", "Printable disc"),
|
||||||
|
("17", "Printable disc (bleed-proof)"),
|
||||||
|
]
|
||||||
|
|
||||||
|
/// Canon Pro9500-shaped fragment: the unqualified base block comes
|
||||||
|
/// early and the `th.` block trails at the end — the ordering that
|
||||||
|
/// let Thai overwrite English under last-write-wins (#181).
|
||||||
|
private var canonPPD: String {
|
||||||
|
var lines = [
|
||||||
|
"*OpenUI *CNIJMediaType/Media Type: PickOne",
|
||||||
|
"*DefaultCNIJMediaType: 0",
|
||||||
|
]
|
||||||
|
for media in canonMedia {
|
||||||
|
lines.append(
|
||||||
|
"*CNIJMediaType \(media.id)/\(media.label): \"\"")
|
||||||
|
}
|
||||||
|
lines.append("*CloseUI: *CNIJMediaType")
|
||||||
|
for media in canonMedia {
|
||||||
|
lines.append(
|
||||||
|
"*th.CNIJMediaType \(media.id)/กระดาษ\(media.id): \"\"")
|
||||||
|
}
|
||||||
|
return lines.joined(separator: "\n")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testPpdLabelsUnqualifiedSurvivesTrailingThai() {
|
||||||
|
let labels = CupsParsers.ppdChoiceLabels(
|
||||||
|
canonPPD, key: "CNIJMediaType")
|
||||||
|
XCTAssertEqual(labels["0"], "Plain Paper")
|
||||||
|
XCTAssertEqual(labels["17"], "Printable disc (bleed-proof)")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testPpdLabelsUnqualifiedWinsRegardlessOfOrder() {
|
||||||
|
// `th.` block first — precedence is deterministic, not
|
||||||
|
// positional (#181, E3).
|
||||||
|
let ppd = """
|
||||||
|
*th.CNIJMediaType 0/กระดาษธรรมดา: ""
|
||||||
|
*CNIJMediaType 0/Plain Paper: ""
|
||||||
|
"""
|
||||||
|
let labels = CupsParsers.ppdChoiceLabels(ppd, key: "CNIJMediaType")
|
||||||
|
XCTAssertEqual(labels["0"], "Plain Paper")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testPpdLabelsQualifiedFallbackOrder() {
|
||||||
|
// en_US > en > first-qualified-seen (#181, E3).
|
||||||
|
let ppd = """
|
||||||
|
*en.CNIJMediaType 1/English Label: ""
|
||||||
|
*en_US.CNIJMediaType 1/US English Label: ""
|
||||||
|
*th.CNIJMediaType 1/กระดาษ: ""
|
||||||
|
*fr.CNIJMediaType 2/Français: ""
|
||||||
|
*de.CNIJMediaType 2/Deutsch: ""
|
||||||
|
"""
|
||||||
|
let labels = CupsParsers.ppdChoiceLabels(ppd, key: "CNIJMediaType")
|
||||||
|
XCTAssertEqual(labels["1"], "US English Label")
|
||||||
|
// A qualified-only id still gets its first-seen qualified
|
||||||
|
// label — never left unlabeled (R9).
|
||||||
|
XCTAssertEqual(labels["2"], "Français")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testPpdLabelsHexEscapeDecoding() {
|
||||||
|
let ppd = """
|
||||||
|
*CNIJMediaType 3/Photo Paper Plus Glossy<2F>Matte: ""
|
||||||
|
*CNIJMediaType 4/Plain<20>Paper: ""
|
||||||
|
*CNIJMediaType 5/Bad<ZZ>Escape: ""
|
||||||
|
"""
|
||||||
|
let labels = CupsParsers.ppdChoiceLabels(ppd, key: "CNIJMediaType")
|
||||||
|
XCTAssertEqual(labels["3"], "Photo Paper Plus Glossy/Matte")
|
||||||
|
XCTAssertEqual(labels["4"], "Plain Paper")
|
||||||
|
XCTAssertEqual(labels["5"], "Bad<ZZ>Escape")
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Every `CNIJMediaType` choice enumerated by `lpoptions -l` gets a
|
||||||
|
/// non-Thai label (E1 — the true count is the hardware gate's, so
|
||||||
|
/// no count is hardcoded here); the 18 named AC labels are
|
||||||
|
/// spot-checked.
|
||||||
|
func testCapabilitiesCanonMediaAllNonThai() {
|
||||||
|
var choices = canonMedia.map(\.id)
|
||||||
|
choices[0] = "*\(choices[0])"
|
||||||
|
let listings = CupsParsers.lpoptionsList(
|
||||||
|
"CNIJMediaType/Media Type: \(choices.joined(separator: " "))\n")
|
||||||
|
let caps = CupsService().capabilities(from: listings, ppd: canonPPD)
|
||||||
|
|
||||||
|
XCTAssertEqual(caps.mediaTypes.count, canonMedia.count)
|
||||||
|
for type in caps.mediaTypes {
|
||||||
|
XCTAssertFalse(type.name.unicodeScalars.contains {
|
||||||
|
(0x0E00...0x0E7F).contains($0.value)
|
||||||
|
}, "Thai label leaked into \(type.id): \(type.name)")
|
||||||
|
}
|
||||||
|
for media in canonMedia {
|
||||||
|
XCTAssertEqual(
|
||||||
|
caps.mediaTypes.first { $0.id == media.id }?.name,
|
||||||
|
media.label)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// UTF-8 PPD carrying Thai labels decodes intact — the English
|
||||||
|
/// base block wins precedence and no mojibake leaks through (#181,
|
||||||
|
/// R10). Exercises `loadPPD` through `capabilities(for:)`.
|
||||||
|
func testLoadPPDUtf8ThaiSurvivesDecode() async throws {
|
||||||
|
let (service, root) = try makeCupsService(
|
||||||
|
ppdData: Data(canonPPD.utf8),
|
||||||
|
listing: "CNIJMediaType/Media Type: *0 1")
|
||||||
|
defer { try? FileManager.default.removeItem(at: root) }
|
||||||
|
|
||||||
|
let caps = try await service.capabilities(for: "Canon_Test")
|
||||||
|
XCTAssertEqual(caps.mediaTypes.map(\.name),
|
||||||
|
["Plain Paper", "Photo Paper Plus Glossy II"])
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A PPD that is not valid UTF-8 (lone `0xE9` for `é`) falls back
|
||||||
|
/// to ISO-Latin-1 instead of yielding nil → raw ids (#181, R10).
|
||||||
|
func testLoadPPDLatin1Fallback() async throws {
|
||||||
|
let ppd = "*CNIJMediaType 0/Papier Couché: \"\"\n"
|
||||||
|
let (service, root) = try makeCupsService(
|
||||||
|
ppdData: ppd.data(using: .isoLatin1)!,
|
||||||
|
listing: "CNIJMediaType/Media Type: *0")
|
||||||
|
defer { try? FileManager.default.removeItem(at: root) }
|
||||||
|
|
||||||
|
let caps = try await service.capabilities(for: "Canon_Test")
|
||||||
|
XCTAssertEqual(caps.mediaTypes,
|
||||||
|
[PrinterMediaType(id: "0", name: "Papier Couché")])
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Fixture `lpoptions` + `ppdDir` so `capabilities(for:)` reaches
|
||||||
|
/// the private `loadPPD` — same mock style as
|
||||||
|
/// `MediaLibraryViewModelTests.installMockCups`.
|
||||||
|
private func makeCupsService(
|
||||||
|
ppdData: Data,
|
||||||
|
listing: String,
|
||||||
|
queue: String = "Canon_Test"
|
||||||
|
) throws -> (CupsService, URL) {
|
||||||
|
let root = FileManager.default.temporaryDirectory
|
||||||
|
.appendingPathComponent("iccery-ppd-\(UUID().uuidString)")
|
||||||
|
let bin = root.appendingPathComponent("bin")
|
||||||
|
let ppdDir = root.appendingPathComponent("ppd")
|
||||||
|
for dir in [bin, ppdDir] {
|
||||||
|
try FileManager.default.createDirectory(
|
||||||
|
at: dir, withIntermediateDirectories: true)
|
||||||
|
}
|
||||||
|
let lpoptions = """
|
||||||
|
#!/bin/sh
|
||||||
|
printf '%s\\n' '\(listing)'
|
||||||
|
"""
|
||||||
|
let scriptURL = bin.appendingPathComponent("lpoptions")
|
||||||
|
try lpoptions.write(to: scriptURL, atomically: true, encoding: .utf8)
|
||||||
|
try FileManager.default.setAttributes(
|
||||||
|
[.posixPermissions: 0o755], ofItemAtPath: scriptURL.path)
|
||||||
|
try ppdData.write(to: ppdDir.appendingPathComponent("\(queue).ppd"))
|
||||||
|
return (CupsService(
|
||||||
|
processManager: ProcessManager(),
|
||||||
|
binaryDir: bin, ppdDir: ppdDir), root)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,173 +0,0 @@
|
|||||||
import XCTest
|
|
||||||
import Foundation
|
|
||||||
@testable import ICCeryCore
|
|
||||||
|
|
||||||
/// Issue 15 — `lp` argv goldens (docs/11 `build_lp_args`).
|
|
||||||
/// `-d`/`options`/`-t` handling is in `CupsService`; these tests cover
|
|
||||||
/// flag order, captured-option precedence, and sanitisation.
|
|
||||||
final class LpArgsTests: XCTestCase {
|
|
||||||
|
|
||||||
private let tiff = "/tmp/work/target_001.tif"
|
|
||||||
private let queue = "EPSON_XP_55_Series"
|
|
||||||
|
|
||||||
private func build(
|
|
||||||
options: PrintOptions = PrintOptions(),
|
|
||||||
optionKeys: Set<String> = []
|
|
||||||
) throws -> [String] {
|
|
||||||
try LpArgs.build(
|
|
||||||
queue: queue, tiffPath: tiff,
|
|
||||||
options: options, optionKeys: optionKeys)
|
|
||||||
}
|
|
||||||
|
|
||||||
func testHeader() throws {
|
|
||||||
let argv = try build()
|
|
||||||
XCTAssertEqual(Array(argv[0...1]), ["-d", queue])
|
|
||||||
XCTAssertEqual(Array(argv[2...3]), ["-t", "ICCery Target - target_001.tif"])
|
|
||||||
XCTAssertEqual(Array(argv[4...5]), ["-o", "AP_ColorMatchingMode=AP_ApplicationColorMatching"])
|
|
||||||
XCTAssertEqual(Array(argv[6...7]), ["-o", "AP.ColorMatchingMode=AP_ApplicationColorMatching"])
|
|
||||||
XCTAssertEqual(argv.last, tiff)
|
|
||||||
XCTAssertFalse(argv.contains { $0 == "raw" || $0 == "-o raw" })
|
|
||||||
}
|
|
||||||
|
|
||||||
func testNeverRaw() throws {
|
|
||||||
let argv = try build(options: PrintOptions(
|
|
||||||
cupsOptions: "raw=true MediaType=Photo"))
|
|
||||||
for (i, arg) in argv.enumerated() where arg == "-o" {
|
|
||||||
XCTAssertNotEqual(argv[i + 1], "raw")
|
|
||||||
XCTAssertNotEqual(argv[i + 1], "raw=true")
|
|
||||||
}
|
|
||||||
XCTAssertFalse(argv.contains { $0.hasPrefix("raw=") })
|
|
||||||
XCTAssertTrue(argv.contains("MediaType=Photo"))
|
|
||||||
}
|
|
||||||
|
|
||||||
func testCapturedReplay() throws {
|
|
||||||
let argv = try build(options: PrintOptions(
|
|
||||||
cupsOptions: "InputSlot=Rear MediaType=Photo"))
|
|
||||||
let rear = argv.firstIndex(of: "InputSlot=Rear")!
|
|
||||||
let apFirst = argv.firstIndex(of:
|
|
||||||
"AP_ColorMatchingMode=AP_ApplicationColorMatching")!
|
|
||||||
XCTAssertTrue(rear > apFirst)
|
|
||||||
}
|
|
||||||
|
|
||||||
func testCapturedWinsMedia() throws {
|
|
||||||
let argv = try build(
|
|
||||||
options: PrintOptions(
|
|
||||||
mediaType: "Plain",
|
|
||||||
cupsOptions: "MediaType=Glossy"),
|
|
||||||
optionKeys: ["MediaType"])
|
|
||||||
XCTAssertTrue(argv.contains("MediaType=Glossy"))
|
|
||||||
XCTAssertFalse(argv.contains("MediaType=Plain"))
|
|
||||||
}
|
|
||||||
|
|
||||||
func testMediaDerived() throws {
|
|
||||||
let argv = try build(
|
|
||||||
options: PrintOptions(mediaType: "SemiGloss"),
|
|
||||||
optionKeys: ["CNIJMediaType", "MediaType"])
|
|
||||||
// CNIJMediaType wins over MediaType in detection order.
|
|
||||||
XCTAssertTrue(argv.contains("CNIJMediaType=SemiGloss"))
|
|
||||||
XCTAssertFalse(argv.contains("MediaType=SemiGloss"))
|
|
||||||
}
|
|
||||||
|
|
||||||
func testBypassRules() throws {
|
|
||||||
let withBypass = try build(
|
|
||||||
optionKeys: ["EPIJ_CMat"])
|
|
||||||
XCTAssertTrue(withBypass.contains("EPIJ_CMat=3"))
|
|
||||||
|
|
||||||
let captured = try build(
|
|
||||||
options: PrintOptions(cupsOptions: "EPIJ_CMat=1"),
|
|
||||||
optionKeys: ["EPIJ_CMat"])
|
|
||||||
// Captured value kept, detection not re-applied.
|
|
||||||
XCTAssertEqual(captured.filter { $0.hasPrefix("EPIJ_CMat") }, ["EPIJ_CMat=1"])
|
|
||||||
}
|
|
||||||
|
|
||||||
func testOrientation() throws {
|
|
||||||
XCTAssertTrue(try build(options: PrintOptions(orientation: "portrait"))
|
|
||||||
.contains("orientation-requested=3"))
|
|
||||||
XCTAssertTrue(try build(options: PrintOptions(orientation: "landscape"))
|
|
||||||
.contains("orientation-requested=4"))
|
|
||||||
let capturedOrients = try build(options: PrintOptions(
|
|
||||||
orientation: "landscape",
|
|
||||||
cupsOptions: "orientation-requested=5"))
|
|
||||||
XCTAssertFalse(capturedOrients.contains("orientation-requested=4"))
|
|
||||||
XCTAssertTrue(capturedOrients.contains("orientation-requested=5"))
|
|
||||||
}
|
|
||||||
|
|
||||||
func testPageSize() throws {
|
|
||||||
XCTAssertTrue(try build(options: PrintOptions(paperSize: "A4"))
|
|
||||||
.contains("PageSize=A4"))
|
|
||||||
let capturedSize = try build(options: PrintOptions(
|
|
||||||
paperSize: "A4", cupsOptions: "PageSize=Letter"))
|
|
||||||
XCTAssertFalse(capturedSize.contains("PageSize=A4"))
|
|
||||||
XCTAssertTrue(capturedSize.contains("PageSize=Letter"))
|
|
||||||
}
|
|
||||||
|
|
||||||
// MARK: - #183 print quality
|
|
||||||
|
|
||||||
func testQualityDerived() throws {
|
|
||||||
let argv = try build(
|
|
||||||
options: PrintOptions(
|
|
||||||
orientation: "portrait", mediaType: "Photo", quality: "305"),
|
|
||||||
optionKeys: ["EPIJ_Qual", "MediaType"])
|
|
||||||
XCTAssertTrue(argv.contains("EPIJ_Qual=305"))
|
|
||||||
// Emit order: after the media option, before orientation.
|
|
||||||
let media = argv.firstIndex(of: "MediaType=Photo")!
|
|
||||||
let quality = argv.firstIndex(of: "EPIJ_Qual=305")!
|
|
||||||
let orient = argv.firstIndex(of: "orientation-requested=3")!
|
|
||||||
XCTAssertTrue(media < quality && quality < orient)
|
|
||||||
}
|
|
||||||
|
|
||||||
func testQualityDetectedKey() throws {
|
|
||||||
// The detected queue key is used, not a hardcoded one.
|
|
||||||
let argv = try build(
|
|
||||||
options: PrintOptions(quality: "High"),
|
|
||||||
optionKeys: ["cupsPrintQuality"])
|
|
||||||
XCTAssertTrue(argv.contains("cupsPrintQuality=High"))
|
|
||||||
}
|
|
||||||
|
|
||||||
func testCapturedWinsQuality() throws {
|
|
||||||
let argv = try build(
|
|
||||||
options: PrintOptions(
|
|
||||||
quality: "303",
|
|
||||||
cupsOptions: "EPIJ_Qual=308"),
|
|
||||||
optionKeys: ["EPIJ_Qual"])
|
|
||||||
XCTAssertTrue(argv.contains("EPIJ_Qual=308"))
|
|
||||||
XCTAssertFalse(argv.contains("EPIJ_Qual=303"))
|
|
||||||
}
|
|
||||||
|
|
||||||
func testCapturedQualityCaseInsensitiveDedup() throws {
|
|
||||||
let argv = try build(
|
|
||||||
options: PrintOptions(
|
|
||||||
quality: "303",
|
|
||||||
cupsOptions: "epij_qual=308"),
|
|
||||||
optionKeys: ["EPIJ_Qual"])
|
|
||||||
XCTAssertFalse(argv.contains("EPIJ_Qual=303"))
|
|
||||||
XCTAssertTrue(argv.contains("epij_qual=308"))
|
|
||||||
}
|
|
||||||
|
|
||||||
func testQualityNilNoEmit() throws {
|
|
||||||
let argv = try build(
|
|
||||||
options: PrintOptions(mediaType: "Photo"),
|
|
||||||
optionKeys: ["EPIJ_Qual", "MediaType"])
|
|
||||||
XCTAssertFalse(argv.contains { $0.hasPrefix("EPIJ_Qual=") })
|
|
||||||
// No quality key on the queue → no emit either.
|
|
||||||
let noKey = try build(
|
|
||||||
options: PrintOptions(quality: "303"),
|
|
||||||
optionKeys: ["MediaType"])
|
|
||||||
XCTAssertFalse(noKey.contains { $0.hasPrefix("EPIJ_Qual=") })
|
|
||||||
}
|
|
||||||
|
|
||||||
func testSanitise() throws {
|
|
||||||
XCTAssertThrowsError(try build(options: PrintOptions(
|
|
||||||
cupsOptions: "InputSlot=Rear;rm -rf /"))) { error in
|
|
||||||
XCTAssertTrue(error is LpArgsError)
|
|
||||||
}
|
|
||||||
XCTAssertThrowsError(try build(options: PrintOptions(
|
|
||||||
cupsOptions: "InputSlot=Rear\nMediaType=Photo"))) { error in
|
|
||||||
XCTAssertTrue(error is LpArgsError)
|
|
||||||
}
|
|
||||||
XCTAssertThrowsError(try build(options: PrintOptions(
|
|
||||||
cupsOptions: "InputSlot=$(whoami)"))) { error in
|
|
||||||
XCTAssertTrue(error is LpArgsError)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -0,0 +1,164 @@
|
|||||||
|
import AppKit
|
||||||
|
import CoreGraphics
|
||||||
|
import Foundation
|
||||||
|
import XCTest
|
||||||
|
@testable import ICCery
|
||||||
|
|
||||||
|
/// Issue #201 Phase 3 — real `NSPrintOperation` with
|
||||||
|
/// `jobDisposition = .save`: proves the canvas paginates at paper size,
|
||||||
|
/// draws the raster 1:1 at the top-left, and survives end-to-end
|
||||||
|
/// without a printer. Skippable via `ICCERY_SKIP_PRINT_PDF=1` for
|
||||||
|
/// hosts where the print system cannot run (R8).
|
||||||
|
@MainActor
|
||||||
|
final class NativeSpoolPDFTests: XCTestCase {
|
||||||
|
|
||||||
|
private var tempRoot: URL!
|
||||||
|
|
||||||
|
/// A4 in points.
|
||||||
|
private let paperSize = NSSize(width: 595.28, height: 841.89)
|
||||||
|
/// Known top-left patch colour — solid fill across the fixture.
|
||||||
|
private let patchBytes: [UInt8] = [230, 40, 50]
|
||||||
|
|
||||||
|
override func setUpWithError() throws {
|
||||||
|
tempRoot = try TargetTestFixtures.makeTempDirectory()
|
||||||
|
}
|
||||||
|
|
||||||
|
override func tearDownWithError() throws {
|
||||||
|
try? FileManager.default.removeItem(at: tempRoot)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testSavePDFDrawsPagesOneToOne() throws {
|
||||||
|
try XCTSkipIf(
|
||||||
|
ProcessInfo.processInfo.environment["ICCERY_SKIP_PRINT_PDF"]
|
||||||
|
== "1",
|
||||||
|
"ICCERY_SKIP_PRINT_PDF=1 — print system unavailable")
|
||||||
|
|
||||||
|
// 72×72 px @ 72 dpi → a 72×72 pt solid block at the top-left.
|
||||||
|
let tiff = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 72, height: 72), dpi: 72,
|
||||||
|
components: 3, bitsPerComponent: 8,
|
||||||
|
pixelBytes: patchBytes, in: tempRoot)
|
||||||
|
let raster = try TargetRasterLoader.load(tiff: tiff)
|
||||||
|
|
||||||
|
let info = NSPrintInfo()
|
||||||
|
info.paperSize = paperSize
|
||||||
|
info.orientation = .portrait
|
||||||
|
info.topMargin = 0
|
||||||
|
info.bottomMargin = 0
|
||||||
|
info.leftMargin = 0
|
||||||
|
info.rightMargin = 0
|
||||||
|
info.horizontalPagination = .clip
|
||||||
|
info.verticalPagination = .clip
|
||||||
|
info.scalingFactor = 1.0
|
||||||
|
info.isHorizontallyCentered = false
|
||||||
|
info.isVerticallyCentered = false
|
||||||
|
info.jobDisposition = .save
|
||||||
|
let pdfURL = tempRoot.appendingPathComponent("spool.pdf")
|
||||||
|
info.dictionary()[NSPrintInfo.AttributeKey.jobSavingURL] = pdfURL
|
||||||
|
|
||||||
|
let canvas = TargetPageCanvasView(
|
||||||
|
pages: [raster, raster], paperSize: paperSize)
|
||||||
|
let operation = NSPrintOperation(view: canvas, printInfo: info)
|
||||||
|
operation.showsPrintPanel = false
|
||||||
|
operation.showsProgressPanel = false
|
||||||
|
operation.canSpawnSeparateThread = false
|
||||||
|
|
||||||
|
XCTAssertTrue(operation.run(),
|
||||||
|
"NSPrintOperation.save failed")
|
||||||
|
XCTAssertTrue(
|
||||||
|
FileManager.default.fileExists(atPath: pdfURL.path))
|
||||||
|
|
||||||
|
let document = try XCTUnwrap(
|
||||||
|
CGPDFDocument(pdfURL as CFURL))
|
||||||
|
XCTAssertEqual(document.numberOfPages, 2)
|
||||||
|
|
||||||
|
let page = try XCTUnwrap(document.page(at: 1))
|
||||||
|
let mediaBox = page.getBoxRect(.mediaBox)
|
||||||
|
XCTAssertEqual(mediaBox.width, paperSize.width, accuracy: 0.5)
|
||||||
|
XCTAssertEqual(mediaBox.height, paperSize.height, accuracy: 0.5)
|
||||||
|
|
||||||
|
try assertTopLeftPatch(on: page, mediaBox: mediaBox)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Render the page at 1 px/pt and check the fixture's solid block
|
||||||
|
/// landed at the top-left at its point size — the coarse 1:1 +
|
||||||
|
/// no-scaling check.
|
||||||
|
private func assertTopLeftPatch(
|
||||||
|
on page: CGPDFPage, mediaBox: CGRect
|
||||||
|
) throws {
|
||||||
|
let width = Int(ceil(mediaBox.width))
|
||||||
|
let height = Int(ceil(mediaBox.height))
|
||||||
|
let rep = try XCTUnwrap(NSBitmapImageRep(
|
||||||
|
bitmapDataPlanes: nil,
|
||||||
|
pixelsWide: width,
|
||||||
|
pixelsHigh: height,
|
||||||
|
bitsPerSample: 8,
|
||||||
|
samplesPerPixel: 4,
|
||||||
|
hasAlpha: true,
|
||||||
|
isPlanar: false,
|
||||||
|
colorSpaceName: .deviceRGB,
|
||||||
|
bytesPerRow: 0,
|
||||||
|
bitsPerPixel: 0))
|
||||||
|
let context = try XCTUnwrap(
|
||||||
|
NSGraphicsContext(bitmapImageRep: rep))
|
||||||
|
let cg = context.cgContext
|
||||||
|
let transform = page.getDrawingTransform(
|
||||||
|
.mediaBox,
|
||||||
|
rect: CGRect(x: 0, y: 0, width: width, height: height),
|
||||||
|
rotate: 0, preserveAspectRatio: true)
|
||||||
|
NSGraphicsContext.saveGraphicsState()
|
||||||
|
NSGraphicsContext.current = context
|
||||||
|
cg.concatenate(transform)
|
||||||
|
cg.drawPDFPage(page)
|
||||||
|
NSGraphicsContext.restoreGraphicsState()
|
||||||
|
|
||||||
|
func pixel(_ x: Int, _ y: Int) throws -> (Double, Double, Double) {
|
||||||
|
let color = try XCTUnwrap(
|
||||||
|
rep.colorAt(x: x, y: y)?.usingColorSpace(.deviceRGB))
|
||||||
|
return (color.redComponent,
|
||||||
|
color.greenComponent,
|
||||||
|
color.blueComponent)
|
||||||
|
}
|
||||||
|
func isPatch(_ p: (Double, Double, Double)) -> Bool {
|
||||||
|
abs(p.0 - Double(patchBytes[0]) / 255) < 0.04
|
||||||
|
&& abs(p.1 - Double(patchBytes[1]) / 255) < 0.04
|
||||||
|
&& abs(p.2 - Double(patchBytes[2]) / 255) < 0.04
|
||||||
|
}
|
||||||
|
|
||||||
|
// The print system insets the view by the queue's unprintable
|
||||||
|
// margin (R10) — host-dependent, ~18 pt on this machine — so
|
||||||
|
// the block's anchor is the painted region's top-left, not
|
||||||
|
// (0,0). Find the painted origin by the first opaque pixel.
|
||||||
|
var originX = width, originY = height
|
||||||
|
for y in 0..<height {
|
||||||
|
for x in 0..<width
|
||||||
|
where (rep.colorAt(x: x, y: y)?.alphaComponent ?? 0) > 0.5 {
|
||||||
|
originX = min(originX, x)
|
||||||
|
originY = min(originY, y)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
XCTAssertLessThan(originX, width, "PDF page rendered empty")
|
||||||
|
XCTAssertLessThan(originY, height, "PDF page rendered empty")
|
||||||
|
|
||||||
|
// 10 px inside the 72 pt block on each axis → patch colour.
|
||||||
|
XCTAssertTrue(try isPatch(pixel(originX + 10, originY + 10)),
|
||||||
|
"top-left block is not the fixture colour")
|
||||||
|
|
||||||
|
// Measure the block's painted width on a row through it:
|
||||||
|
// 72 pt at 1 px/pt — the 1:1 / no-scaling assertion.
|
||||||
|
var blockWidth = 0
|
||||||
|
var x = originX
|
||||||
|
while x < width,
|
||||||
|
isPatch(try pixel(x, originY + 10)) {
|
||||||
|
blockWidth += 1
|
||||||
|
x += 1
|
||||||
|
}
|
||||||
|
XCTAssertEqual(blockWidth, 72, accuracy: 2)
|
||||||
|
|
||||||
|
// Past the block edge the canvas's white page fill shows.
|
||||||
|
let outside = try pixel(originX + 80, originY + 80)
|
||||||
|
XCTAssertEqual(outside.0, 1, accuracy: 0.04)
|
||||||
|
XCTAssertEqual(outside.1, 1, accuracy: 0.04)
|
||||||
|
XCTAssertEqual(outside.2, 1, accuracy: 0.04)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -69,6 +69,24 @@ final class PrintPanelStubTests: XCTestCase {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// #186 — a vendor media key in the captured string reaches
|
||||||
|
/// `options.mediaType` through the detection roster
|
||||||
|
/// (`CNIJMediaType`/`StpMediaType`, not only `MediaType`).
|
||||||
|
func testOkResultExtractsVendorMediaKey() throws {
|
||||||
|
try withEnv([
|
||||||
|
"ICCERY_UI_TESTING": "1",
|
||||||
|
"ICCERY_TEST_PRINT_PANEL": "ok",
|
||||||
|
"ICCERY_TEST_PANEL_OPTIONS":
|
||||||
|
"PageSize=A4 orientation-requested=4 CNIJMediaType=Photo",
|
||||||
|
"ICCERY_TEST_PANEL_PRINTER": nil,
|
||||||
|
]) {
|
||||||
|
let result = UITestHooks.printPanelResult(forQueue: "q")
|
||||||
|
XCTAssertEqual(result?.options.paperSize, "A4")
|
||||||
|
XCTAssertEqual(result?.options.orientation, "landscape")
|
||||||
|
XCTAssertEqual(result?.options.mediaType, "Photo")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func testOkDefaultsPrinter() throws {
|
func testOkDefaultsPrinter() throws {
|
||||||
try withEnv([
|
try withEnv([
|
||||||
"ICCERY_UI_TESTING": "1",
|
"ICCERY_UI_TESTING": "1",
|
||||||
|
|||||||
@@ -5,33 +5,35 @@ import XCTest
|
|||||||
|
|
||||||
/// Issue #183 — Stage 2 paper-size / quality selection: seeding from
|
/// Issue #183 — Stage 2 paper-size / quality selection: seeding from
|
||||||
/// Stage 1 `pageSize`, the synthetic `Custom.<pt>x<pt>` entry, re-mirror
|
/// Stage 1 `pageSize`, the synthetic `Custom.<pt>x<pt>` entry, re-mirror
|
||||||
/// triggers, and `PrintOptions` wiring into `lp` argv.
|
/// triggers, and `TargetPrintOverrides` wiring into the resolved
|
||||||
/// `lpoptions`/`lp` are mock scripts in the test env's `cups-bin` — no
|
/// ticket writes (#201 — the `RecordingTargetSpooler` seam replaces
|
||||||
|
/// the deleted `lp` argv log).
|
||||||
|
/// `lpoptions` is a mock script in the test env's `cups-bin` — no
|
||||||
/// live CUPS is touched.
|
/// live CUPS is touched.
|
||||||
@MainActor
|
@MainActor
|
||||||
final class PrintSessionViewModelTests: XCTestCase {
|
final class PrintSessionViewModelTests: XCTestCase {
|
||||||
|
|
||||||
private var env: TestAppEnvironment!
|
private var env: TestAppEnvironment!
|
||||||
private var lpArgvURL: URL!
|
private var spoolLogURL: URL!
|
||||||
|
|
||||||
override func setUp() async throws {
|
override func setUp() async throws {
|
||||||
env = try TestAppEnvironment.make()
|
env = try TestAppEnvironment.make()
|
||||||
lpArgvURL = env.root.appendingPathComponent("lp-argv.log")
|
spoolLogURL = env.root.appendingPathComponent("spool.log")
|
||||||
try writeCupsFixtures()
|
try writeCupsFixtures()
|
||||||
}
|
}
|
||||||
|
|
||||||
override func tearDown() async throws {
|
override func tearDown() async throws {
|
||||||
env?.cleanup()
|
env?.cleanup()
|
||||||
env = nil
|
env = nil
|
||||||
lpArgvURL = nil
|
spoolLogURL = nil
|
||||||
}
|
}
|
||||||
|
|
||||||
private var binDir: URL {
|
private var binDir: URL {
|
||||||
env.root.appendingPathComponent("cups-bin")
|
env.root.appendingPathComponent("cups-bin")
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Mock `lpoptions -l` advertises paper sizes + a quality key;
|
/// Mock `lpoptions -l` advertises paper sizes + a quality key —
|
||||||
/// mock `lp` appends its argv to `lpArgvURL` for assertions.
|
/// the queue's option-key roster feeds media/quality detection.
|
||||||
private func writeCupsFixtures() throws {
|
private func writeCupsFixtures() throws {
|
||||||
try FileManager.default.createDirectory(
|
try FileManager.default.createDirectory(
|
||||||
at: binDir, withIntermediateDirectories: true)
|
at: binDir, withIntermediateDirectories: true)
|
||||||
@@ -56,17 +58,10 @@ final class PrintSessionViewModelTests: XCTestCase {
|
|||||||
printf "printer-info='Mock %s' printer-type=42\\n" "$queue"
|
printf "printer-info='Mock %s' printer-type=42\\n" "$queue"
|
||||||
exit 0
|
exit 0
|
||||||
"""
|
"""
|
||||||
let lp = """
|
let url = binDir.appendingPathComponent("lpoptions")
|
||||||
#!/bin/sh
|
try lpoptions.write(to: url, atomically: true, encoding: .utf8)
|
||||||
printf '%s\\n' "$*" >> "\(lpArgvURL.path)"
|
try FileManager.default.setAttributes(
|
||||||
exit 0
|
[.posixPermissions: 0o755], ofItemAtPath: url.path)
|
||||||
"""
|
|
||||||
for (name, body) in [("lpoptions", lpoptions), ("lp", lp)] {
|
|
||||||
let url = binDir.appendingPathComponent(name)
|
|
||||||
try body.write(to: url, atomically: true, encoding: .utf8)
|
|
||||||
try FileManager.default.setAttributes(
|
|
||||||
[.posixPermissions: 0o755], ofItemAtPath: url.path)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
private func makeWorkflow() -> TargetWorkflowViewModel {
|
private func makeWorkflow() -> TargetWorkflowViewModel {
|
||||||
@@ -185,14 +180,17 @@ final class PrintSessionViewModelTests: XCTestCase {
|
|||||||
|
|
||||||
// MARK: - Spool wiring
|
// MARK: - Spool wiring
|
||||||
|
|
||||||
/// `spool` emits the Stage 2 paper token and quality through
|
/// `spool` resolves the Stage 2 paper token and quality into the
|
||||||
/// `PrintOptions` → `lp` argv (`-o PageSize=`, `-o <qualityKey>=`).
|
/// ticket writes (`PageSize=`, `<qualityKey>=`) recorded by the
|
||||||
|
/// DEBUG spool seam (#201 D8).
|
||||||
func testSpoolPassesPaperTokenAndQuality() async throws {
|
func testSpoolPassesPaperTokenAndQuality() async throws {
|
||||||
let workflow = makeWorkflow()
|
let workflow = makeWorkflow()
|
||||||
workflow.pageSize = .a4
|
workflow.pageSize = .a4
|
||||||
await loadCaps(workflow.print)
|
await loadCaps(workflow.print)
|
||||||
workflow.print.selectedPaperSize = 4 // Letter
|
workflow.print.selectedPaperSize = 4 // Letter
|
||||||
workflow.print.selectedQuality = "301"
|
workflow.print.selectedQuality = "301"
|
||||||
|
workflow.print.spooler = RecordingTargetSpooler(
|
||||||
|
logURL: spoolLogURL)
|
||||||
|
|
||||||
let tiff = env.root.appendingPathComponent("page1.tif")
|
let tiff = env.root.appendingPathComponent("page1.tif")
|
||||||
try Data([0x49, 0x49]).write(to: tiff)
|
try Data([0x49, 0x49]).write(to: tiff)
|
||||||
@@ -208,9 +206,46 @@ final class PrintSessionViewModelTests: XCTestCase {
|
|||||||
pages: [page])
|
pages: [page])
|
||||||
workflow.print.printAllPages(from: result)
|
workflow.print.printAllPages(from: result)
|
||||||
|
|
||||||
let argv = await waitForFile(lpArgvURL)
|
let log = await waitForFile(spoolLogURL)
|
||||||
XCTAssertTrue(argv.contains("PageSize=Letter"), argv)
|
XCTAssertTrue(log.contains("PageSize=Letter"), log)
|
||||||
XCTAssertTrue(argv.contains("EPIJ_Qual=301"), argv)
|
XCTAssertTrue(log.contains("EPIJ_Qual=301"), log)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// #201 — the stubbed panel never produces a `PrintTicket`, so a
|
||||||
|
/// spool with `capturedTickets` empty must still resolve every
|
||||||
|
/// Stage 2 write (the default UI-test path).
|
||||||
|
func testSpoolWithoutTicketResolvesStage2Writes() async throws {
|
||||||
|
let workflow = makeWorkflow()
|
||||||
|
workflow.pageSize = .a4
|
||||||
|
await loadCaps(workflow.print)
|
||||||
|
workflow.print.spooler = RecordingTargetSpooler(
|
||||||
|
logURL: spoolLogURL)
|
||||||
|
XCTAssertTrue(workflow.print.capturedTickets.isEmpty)
|
||||||
|
|
||||||
|
let tiff = env.root.appendingPathComponent("page1.tif")
|
||||||
|
try Data([0x49, 0x49]).write(to: tiff)
|
||||||
|
let page = GalleryPage(
|
||||||
|
index: 0,
|
||||||
|
page: PrinttargPage(
|
||||||
|
filename: "page1.tif", patches: 10,
|
||||||
|
widthMm: 210, heightMm: 297),
|
||||||
|
fileURL: tiff, previewPNG: nil, previewError: nil)
|
||||||
|
let result = PrinttargResult(
|
||||||
|
ti2URL: env.root.appendingPathComponent("target.ti2"),
|
||||||
|
manifest: PrinttargManifest(pages: [page.page]),
|
||||||
|
pages: [page])
|
||||||
|
workflow.print.printAllPages(from: result)
|
||||||
|
|
||||||
|
let log = await waitForFile(spoolLogURL)
|
||||||
|
XCTAssertTrue(log.contains("pages=1"), log)
|
||||||
|
XCTAssertTrue(log.contains("PageSize=A4"), log)
|
||||||
|
XCTAssertTrue(log.contains("EPIJ_Qual=303"), log)
|
||||||
|
XCTAssertTrue(log.contains("MediaType=Stationery"), log)
|
||||||
|
XCTAssertTrue(log.contains("orientation-requested=3"), log)
|
||||||
|
XCTAssertTrue(log.contains(
|
||||||
|
"AP_ColorMatchingMode=AP_ApplicationColorMatching"), log)
|
||||||
|
XCTAssertTrue(log.contains(
|
||||||
|
"PMColorMatchingMode=APCustomColorMatching"), log)
|
||||||
}
|
}
|
||||||
|
|
||||||
// MARK: - Panel apply-back (stubbed NSPrintPanel)
|
// MARK: - Panel apply-back (stubbed NSPrintPanel)
|
||||||
@@ -244,4 +279,149 @@ final class PrintSessionViewModelTests: XCTestCase {
|
|||||||
XCTAssertEqual(workflow.print.selectedPaperSize, 4)
|
XCTAssertEqual(workflow.print.selectedPaperSize, 4)
|
||||||
XCTAssertEqual(workflow.print.selectedQuality, "305")
|
XCTAssertEqual(workflow.print.selectedQuality, "305")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// #186 — the captured `orientation-requested`/media token apply
|
||||||
|
/// back to `printOrientation`/`selectedMediaType`, and a dialog
|
||||||
|
/// result never mutates `workflow.pageSize` (printtarg layout).
|
||||||
|
func testPanelResultAppliesBackOrientationAndMedia() async throws {
|
||||||
|
setenv("ICCERY_UI_TESTING", "1", 1)
|
||||||
|
setenv("ICCERY_TEST_PRINT_PANEL", "ok", 1)
|
||||||
|
setenv("ICCERY_TEST_PANEL_OPTIONS",
|
||||||
|
"orientation-requested=4 MediaType=Glossy", 1)
|
||||||
|
defer {
|
||||||
|
unsetenv("ICCERY_UI_TESTING")
|
||||||
|
unsetenv("ICCERY_TEST_PRINT_PANEL")
|
||||||
|
unsetenv("ICCERY_TEST_PANEL_OPTIONS")
|
||||||
|
}
|
||||||
|
|
||||||
|
let workflow = makeWorkflow()
|
||||||
|
workflow.pageSize = .a4
|
||||||
|
await loadCaps(workflow.print)
|
||||||
|
XCTAssertEqual(workflow.print.printOrientation, "portrait")
|
||||||
|
XCTAssertEqual(workflow.print.selectedMediaType, "Stationery")
|
||||||
|
|
||||||
|
workflow.print.openPrinterPreferences()
|
||||||
|
await waitForNotice(workflow.print, containing: "Settings captured")
|
||||||
|
XCTAssertEqual(workflow.print.printOrientation, "landscape")
|
||||||
|
XCTAssertEqual(workflow.print.selectedMediaType, "Glossy")
|
||||||
|
XCTAssertEqual(workflow.pageSize, .a4)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// #186 — a captured `PageSize` token with no capability match
|
||||||
|
/// leaves `selectedPaperSize` unchanged (never a guessed id).
|
||||||
|
func testPanelResultUnknownPaperLeavesSelection() async throws {
|
||||||
|
setenv("ICCERY_UI_TESTING", "1", 1)
|
||||||
|
setenv("ICCERY_TEST_PRINT_PANEL", "ok", 1)
|
||||||
|
setenv("ICCERY_TEST_PANEL_OPTIONS", "PageSize=Bogus", 1)
|
||||||
|
defer {
|
||||||
|
unsetenv("ICCERY_UI_TESTING")
|
||||||
|
unsetenv("ICCERY_TEST_PRINT_PANEL")
|
||||||
|
unsetenv("ICCERY_TEST_PANEL_OPTIONS")
|
||||||
|
}
|
||||||
|
|
||||||
|
let workflow = makeWorkflow()
|
||||||
|
workflow.pageSize = .a4
|
||||||
|
await loadCaps(workflow.print)
|
||||||
|
XCTAssertEqual(workflow.print.selectedPaperSize, 3)
|
||||||
|
|
||||||
|
workflow.print.openPrinterPreferences()
|
||||||
|
await waitForNotice(workflow.print, containing: "Settings captured")
|
||||||
|
XCTAssertEqual(workflow.print.selectedPaperSize, 3)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// #186 — a stub result pointing at another queue in `printers`
|
||||||
|
/// switches `selectedPrinter` and reloads its capabilities.
|
||||||
|
func testPanelResultSwitchesToKnownQueue() async throws {
|
||||||
|
setenv("ICCERY_UI_TESTING", "1", 1)
|
||||||
|
setenv("ICCERY_TEST_PRINT_PANEL", "ok", 1)
|
||||||
|
setenv("ICCERY_TEST_PANEL_OPTIONS", "PageSize=Letter", 1)
|
||||||
|
setenv("ICCERY_TEST_PANEL_PRINTER", "Other_Q", 1)
|
||||||
|
defer {
|
||||||
|
unsetenv("ICCERY_UI_TESTING")
|
||||||
|
unsetenv("ICCERY_TEST_PRINT_PANEL")
|
||||||
|
unsetenv("ICCERY_TEST_PANEL_OPTIONS")
|
||||||
|
unsetenv("ICCERY_TEST_PANEL_PRINTER")
|
||||||
|
}
|
||||||
|
|
||||||
|
let workflow = makeWorkflow()
|
||||||
|
workflow.pageSize = .a4
|
||||||
|
workflow.print.printers = [
|
||||||
|
Printer(name: "Mock_Q", isDefault: true),
|
||||||
|
Printer(name: "Other_Q"),
|
||||||
|
]
|
||||||
|
await loadCaps(workflow.print)
|
||||||
|
|
||||||
|
workflow.print.openPrinterPreferences()
|
||||||
|
await waitForNotice(
|
||||||
|
workflow.print, containing: "Settings captured for Other_Q")
|
||||||
|
XCTAssertEqual(workflow.print.selectedPrinter, "Other_Q")
|
||||||
|
// Caps reloaded for the new queue: paper re-seeded, then the
|
||||||
|
// captured PageSize applied back onto the new caps.
|
||||||
|
XCTAssertEqual(workflow.print.selectedPaperSize, 4)
|
||||||
|
XCTAssertEqual(workflow.print.capturedCupsOptions["Other_Q"],
|
||||||
|
"PageSize=Letter")
|
||||||
|
}
|
||||||
|
|
||||||
|
/// #186 — a stub result naming a queue absent from `printers`
|
||||||
|
/// leaves the selection on the opened queue.
|
||||||
|
func testPanelResultGhostQueueIgnored() async throws {
|
||||||
|
setenv("ICCERY_UI_TESTING", "1", 1)
|
||||||
|
setenv("ICCERY_TEST_PRINT_PANEL", "ok", 1)
|
||||||
|
setenv("ICCERY_TEST_PANEL_PRINTER", "Ghost_Q", 1)
|
||||||
|
defer {
|
||||||
|
unsetenv("ICCERY_UI_TESTING")
|
||||||
|
unsetenv("ICCERY_TEST_PRINT_PANEL")
|
||||||
|
unsetenv("ICCERY_TEST_PANEL_PRINTER")
|
||||||
|
}
|
||||||
|
|
||||||
|
let workflow = makeWorkflow()
|
||||||
|
workflow.pageSize = .a4
|
||||||
|
workflow.print.printers = [Printer(name: "Mock_Q", isDefault: true)]
|
||||||
|
await loadCaps(workflow.print)
|
||||||
|
|
||||||
|
workflow.print.openPrinterPreferences()
|
||||||
|
await waitForNotice(
|
||||||
|
workflow.print, containing: "Settings captured for Mock_Q")
|
||||||
|
XCTAssertEqual(workflow.print.selectedPrinter, "Mock_Q")
|
||||||
|
}
|
||||||
|
|
||||||
|
/// #186 — cancel returns `nil`: info notice, no field changes.
|
||||||
|
func testPanelCancelLeavesSelections() async throws {
|
||||||
|
setenv("ICCERY_UI_TESTING", "1", 1)
|
||||||
|
setenv("ICCERY_TEST_PRINT_PANEL", "cancel", 1)
|
||||||
|
defer {
|
||||||
|
unsetenv("ICCERY_UI_TESTING")
|
||||||
|
unsetenv("ICCERY_TEST_PRINT_PANEL")
|
||||||
|
}
|
||||||
|
|
||||||
|
let workflow = makeWorkflow()
|
||||||
|
workflow.pageSize = .a4
|
||||||
|
await loadCaps(workflow.print)
|
||||||
|
workflow.print.printOrientation = "landscape"
|
||||||
|
|
||||||
|
workflow.print.openPrinterPreferences()
|
||||||
|
await waitForNotice(workflow.print, containing: "cancelled")
|
||||||
|
XCTAssertEqual(workflow.print.selectedPaperSize, 3)
|
||||||
|
XCTAssertEqual(workflow.print.selectedQuality, "303")
|
||||||
|
XCTAssertEqual(workflow.print.selectedMediaType, "Stationery")
|
||||||
|
XCTAssertEqual(workflow.print.printOrientation, "landscape")
|
||||||
|
XCTAssertTrue(workflow.print.capturedCupsOptions.isEmpty)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Poll until the panel task posts a notice whose text contains
|
||||||
|
/// `fragment` (the Task-completion signal for `nil` results too).
|
||||||
|
private func waitForNotice(
|
||||||
|
_ vm: PrintSessionViewModel,
|
||||||
|
containing fragment: String,
|
||||||
|
timeout: TimeInterval = 10
|
||||||
|
) async {
|
||||||
|
let deadline = Date().addingTimeInterval(timeout)
|
||||||
|
while Date() < deadline {
|
||||||
|
if let text = vm.printNotice?.text, text.contains(fragment) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
try? await Task.sleep(nanoseconds: 100_000_000)
|
||||||
|
}
|
||||||
|
XCTFail("Timed out waiting for notice containing '\(fragment)'")
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,121 @@
|
|||||||
|
import AppKit
|
||||||
|
import Foundation
|
||||||
|
import XCTest
|
||||||
|
@testable import ICCery
|
||||||
|
|
||||||
|
/// Issue #201 Phase 2 — `PMTicketBridge.serialise`/`restore` byte
|
||||||
|
/// round-trip, cross-queue refusal (R3), plist fallback, and the
|
||||||
|
/// `takeRetainedValue` ownership canary.
|
||||||
|
@MainActor
|
||||||
|
final class PrintTicketTests: XCTestCase {
|
||||||
|
|
||||||
|
/// The queue a destination `NSPrintInfo` will report as bound —
|
||||||
|
/// the session's current printer, else the Cocoa printer name,
|
||||||
|
/// else a synthetic token for a queue-less environment.
|
||||||
|
private func boundQueue(of printInfo: NSPrintInfo) -> String {
|
||||||
|
PMTicketBridge.currentPrinterID(
|
||||||
|
session: PMTicketBridge.session(printInfo),
|
||||||
|
fallback: "UnboundQueue")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testRoundTripRetainsVendorValue() throws {
|
||||||
|
let source = NSPrintInfo()
|
||||||
|
XCTAssertTrue(
|
||||||
|
PMTicketBridge.setValue(
|
||||||
|
"305", forKey: "EPIJ_Qual", locked: false,
|
||||||
|
in: PMTicketBridge.settings(source),
|
||||||
|
context: "PrintTicketTests"))
|
||||||
|
|
||||||
|
let target = NSPrintInfo()
|
||||||
|
let ticket = try PMTicketBridge.serialise(
|
||||||
|
source, queue: boundQueue(of: target))
|
||||||
|
try PMTicketBridge.restore(ticket, into: target)
|
||||||
|
|
||||||
|
XCTAssertEqual(
|
||||||
|
PMTicketBridge.stringValue(
|
||||||
|
forKey: "EPIJ_Qual",
|
||||||
|
in: PMTicketBridge.settings(target)),
|
||||||
|
"305")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testPrintSettingsDataIsXmlPlist() throws {
|
||||||
|
let ticket = try PMTicketBridge.serialise(
|
||||||
|
NSPrintInfo(), queue: "AnyQueue")
|
||||||
|
XCTAssertFalse(ticket.printSettings.isEmpty)
|
||||||
|
XCTAssertFalse(ticket.pageFormat.isEmpty)
|
||||||
|
XCTAssertEqual(
|
||||||
|
String(decoding: ticket.printSettings.prefix(5),
|
||||||
|
as: UTF8.self),
|
||||||
|
"<?xml")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testCrossQueueReplayIsRefused() throws {
|
||||||
|
let target = NSPrintInfo()
|
||||||
|
let bound = boundQueue(of: target)
|
||||||
|
let foreign = "DefinitelyNot_\(bound)"
|
||||||
|
try XCTSkipIf(
|
||||||
|
bound == foreign,
|
||||||
|
"destination resolved to the foreign queue")
|
||||||
|
|
||||||
|
// Sentinel on the destination — a refused restore must leave
|
||||||
|
// the target's settings untouched.
|
||||||
|
XCTAssertTrue(
|
||||||
|
PMTicketBridge.setValue(
|
||||||
|
"999", forKey: "EPIJ_Qual", locked: false,
|
||||||
|
in: PMTicketBridge.settings(target),
|
||||||
|
context: "PrintTicketTests"))
|
||||||
|
|
||||||
|
let source = NSPrintInfo()
|
||||||
|
XCTAssertTrue(
|
||||||
|
PMTicketBridge.setValue(
|
||||||
|
"305", forKey: "EPIJ_Qual", locked: false,
|
||||||
|
in: PMTicketBridge.settings(source),
|
||||||
|
context: "PrintTicketTests"))
|
||||||
|
let ticket = try PMTicketBridge.serialise(
|
||||||
|
source, queue: foreign)
|
||||||
|
|
||||||
|
try PMTicketBridge.restore(ticket, into: target)
|
||||||
|
XCTAssertEqual(
|
||||||
|
PMTicketBridge.stringValue(
|
||||||
|
forKey: "EPIJ_Qual",
|
||||||
|
in: PMTicketBridge.settings(target)),
|
||||||
|
"999")
|
||||||
|
}
|
||||||
|
|
||||||
|
func testPrintInfoPlistFallbackRoundTrips() throws {
|
||||||
|
let source = NSPrintInfo()
|
||||||
|
// The `com.apple.print.PrintSettings` entry only exists once
|
||||||
|
// something writes into the attribute dictionary — the
|
||||||
|
// ColorSync mirror does this on the real panel path.
|
||||||
|
source.dictionary()[
|
||||||
|
NSPrintInfo.AttributeKey("com.apple.print.PrintSettings")] =
|
||||||
|
["PMColorMatchingMode": "APCustomColorMatching"]
|
||||||
|
as NSDictionary
|
||||||
|
let ticket = try PMTicketBridge.serialise(
|
||||||
|
source, queue: "AnyQueue")
|
||||||
|
let data = try XCTUnwrap(ticket.printInfoPlist)
|
||||||
|
let object = try PropertyListSerialization.propertyList(
|
||||||
|
from: data, options: [], format: nil)
|
||||||
|
let dictionary = try XCTUnwrap(object as? [String: Any])
|
||||||
|
XCTAssertNotNil(
|
||||||
|
dictionary["com.apple.print.PrintSettings"])
|
||||||
|
}
|
||||||
|
|
||||||
|
/// 200× serialise loop — a `takeRetainedValue` over/under-release
|
||||||
|
/// canary. Byte counts must stay stable; ASan + Malloc Scribble
|
||||||
|
/// catches an actual imbalance.
|
||||||
|
func testSerialiseIsStableAcrossIterations() throws {
|
||||||
|
let source = NSPrintInfo()
|
||||||
|
var firstCount: Int?
|
||||||
|
for _ in 0..<200 {
|
||||||
|
let ticket = try PMTicketBridge.serialise(
|
||||||
|
source, queue: "AnyQueue")
|
||||||
|
if let first = firstCount {
|
||||||
|
XCTAssertEqual(ticket.printSettings.count, first)
|
||||||
|
} else {
|
||||||
|
firstCount = ticket.printSettings.count
|
||||||
|
}
|
||||||
|
}
|
||||||
|
XCTAssertNotNil(firstCount)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,170 @@
|
|||||||
|
import AppKit
|
||||||
|
import CoreGraphics
|
||||||
|
import Foundation
|
||||||
|
import XCTest
|
||||||
|
@testable import ICCery
|
||||||
|
|
||||||
|
/// Issue #201 Phase 3 — `TargetPageCanvasView` top-down page stacking,
|
||||||
|
/// snapped top-left anchoring, and the draw-time interpolation /
|
||||||
|
/// antialias contract asserted via `drawProbe`.
|
||||||
|
@MainActor
|
||||||
|
final class TargetCanvasGeometryTests: XCTestCase {
|
||||||
|
|
||||||
|
/// A4-ish paper, points.
|
||||||
|
private let paperSize = NSSize(width: 595.28, height: 841.89)
|
||||||
|
|
||||||
|
private func raster(
|
||||||
|
pixelWidth: Int = 2480,
|
||||||
|
pixelHeight: Int = 3508,
|
||||||
|
dpi: Double = 300
|
||||||
|
) -> TargetPageRaster {
|
||||||
|
let image = TargetTestFixtures.makeImage(
|
||||||
|
px: CGSize(width: 8, height: 8),
|
||||||
|
components: 3, bitsPerComponent: 8)!
|
||||||
|
return TargetPageRaster(
|
||||||
|
sourceURL: URL(fileURLWithPath: "/fixture.tiff"),
|
||||||
|
cgImage: image,
|
||||||
|
pixelWidth: pixelWidth,
|
||||||
|
pixelHeight: pixelHeight,
|
||||||
|
dpiX: dpi, dpiY: dpi,
|
||||||
|
componentCount: 3,
|
||||||
|
bitsPerComponent: 8,
|
||||||
|
expectedWidthMm: nil,
|
||||||
|
expectedHeightMm: nil)
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: - Page stacking
|
||||||
|
|
||||||
|
func testRectForPageStacksTopDown() {
|
||||||
|
let view = TargetPageCanvasView(
|
||||||
|
pages: [raster(), raster(), raster()],
|
||||||
|
paperSize: paperSize)
|
||||||
|
XCTAssertTrue(view.isFlipped)
|
||||||
|
|
||||||
|
let page1 = view.rectForPage(1)
|
||||||
|
let page3 = view.rectForPage(3)
|
||||||
|
XCTAssertEqual(page1.minY, 0, accuracy: 0.001)
|
||||||
|
XCTAssertEqual(page3.minY, 2 * paperSize.height, accuracy: 0.001)
|
||||||
|
XCTAssertEqual(page1.size, paperSize)
|
||||||
|
XCTAssertEqual(page3.size, paperSize)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testKnowsPageRangeAndFrame() {
|
||||||
|
let view = TargetPageCanvasView(
|
||||||
|
pages: [raster(), raster()],
|
||||||
|
paperSize: paperSize)
|
||||||
|
var range = NSRange()
|
||||||
|
XCTAssertTrue(view.knowsPageRange(&range))
|
||||||
|
XCTAssertEqual(range, NSRange(location: 1, length: 2))
|
||||||
|
XCTAssertEqual(
|
||||||
|
view.frame.height, 2 * paperSize.height, accuracy: 0.001)
|
||||||
|
XCTAssertEqual(view.frame.width, paperSize.width, accuracy: 0.001)
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: - Destination rect
|
||||||
|
|
||||||
|
func testDestinationRectAnchorsTopLeftAndSnaps() {
|
||||||
|
let view = TargetPageCanvasView(
|
||||||
|
pages: [raster(), raster()],
|
||||||
|
paperSize: paperSize)
|
||||||
|
|
||||||
|
let first = view.destinationRect(forPage: 1)
|
||||||
|
XCTAssertEqual(first.origin.x, 0, accuracy: 0.001)
|
||||||
|
XCTAssertEqual(first.origin.y, 0, accuracy: 0.001)
|
||||||
|
XCTAssertEqual(first.width, 595.2, accuracy: 0.01)
|
||||||
|
XCTAssertEqual(first.height, 841.92, accuracy: 0.01)
|
||||||
|
|
||||||
|
let second = view.destinationRect(forPage: 2)
|
||||||
|
XCTAssertEqual(
|
||||||
|
second.origin.y, paperSize.height, accuracy: 0.001)
|
||||||
|
XCTAssertEqual(second.size, first.size)
|
||||||
|
|
||||||
|
for rect in [first, second] {
|
||||||
|
XCTAssertEqual(
|
||||||
|
rect.origin.x * 1000,
|
||||||
|
(rect.origin.x * 1000).rounded(),
|
||||||
|
accuracy: 1e-9)
|
||||||
|
XCTAssertEqual(
|
||||||
|
rect.origin.y * 1000,
|
||||||
|
(rect.origin.y * 1000).rounded(),
|
||||||
|
accuracy: 1e-9)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: - Draw flags
|
||||||
|
|
||||||
|
/// Render the canvas into an offscreen bitmap context and assert —
|
||||||
|
/// from inside `drawProbe` — that interpolation and antialiasing
|
||||||
|
/// are off and the drawn rect is `destinationRect(forPage:)`.
|
||||||
|
func testDrawDisablesInterpolationAndAntialias() throws {
|
||||||
|
let pages = [raster(), raster()]
|
||||||
|
let view = TargetPageCanvasView(
|
||||||
|
pages: pages, paperSize: paperSize)
|
||||||
|
|
||||||
|
let rep = try XCTUnwrap(NSBitmapImageRep(
|
||||||
|
bitmapDataPlanes: nil,
|
||||||
|
pixelsWide: Int(ceil(view.frame.width)),
|
||||||
|
pixelsHigh: Int(ceil(view.frame.height)),
|
||||||
|
bitsPerSample: 8,
|
||||||
|
samplesPerPixel: 4,
|
||||||
|
hasAlpha: true,
|
||||||
|
isPlanar: false,
|
||||||
|
colorSpaceName: .deviceRGB,
|
||||||
|
bytesPerRow: 0,
|
||||||
|
bitsPerPixel: 0))
|
||||||
|
let context = try XCTUnwrap(
|
||||||
|
NSGraphicsContext(bitmapImageRep: rep))
|
||||||
|
|
||||||
|
var probed: [(page: Int, rect: NSRect)] = []
|
||||||
|
view.drawProbe = { ctx, page, rect in
|
||||||
|
XCTAssertEqual(ctx.imageInterpolation, .none,
|
||||||
|
"page \(page): interpolation not .none")
|
||||||
|
XCTAssertFalse(ctx.shouldAntialias,
|
||||||
|
"page \(page): antialiasing still on")
|
||||||
|
probed.append((page, rect))
|
||||||
|
}
|
||||||
|
|
||||||
|
NSGraphicsContext.saveGraphicsState()
|
||||||
|
NSGraphicsContext.current = context
|
||||||
|
view.draw(view.bounds)
|
||||||
|
NSGraphicsContext.restoreGraphicsState()
|
||||||
|
|
||||||
|
XCTAssertEqual(probed.count, pages.count)
|
||||||
|
for (page, rect) in probed {
|
||||||
|
XCTAssertEqual(
|
||||||
|
rect, view.destinationRect(forPage: page),
|
||||||
|
"page \(page): probe rect mismatch")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A dirty rect covering only page 2's band must draw only page 2.
|
||||||
|
func testDrawSkipsPagesOutsideDirtyRect() throws {
|
||||||
|
let view = TargetPageCanvasView(
|
||||||
|
pages: [raster(), raster(), raster()],
|
||||||
|
paperSize: paperSize)
|
||||||
|
|
||||||
|
let rep = try XCTUnwrap(NSBitmapImageRep(
|
||||||
|
bitmapDataPlanes: nil,
|
||||||
|
pixelsWide: Int(ceil(view.frame.width)),
|
||||||
|
pixelsHigh: Int(ceil(view.frame.height)),
|
||||||
|
bitsPerSample: 8,
|
||||||
|
samplesPerPixel: 4,
|
||||||
|
hasAlpha: true,
|
||||||
|
isPlanar: false,
|
||||||
|
colorSpaceName: .deviceRGB,
|
||||||
|
bytesPerRow: 0,
|
||||||
|
bitsPerPixel: 0))
|
||||||
|
let context = try XCTUnwrap(
|
||||||
|
NSGraphicsContext(bitmapImageRep: rep))
|
||||||
|
|
||||||
|
var probedPages: [Int] = []
|
||||||
|
view.drawProbe = { _, page, _ in probedPages.append(page) }
|
||||||
|
|
||||||
|
NSGraphicsContext.saveGraphicsState()
|
||||||
|
NSGraphicsContext.current = context
|
||||||
|
view.draw(view.rectForPage(2))
|
||||||
|
NSGraphicsContext.restoreGraphicsState()
|
||||||
|
|
||||||
|
XCTAssertEqual(probedPages, [2])
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,126 @@
|
|||||||
|
import CoreGraphics
|
||||||
|
import Foundation
|
||||||
|
import ImageIO
|
||||||
|
import UniformTypeIdentifiers
|
||||||
|
|
||||||
|
/// Shared TIFF fixture builder for the #201 raster / canvas / PDF
|
||||||
|
/// harness tests. Writes real TIFFs via `CGImageDestination` so the
|
||||||
|
/// loader exercises the same decode path as production.
|
||||||
|
enum TargetTestFixtures {
|
||||||
|
|
||||||
|
enum FixtureError: Error {
|
||||||
|
case imageNotCreated
|
||||||
|
case destinationNotCreated
|
||||||
|
case finalizeFailed
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Fresh per-test directory under the temp root.
|
||||||
|
static func makeTempDirectory() throws -> URL {
|
||||||
|
let url = FileManager.default.temporaryDirectory
|
||||||
|
.appendingPathComponent("iccery-raster-\(UUID().uuidString)")
|
||||||
|
try FileManager.default.createDirectory(
|
||||||
|
at: url, withIntermediateDirectories: true)
|
||||||
|
return url
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A solid-fill (or repeating-pattern) `CGImage` with a device
|
||||||
|
/// colour space for 1/3/4 components at 8 or 16 bpc. `alpha: true`
|
||||||
|
/// appends one alpha sample per pixel (`last`). `pixelBytes` is the
|
||||||
|
/// repeating per-pixel pattern (big-endian for 16 bpc).
|
||||||
|
static func makeImage(
|
||||||
|
px: CGSize,
|
||||||
|
components: Int,
|
||||||
|
bitsPerComponent: Int,
|
||||||
|
alpha: Bool = false,
|
||||||
|
pixelBytes: [UInt8]? = nil
|
||||||
|
) -> CGImage? {
|
||||||
|
let width = Int(px.width)
|
||||||
|
let height = Int(px.height)
|
||||||
|
let bytesPerComponent = bitsPerComponent / 8
|
||||||
|
let samples = components + (alpha ? 1 : 0)
|
||||||
|
let bytesPerPixel = samples * bytesPerComponent
|
||||||
|
let bytesPerRow = width * bytesPerPixel
|
||||||
|
let pattern = pixelBytes
|
||||||
|
?? Array(0..<bytesPerPixel).map { UInt8(($0 * 37 + 11) & 0xff) }
|
||||||
|
var row = [UInt8](repeating: 0, count: bytesPerRow)
|
||||||
|
for offset in stride(from: 0, to: bytesPerRow, by: pattern.count) {
|
||||||
|
for (index, byte) in pattern.enumerated()
|
||||||
|
where offset + index < bytesPerRow {
|
||||||
|
row[offset + index] = byte
|
||||||
|
}
|
||||||
|
}
|
||||||
|
var bytes = [UInt8]()
|
||||||
|
bytes.reserveCapacity(bytesPerRow * height)
|
||||||
|
for _ in 0..<height {
|
||||||
|
bytes.append(contentsOf: row)
|
||||||
|
}
|
||||||
|
let data = Data(bytes)
|
||||||
|
|
||||||
|
let space: CGColorSpace
|
||||||
|
switch components {
|
||||||
|
case 1: space = CGColorSpaceCreateDeviceGray()
|
||||||
|
case 3: space = CGColorSpaceCreateDeviceRGB()
|
||||||
|
case 4: space = CGColorSpaceCreateDeviceCMYK()
|
||||||
|
default: return nil
|
||||||
|
}
|
||||||
|
var info = CGBitmapInfo()
|
||||||
|
if bitsPerComponent == 16 {
|
||||||
|
info.insert(.byteOrder16Big)
|
||||||
|
}
|
||||||
|
if alpha {
|
||||||
|
info = CGBitmapInfo(
|
||||||
|
rawValue: info.rawValue | CGImageAlphaInfo.last.rawValue)
|
||||||
|
}
|
||||||
|
guard let provider = CGDataProvider(data: data as CFData)
|
||||||
|
else { return nil }
|
||||||
|
return CGImage(
|
||||||
|
width: width, height: height,
|
||||||
|
bitsPerComponent: bitsPerComponent,
|
||||||
|
bitsPerPixel: bitsPerComponent * samples,
|
||||||
|
bytesPerRow: bytesPerRow,
|
||||||
|
space: space,
|
||||||
|
bitmapInfo: info,
|
||||||
|
provider: provider,
|
||||||
|
decode: nil,
|
||||||
|
shouldInterpolate: false,
|
||||||
|
intent: .defaultIntent)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Writes `makeImage` output to a single-page TIFF. `dpi` nil
|
||||||
|
/// produces a TIFF with no resolution tags (the 72-fallback path).
|
||||||
|
static func makeTIFF(
|
||||||
|
px: CGSize,
|
||||||
|
dpi: Double?,
|
||||||
|
components: Int = 3,
|
||||||
|
bitsPerComponent: Int = 8,
|
||||||
|
alpha: Bool = false,
|
||||||
|
pixelBytes: [UInt8]? = nil,
|
||||||
|
in directory: URL
|
||||||
|
) throws -> URL {
|
||||||
|
guard let image = makeImage(
|
||||||
|
px: px, components: components,
|
||||||
|
bitsPerComponent: bitsPerComponent,
|
||||||
|
alpha: alpha, pixelBytes: pixelBytes)
|
||||||
|
else { throw FixtureError.imageNotCreated }
|
||||||
|
let url = directory.appendingPathComponent(
|
||||||
|
"fixture-\(UUID().uuidString).tiff")
|
||||||
|
guard let destination = CGImageDestinationCreateWithURL(
|
||||||
|
url as CFURL, UTType.tiff.identifier as CFString, 1, nil)
|
||||||
|
else { throw FixtureError.destinationNotCreated }
|
||||||
|
var properties: [CFString: Any] = [:]
|
||||||
|
if let dpi {
|
||||||
|
properties[kCGImagePropertyDPIWidth] = dpi
|
||||||
|
properties[kCGImagePropertyDPIHeight] = dpi
|
||||||
|
properties[kCGImagePropertyTIFFDictionary] = [
|
||||||
|
kCGImagePropertyTIFFXResolution: dpi,
|
||||||
|
kCGImagePropertyTIFFYResolution: dpi,
|
||||||
|
kCGImagePropertyTIFFResolutionUnit: 2, // inches
|
||||||
|
]
|
||||||
|
}
|
||||||
|
CGImageDestinationAddImage(
|
||||||
|
destination, image, properties as CFDictionary)
|
||||||
|
guard CGImageDestinationFinalize(destination)
|
||||||
|
else { throw FixtureError.finalizeFailed }
|
||||||
|
return url
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,241 @@
|
|||||||
|
import CoreGraphics
|
||||||
|
import Foundation
|
||||||
|
import ImageIO
|
||||||
|
import XCTest
|
||||||
|
@testable import ICCery
|
||||||
|
|
||||||
|
/// Issue #201 Phase 3 — `TargetRasterLoader` DPI handling, device
|
||||||
|
/// re-tag (D10), unsupported-layout rejection, and manifest drift (D9).
|
||||||
|
final class TargetRasterTests: XCTestCase {
|
||||||
|
|
||||||
|
private var tempRoot: URL!
|
||||||
|
|
||||||
|
override func setUpWithError() throws {
|
||||||
|
tempRoot = try TargetTestFixtures.makeTempDirectory()
|
||||||
|
}
|
||||||
|
|
||||||
|
override func tearDownWithError() throws {
|
||||||
|
try? FileManager.default.removeItem(at: tempRoot)
|
||||||
|
}
|
||||||
|
|
||||||
|
private func load(_ url: URL) throws -> TargetPageRaster {
|
||||||
|
try TargetRasterLoader.load(tiff: url)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Decode index 0 the same way the loader does, for provider-byte
|
||||||
|
/// comparisons that prove the re-tag did not resample.
|
||||||
|
private func decoded(_ url: URL) throws -> CGImage {
|
||||||
|
let source = try XCTUnwrap(
|
||||||
|
CGImageSourceCreateWithURL(url as CFURL, nil))
|
||||||
|
return try XCTUnwrap(
|
||||||
|
CGImageSourceCreateImageAtIndex(source, 0, nil))
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: - pointSize / physicalMm
|
||||||
|
|
||||||
|
func testPointSizeFromDPI() throws {
|
||||||
|
let url = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 2480, height: 3508), dpi: 300,
|
||||||
|
in: tempRoot)
|
||||||
|
let raster = try load(url)
|
||||||
|
XCTAssertEqual(raster.pointSize.width, 595.2, accuracy: 0.01)
|
||||||
|
XCTAssertEqual(raster.pointSize.height, 841.92, accuracy: 0.01)
|
||||||
|
XCTAssertEqual(raster.physicalMm.width, 209.97, accuracy: 0.01)
|
||||||
|
XCTAssertEqual(raster.physicalMm.height, 297.01, accuracy: 0.01)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testPointSizeAt600dpi() throws {
|
||||||
|
let url = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 1200, height: 1800), dpi: 600,
|
||||||
|
in: tempRoot)
|
||||||
|
let raster = try load(url)
|
||||||
|
XCTAssertEqual(raster.pointSize.width, 144, accuracy: 0.01)
|
||||||
|
XCTAssertEqual(raster.pointSize.height, 216, accuracy: 0.01)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testMissingDPIFallsBackTo72() throws {
|
||||||
|
let url = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 100, height: 80), dpi: nil,
|
||||||
|
in: tempRoot)
|
||||||
|
let raster = try load(url)
|
||||||
|
XCTAssertEqual(raster.dpiX, TargetRasterLoader.fallbackDPI)
|
||||||
|
XCTAssertEqual(raster.dpiY, TargetRasterLoader.fallbackDPI)
|
||||||
|
XCTAssertEqual(raster.pointSize.width, 100, accuracy: 0.01)
|
||||||
|
XCTAssertEqual(raster.pointSize.height, 80, accuracy: 0.01)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testMissingFileThrows() {
|
||||||
|
let url = tempRoot.appendingPathComponent("nope.tiff")
|
||||||
|
XCTAssertThrowsError(try load(url)) { error in
|
||||||
|
XCTAssertEqual(
|
||||||
|
error as? TargetRasterError,
|
||||||
|
.tiffMissing(url.path))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func testGarbageFileThrowsUndecodable() throws {
|
||||||
|
let url = tempRoot.appendingPathComponent("junk.tiff")
|
||||||
|
try Data([0x00, 0x01, 0x02, 0x03]).write(to: url)
|
||||||
|
XCTAssertThrowsError(try load(url)) { error in
|
||||||
|
XCTAssertEqual(
|
||||||
|
error as? TargetRasterError,
|
||||||
|
.undecodable(url.path))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: - deviceTagged (D10)
|
||||||
|
|
||||||
|
func testDeviceTaggedRGB8() throws {
|
||||||
|
let source = try XCTUnwrap(TargetTestFixtures.makeImage(
|
||||||
|
px: CGSize(width: 16, height: 16),
|
||||||
|
components: 3, bitsPerComponent: 8))
|
||||||
|
let tagged = try XCTUnwrap(
|
||||||
|
TargetRasterLoader.deviceTagged(source))
|
||||||
|
XCTAssertEqual(tagged.colorSpace?.model, .rgb)
|
||||||
|
XCTAssertEqual(tagged.bitsPerComponent, 8)
|
||||||
|
XCTAssertFalse(tagged.shouldInterpolate)
|
||||||
|
XCTAssertEqual(
|
||||||
|
tagged.dataProvider?.data as? Data,
|
||||||
|
source.dataProvider?.data as? Data)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testDeviceTaggedCMYK8() throws {
|
||||||
|
let source = try XCTUnwrap(TargetTestFixtures.makeImage(
|
||||||
|
px: CGSize(width: 16, height: 16),
|
||||||
|
components: 4, bitsPerComponent: 8))
|
||||||
|
let tagged = try XCTUnwrap(
|
||||||
|
TargetRasterLoader.deviceTagged(source))
|
||||||
|
XCTAssertEqual(tagged.colorSpace?.model, .cmyk)
|
||||||
|
XCTAssertEqual(tagged.bitsPerComponent, 8)
|
||||||
|
XCTAssertEqual(
|
||||||
|
tagged.dataProvider?.data as? Data,
|
||||||
|
source.dataProvider?.data as? Data)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testDeviceTaggedGray8() throws {
|
||||||
|
let source = try XCTUnwrap(TargetTestFixtures.makeImage(
|
||||||
|
px: CGSize(width: 16, height: 16),
|
||||||
|
components: 1, bitsPerComponent: 8))
|
||||||
|
let tagged = try XCTUnwrap(
|
||||||
|
TargetRasterLoader.deviceTagged(source))
|
||||||
|
XCTAssertEqual(tagged.colorSpace?.model, .monochrome)
|
||||||
|
XCTAssertEqual(tagged.bitsPerComponent, 8)
|
||||||
|
XCTAssertEqual(
|
||||||
|
tagged.dataProvider?.data as? Data,
|
||||||
|
source.dataProvider?.data as? Data)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testDeviceTaggedRGB16KeepsBitDepth() throws {
|
||||||
|
let source = try XCTUnwrap(TargetTestFixtures.makeImage(
|
||||||
|
px: CGSize(width: 16, height: 16),
|
||||||
|
components: 3, bitsPerComponent: 16))
|
||||||
|
let tagged = try XCTUnwrap(
|
||||||
|
TargetRasterLoader.deviceTagged(source))
|
||||||
|
XCTAssertEqual(tagged.colorSpace?.model, .rgb)
|
||||||
|
XCTAssertEqual(tagged.bitsPerComponent, 16)
|
||||||
|
XCTAssertEqual(
|
||||||
|
tagged.dataProvider?.data as? Data,
|
||||||
|
source.dataProvider?.data as? Data)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The loaded raster reuses the decoder's provider verbatim — byte
|
||||||
|
/// equality is the no-resample guarantee (R5).
|
||||||
|
func testLoadedRasterSharesDecodedBytes() throws {
|
||||||
|
let url = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 32, height: 24), dpi: 300,
|
||||||
|
in: tempRoot)
|
||||||
|
let raster = try load(url)
|
||||||
|
let decoded = try decoded(url)
|
||||||
|
XCTAssertEqual(
|
||||||
|
raster.cgImage.dataProvider?.data as? Data,
|
||||||
|
decoded.dataProvider?.data as? Data)
|
||||||
|
XCTAssertEqual(raster.cgImage.colorSpace?.model, .rgb)
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: - Rejections
|
||||||
|
|
||||||
|
func testAlphaTIFFThrowsUnsupportedLayout() throws {
|
||||||
|
let url = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 16, height: 16), dpi: 300,
|
||||||
|
components: 3, alpha: true, in: tempRoot)
|
||||||
|
XCTAssertThrowsError(try load(url)) { error in
|
||||||
|
guard case .unsupportedLayout(_, _, _, let hasAlpha) =
|
||||||
|
error as? TargetRasterError
|
||||||
|
else {
|
||||||
|
return XCTFail("expected unsupportedLayout, got \(error)")
|
||||||
|
}
|
||||||
|
XCTAssertTrue(hasAlpha)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func testDeviceTaggedRejectsFloat() throws {
|
||||||
|
var info = CGBitmapInfo(rawValue: CGImageAlphaInfo.none.rawValue)
|
||||||
|
info.insert(.floatComponents)
|
||||||
|
info.insert(.byteOrder32Little)
|
||||||
|
var bytes = [Float](repeating: 0.5, count: 4 * 4 * 3)
|
||||||
|
let floatImage = bytes.withUnsafeMutableBytes { buffer -> CGImage? in
|
||||||
|
CGImage(
|
||||||
|
width: 4, height: 4,
|
||||||
|
bitsPerComponent: 32, bitsPerPixel: 96,
|
||||||
|
bytesPerRow: 4 * 3 * 4,
|
||||||
|
space: CGColorSpaceCreateDeviceRGB(),
|
||||||
|
bitmapInfo: info,
|
||||||
|
provider: CGDataProvider(data: Data(buffer) as CFData)!,
|
||||||
|
decode: nil, shouldInterpolate: false,
|
||||||
|
intent: .defaultIntent)
|
||||||
|
}
|
||||||
|
bytes = []
|
||||||
|
let image = try XCTUnwrap(floatImage)
|
||||||
|
XCTAssertNil(TargetRasterLoader.deviceTagged(image))
|
||||||
|
}
|
||||||
|
|
||||||
|
func testDeviceTaggedRejectsIndexed() throws {
|
||||||
|
var table = [UInt8](repeating: 0, count: 256 * 3)
|
||||||
|
let indexed = try XCTUnwrap(CGColorSpace(
|
||||||
|
indexedBaseSpace: CGColorSpaceCreateDeviceRGB(),
|
||||||
|
last: 255, colorTable: &table))
|
||||||
|
let image = try XCTUnwrap(CGImage(
|
||||||
|
width: 8, height: 8,
|
||||||
|
bitsPerComponent: 8, bitsPerPixel: 8,
|
||||||
|
bytesPerRow: 8,
|
||||||
|
space: indexed,
|
||||||
|
bitmapInfo: CGBitmapInfo(),
|
||||||
|
provider: CGDataProvider(
|
||||||
|
data: Data(repeating: 7, count: 64) as CFData)!,
|
||||||
|
decode: nil, shouldInterpolate: false,
|
||||||
|
intent: .defaultIntent))
|
||||||
|
XCTAssertNil(TargetRasterLoader.deviceTagged(image))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// No 2-component `CGImage` is fabricatable through public API —
|
||||||
|
/// the rejection lives in `deviceSpace(for:)`, asserted here.
|
||||||
|
func testDeviceSpaceRejectsTwoAndFiveComponents() {
|
||||||
|
XCTAssertNil(TargetRasterLoader.deviceSpace(for: 2))
|
||||||
|
XCTAssertNil(TargetRasterLoader.deviceSpace(for: 0))
|
||||||
|
XCTAssertNil(TargetRasterLoader.deviceSpace(for: 5))
|
||||||
|
XCTAssertNotNil(TargetRasterLoader.deviceSpace(for: 1))
|
||||||
|
XCTAssertNotNil(TargetRasterLoader.deviceSpace(for: 3))
|
||||||
|
XCTAssertNotNil(TargetRasterLoader.deviceSpace(for: 4))
|
||||||
|
}
|
||||||
|
|
||||||
|
// MARK: - Manifest drift (D9)
|
||||||
|
|
||||||
|
func testManifestDriftWhenMismatch() throws {
|
||||||
|
let url = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 2480, height: 3508), dpi: 300,
|
||||||
|
in: tempRoot)
|
||||||
|
let raster = try TargetRasterLoader.load(
|
||||||
|
tiff: url, expectedWidthMm: 200, expectedHeightMm: 297)
|
||||||
|
XCTAssertNotNil(raster.manifestDrift)
|
||||||
|
}
|
||||||
|
|
||||||
|
func testManifestDriftNilWhenMatching() throws {
|
||||||
|
let url = try TargetTestFixtures.makeTIFF(
|
||||||
|
px: CGSize(width: 2480, height: 3508), dpi: 300,
|
||||||
|
in: tempRoot)
|
||||||
|
// 2480 px @300 dpi = 209.97 mm — inside the 0.5 mm band.
|
||||||
|
let raster = try TargetRasterLoader.load(
|
||||||
|
tiff: url, expectedWidthMm: 210, expectedHeightMm: 297)
|
||||||
|
XCTAssertNil(raster.manifestDrift)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,196 @@
|
|||||||
|
import XCTest
|
||||||
|
@testable import ICCeryCore
|
||||||
|
@testable import ICCery
|
||||||
|
|
||||||
|
/// Issue #201 Phase 4 — the resolved ticket-write list that replaces
|
||||||
|
/// the `lp` argv goldens: locked order 1–10, D6 (Stage 2 always
|
||||||
|
/// wins), `raw` can never appear.
|
||||||
|
final class TicketWriteResolverTests: XCTestCase {
|
||||||
|
|
||||||
|
private func resolve(
|
||||||
|
overrides: TargetPrintOverrides = TargetPrintOverrides(),
|
||||||
|
optionKeys: Set<String> = []
|
||||||
|
) -> ResolvedTicketWrites {
|
||||||
|
TicketWriteResolver.resolve(
|
||||||
|
overrides: overrides, optionKeys: optionKeys)
|
||||||
|
}
|
||||||
|
|
||||||
|
private func keys(_ r: ResolvedTicketWrites) -> [String] {
|
||||||
|
r.writes.map(\.key)
|
||||||
|
}
|
||||||
|
|
||||||
|
private func value(
|
||||||
|
_ key: String, in r: ResolvedTicketWrites
|
||||||
|
) -> String? {
|
||||||
|
r.writes.first { $0.key == key }?.value
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Both AP_* spellings are always present and locked; all three
|
||||||
|
/// Quartz keys are always present (D2 dual vocabulary).
|
||||||
|
func testColourKeysAlwaysPresent() {
|
||||||
|
let r = resolve()
|
||||||
|
let ap = r.writes.filter {
|
||||||
|
ColorMatchingAttempts.printSettingsKeys.contains($0.key)
|
||||||
|
}
|
||||||
|
XCTAssertEqual(ap.count, 2)
|
||||||
|
XCTAssertTrue(ap.allSatisfy {
|
||||||
|
$0.locked
|
||||||
|
&& $0.value == "AP_ApplicationColorMatching"
|
||||||
|
})
|
||||||
|
XCTAssertEqual(value("PMColorMatchingMode", in: r),
|
||||||
|
"APCustomColorMatching")
|
||||||
|
XCTAssertEqual(value("PMCustomColorMatchingProfile", in: r), "")
|
||||||
|
XCTAssertEqual(
|
||||||
|
value("com.apple.print.PrintSettings.PMColorMatchingMode",
|
||||||
|
in: r),
|
||||||
|
"APCustomColorMatching")
|
||||||
|
// The Quartz mode key is locked; profile + legacy key are not.
|
||||||
|
XCTAssertTrue(r.writes.first { $0.key == "PMColorMatchingMode" }!
|
||||||
|
.locked)
|
||||||
|
XCTAssertFalse(r.writes.first {
|
||||||
|
$0.key == "PMCustomColorMatchingProfile" }!.locked)
|
||||||
|
XCTAssertFalse(r.writes.first {
|
||||||
|
$0.key == "com.apple.print.PrintSettings.PMColorMatchingMode"
|
||||||
|
}!.locked)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// `raw` can never appear — there is no `lp` and the resolver has
|
||||||
|
/// no captured-options input that could smuggle it in (#92).
|
||||||
|
func testRawNeverAppears() {
|
||||||
|
for optionKeys in [Set<String>(), ["raw"],
|
||||||
|
["MediaType", "raw"]] {
|
||||||
|
let r = resolve(
|
||||||
|
overrides: TargetPrintOverrides(
|
||||||
|
paperSize: "raw", mediaType: "raw",
|
||||||
|
qualityKey: "raw", quality: "raw",
|
||||||
|
orientation: "raw"),
|
||||||
|
optionKeys: optionKeys)
|
||||||
|
XCTAssertFalse(r.writes.contains {
|
||||||
|
$0.key.lowercased() == "raw"
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// D6 inversion — the deleted argv builder suppressed the Stage 2
|
||||||
|
/// value when the captured string already carried the key (the old
|
||||||
|
/// media branch at `build`'s line 81). There is no captured-wins
|
||||||
|
/// path any more:
|
||||||
|
/// the explicit Stage 2 value is emitted unconditionally.
|
||||||
|
func testStage2MediaTypeAlwaysWins() {
|
||||||
|
let r = resolve(
|
||||||
|
overrides: TargetPrintOverrides(mediaType: "Matte"),
|
||||||
|
optionKeys: ["MediaType"])
|
||||||
|
XCTAssertEqual(value("MediaType", in: r), "Matte")
|
||||||
|
// …and likewise for a vendor key — nothing consults captured
|
||||||
|
// options before writing.
|
||||||
|
let epson = resolve(
|
||||||
|
overrides: TargetPrintOverrides(mediaType: "Matte"),
|
||||||
|
optionKeys: ["EPIJ_Medi"])
|
||||||
|
XCTAssertEqual(value("EPIJ_Medi", in: epson), "Matte")
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Vendor media-key selection follows `CupsParsers.mediaTypeKeys`:
|
||||||
|
/// `EPIJ_Medi` is picked when present; `CNIJMediaType` beats
|
||||||
|
/// `MediaType`.
|
||||||
|
func testVendorMediaKeySelection() {
|
||||||
|
let epson = resolve(
|
||||||
|
overrides: TargetPrintOverrides(mediaType: "Photo"),
|
||||||
|
optionKeys: ["EPIJ_Medi", "MediaType"])
|
||||||
|
XCTAssertEqual(value("EPIJ_Medi", in: epson), "Photo")
|
||||||
|
XCTAssertNil(value("MediaType", in: epson))
|
||||||
|
|
||||||
|
let canon = resolve(
|
||||||
|
overrides: TargetPrintOverrides(mediaType: "Photo"),
|
||||||
|
optionKeys: ["CNIJMediaType", "MediaType"])
|
||||||
|
XCTAssertEqual(value("CNIJMediaType", in: canon), "Photo")
|
||||||
|
XCTAssertNil(value("MediaType", in: canon))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Driver "no colour adjustment" bypass — Canon, Epson (CCor
|
||||||
|
/// preferred over CMat), Gutenprint — always unlocked and never
|
||||||
|
/// gated on `ppdUncorrectedPassthrough`.
|
||||||
|
func testDriverBypass() {
|
||||||
|
let canon = resolve(optionKeys: ["CNIJIntent2"])
|
||||||
|
XCTAssertEqual(value("CNIJIntent2", in: canon), "4")
|
||||||
|
XCTAssertFalse(canon.writes.first { $0.key == "CNIJIntent2" }!
|
||||||
|
.locked)
|
||||||
|
|
||||||
|
let epson = resolve(optionKeys: ["EPIJ_CCor", "EPIJ_CMat"])
|
||||||
|
XCTAssertEqual(value("EPIJ_CCor", in: epson), "0")
|
||||||
|
XCTAssertNil(value("EPIJ_CMat", in: epson))
|
||||||
|
|
||||||
|
let epsonMat = resolve(optionKeys: ["EPIJ_CMat"])
|
||||||
|
XCTAssertEqual(value("EPIJ_CMat", in: epsonMat), "3")
|
||||||
|
|
||||||
|
let gutenprint = resolve(optionKeys: ["StpColorCorrection"])
|
||||||
|
XCTAssertEqual(value("StpColorCorrection", in: gutenprint),
|
||||||
|
"Uncorrected")
|
||||||
|
|
||||||
|
XCTAssertNil(value("EPIJ_CMat", in: resolve()))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Orientation: landscape → 4, portrait → 3, nil → no write.
|
||||||
|
func testOrientation() {
|
||||||
|
XCTAssertEqual(
|
||||||
|
value("orientation-requested", in: resolve(
|
||||||
|
overrides: TargetPrintOverrides(
|
||||||
|
orientation: "landscape"))),
|
||||||
|
"4")
|
||||||
|
XCTAssertEqual(
|
||||||
|
value("orientation-requested", in: resolve(
|
||||||
|
overrides: TargetPrintOverrides(
|
||||||
|
orientation: "portrait"))),
|
||||||
|
"3")
|
||||||
|
XCTAssertNil(value("orientation-requested", in: resolve()))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A `nil` override emits no write for that key; quality needs
|
||||||
|
/// **both** the detected key and the value.
|
||||||
|
func testNilOverridesEmitNoWrite() {
|
||||||
|
let r = resolve(optionKeys: ["MediaType", "EPIJ_Qual"])
|
||||||
|
XCTAssertNil(value("PageSize", in: r))
|
||||||
|
XCTAssertNil(value("MediaType", in: r))
|
||||||
|
XCTAssertNil(value("EPIJ_Qual", in: r))
|
||||||
|
XCTAssertNil(value("orientation-requested", in: r))
|
||||||
|
XCTAssertNil(r.paperToken)
|
||||||
|
XCTAssertNil(r.orientation)
|
||||||
|
|
||||||
|
let keyOnly = resolve(
|
||||||
|
overrides: TargetPrintOverrides(qualityKey: "EPIJ_Qual"),
|
||||||
|
optionKeys: ["EPIJ_Qual"])
|
||||||
|
XCTAssertNil(value("EPIJ_Qual", in: keyOnly))
|
||||||
|
let valueOnly = resolve(
|
||||||
|
overrides: TargetPrintOverrides(quality: "305"),
|
||||||
|
optionKeys: ["EPIJ_Qual"])
|
||||||
|
XCTAssertNil(value("EPIJ_Qual", in: valueOnly))
|
||||||
|
// An empty paper token emits no write and no paperToken.
|
||||||
|
let emptyPaper = resolve(
|
||||||
|
overrides: TargetPrintOverrides(paperSize: ""))
|
||||||
|
XCTAssertNil(value("PageSize", in: emptyPaper))
|
||||||
|
XCTAssertNil(emptyPaper.paperToken)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The write list equals the locked 1–10 order, exactly.
|
||||||
|
func testLockedWriteOrder() {
|
||||||
|
let r = resolve(
|
||||||
|
overrides: TargetPrintOverrides(
|
||||||
|
paperSize: "A4", mediaType: "Photo",
|
||||||
|
qualityKey: "EPIJ_Qual", quality: "305",
|
||||||
|
orientation: "landscape"),
|
||||||
|
optionKeys: ["MediaType", "EPIJ_Qual", "EPIJ_CMat"])
|
||||||
|
XCTAssertEqual(keys(r), [
|
||||||
|
"AP_ColorMatchingMode",
|
||||||
|
"AP.ColorMatchingMode",
|
||||||
|
"PMColorMatchingMode",
|
||||||
|
"PMCustomColorMatchingProfile",
|
||||||
|
"com.apple.print.PrintSettings.PMColorMatchingMode",
|
||||||
|
"PageSize",
|
||||||
|
"MediaType",
|
||||||
|
"EPIJ_Qual",
|
||||||
|
"EPIJ_CMat",
|
||||||
|
"orientation-requested",
|
||||||
|
])
|
||||||
|
XCTAssertEqual(r.paperToken, "A4")
|
||||||
|
XCTAssertEqual(r.orientation, "landscape")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,14 +0,0 @@
|
|||||||
#!/bin/sh
|
|
||||||
# Mock lp for Milestone3UITests. Appends its full argv to
|
|
||||||
# ICCERY_TEST_LP_ARGV so the test can assert flag order and option
|
|
||||||
# replay, then exits 0 (or ICCERY_MOCK_LP_EXIT for failure injection).
|
|
||||||
{
|
|
||||||
printf 'lp'
|
|
||||||
for arg in "$@"; do printf ' %s' "$arg"; done
|
|
||||||
printf '\n'
|
|
||||||
} >> "${ICCERY_TEST_LP_ARGV:-/dev/null}"
|
|
||||||
if [ "${ICCERY_MOCK_LP_EXIT:-0}" -ne 0 ]; then
|
|
||||||
echo "mock lp failure" >&2
|
|
||||||
exit "$ICCERY_MOCK_LP_EXIT"
|
|
||||||
fi
|
|
||||||
exit 0
|
|
||||||
@@ -1,6 +1,8 @@
|
|||||||
#!/bin/sh
|
#!/bin/sh
|
||||||
# Mock printtarg for Milestone2UITests. Writes one 2x2 TIFF, a pretty
|
# Mock printtarg for Milestone2UITests. Writes N 2x2 TIFFs, a pretty
|
||||||
# manifest on stdout, and a fake .ti2 next to the basename (last argv).
|
# manifest on stdout, and a fake .ti2 next to the basename (last argv).
|
||||||
|
# N defaults to 1; ICCERY_MOCK_PRINTTARG_PAGES raises it for the
|
||||||
|
# single-spool-job granularity test (#201 D5).
|
||||||
# Exit code is overridable via ICCERY_MOCK_PRINTTARG_EXIT.
|
# Exit code is overridable via ICCERY_MOCK_PRINTTARG_EXIT.
|
||||||
last=""
|
last=""
|
||||||
for arg in "$@"; do last="$arg"; done
|
for arg in "$@"; do last="$arg"; done
|
||||||
@@ -8,7 +10,16 @@ if [ "${ICCERY_MOCK_PRINTTARG_EXIT:-0}" -ne 0 ]; then
|
|||||||
echo "mock printtarg failure" >&2
|
echo "mock printtarg failure" >&2
|
||||||
exit "$ICCERY_MOCK_PRINTTARG_EXIT"
|
exit "$ICCERY_MOCK_PRINTTARG_EXIT"
|
||||||
fi
|
fi
|
||||||
echo 'SUkqAAgAAAAKAAABAwABAAAAAgAAAAEBAwABAAAAAgAAAAIBAwABAAAACAAAAAMBAwABAAAAAQAAAAYBAwABAAAAAQAAABEBBAABAAAAhgAAABUBAwABAAAAAQAAABYBAwABAAAAAgAAABcBBAABAAAABAAAABwBAwABAAAAAQAAAAAAAAA8eLTw' | /usr/bin/base64 -D > "page1.tif"
|
pages="${ICCERY_MOCK_PRINTTARG_PAGES:-1}"
|
||||||
printf '{\n "event": "manifest",\n "pages": [\n {"filename": "page1.tif", "patches": 4, "width_mm": 210, "height_mm": 297}\n ]\n}\n'
|
i=1
|
||||||
|
printf '{\n "event": "manifest",\n "pages": [\n'
|
||||||
|
while [ "$i" -le "$pages" ]; do
|
||||||
|
echo 'SUkqAAgAAAAKAAABAwABAAAAAgAAAAEBAwABAAAAAgAAAAIBAwABAAAACAAAAAMBAwABAAAAAQAAAAYBAwABAAAAAQAAABEBBAABAAAAhgAAABUBAwABAAAAAQAAABYBAwABAAAAAgAAABcBBAABAAAABAAAABwBAwABAAAAAQAAAAAAAAA8eLTw' | /usr/bin/base64 -D > "page$i.tif"
|
||||||
|
sep=","
|
||||||
|
if [ "$i" -eq "$pages" ]; then sep=""; fi
|
||||||
|
printf ' {"filename": "page%s.tif", "patches": 4, "width_mm": 210, "height_mm": 297}%s\n' "$i" "$sep"
|
||||||
|
i=$((i + 1))
|
||||||
|
done
|
||||||
|
printf ' ]\n}\n'
|
||||||
touch "$last.ti2"
|
touch "$last.ti2"
|
||||||
exit 0
|
exit 0
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ final class Milestone11PrintSettingsUITests: XCTestCase {
|
|||||||
private var testRoot: URL!
|
private var testRoot: URL!
|
||||||
private var binDir: URL!
|
private var binDir: URL!
|
||||||
private var workDir: URL!
|
private var workDir: URL!
|
||||||
private var lpArgvURL: URL!
|
private var spoolLogURL: URL!
|
||||||
|
|
||||||
override func setUp() async throws {
|
override func setUp() async throws {
|
||||||
continueAfterFailure = false
|
continueAfterFailure = false
|
||||||
@@ -21,7 +21,7 @@ final class Milestone11PrintSettingsUITests: XCTestCase {
|
|||||||
.deletingLastPathComponent()
|
.deletingLastPathComponent()
|
||||||
.appendingPathComponent("Fixtures/bin")
|
.appendingPathComponent("Fixtures/bin")
|
||||||
workDir = testRoot.appendingPathComponent("work")
|
workDir = testRoot.appendingPathComponent("work")
|
||||||
lpArgvURL = testRoot.appendingPathComponent("lp-argv.log")
|
spoolLogURL = testRoot.appendingPathComponent("spool.log")
|
||||||
try FileManager.default.createDirectory(
|
try FileManager.default.createDirectory(
|
||||||
at: workDir, withIntermediateDirectories: true)
|
at: workDir, withIntermediateDirectories: true)
|
||||||
|
|
||||||
@@ -34,7 +34,7 @@ final class Milestone11PrintSettingsUITests: XCTestCase {
|
|||||||
"ICCERY_TEST_SAVE_TARGET":
|
"ICCERY_TEST_SAVE_TARGET":
|
||||||
workDir.appendingPathComponent("mytarget.ti1").path,
|
workDir.appendingPathComponent("mytarget.ti1").path,
|
||||||
"ICCERY_TEST_WORKDIR": workDir.path,
|
"ICCERY_TEST_WORKDIR": workDir.path,
|
||||||
"ICCERY_TEST_LP_ARGV": lpArgvURL.path,
|
"ICCERY_TEST_SPOOL_LOG": spoolLogURL.path,
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -75,14 +75,33 @@ final class Milestone11PrintSettingsUITests: XCTestCase {
|
|||||||
_ = waitFor("galleryPage-0", timeout: 25)
|
_ = waitFor("galleryPage-0", timeout: 25)
|
||||||
}
|
}
|
||||||
|
|
||||||
private func waitForLpLine(_ timeout: TimeInterval = 10) -> String {
|
private func spoolLogLines() -> [String] {
|
||||||
|
((try? String(contentsOf: spoolLogURL, encoding: .utf8)) ?? "")
|
||||||
|
.split(separator: "\n").map(String.init)
|
||||||
|
}
|
||||||
|
|
||||||
|
private func waitForSpoolLine(_ timeout: TimeInterval = 10) -> String {
|
||||||
let deadline = Date().addingTimeInterval(timeout)
|
let deadline = Date().addingTimeInterval(timeout)
|
||||||
while Date() < deadline {
|
while Date() < deadline {
|
||||||
let out = (try? String(contentsOf: lpArgvURL, encoding: .utf8)) ?? ""
|
let lines = spoolLogLines()
|
||||||
if !out.isEmpty { return out }
|
if !lines.isEmpty { return lines.joined(separator: "\n") }
|
||||||
RunLoop.current.run(until: Date().addingTimeInterval(0.1))
|
RunLoop.current.run(until: Date().addingTimeInterval(0.1))
|
||||||
}
|
}
|
||||||
return (try? String(contentsOf: lpArgvURL, encoding: .utf8)) ?? ""
|
return spoolLogLines().joined(separator: "\n")
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Poll until the spool log holds at least `count` lines.
|
||||||
|
@discardableResult
|
||||||
|
private func waitForSpoolLineCount(
|
||||||
|
_ count: Int, timeout: TimeInterval = 15
|
||||||
|
) -> [String] {
|
||||||
|
let deadline = Date().addingTimeInterval(timeout)
|
||||||
|
while Date() < deadline {
|
||||||
|
let lines = spoolLogLines()
|
||||||
|
if lines.count >= count { return lines }
|
||||||
|
RunLoop.current.run(until: Date().addingTimeInterval(0.1))
|
||||||
|
}
|
||||||
|
return spoolLogLines()
|
||||||
}
|
}
|
||||||
|
|
||||||
// MARK: - Tests
|
// MARK: - Tests
|
||||||
@@ -163,8 +182,8 @@ final class Milestone11PrintSettingsUITests: XCTestCase {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// The stubbed panel result's captured `PageSize=`/`EPIJ_Qual=`
|
/// The stubbed panel result's captured `PageSize=`/`EPIJ_Qual=`
|
||||||
/// apply back into the Stage 2 pickers and reach the `lp` argv
|
/// apply back into the Stage 2 pickers and reach the recorded
|
||||||
/// (R15 — the real modal is never driven).
|
/// ticket writes (#201 — the real modal is never driven).
|
||||||
func testPanelResultAppliesBackToPickers() throws {
|
func testPanelResultAppliesBackToPickers() throws {
|
||||||
app.launchEnvironment["ICCERY_TEST_PRINT_PANEL"] = "ok"
|
app.launchEnvironment["ICCERY_TEST_PRINT_PANEL"] = "ok"
|
||||||
app.launchEnvironment["ICCERY_TEST_PANEL_OPTIONS"] =
|
app.launchEnvironment["ICCERY_TEST_PANEL_OPTIONS"] =
|
||||||
@@ -183,9 +202,80 @@ final class Milestone11PrintSettingsUITests: XCTestCase {
|
|||||||
XCTAssertEqual(selection(of: "printerQualitySelect"), "305")
|
XCTAssertEqual(selection(of: "printerQualitySelect"), "305")
|
||||||
|
|
||||||
app.buttons["btnPrintAll"].click()
|
app.buttons["btnPrintAll"].click()
|
||||||
let argv = waitForLpLine()
|
let log = waitForSpoolLine()
|
||||||
XCTAssertTrue(argv.contains("PageSize=Letter"), argv)
|
XCTAssertTrue(log.contains("PageSize=Letter"), log)
|
||||||
XCTAssertTrue(argv.contains("EPIJ_Qual=305"), argv)
|
XCTAssertTrue(log.contains("EPIJ_Qual=305"), log)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// #186 — the stubbed panel result's `orientation-requested=` /
|
||||||
|
/// `MediaType=` apply back to the Stage 2 selections and reach the
|
||||||
|
/// recorded ticket writes via the Stage 2 overrides (#201 D6).
|
||||||
|
func testPanelResultAppliesBackOrientationAndMedia() throws {
|
||||||
|
app.launchEnvironment["ICCERY_TEST_PRINT_PANEL"] = "ok"
|
||||||
|
app.launchEnvironment["ICCERY_TEST_PANEL_OPTIONS"] =
|
||||||
|
"PageSize=Letter EPIJ_Qual=305 orientation-requested=4 MediaType=PhotographicGlossy"
|
||||||
|
launchAppWithDefaults()
|
||||||
|
reachPrintPanel()
|
||||||
|
_ = waitFor("printerStatusBadge")
|
||||||
|
|
||||||
|
element("btnPrinterProperties").click()
|
||||||
|
let notice = element("printNotificationText")
|
||||||
|
XCTAssertTrue(notice.waitForExistence(timeout: 10))
|
||||||
|
XCTAssertTrue((notice.value as? String ?? "")
|
||||||
|
.contains("Settings captured"))
|
||||||
|
|
||||||
|
// `printerMediaTypeSelect` is the group's id — the popup is a
|
||||||
|
// descendant (stacked identifiers collapse to the container).
|
||||||
|
// The popup's AX title lags the binding — poll for the
|
||||||
|
// apply-back value.
|
||||||
|
let mediaPopup = element("printerMediaTypeSelect")
|
||||||
|
.descendants(matching: .popUpButton).firstMatch
|
||||||
|
XCTAssertTrue(mediaPopup.waitForExistence(timeout: 5))
|
||||||
|
var mediaSelection = ""
|
||||||
|
let deadline = Date().addingTimeInterval(10)
|
||||||
|
while Date() < deadline, mediaSelection != "PhotographicGlossy" {
|
||||||
|
mediaSelection = [
|
||||||
|
mediaPopup.title, mediaPopup.label,
|
||||||
|
mediaPopup.value as? String ?? "",
|
||||||
|
].first { !$0.isEmpty } ?? ""
|
||||||
|
RunLoop.current.run(until: Date().addingTimeInterval(0.2))
|
||||||
|
}
|
||||||
|
XCTAssertEqual(mediaSelection, "PhotographicGlossy")
|
||||||
|
XCTAssertEqual(selection(of: "printerPaperSizeSelect"), "Letter")
|
||||||
|
|
||||||
|
app.buttons["btnPrintAll"].click()
|
||||||
|
let log = waitForSpoolLine()
|
||||||
|
XCTAssertTrue(log.contains("orientation-requested=4"), log)
|
||||||
|
XCTAssertTrue(log.contains("MediaType=PhotographicGlossy"), log)
|
||||||
|
XCTAssertTrue(log.contains("PageSize=Letter"), log)
|
||||||
|
XCTAssertTrue(log.contains("EPIJ_Qual=305"), log)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// #201 D5 — per-page mode records one line per page; the
|
||||||
|
/// `chkSingleSpoolJob` toggle collapses the job into a single
|
||||||
|
/// request logged once with `pages=N`.
|
||||||
|
func testSingleSpoolJobTogglesGranularity() throws {
|
||||||
|
app.launchEnvironment["ICCERY_MOCK_PRINTTARG_PAGES"] = "2"
|
||||||
|
launchAppWithDefaults()
|
||||||
|
reachPrintPanel()
|
||||||
|
_ = waitFor("printerStatusBadge")
|
||||||
|
XCTAssertTrue(element("chkSingleSpoolJob").exists)
|
||||||
|
|
||||||
|
// Default off → one request per page → one line per page.
|
||||||
|
app.buttons["btnPrintAll"].click()
|
||||||
|
var lines = waitForSpoolLineCount(2)
|
||||||
|
XCTAssertEqual(lines.count, 2)
|
||||||
|
XCTAssertTrue(lines.allSatisfy { $0.contains("pages=1") },
|
||||||
|
lines.joined(separator: "\n"))
|
||||||
|
|
||||||
|
// Toggle on → one request for all pages → a single line.
|
||||||
|
element("chkSingleSpoolJob").click()
|
||||||
|
app.buttons["btnPrintAll"].click()
|
||||||
|
lines = waitForSpoolLineCount(3)
|
||||||
|
XCTAssertEqual(lines.count, 3)
|
||||||
|
XCTAssertEqual(
|
||||||
|
lines.filter { $0.contains("pages=2") }.count, 1,
|
||||||
|
lines.joined(separator: "\n"))
|
||||||
}
|
}
|
||||||
|
|
||||||
private func launchAppWithDefaults() {
|
private func launchAppWithDefaults() {
|
||||||
|
|||||||
@@ -3,9 +3,10 @@ import XCTest
|
|||||||
/// Milestone 3 UI tests — issue #17 print panel end-to-end with mock
|
/// Milestone 3 UI tests — issue #17 print panel end-to-end with mock
|
||||||
/// CUPS binaries and a stubbed `NSPrintPanel`. The real panel is a
|
/// CUPS binaries and a stubbed `NSPrintPanel`. The real panel is a
|
||||||
/// system modal XCUITest cannot drive; `ICCERY_TEST_PRINT_PANEL`
|
/// system modal XCUITest cannot drive; `ICCERY_TEST_PRINT_PANEL`
|
||||||
/// returns a canned `PrintPropertiesResult` instead. Mock `lp` appends
|
/// returns a canned `PrintPropertiesResult` instead. The DEBUG
|
||||||
/// its argv to `ICCERY_TEST_LP_ARGV` for assertions — that file is the
|
/// `RecordingTargetSpooler` appends one resolved-ticket line per
|
||||||
/// evidence that captured options are replayed (docs/11 §tests).
|
/// request to `ICCERY_TEST_SPOOL_LOG` (#201 D8) — that file is the
|
||||||
|
/// evidence that the Stage 2 selections reach the spool.
|
||||||
@MainActor
|
@MainActor
|
||||||
final class Milestone3UITests: XCTestCase {
|
final class Milestone3UITests: XCTestCase {
|
||||||
|
|
||||||
@@ -13,7 +14,7 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
private var testRoot: URL!
|
private var testRoot: URL!
|
||||||
private var binDir: URL!
|
private var binDir: URL!
|
||||||
private var workDir: URL!
|
private var workDir: URL!
|
||||||
private var lpArgvURL: URL!
|
private var spoolLogURL: URL!
|
||||||
|
|
||||||
override func setUp() async throws {
|
override func setUp() async throws {
|
||||||
continueAfterFailure = false
|
continueAfterFailure = false
|
||||||
@@ -23,7 +24,7 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
.deletingLastPathComponent()
|
.deletingLastPathComponent()
|
||||||
.appendingPathComponent("Fixtures/bin")
|
.appendingPathComponent("Fixtures/bin")
|
||||||
workDir = testRoot.appendingPathComponent("work")
|
workDir = testRoot.appendingPathComponent("work")
|
||||||
lpArgvURL = testRoot.appendingPathComponent("lp-argv.log")
|
spoolLogURL = testRoot.appendingPathComponent("spool.log")
|
||||||
try FileManager.default.createDirectory(
|
try FileManager.default.createDirectory(
|
||||||
at: workDir, withIntermediateDirectories: true)
|
at: workDir, withIntermediateDirectories: true)
|
||||||
|
|
||||||
@@ -36,7 +37,7 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
"ICCERY_TEST_SAVE_TARGET":
|
"ICCERY_TEST_SAVE_TARGET":
|
||||||
workDir.appendingPathComponent("mytarget.ti1").path,
|
workDir.appendingPathComponent("mytarget.ti1").path,
|
||||||
"ICCERY_TEST_WORKDIR": workDir.path,
|
"ICCERY_TEST_WORKDIR": workDir.path,
|
||||||
"ICCERY_TEST_LP_ARGV": lpArgvURL.path,
|
"ICCERY_TEST_SPOOL_LOG": spoolLogURL.path,
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -99,18 +100,18 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
_ = waitFor("galleryPage-0", timeout: 25)
|
_ = waitFor("galleryPage-0", timeout: 25)
|
||||||
}
|
}
|
||||||
|
|
||||||
private func recordedLpArgv() -> String {
|
private func recordedSpoolLog() -> String {
|
||||||
(try? String(contentsOf: lpArgvURL, encoding: .utf8)) ?? ""
|
(try? String(contentsOf: spoolLogURL, encoding: .utf8)) ?? ""
|
||||||
}
|
}
|
||||||
|
|
||||||
private func waitForLpLine(_ timeout: TimeInterval = 10) -> String {
|
private func waitForSpoolLine(_ timeout: TimeInterval = 10) -> String {
|
||||||
let deadline = Date().addingTimeInterval(timeout)
|
let deadline = Date().addingTimeInterval(timeout)
|
||||||
while Date() < deadline {
|
while Date() < deadline {
|
||||||
let out = recordedLpArgv()
|
let out = recordedSpoolLog()
|
||||||
if !out.isEmpty { return out }
|
if !out.isEmpty { return out }
|
||||||
RunLoop.current.run(until: Date().addingTimeInterval(0.1))
|
RunLoop.current.run(until: Date().addingTimeInterval(0.1))
|
||||||
}
|
}
|
||||||
return recordedLpArgv()
|
return recordedSpoolLog()
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Drags `#galleryPage-0`'s TIFF upward so `identifier`'s button
|
/// Drags `#galleryPage-0`'s TIFF upward so `identifier`'s button
|
||||||
@@ -203,10 +204,13 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
XCTAssertEqual(element("printNotificationIcon").value as? String, "info")
|
XCTAssertEqual(element("printNotificationIcon").value as? String, "info")
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Preferences OK → captured options are replayed verbatim in the
|
/// Preferences OK → the captured media selection applies back to
|
||||||
/// `lp` argv alongside the two mandatory AP_* headers (issue 17's
|
/// Stage 2 and reaches the recorded ticket writes alongside the
|
||||||
/// acceptance test: "captured options replayed in argv").
|
/// mandatory colour keys (issue 17's acceptance test, ported to
|
||||||
func testCapturedOptionsReplayedInLpArgv() throws {
|
/// the native spool seam in #201). The captured `InputSlot` is no
|
||||||
|
/// longer replayed — captured vendor state lives inside the
|
||||||
|
/// `PrintTicket`, which the stub deliberately does not produce.
|
||||||
|
func testPanelSelectionsApplyBackToSpoolWrites() throws {
|
||||||
app.launchEnvironment["ICCERY_TEST_PRINT_PANEL"] = "ok"
|
app.launchEnvironment["ICCERY_TEST_PRINT_PANEL"] = "ok"
|
||||||
app.launchEnvironment["ICCERY_TEST_PANEL_OPTIONS"] =
|
app.launchEnvironment["ICCERY_TEST_PANEL_OPTIONS"] =
|
||||||
"InputSlot=Rear MediaType=PhotographicGlossy"
|
"InputSlot=Rear MediaType=PhotographicGlossy"
|
||||||
@@ -221,20 +225,17 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
.contains("Settings captured"))
|
.contains("Settings captured"))
|
||||||
|
|
||||||
app.buttons["btnPrintAll"].click()
|
app.buttons["btnPrintAll"].click()
|
||||||
let argv = waitForLpLine()
|
let log = waitForSpoolLine()
|
||||||
XCTAssertTrue(argv.contains(
|
XCTAssertTrue(log.contains(
|
||||||
"AP_ColorMatchingMode=AP_ApplicationColorMatching"), argv)
|
"AP_ColorMatchingMode=AP_ApplicationColorMatching"), log)
|
||||||
XCTAssertTrue(argv.contains(
|
XCTAssertTrue(log.contains(
|
||||||
"AP.ColorMatchingMode=AP_ApplicationColorMatching"), argv)
|
"AP.ColorMatchingMode=AP_ApplicationColorMatching"), log)
|
||||||
XCTAssertTrue(argv.contains("InputSlot=Rear"), argv)
|
XCTAssertTrue(log.contains("MediaType=PhotographicGlossy"), log)
|
||||||
XCTAssertTrue(argv.contains("MediaType=PhotographicGlossy"), argv)
|
|
||||||
// Detected bypass for the mock queue (EPIJ_CMat present in
|
// Detected bypass for the mock queue (EPIJ_CMat present in
|
||||||
// lpoptions -l) is appended when not captured.
|
// lpoptions -l) is always written.
|
||||||
XCTAssertTrue(argv.contains("EPIJ_CMat=3"), argv)
|
XCTAssertTrue(log.contains("EPIJ_CMat=3"), log)
|
||||||
XCTAssertTrue(argv.contains("orientation-requested=3"), argv)
|
XCTAssertTrue(log.contains("orientation-requested=3"), log)
|
||||||
// Last token is the TIFF.
|
XCTAssertTrue(log.contains("page=page1.tif"), log)
|
||||||
XCTAssertTrue(argv.trimmingCharacters(in: .whitespacesAndNewlines)
|
|
||||||
.hasSuffix("page1.tif"), argv)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Per-page print uses the same spool path (btnPrintPage-N).
|
/// Per-page print uses the same spool path (btnPrintPage-N).
|
||||||
@@ -262,14 +263,16 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
printPage.click()
|
printPage.click()
|
||||||
let argv = waitForLpLine()
|
let log = waitForSpoolLine()
|
||||||
XCTAssertTrue(argv.contains("AP_ColorMatchingMode"), argv)
|
XCTAssertTrue(log.contains("AP_ColorMatchingMode"), log)
|
||||||
XCTAssertTrue(argv.contains("page1.tif"), argv)
|
XCTAssertTrue(log.contains("page=page1.tif"), log)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// lp failure surfaces in the in-panel notice, not the wizard banner.
|
/// A spool failure surfaces in the in-panel notice, not the
|
||||||
func testLpFailureShowsPrintNotice() throws {
|
/// wizard banner (`ICCERY_TEST_SPOOL_FAIL` makes the recording
|
||||||
app.launchEnvironment["ICCERY_MOCK_LP_EXIT"] = "1"
|
/// spooler throw `TargetSpoolError.operationFailed`).
|
||||||
|
func testSpoolFailureShowsPrintNotice() throws {
|
||||||
|
app.launchEnvironment["ICCERY_TEST_SPOOL_FAIL"] = "1"
|
||||||
launchApp()
|
launchApp()
|
||||||
reachPrintPanel()
|
reachPrintPanel()
|
||||||
_ = waitFor("printerStatusBadge")
|
_ = waitFor("printerStatusBadge")
|
||||||
@@ -290,7 +293,7 @@ final class Milestone3UITests: XCTestCase {
|
|||||||
_ = waitFor("printerStatusBadge")
|
_ = waitFor("printerStatusBadge")
|
||||||
|
|
||||||
app.buttons["btnPrintAll"].click()
|
app.buttons["btnPrintAll"].click()
|
||||||
_ = waitForLpLine()
|
_ = waitForSpoolLine()
|
||||||
let stateURL = testRoot
|
let stateURL = testRoot
|
||||||
.appendingPathComponent("AppData")
|
.appendingPathComponent("AppData")
|
||||||
.appendingPathComponent("wizard_state.json")
|
.appendingPathComponent("wizard_state.json")
|
||||||
|
|||||||
File diff suppressed because one or more lines are too long
+1
-1
@@ -61,7 +61,7 @@ targets:
|
|||||||
INFOPLIST_KEY_LSMinimumSystemVersion: "12.0"
|
INFOPLIST_KEY_LSMinimumSystemVersion: "12.0"
|
||||||
INFOPLIST_KEY_NSPrincipalClass: NSApplication
|
INFOPLIST_KEY_NSPrincipalClass: NSApplication
|
||||||
INFOPLIST_KEY_NSHumanReadableCopyright: "Copyright © 2026 Gronod. AGPLv3."
|
INFOPLIST_KEY_NSHumanReadableCopyright: "Copyright © 2026 Gronod. AGPLv3."
|
||||||
MARKETING_VERSION: "2.0.0"
|
MARKETING_VERSION: "2.0.1"
|
||||||
CURRENT_PROJECT_VERSION: "1"
|
CURRENT_PROJECT_VERSION: "1"
|
||||||
# Stamped by scripts/version.sh at packaging/CI time (release tag or
|
# Stamped by scripts/version.sh at packaging/CI time (release tag or
|
||||||
# `git describe` string); About shows it next to the marketing version.
|
# `git describe` string); About shows it next to the marketing version.
|
||||||
|
|||||||
Reference in New Issue
Block a user