fix(m9): ad-hoc sign embedded ICCeryCore framework so test host launches (#119 )

Merge pull request 'fix(m9): link ICCeryCore statically so the app launches standalone (#117 )' (#118 ) from feat/117-static-iccerycore into milestone/m9-monterey
Reviewed-on: #118
2026-09-12 09:29:40 +01:00 · 2026-09-12 09:17:22 +01:00 · 2026-09-12 09:14:54 +01:00 · 2026-09-12 09:07:06 +01:00
2 changed files with 20 additions and 0 deletions
@@ -45,6 +45,19 @@ jobs:
            CODE_SIGNING_ALLOWED=YES \
            CODE_SIGN_IDENTITY='-'

+      # Xcode embeds the shared ICCeryCore package framework into the app
+      # and the test bundle without signing it. Ad-hoc hosts still require
+      # every loaded dylib to carry a cdhash — dyld killed the test host at
+      # launch (run 31992) — so sign every embedded copy once the build is
+      # done (embed steps run after any build script phase) (#119).
+      - name: Sign package product frameworks
+        run: |
+          find "$DERIVED/Build/Products/Debug" -depth -name '*_PackageProduct.framework' -print0 \
+            | while IFS= read -r -d '' fw; do
+                echo "signing $fw"
+                codesign --force --sign - --timestamp=none "$fw"
+              done
+
      - name: Test unit (ICCeryCoreTests)
        run: |
          XCTESTRUN="$(find "$DERIVED" -name 'ICCery*.xctestrun' | head -n 1)"
@@ -62,6 +62,13 @@ targets:
        OTHER_SWIFT_FLAGS: ["$(inherited)", "-strict-concurrency=minimal"]
        MACOSX_DEPLOYMENT_TARGET: "12.0"
        ARCHS: "$(ARCHS_STANDARD)"
+      # Debug builds sign ad-hoc; hardened-runtime library validation would
+      # reject the unsigned embedded ICCeryCore package framework when the
+      # test host launches (run 31992, #119). Release keeps validation and
+      # links the package statically anyway.
+      configs:
+        Debug:
+          DISABLE_LIBRARY_VALIDATION: YES

  ICCeryCoreTests:
    type: bundle.unit-test
Author	SHA1	Message	Date
gronod	a2e3f11e70	fix(m9): ad-hoc sign embedded ICCeryCore framework so test host launches (#119 )	2026-09-12 09:29:40 +01:00
gronod	c3c9bbc5ba	Merge pull request 'fix(m9): link ICCeryCore statically so the app launches standalone (#117 )' (#118 ) from feat/117-static-iccerycore into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 26s Details macOS CI / package (push) Skipped Details Reviewed-on: #118	2026-09-12 09:17:22 +01:00
gronodandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	b5683aa36a	fix(m9): link ICCeryCore statically so the app launches standalone (#117 ) When the app and test bundles share the local ICCeryCore package, Xcode builds it as a dynamic package-product framework that is not embedded in ICCery.app — the app crashes in dyld at launch when run outside the test host (macOS 12 VM crash, run 31985 products). Declare the product .static so each consumer links it directly. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-09-12 09:14:54 +01:00
gronod	707455dcfb	Merge pull request 'test(m9): replace MainActor.assertIsolated for Swift 5.7 (#115 )' (#116 ) from feat/115-assertisolated-swift57 into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 2m53s Details macOS CI / package (push) Skipped Details Reviewed-on: #116	2026-09-12 09:07:06 +01:00