Merge pull request 'fix(m9): Debug entitlements disable library validation for test host (#119 )' (#121 ) from feat/119-debug-entitlements into milestone/m9-monterey

fix(m9): Debug entitlements file to disable library validation for test host (#119 )
Merge pull request 'fix(m9): ad-hoc sign embedded ICCeryCore framework so test host launches (#119 )' (#120 ) from feat/119-debug-disable-lib-validation into milestone/m9-monterey
2026-09-12 09:42:16 +01:00 · 2026-09-12 09:41:11 +01:00 · 2026-09-12 09:30:54 +01:00 · 2026-09-12 09:29:40 +01:00 · 2026-09-12 09:17:22 +01:00 · 2026-09-12 09:14:54 +01:00
4 changed files with 42 additions and 1 deletions
@@ -45,6 +45,19 @@ jobs:
            CODE_SIGNING_ALLOWED=YES \
            CODE_SIGN_IDENTITY='-'

+      # Xcode embeds the shared ICCeryCore package framework into the app
+      # and the test bundle without signing it. Ad-hoc hosts still require
+      # every loaded dylib to carry a cdhash — dyld killed the test host at
+      # launch (run 31992) — so sign every embedded copy once the build is
+      # done (embed steps run after any build script phase) (#119).
+      - name: Sign package product frameworks
+        run: |
+          find "$DERIVED/Build/Products/Debug" -depth -name '*_PackageProduct.framework' -print0 \
+            | while IFS= read -r -d '' fw; do
+                echo "signing $fw"
+                codesign --force --sign - --timestamp=none "$fw"
+              done
+
      - name: Test unit (ICCeryCoreTests)
        run: |
          XCTESTRUN="$(find "$DERIVED" -name 'ICCery*.xctestrun' | head -n 1)"
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<!-- App Sandbox intentionally absent: ICCery must spawn Argyll tools,
+	     read/write user-chosen working directories, and talk to lp/CUPS. -->
+	<key>com.apple.security.device.usb</key>
+	<true/>
+	<!-- Debug only: the shared ICCeryCore package framework embedded in the
+	     test products is ad-hoc signed with no Team ID, so hardened-runtime
+	     library validation kills the test host at launch (run 31992, #119).
+	     Release uses ICCery.entitlements and links the package statically. -->
+	<key>com.apple.security.cs.disable-library-validation</key>
+	<true/>
+</dict>
+</plist>
@@ -21,7 +21,9 @@ final class ProcessRunSupportTests: XCTestCase {
            setRunning: { running.append($0) },
            resetLog: { resets += 1 },
            onLog: { batch in
-                MainActor.assertIsolated()
+                // MainActor.assertIsolated() needs Swift 5.9; the runner is
+                // on Xcode 14.2 (Swift 5.7) (#115).
+                XCTAssertTrue(Thread.isMainThread)
                received.append(contentsOf: batch)
            }
        ) { onLog in
@@ -19,6 +19,7 @@ targets:
      - path: Resources
        excludes:
          - ICCery.entitlements
+          - ICCery.Debug.entitlements
          - Argyll
      - path: Resources/Argyll
        type: folder
@@ -62,6 +63,15 @@ targets:
        OTHER_SWIFT_FLAGS: ["$(inherited)", "-strict-concurrency=minimal"]
        MACOSX_DEPLOYMENT_TARGET: "12.0"
        ARCHS: "$(ARCHS_STANDARD)"
+      # Debug builds sign ad-hoc; hardened-runtime library validation would
+      # reject the embedded ICCeryCore package framework (no Team ID) when
+      # the test host launches (run 31992, #119). DISABLE_LIBRARY_VALIDATION
+      # does not inject the entitlement on Xcode 14.2, so use a dedicated
+      # Debug entitlements file. Release keeps validation and links the
+      # package statically anyway.
+      configs:
+        Debug:
+          CODE_SIGN_ENTITLEMENTS: Resources/ICCery.Debug.entitlements

  ICCeryCoreTests:
    type: bundle.unit-test
Author	SHA1	Message	Date
gronod	a0fcede454	Merge pull request 'fix(m9): Debug entitlements disable library validation for test host (#119 )' (#121 ) from feat/119-debug-entitlements into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 21m3s Details macOS CI / package (push) Skipped Details	2026-09-12 09:42:16 +01:00
gronod	97eafd11fb	fix(m9): Debug entitlements file to disable library validation for test host (#119 )	2026-09-12 09:41:11 +01:00
gronod	ed7487c2b6	Merge pull request 'fix(m9): ad-hoc sign embedded ICCeryCore framework so test host launches (#119 )' (#120 ) from feat/119-debug-disable-lib-validation into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 3m15s Details macOS CI / package (push) Skipped Details Reviewed-on: #120	2026-09-12 09:30:54 +01:00
gronod	a2e3f11e70	fix(m9): ad-hoc sign embedded ICCeryCore framework so test host launches (#119 )	2026-09-12 09:29:40 +01:00
gronod	c3c9bbc5ba	Merge pull request 'fix(m9): link ICCeryCore statically so the app launches standalone (#117 )' (#118 ) from feat/117-static-iccerycore into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 26s Details macOS CI / package (push) Skipped Details Reviewed-on: #118	2026-09-12 09:17:22 +01:00
gronodandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	b5683aa36a	fix(m9): link ICCeryCore statically so the app launches standalone (#117 ) When the app and test bundles share the local ICCeryCore package, Xcode builds it as a dynamic package-product framework that is not embedded in ICCery.app — the app crashes in dyld at launch when run outside the test host (macOS 12 VM crash, run 31985 products). Declare the product .static so each consumer links it directly. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-09-12 09:14:54 +01:00
gronod	707455dcfb	Merge pull request 'test(m9): replace MainActor.assertIsolated for Swift 5.7 (#115 )' (#116 ) from feat/115-assertisolated-swift57 into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 2m53s Details macOS CI / package (push) Skipped Details Reviewed-on: #116	2026-09-12 09:07:06 +01:00
gronodandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	17ee5d6717	test(m9): replace MainActor.assertIsolated for Swift 5.7 (#115 ) MainActor.assertIsolated() requires Swift 5.9 (Xcode 15); the macOS 12 CI runner compiles the test bundle with Swift 5.7 and failed run 31985. Assert Thread.isMainThread instead — it checks the same contract (the coalesced log sink hops back to the main actor). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-09-12 09:06:45 +01:00
gronod	2295bcdbae	Merge pull request 'fix(m9): clear printTask without defer for Swift 5.7 (#113 )' (#114 ) from feat/113-printtask-defer-swift57 into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 1m59s Details macOS CI / package (push) Skipped Details Reviewed-on: #114	2026-09-12 09:01:37 +01:00