Compare commits

...
2 Commits
Author SHA1 Message Date
gronod 7a05da3a35 Merge pull request 'fix(m9): stable 'sidebar' a11y identifier for AboutHelp UI test (#122)' (#125) from feat/122-sidebar-a11y-id into milestone/m9-monterey 2026-09-12 11:39:35 +01:00
gronodandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 5134e82e63 fix(m9): stable 'sidebar' a11y identifier for AboutHelp UI test (#122)
Xcode 14.2 / SDK 13.1 does not surface the sidebar root as an AXGroup,
so the groups-containing query in testHelpOverlaysDoNotChangeSidebarHeight
found nothing (run 32029). Give the sidebar root a stable identifier and
query it directly.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-09-12 11:39:16 +01:00
2 changed files with 3 additions and 1 deletions
+1
View File
@@ -129,6 +129,7 @@ struct SidebarView: View {
}
.frame(width: Theme.Metrics.sidebarWidth)
.background(Theme.panel)
.accessibilityIdentifier("sidebar")
}
}
+2 -1
View File
@@ -64,7 +64,8 @@ final class AboutHelpUITests: XCTestCase {
let toggle = app.buttons["btnToggleAllHelp"]
XCTAssertTrue(toggle.waitForExistence(timeout: 10))
let sidebar = app.groups.containing(.button, identifier: "openSettingsBtn").element
let sidebar = app.descendants(matching: .any)["sidebar"]
XCTAssertTrue(sidebar.waitForExistence(timeout: 10))
let before = sidebar.frame
toggle.click()