Merge pull request 'fix(m9): clear printTask without defer for Swift 5.7 (#113 )' (#114 ) from feat/113-printtask-defer-swift57 into milestone/m9-monterey

Reviewed-on: #114
fix(m9): clear printTask without defer for Swift 5.7 (#113 )
2026-09-12 09:01:37 +01:00 · 2026-09-12 09:00:48 +01:00
1 changed files with 5 additions and 2 deletions
@@ -110,7 +110,8 @@ final class PrintSessionViewModel: ObservableObject {
        isPrinting = true
        let task = Task { @MainActor [weak self] in
            guard let self else { return }
-            defer { self.printTask = nil }
+            // `defer` cannot mutate isolated state under Swift 5.7
            // (Xcode 14.2 / macOS 12 runner), so clear explicitly (#113).
            var printed = 0
            for page in result.pages {
                do {
@@ -123,6 +124,7 @@ final class PrintSessionViewModel: ObservableObject {
                            + error.localizedDescription
                    )
                    isPrinting = false
                    self.printTask = nil
                    return
                }
            }
@@ -132,6 +134,7 @@ final class PrintSessionViewModel: ObservableObject {
                autoHideAfter: nil
            )
            isPrinting = false
            self.printTask = nil
        }
        printTask = task
    }
@@ -141,7 +144,6 @@ final class PrintSessionViewModel: ObservableObject {
        isPrinting = true
        let task = Task { @MainActor [weak self] in
            guard let self else { return }
            defer { self.printTask = nil }
            do {
                try await spool(page, index: page.index, pageSize: pageSize)
                printNotice = Notice(
@@ -156,6 +158,7 @@ final class PrintSessionViewModel: ObservableObject {
                )
            }
            isPrinting = false
            self.printTask = nil
        }
        printTask = task
    }
Author	SHA1	Message	Date
gronod	2295bcdbae	Merge pull request 'fix(m9): clear printTask without defer for Swift 5.7 (#113 )' (#114 ) from feat/113-printtask-defer-swift57 into milestone/m9-monterey macOS CI / build-and-test (push) Failing after 1m59s Details macOS CI / package (push) Skipped Details Reviewed-on: #114	2026-09-12 09:01:37 +01:00
gronodandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	c9bff50a1a	fix(m9): clear printTask without defer for Swift 5.7 (#113 ) Swift 5.7 on the macOS 12 CI runner (Xcode 14.2) rejects mutation of actor-isolated properties inside defer bodies, failing run 31978 at PrintSessionViewModel.swift:113 and :144. Clear printTask explicitly at each exit point of the print task closures. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-09-12 09:00:48 +01:00