From e30cb2620049ddf50a8d7b88b544d03cd7383706 Mon Sep 17 00:00:00 2001 From: Bas Stottelaar Date: Mon, 12 May 2014 11:11:57 +0200 Subject: [PATCH] Clarified meaning of HTTP error codes. Will show if it's local or remote error --- headphones/request.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/headphones/request.py b/headphones/request.py index 612d8679..4edb8b2f 100644 --- a/headphones/request.py +++ b/headphones/request.py @@ -50,7 +50,15 @@ def request_response(url, method="get", auto_raise=True, whitelist_status_code=N logger.error("Request timed out.") except requests.HTTPError, e: if e.response is not None: - logger.error("Request raise HTTP error with status code: %d", e.response.status_code) + if e.response.status_code >= 500: + cause = "remote server error" + elif e.response.status_code >= 400: + cause = "local request error" + else: + # I don't think we will end up here, but for completeness + cause = "unknown" + + logger.error("Request raise HTTP error with status code %d (%s).", e.response.status_code, cause) else: logger.error("Request raised HTTP error.") except requests.RequestException, e: