gronod/ha_ecovacs_bumper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix failing test

Browse Source 
It wasn't because of a space.... The tests were failing depending on the run because the xml string may have the id in a different order from run to run.

Changed test to convert string to xml for testing id exists or matches customid.
This commit is contained in:
Brian Martin
2019-02-28 09:20:29 -05:00
parent 91e3f3d577
commit e4848cb4d8
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_ecovacs_xmpp.py
+11 -3
View File
@@ -13,12 +13,20 @@ def test_wrap_command():
c = str(x._wrap_command(Clean().to_xml(), 'E0000000001234567890@126.ecorobot.net/atom')) c = str(x._wrap_command(Clean().to_xml(), 'E0000000001234567890@126.ecorobot.net/atom'))
assert_true(search(r'from="20170101abcdefabcdefa@ecouser.net/abcdef12"', c)) assert_true(search(r'from="20170101abcdefabcdefa@ecouser.net/abcdef12"', c))
assert_true(search(r'to="E0000000001234567890@126.ecorobot.net/atom"', c)) assert_true(search(r'to="E0000000001234567890@126.ecorobot.net/atom"', c))
assert_true(search(r'td="Clean" id="', c)) #Check that an id was added to ctl #Convert to XML to make it easy to see if id was added to ctl
xml_test = ET.fromstring(c)
ctl = xml_test.getchildren()[0][0]
assert_true(ctl.get("id")) #Check that an id was added to ctl
#Test if customid is added to ctl
cwithid = Clean().to_xml() cwithid = Clean().to_xml()
cwithid.attrib["id"] = "12345678" cwithid.attrib["id"] = "12345678" #customid 12345678
c = str(x._wrap_command(cwithid, 'E0000000001234567890@126.ecorobot.net/atom')) c = str(x._wrap_command(cwithid, 'E0000000001234567890@126.ecorobot.net/atom'))
assert_true(search(r'td="Clean" id="12345678', c)) #Check that customid was added to ctl #Convert to XML to make it easy to see if id was added to ctl
xml_test = ET.fromstring(c)
ctl = xml_test.getchildren()[0][0]
assert_equals(ctl.get("id"), "12345678") #Check that an id was added to ctl
def test_getReqID(): def test_getReqID():
x = make_ecovacs_xmpp() x = make_ecovacs_xmpp()