gronod/ha_ecovacs_bumper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #44 from OverloadUT/fix-lifespan-calculations

Browse Source 
Fix lifespans being reported much lower than reality
This commit is contained in:
William Pietri
2018-08-28 15:26:54 -07:00
committed by GitHub
parent 73c906bc6e 276721e280
commit b26e150e71
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sucks/__init__.py
+1 -3
View File
@@ -296,9 +296,7 @@ class VacBot():
except KeyError: except KeyError:
_LOGGER.warning("Unknown component type: '" + type + "'") _LOGGER.warning("Unknown component type: '" + type + "'")
total = float(event['total']) lifespan = int(event['val']) / 100
val = float(event['val'])
lifespan = val / total
self.components[type] = lifespan self.components[type] = lifespan
lifespan_event = {'type': type, 'lifespan': lifespan} lifespan_event = {'type': type, 'lifespan': lifespan}
tests/test_vacbot.py
+5 -3
View File
@@ -83,17 +83,19 @@ def test_lifespan_reports():
v = a_vacbot() v = a_vacbot()
assert_equals({}, v.components) assert_equals({}, v.components)
# Note: The "total" values don't seem to have any meaning
v._handle_ctl({'event': 'life_span', 'type': 'side_brush', 'total': '100', 'val': '50'}) v._handle_ctl({'event': 'life_span', 'type': 'side_brush', 'total': '100', 'val': '50'})
assert_equals({'side_brush': 0.5}, v.components) assert_equals({'side_brush': 0.5}, v.components)
v._handle_ctl({'event': 'life_span', 'type': 'brush', 'total': '200', 'val': '1'}) v._handle_ctl({'event': 'life_span', 'type': 'brush', 'total': '200', 'val': '1'})
assert_equals({'side_brush': 0.5, 'main_brush': 0.005}, v.components) assert_equals({'side_brush': 0.5, 'main_brush': 0.01}, v.components)
v._handle_ctl({'event': 'life_span', 'type': 'side_brush', 'total': '100', 'val': '0'}) v._handle_ctl({'event': 'life_span', 'type': 'side_brush', 'total': '100', 'val': '0'})
assert_equals({'side_brush': 0, 'main_brush': 0.005}, v.components) assert_equals({'side_brush': 0, 'main_brush': 0.01}, v.components)
v._handle_ctl({'event': 'life_span', 'type': 'a_weird_component', 'total': '100', 'val': '87'}) v._handle_ctl({'event': 'life_span', 'type': 'a_weird_component', 'total': '100', 'val': '87'})
assert_equals({'side_brush': 0, 'main_brush': 0.005, 'a_weird_component': 0.87}, v.components) assert_equals({'side_brush': 0, 'main_brush': 0.01, 'a_weird_component': 0.87}, v.components)
def test_is_cleaning(): def test_is_cleaning():
v = a_vacbot() v = a_vacbot()