gronod/ha_ecovacs_bumper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix lifespans being reported much lower than reality

Browse Source 
Original implementation assumed that the "total" value from the API response was the denominator for lifespan, but this was incorrect. The "val" from the `life_span` message is the percentage represented as a whole number, with no dividing necessary.
This commit is contained in:
Greg Laabs
2018-07-29 15:22:31 -07:00
parent 73c906bc6e
commit 276721e280
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sucks/__init__.py
+1 -3
View File
@@ -296,9 +296,7 @@ class VacBot():
except KeyError:
_LOGGER.warning("Unknown component type: '" + type + "'")
total = float(event['total'])
val = float(event['val'])
lifespan = val / total
lifespan = int(event['val']) / 100
self.components[type] = lifespan
lifespan_event = {'type': type, 'lifespan': lifespan}
tests/test_vacbot.py
+5 -3
View File
@@ -83,17 +83,19 @@ def test_lifespan_reports():
v = a_vacbot()
assert_equals({}, v.components)
# Note: The "total" values don't seem to have any meaning
v._handle_ctl({'event': 'life_span', 'type': 'side_brush', 'total': '100', 'val': '50'})
assert_equals({'side_brush': 0.5}, v.components)
v._handle_ctl({'event': 'life_span', 'type': 'brush', 'total': '200', 'val': '1'})
assert_equals({'side_brush': 0.5, 'main_brush': 0.005}, v.components)
assert_equals({'side_brush': 0.5, 'main_brush': 0.01}, v.components)
v._handle_ctl({'event': 'life_span', 'type': 'side_brush', 'total': '100', 'val': '0'})
assert_equals({'side_brush': 0, 'main_brush': 0.005}, v.components)
assert_equals({'side_brush': 0, 'main_brush': 0.01}, v.components)
v._handle_ctl({'event': 'life_span', 'type': 'a_weird_component', 'total': '100', 'val': '87'})
assert_equals({'side_brush': 0, 'main_brush': 0.005, 'a_weird_component': 0.87}, v.components)
assert_equals({'side_brush': 0, 'main_brush': 0.01, 'a_weird_component': 0.87}, v.components)
def test_is_cleaning():
v = a_vacbot()