Main #15

Merged

gronod merged 34 commits from main into development 2026-08-25 22:57:46 +01:00

Conversation 0 Commits 34 Files Changed 100

+2190 -31

gronod commented 2026-08-25 22:57:34 +01:00

Owner

Copy Link

Copy Source

No description provided.

gronod added 34 commits 2026-08-25 22:57:35 +01:00

Fix CI jam dependencies for Windows and MacOS 8e39e44027

Fix macOS CI jam dependency c5fcea8923

Fix Windows ftjam compilation with win32-gcc.mk 2bdef41460

Fix ftjam compilation strictness errors on macOS and Windows 2ff3f0cf43

Fix Windows ftjam execution by adding current dir to PATH c2a000a98a

Fix ArgyllCMS compilation strictness errors on macOS and Windows 19739981b5

Fix Windows ftjam toolset and Mac CCFLAGS issues 7afd91bba9

Fix Windows ftjam segfault by using pre-built binary and remove Mac CFLAGS overrides 68a67f5ec3

Fix Windows unzip and disable Mac optimization for GenRMGam crash c7147771d7

Fix Windows ArgyllCMS build by passing MINGW path to Jambase c1da09b662

Fix radial internal error on macOS ARM64 due to floating point precision 28b9d96f7a

Fix macOS UI link errors by adding missing ui.h includes d0209ec246

Fix ui.h includes in gamut and imdi tools b94487108a

Remove incorrect ui.h include from imdi_make 95c05100d2

Fix Windows packaging step by exporting MINGW bc3cbdca49

Remove experimental denom zero check in radial_point that caused fatal crash on macOS 27c6944fdb

Add robust fallback to radial_bf in gamut_radial when BSP traversal fails 08edcc33af

Fix segfault in radial_bf fallback by providing a valid array d45677a02c

Fix radial_bf implementation bug where ss was overwritten in the normalization loop fef8585187

Fix division by zero and NaN propagation in radial_bf 8ce0e77fdb

Fix segfault: add NULL checks in BSP tree traversal and graceful fallback in radial_point ... 5561dc2d25

The BSP tree built by lu_split() can have NULL child pointers (po/ne)
when all triangles sort to one side of a split plane. On x86_64, the
traversal never visits these NULL branches due to floating-point
rounding. On ARM64 (macOS), different FP precision causes the
traversal to descend into NULL branches, dereferencing np->tag on a
NULL pointer -> segfault.

Fixes:
- radial_point_triang(): return NULL if np is NULL
- vector_isect_rec(): return early if np is NULL
- radial_point(): return -1.0 instead of fatal error() when no
  triangle found, allowing _radial() fallback to radial_bf()

Add pre-generated gamut/RefMediumGamut.gam to avoid segfault on macOS ARM64 ... 1f9499e747

GenRMGam crashes on macOS ARM64 due to floating-point precision
differences in the BSP tree traversal. Since this file is marked
NNoUpdate in the Jamfile (meaning Jam will not regenerate it if it
already exists), committing this pre-built Linux-generated file
allows macOS ARM64 CI builds to skip the GenRMGam step entirely.

Debug macOS ARM64 crash with lldb 682c0ceeda

Fix debug compile command 3685af99d0

Fix missing include directory in debug build a58008e40a

Fix missing spectro include directory in debug build 5ed13ae372

Define UNIX and APPLE in debug build 7f73dfef85

Run jam GenFile1 under lldb to capture actual crash c62f3cba8a

Fix lldb GenFile1 action args 9d43f4de2d

Fix syntax error and restrict lldb to macOS 55471fb1cf

Fix Jam dropping quotes from empty list variables 60969b40bd

Fix strict aliasing in gamut.c 2a993d9e23

Restore Jamfile 8c0ebb1872

Update .github/workflows/build-macos.yml ... 249dc9dac2

Update action runner to macos-15 / macos-15-intel

gronod merged commit 6d1886f1d2 into development 2026-08-25 22:57:46 +01:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Area/UI

User Interface and Subprocess Integration

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

gronod

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gronod/argyllcms#15