Compare commits

...
Author SHA1 Message Date
gronod 9c3982354d Update .github/workflows/build-macos.yml
Update action runner for MacOS to macos-latest
2026-09-01 11:20:43 +01:00
gronod 86e692ecda ci(macos): add ad-hoc codesigning and signature verification to macOS workflow 2026-09-01 10:18:18 +01:00
gronod f30d16816f fix(package): apply ad-hoc code signatures to macOS Mach-O binaries in makepackagebin.sh 2026-09-01 10:18:10 +01:00
gronod c196912bed Fix: Handle non-Mach-O files during macOS universal binary lipo assembly
Merge pull request 'Fix: Handle non-Mach-O files during macOS universal binary lipo assembly' (#30) from fix/macos-universal-non-macho-lipo into development
2026-09-01 00:16:49 +01:00
gronod ebbc675297 fix(ci): handle non-Mach-O files like metainfo.xml during universal lipo assembly 2026-09-01 00:16:11 +01:00
gronod 7b3ebf4c87 Feature: Build and publish macOS Universal Binary release archive
Merge pull request 'Feature: Build and publish macOS Universal Binary release archive' (#28) from feature/issue-27-macos-universal-binaries into development
2026-09-01 00:03:36 +01:00
gronod cc61e2aa4c feat(ci): build and publish macOS universal binary release archive (fixes #27) 2026-09-01 00:02:53 +01:00
gronod 5b75dd4284 Merge pull request 'Fix: Use PeekNamedPipe to prevent blocking ReadFile on anonymous stdin pipes' (#25) from fix/win32-pipe-peek-named-pipe into development
Merge pull request #25 from fix/win32-pipe-peek-named-pipe into development
2026-08-29 14:39:29 +01:00
gronod fb6b37bade fix(spectro): use PeekNamedPipe to prevent blocking ReadFile on anonymous stdin pipes (fixes #24) 2026-08-29 14:39:08 +01:00
gronod 429c772e4a Merge pull request 'Fix: Sanitize manifest CRLF line endings and complete Windows release packaging' (#22) from fix/windows-package-crlf-manifests into development
Merge pull request #22 from fix/windows-package-crlf-manifests into development
2026-08-28 20:23:35 +01:00
gronod d843716e8b fix(packaging): sanitize CRLF line endings in manifest files and ensure catalog files exist (fixes #21) 2026-08-28 20:23:09 +01:00
8 changed files with 203 additions and 38 deletions
+9
View File
@@ -63,6 +63,15 @@ jobs:
echo "SHORT_SHA=${SHORT_SHA}" >> $GITHUB_ENV echo "SHORT_SHA=${SHORT_SHA}" >> $GITHUB_ENV
mv Argyll_V*_win64_exe.zip "Argyll_${TAG}_${SHORT_SHA}_win64_exe.zip" mv Argyll_V*_win64_exe.zip "Argyll_${TAG}_${SHORT_SHA}_win64_exe.zip"
- name: Verify Package Contents
run: |
ZIP_FILE=$(ls Argyll_*_win64_exe.zip)
echo "Verifying contents of ${ZIP_FILE}..."
unzip -l "${ZIP_FILE}" | grep "usb/ArgyllCMS.inf"
unzip -l "${ZIP_FILE}" | grep "usb/bin/amd64/libusb0.sys"
unzip -l "${ZIP_FILE}" | grep "doc/ArgyllDoc.html"
unzip -l "${ZIP_FILE}" | grep "ReadMe.txt"
- name: Upload Artifact - name: Upload Artifact
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v3
with: with:
+118 -2
View File
@@ -11,11 +11,11 @@ jobs:
strategy: strategy:
matrix: matrix:
include: include:
- os: macos-15-intel - os: macos-latest
arch: x86_64 arch: x86_64
machtype: x86_64-apple-darwin machtype: x86_64-apple-darwin
artifact: macOS_x86_64_bin artifact: macOS_x86_64_bin
- os: macos-15 - os: macos-latest
arch: arm64 arch: arm64
machtype: arm64-apple-darwin machtype: arm64-apple-darwin
artifact: macOS_arm64_bin artifact: macOS_arm64_bin
@@ -43,6 +43,16 @@ jobs:
export CCOPTFLAG="-O0" export CCOPTFLAG="-O0"
jam -q -d2 -fJambase -j1 -sBUILTIN_TIFF=true -sBUILTIN_JPEG=true -sBUILTIN_PNG=true -sBUILTIN_Z=true -sBUILTIN_SSL=true install jam -q -d2 -fJambase -j1 -sBUILTIN_TIFF=true -sBUILTIN_JPEG=true -sBUILTIN_PNG=true -sBUILTIN_Z=true -sBUILTIN_SSL=true install
- name: Ad-hoc Sign & Verify Binaries
run: |
for f in bin/*; do
if [ -f "$f" ] && file "$f" | grep -q "Mach-O"; then
echo "Ad-hoc signing $f"
codesign -f -s - "$f"
codesign -dvv "$f"
fi
done
- name: Smoke Tests - name: Smoke Tests
env: env:
ARGYLL_NOT_INTERACTIVE: "1" ARGYLL_NOT_INTERACTIVE: "1"
@@ -64,6 +74,12 @@ jobs:
echo "SHORT_SHA=${SHORT_SHA}" >> $GITHUB_ENV echo "SHORT_SHA=${SHORT_SHA}" >> $GITHUB_ENV
mv Argyll_V*_${{ matrix.artifact }}.tgz "Argyll_${TAG}_${SHORT_SHA}_${{ matrix.artifact }}.tgz" mv Argyll_V*_${{ matrix.artifact }}.tgz "Argyll_${TAG}_${SHORT_SHA}_${{ matrix.artifact }}.tgz"
- name: Upload Raw Binaries
uses: actions/upload-artifact@v4
with:
name: raw-bin-${{ matrix.arch }}
path: bin/
- name: Upload Artifact - name: Upload Artifact
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v4
with: with:
@@ -77,3 +93,103 @@ jobs:
name: Release ${{ github.ref_name }} name: Release ${{ github.ref_name }}
body: "Release ${{ github.ref_name }} built from commit ${{ github.sha }}" body: "Release ${{ github.ref_name }} built from commit ${{ github.sha }}"
files: Argyll_*_${{ matrix.artifact }}.tgz files: Argyll_*_${{ matrix.artifact }}.tgz
universal:
needs: build
runs-on: macos-15
permissions:
contents: write
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Download x86_64 binaries
uses: actions/download-artifact@v4
with:
name: raw-bin-x86_64
path: raw-bin-x86_64
- name: Download arm64 binaries
uses: actions/download-artifact@v4
with:
name: raw-bin-arm64
path: raw-bin-arm64
- name: Create Universal Binaries
run: |
mkdir -p bin
for file in raw-bin-arm64/*; do
bin_name=$(basename "$file")
if [ -f "raw-bin-x86_64/$bin_name" ]; then
if file "raw-bin-arm64/$bin_name" | grep -q "Mach-O" && file "raw-bin-x86_64/$bin_name" | grep -q "Mach-O"; then
echo "Creating universal binary with lipo: $bin_name"
lipo -create "raw-bin-x86_64/$bin_name" "raw-bin-arm64/$bin_name" -output "bin/$bin_name"
chmod +x "bin/$bin_name"
codesign -f -s - "bin/$bin_name"
else
echo "Non Mach-O file, copying directly: $bin_name"
cp "$file" "bin/$bin_name"
fi
else
echo "Warning: $bin_name not found in raw-bin-x86_64, copying arm64 version"
cp "$file" "bin/$bin_name"
if file "bin/$bin_name" | grep -q "Mach-O"; then
codesign -f -s - "bin/$bin_name"
fi
fi
done
for file in raw-bin-x86_64/*; do
bin_name=$(basename "$file")
if [ ! -f "bin/$bin_name" ]; then
echo "Warning: $bin_name only found in raw-bin-x86_64, copying x86_64 version"
cp "$file" "bin/$bin_name"
if file "bin/$bin_name" | grep -q "Mach-O"; then
codesign -f -s - "bin/$bin_name"
fi
fi
done
- name: Verify Architecture & Code Signatures
env:
ARGYLL_NOT_INTERACTIVE: "1"
ARGYLL_EXCLUDE_SERIAL_SCAN: "1"
run: |
echo "=== Binary Architecture & Signature Verification ==="
for file in bin/*; do
if [ -f "$file" ] && file "$file" | grep -q "Mach-O"; then
file "$file"
codesign -dvv "$file"
fi
done
echo "=== Smoke Tests ==="
./bin/dispcal -? || true
./bin/chartread -? || true
./bin/colprof -? || true
./bin/targen -? || true
- name: Package Universal Release
run: |
export OSTYPE=darwin
export MACHTYPE=universal-apple-darwin
export HOSTTYPE=universal
export NO_BUILD=1
./makepackagebin.sh
TAG="${{ github.ref_name }}"
SHORT_SHA="$(git rev-parse --short HEAD)"
echo "SHORT_SHA=${SHORT_SHA}" >> $GITHUB_ENV
mv Argyll_V*_macOS_universal_bin.tgz "Argyll_${TAG}_${SHORT_SHA}_macOS_universal_bin.tgz"
- name: Upload Universal Artifact
uses: actions/upload-artifact@v4
with:
name: Argyll_${{ github.ref_name }}_${{ env.SHORT_SHA }}_macOS_universal_bin
path: Argyll_*_macOS_universal_bin.tgz
- name: Upload Universal Release Asset
if: startsWith(github.ref, 'refs/tags/')
uses: softprops/action-gh-release@v2
with:
name: Release ${{ github.ref_name }}
body: "Release ${{ github.ref_name }} built from commit ${{ github.sha }}"
files: Argyll_*_macOS_universal_bin.tgz
+9
View File
@@ -65,6 +65,15 @@ jobs:
echo "SHORT_SHA=${SHORT_SHA}" >> $GITHUB_ENV echo "SHORT_SHA=${SHORT_SHA}" >> $GITHUB_ENV
mv Argyll_V*_win64_exe.zip "Argyll_${TAG}_${SHORT_SHA}_win64_exe.zip" mv Argyll_V*_win64_exe.zip "Argyll_${TAG}_${SHORT_SHA}_win64_exe.zip"
- name: Verify Package Contents
run: |
ZIP_FILE=$(ls Argyll_*_win64_exe.zip)
echo "Verifying contents of ${ZIP_FILE}..."
unzip -l "${ZIP_FILE}" | grep "usb/ArgyllCMS.inf"
unzip -l "${ZIP_FILE}" | grep "usb/bin/amd64/libusb0.sys"
unzip -l "${ZIP_FILE}" | grep "doc/ArgyllDoc.html"
unzip -l "${ZIP_FILE}" | grep "ReadMe.txt"
- name: Upload Artifact - name: Upload Artifact
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v4
with: with:
+2
View File
@@ -19,6 +19,8 @@
<h1>[V3.4.1 -&gt; V3.5.0] 4th February 2026<br> <h1>[V3.4.1 -&gt; V3.5.0] 4th February 2026<br>
</h1> </h1>
<ul> <ul>
<li>Added macOS Universal Binary release archive (Intel x86_64 + Apple Silicon arm64).</li>
<li>Fixed non-blocking stdin polling deadlock on MSWindows anonymous pipes when running interactive measurement tools in subprocess mode.</li>
<li>Added -d switch to printtarg to allow custom chart label strings or omit labelling entirely.</li> <li>Added -d switch to printtarg to allow custom chart label strings or omit labelling entirely.</li>
<li>Added MSWindows ARM release.</li> <li>Added MSWindows ARM release.</li>
<li>Added Mac ARM release.</li> <li>Added Mac ARM release.</li>
+51 -23
View File
@@ -7,7 +7,7 @@ echo "Script to invoke Jam and then package the binary release."
PRODUCT=Argyll PRODUCT=Argyll
# Set the environment string VERSION from the #define, ie 1.0.0 # Set the environment string VERSION from the #define, ie 1.0.0
VERSION=`grep ARGYLL_VERSION_STR h/aconfig.h | head -1 | sed 's/# define ARGYLL_VERSION_STR //' | sed 's/"//g'` VERSION=`grep ARGYLL_VERSION_STR h/aconfig.h | head -1 | sed 's/# define ARGYLL_VERSION_STR //' | sed 's/\"//g'`
# Typical environment variables: # Typical environment variables:
# (NOTE some systems don't export these ENV vars. by default !!!) # (NOTE some systems don't export these ENV vars. by default !!!)
@@ -113,6 +113,13 @@ else if [ "${OSTYPE#*darwin*}" != "$OSTYPE" ] ; then
echo "We're on MacOS arm64!" echo "We're on MacOS arm64!"
PACKAGE=${PRODUCT}_V${VERSION}_macOS_arm64_bin.tgz PACKAGE=${PRODUCT}_V${VERSION}_macOS_arm64_bin.tgz
export MACOSX_DEPLOYMENT_TARGET="11.0" # Minimum target platform version export MACOSX_DEPLOYMENT_TARGET="11.0" # Minimum target platform version
else if [ X$HOSTTYPE = "Xuniversal" \
-o X$MACHTYPE = "Xuniversal-apple-darwin" \
-o X$COMPILER = "XUNIVERSAL" ] ; then
echo "We're on MacOS Universal!"
PACKAGE=${PRODUCT}_V${VERSION}_macOS_universal_bin.tgz
export MACOSX_DEPLOYMENT_TARGET="10.15" # Minimum target platform version
fi
fi fi
fi fi
fi fi
@@ -145,35 +152,56 @@ fi
echo "Making GNU $PRODUCT binary distribution $PACKAGE for Version $VERSION" echo "Making GNU $PRODUCT binary distribution $PACKAGE for Version $VERSION"
# Clean up so we get a solid build if [ X$NO_BUILD = "X" ] ; then
# .sp come from profile, .cht from scanin and .ti3 from spectro # Clean up so we get a solid build
rm -f bin/*.exe bin/*.dll # .sp come from profile, .cht from scanin and .ti3 from spectro
rm -f ref/*.sp ref/*.cht ref/*.ti2 rm -f bin/*.exe bin/*.dll
rm -f ref/*.sp ref/*.cht ref/*.ti2
if [ X$CROSS_COMPILE = "X" ] ; then # If not cross compiling if [ X$CROSS_COMPILE = "X" ] ; then # If not cross compiling
echo "Cleaning before build ..." echo "Cleaning before build ..."
if ! jam -fJambase -sBUILTIN_TIFF=true -sBUILTIN_JPEG=true -sBUILTIN_PNG=true -sBUILTIN_Z=true -sBUILTIN_SSL=true clean ; then if ! jam -fJambase -sBUILTIN_TIFF=true -sBUILTIN_JPEG=true -sBUILTIN_PNG=true -sBUILTIN_Z=true -sBUILTIN_SSL=true clean ; then
echo "Clean failed!" echo "Clean failed!"
exit 1 exit 1
fi fi
fi
# Make sure it's built and installed
if ! jam -q -fJambase -j${NUMBER_OF_PROCESSORS:-1} -sBUILTIN_TIFF=true -sBUILTIN_JPEG=true -sBUILTIN_PNG=true -sBUILTIN_Z=true -sBUILTIN_SSL=true install ; then
echo "Build failed!"
exit 1
fi
fi fi
# Make sure it's built and installed # Apply ad-hoc code signatures to macOS Mach-O binaries before staging
if ! jam -q -fJambase -j${NUMBER_OF_PROCESSORS:-1} -sBUILTIN_TIFF=true -sBUILTIN_JPEG=true -sBUILTIN_PNG=true -sBUILTIN_Z=true -sBUILTIN_SSL=true install ; then if [ "${OSTYPE#*darwin*}" != "$OSTYPE" ] ; then
echo "Build failed!" echo "=== Applying ad-hoc code signatures to macOS Mach-O binaries ==="
exit 1 for f in bin/* ; do
if [ -f "$f" ] && file "$f" | grep -q "Mach-O" ; then
echo "Signing $f..."
codesign -f -s - "$f" || true
fi
done
fi fi
rm -rf $TOPDIR rm -rf $TOPDIR
mkdir $TOPDIR mkdir $TOPDIR
# Ensure catalog copies exist if needed for Windows packaging
if [ -d usb ] ; then
if [ -f usb/ArgyllCMS.cat ] ; then
[ ! -f usb/ArgyllCMS_x64.cat ] && cp usb/ArgyllCMS.cat usb/ArgyllCMS_x64.cat
[ ! -f usb/ArgyllCMS_arm64.cat ] && cp usb/ArgyllCMS.cat usb/ArgyllCMS_arm64.cat
fi
fi
# Collect the names of all the files that we're going to package # Collect the names of all the files that we're going to package
unset topfiles; for i in `cat binfiles`; do topfiles="$topfiles ${i}"; done unset topfiles; for i in `tr -d '\r' < binfiles`; do topfiles="$topfiles ${i}"; done
unset docfiles; for i in `cat doc/afiles`; do docfiles="$docfiles doc/${i}"; done unset docfiles; for i in `tr -d '\r' < doc/afiles`; do docfiles="$docfiles doc/${i}"; done
unset usbfiles; unset usbfiles;
for j in ${USBDIRS}; do for j in ${USBDIRS}; do
if [ ${j} ]; then if [ ${j} ]; then
for i in `cat ${j}/${USBBINFILES}`; do usbfiles="$usbfiles ${j}/${i}"; done for i in `tr -d '\r' < ${j}/${USBBINFILES}`; do usbfiles="$usbfiles ${j}/${i}"; done
fi fi
done done
@@ -183,16 +211,16 @@ allfiles="${topfiles} bin/* ref/* ${docfiles} ${usbfiles}"
for i in ${allfiles}; do for i in ${allfiles}; do
path=${i%/*} # extract path without filename path=${i%/*} # extract path without filename
file=${i##*/} # extract filename file=${i##*/} # extract filename
if [ $path = $i ] ; then if [ "$path" = "$i" ] ; then
path= path=
fi fi
if [ X$path != "X" ] ; then if [ X"$path" != "X" ] ; then
mkdir -p $TOPDIR/${path} mkdir -p "$TOPDIR/${path}"
fi fi
if [ X${file} = "Xafiles" ] ; then if [ X"${file}" = "Xafiles" ] ; then
continue continue
fi fi
cp $i $TOPDIR/$i cp "$i" "$TOPDIR/$i" || { echo "Failed to copy $i to $TOPDIR/$i"; exit 1; }
done done
# Create the package # Create the package
+13 -12
View File
@@ -203,36 +203,37 @@ static int con_char(int wait) {
/* We assume pipe has been set to NOWAIT mode. */ /* We assume pipe has been set to NOWAIT mode. */
} else if (stdin_type == FILE_TYPE_PIPE) { } else if (stdin_type == FILE_TYPE_PIPE) {
int i, bib; int i, bib;
//fprintf(stderr,"~1 top of pipe\n"); DWORD bytes_avail = 0;
/* Check available bytes in pipe before blocking */
if (!PeekNamedPipe(stdinh, NULL, 0, NULL, &bytes_avail, NULL) || bytes_avail == 0) {
if (!wait) {
return 0;
}
}
for (bib = 0; bib < 10;) { for (bib = 0; bib < 10;) {
//fprintf(stderr,"~1 got %d in buf\n",bib); if (!wait) {
if (!PeekNamedPipe(stdinh, NULL, 0, NULL, &bytes_avail, NULL) || bytes_avail == 0) {
break;
}
}
if ((!ReadFile(stdinh, buf + bib, 10 - bib, &bread, NULL) || bread == 0) if ((!ReadFile(stdinh, buf + bib, 10 - bib, &bread, NULL) || bread == 0)
&& !wait) { && !wait) {
//fprintf(stderr,"~1 no chars waiting\n");
break; break;
} }
bib += bread; bib += bread;
for (i = 0; i < bib; i++) { for (i = 0; i < bib; i++) {
if (buf[i] == '\n' || buf[i] == '\r' || buf[i] == 0x3) { if (buf[i] == '\n' || buf[i] == '\r' || buf[i] == 0x3) {
//fprintf(stderr,"~1 found lf at ix %d\n",i);
break; break;
} }
} }
if (i < bib) { if (i < bib) {
//fprintf(stderr,"~1 found lf\n");
break; /* Found '\n' */ break; /* Found '\n' */
} }
Sleep(100); /* Wait for a line ending in '\n' */ Sleep(100); /* Wait for a line ending in '\n' */
} }
//if (bread > 0) {
//fprintf(stderr,"~1 read %d: ",bread);
//for (i = 0; i < bread; i++)
//fprintf(stderr," 0x%x",buf[i]);
//fprintf(stderr,"\n//");
//}
rv = buf[0]; rv = buf[0];
/* Assume a file. This will have very limited functionality. */ /* Assume a file. This will have very limited functionality. */
Binary file not shown.
Binary file not shown.