Rubidium
90f1768006
Codechange: add non-nullptr asserts in cases where it should never be nullptr
...
Though where similar calls are checked for nullptr as in those instances of
the use of that function it can actually return nullptr. In other words, write
down the assumption that the function never returns nullptr in an assert.
2023-01-14 21:15:23 +01:00
Bernard Teo
8a78fa7121
Feature: Contextual actions for vehicles grouped by shared orders ( #8425 )
2022-11-26 18:03:21 +01:00
Peter Nelson
890b2666d3
Change: Use scaled WidgetDimensions.
2022-11-12 18:28:39 +00:00
Peter Nelson
b6ed595176
Codechange: Prefer suggested widget padding.
2022-11-12 18:28:39 +00:00
Peter Nelson
6f95e04005
Change: Use Rect helpers for widget drawing.
...
This replaces repetitive and sometimes unwieldy use of constants.
2022-11-12 18:28:39 +00:00
Nicolas Chappe
a9a21e784d
Codechange: Always set the ODATFB_NEAREST_DEPOT flag for 'any depot' orders
2022-10-22 14:19:08 +02:00
Michael Lutz
211c630cbe
Codechange: Un-bitstuff order commands.
2021-12-16 22:28:32 +01:00
Michael Lutz
0f64ee5ce1
Codechange: Template DoCommandP to automagically reflect the parameters of the command proc.
...
When finished, this will allow each command handler to take individually
different parameters, obliviating the need for bit-packing.
2021-12-16 22:28:32 +01:00
Michael Lutz
a38bbefe1b
Codechange: Untangle command code, flags and error string for DoCommand*.
2021-12-16 22:28:32 +01:00
Michael Lutz
549caca39c
Codechange: Move command arguments to the back of the networked command function calls.
2021-12-16 22:28:32 +01:00
glx22
5799402f7a
Codechange: Rename window related DeleteXXX to match new behaviour
2021-05-29 21:08:25 +02:00
Patric Stout
7648483364
Change: by default, make "unload all" leave stations empty ( #9301 )
2021-05-27 18:56:39 +02:00
rubidium42
b280f16316
Codechange: remove unneeded comparison and casts
...
Division by resize_y is already yielding an unsigned number, so when clicking in the WD_FRAMERECT_TOP you would already get a huge value, so sel would never be negative. So, leave sel an unsigned number and remove the <= check.
2021-05-27 18:30:56 +02:00
Charles Pigott
f1fc083f2b
Change: Make order window hotkeys toggle for load & unload variants
2021-02-13 22:14:58 +00:00
Patric Stout
9aa39d0af9
Fix #7972 : show invalid orders to stations that don't accept your vehicle ( #8516 )
...
Before it was shown as a normal order, but the vehicle was skipping
it. This was rather unclear to the user. Now it is red and contains
text with some hints what is going on.
The text is prefixed rather than post-fixed, as we have many
post-fixes already.
2021-01-08 16:04:44 +01:00
Charles Pigott
9b800a96ed
Codechange: Remove min/max functions in favour of STL variants ( #8502 )
2021-01-08 11:16:18 +01:00
glx22
d8605ad18d
Codechange: Replace FOR_VEHICLE_ORDERS with range-based for loops
2020-12-27 10:28:46 +00:00
S. D. Cloudt
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
frosch
041088d317
Fix fbbbc6e193: Crash when creating orders to stations with relocated station sign. ( #7755 )
...
Station::xy is the position of the station sign, and not necessarily a tile of the station.
2019-09-29 22:48:19 +02:00
JMcKiern
fbbbc6e193
Fix #7692 : Added industry tile to GetOrderCmdFromTile() ( #7709 )
...
Sending order command to an industry tile now checks if a neutral_station is available and sends the order to that station
2019-09-04 22:47:21 +02:00
PeterN
b9b34f676b
Change: Always report error when ordering a road vehicle to wrong type of road stop. ( #7316 )
...
This was inconsistent before, depending on road/tram and articulated/single vehicle status.
2019-04-13 12:43:49 +01:00
Henry Wilson
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
Michael Lutz
c7b9987d08
Codechange: Switch DropDownList to directly use std::vector, thus making AutoDeleteSmallVector obsolete.
...
DropDownListItem are strongly managed using std::unique_ptr to ensure leak-free handling. Appropriate use
of move-semantics make intent a lot clearer than parameter comments and allows the compiler to generate
copy-free code for most situations.
2019-04-09 22:45:15 +02:00
Henry Wilson
a0f36a50e6
Codechange: Replaced SmallVector::Append() with std::vector::[push|emplace]_back()
2019-03-26 20:15:57 +00:00
peter1138
317f69c152
Codechange: Use override specifier in Window-derived classes.
2019-03-24 16:10:04 +01:00
Johannes E. Krause
21ec3e5531
Cleanup: Remove questionable syntax in GetOrderCmdFromTile
2019-03-13 07:47:32 +00:00
Eddi-z
13056aedbc
Add: Conditional order for max. reliability (patch by Cirdan, #6360 ) ( #7017 )
2019-01-05 22:10:37 +01:00
frosch
b4b98e5165
(svn r27893) -Codechange: Use fallthrough attribute. (LordAro)
2017-08-13 18:38:42 +00:00
frosch
44d1fc4253
(svn r27425) -Fix [FS#5842]: Crash when switching to or taking over companies, when an order window of a vehicle of the new company was opened. Now close those windows.
2015-10-30 17:23:16 +00:00
frosch
8701514172
(svn r26693) -Codechange: Simplify GetOrderCmdFromTile (Juanjo)
2014-07-16 21:06:45 +00:00
frosch
14c4b24405
(svn r26692) -Fix [FS#6059]: Ordering a vehicle to a competitor's rail waypoint displayed an error message. Ignore the click as is done for the other order types to competitor's stuff. (Juanjo)
2014-07-16 20:56:39 +00:00
fonsinchen
64e4e52c33
(svn r26550) -Change: Show measured order times in timetable GUI
2014-05-01 14:53:06 +00:00
fonsinchen
3ee31a8f89
(svn r26547) -Codechange: Collect order travel and wait times independent of timetables
2014-05-01 14:49:16 +00:00
fonsinchen
c915d9fa55
(svn r26546) -Codechange: Make order wait_time, travel_time and max_speed private
2014-05-01 14:48:44 +00:00
rubidium
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
rubidium
83eeba28b7
(svn r26086) -Codechange: use AutoDeleteSmallVector instead std::list for dropdowns
2013-11-24 14:46:26 +00:00
rubidium
b3e93d6520
(svn r26057) -Fix: a number of possibly uninitialised variables
2013-11-23 13:12:19 +00:00
rubidium
1b924f194f
(svn r26049) -Codechange: remove some dead code as order can't be NULL there
2013-11-22 21:42:47 +00:00
planetmaker
dc10b6c167
(svn r25894) -Change: Unify behaviour when clicking on different items in the goto dropdown list when giving orders (adf88)
2013-10-20 19:45:27 +00:00
planetmaker
122158b4d8
(svn r25859) -Add [FS#5784]: Hightlight active goto item in order list dropdown (adf88)
2013-10-13 11:06:58 +00:00
planetmaker
2609693fe8
(svn r25858) -Fix [FS#5783]: Goto button in order window was not always lowered when it should (adf88)
2013-10-13 11:06:05 +00:00
planetmaker
7ed5f6edf9
(svn r25857) -Codechange [FS#5783]: Add void goto type to indicate inactivity in order window (adf88)
2013-10-13 11:05:20 +00:00
frosch
e158383118
(svn r25459) -Fix: Disable the depot-refit button in the order GUI, if the consist is not refittable.
2013-06-24 21:02:26 +00:00
frosch
58ae2d5aeb
(svn r25458) -Fix-ish: Enable the autorefit-button in the order GUI in case the vehicle is not auto-refittable but already has a autorefit-order set to allow clearing the refit.
2013-06-24 21:01:05 +00:00
frosch
bfbdbe688e
(svn r25457) -Fix: Do not test EF_AUTO_REFIT for the mail apartment or rotor of aircraft.
2013-06-24 20:58:25 +00:00
frosch
5cb174c6b8
(svn r25412) -Codechange: Make use of Window::OnHotkey
2013-06-15 15:30:44 +00:00
frosch
1b8b1f3f6c
(svn r25410) -Codechange: Put all hotkeys of a window into a static HotkeyList member.
2013-06-15 15:28:09 +00:00
frosch
d9e9710cb3
(svn r25408) -Codechange: Simplify hotkeys by removing unused stuff.
2013-06-15 15:27:33 +00:00
frosch
cd0a57fba3
(svn r25407) -Codechange: Use order hotkey enum instead of function pointers.
2013-06-15 15:27:08 +00:00
frosch
59b71b5666
(svn r25406) -Cleanup: There were two hotkeys to toggle between 'unload' and 'unload if possible'.
2013-06-15 15:26:49 +00:00
