From feab2ace94ed8d0ffd9fda39dbcb52fd69dbd267 Mon Sep 17 00:00:00 2001 From: tron Date: Sat, 3 Feb 2007 07:47:00 +0000 Subject: [PATCH] (svn r8547) -Fix Remove redundant second retrieval of the station and airport when building an aircraft --- src/aircraft_cmd.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/aircraft_cmd.cpp b/src/aircraft_cmd.cpp index 8e45e90016..b3a1bb793d 100644 --- a/src/aircraft_cmd.cpp +++ b/src/aircraft_cmd.cpp @@ -210,7 +210,6 @@ int32 CmdBuildAircraft(TileIndex tile, uint32 flags, uint32 p1, uint32 p2) Vehicle *vl[3]; UnitID unit_num; const AircraftVehicleInfo *avi; - const AirportFTAClass* ap; if (!IsEngineBuildable(p1, VEH_Aircraft, _current_player)) return_cmd_error(STR_ENGINE_NOT_BUILDABLE); @@ -226,8 +225,9 @@ int32 CmdBuildAircraft(TileIndex tile, uint32 flags, uint32 p1, uint32 p2) avi = AircraftVehInfo(p1); // Prevent building aircraft types at places which can't handle them - ap = GetAirport(GetStationByTile(tile)->airport_type); - if ((avi->subtype & AIR_CTOL ? HELICOPTERS_ONLY : AIRCRAFT_ONLY) == ap->acc_planes) { + const Station* st = GetStationByTile(tile); + const AirportFTAClass* apc = GetAirport(st->airport_type); + if ((avi->subtype & AIR_CTOL ? HELICOPTERS_ONLY : AIRCRAFT_ONLY) == apc->acc_planes) { return CMD_ERROR; } @@ -348,8 +348,6 @@ int32 CmdBuildAircraft(TileIndex tile, uint32 flags, uint32 p1, uint32 p2) * layout for #th position of depot. Since layout must start with a listing * of all depots, it is simple */ { - const Station* st = GetStationByTile(tile); - const AirportFTAClass* apc = GetAirport(st->airport_type); uint i; for (i = 0; i < apc->nof_depots; i++) {